Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread Nir Lisker
On Wed, 23 Nov 2022 23:06:45 GMT, John Hendrikx wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactory.java >> line 287: >> >>> 285: .map(d -> new Object[] {d, }) >>> 286: .collect(toList()); >>> 287:

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread Nir Lisker
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread John Hendrikx
On Wed, 23 Nov 2022 22:36:36 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert instanceof changes and replace with null checks > > modules/javafx.controls/src/test/java/test/com/sun/javafx/sce

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread John Hendrikx
On Wed, 23 Nov 2022 22:48:43 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/chart/CategoryAxisTest.java >> line 122: >> >>> 120: >>> 121: @Test public void checkCategorySpacingReadOnlyCannotBind() { >>> 122: assertTrue(axis.categorySpacingPro

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread Kevin Rushforth
On Wed, 23 Nov 2022 22:40:31 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert instanceof changes and replace with null checks > > modules/javafx.controls/src/test/java/test/javafx/scene/chart

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread Kevin Rushforth
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-23 Thread Nir Lisker
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-22 Thread Kevin Rushforth
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-22 Thread Andy Goryachev
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

2022-11-22 Thread John Hendrikx
> Note: I ran into a `javac` compiler bug while replacing types with diamond > operators (ecj has no issues). I had two options, add a > `SuppressWarnings("unused")` or to use a lambda instead of a method reference > to make `javac` happy. I choose the later and added a comment so it can be >