On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request increment
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request increment
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request increment
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix re
On Sun, 12 Feb 2023 18:35:40 GMT, Nir Lisker wrote:
>> Can make these consistent if the approach is agreed upon.
>
> So let's make the list and the set use an instance singleton pattern, like
> the empty list does.
Fixed
-
PR: https://git.openjdk.org/jfx/pull/972
On Sun, 12 Feb 2023 16:31:35 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits
On Sun, 1 Jan 2023 15:25:01 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line
>> 1640:
>>
>>> 1638: @Override
>>> 1639: public Iterator iterator() {
>>> 1640: return new Iterator<>() {
>>
>> Here the empty `Set
On Wed, 8 Feb 2023 15:05:46 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request with a new
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
John Hendrikx has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev e
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Simpli
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request incrementa
On Wed, 4 Jan 2023 05:28:10 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Clean up expression classes repeated null checks
>> - Use instanceof with pattern matching in a few spots
>
> I took a
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request incrementa
On Tue, 3 Jan 2023 00:24:25 GMT, Nir Lisker wrote:
>> What would go wrong if they're not the same type? `ListContentBinding`
>> doesn't (and can't) enforce it and doesn't care either way. The whole
>> function fails silently if types don't match. Also `ListContentBinding` is
>> a private cl
On Tue, 3 Jan 2023 00:26:21 GMT, Nir Lisker wrote:
>> Yes, looks like this is quite broken. This wouldn't have gone unnoticed so
>> long if unbind would just throw an exception when nothing could be unbound;
>> silently failing is never a good idea.
>
> Can you file an issue for this if it's no
On Wed, 28 Dec 2022 20:16:51 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Clean up expression classes repeated null checks
>> - Use instanceof with pattern matching in a few spots
>
> modules
On Sun, 1 Jan 2023 15:04:17 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/BidirectionalContentBinding.java
>> line 81:
>>
>>> 79: if ((obj1 instanceof ObservableList list1) && (obj2
>>> instanceof ObservableList list2)) {
>>> 80: @Sup
On Sun, 1 Jan 2023 15:23:16 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line
>> 709:
>>
>>> 707: private static class EmptyObservableList extends
>>> AbstractList implements ObservableList {
>>> 708:
>>> 709: private static
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
John Hendrikx has updated the pull request incrementally with two additional
commits since the last revision:
- Clea
On Fri, 30 Dec 2022 16:21:10 GMT, Nir Lisker wrote:
>> I'm fine with that; the first two are equivalent, but in some cases I need
>> to add the type witness to avoid a warning and you can only do that by
>> adding the class name as well (ie. `emptyList()` is not allowed, but
>> `ListExpression
On Fri, 30 Dec 2022 20:53:01 GMT, Nir Lisker wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> modules/javafx.base/src/main/java/javafx/collections/FX
On Wed, 28 Dec 2022 19:11:38 GMT, Nir Lisker wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> modules/javafx.base/src/main/java/com/sun/javafx/bindin
On Wed, 28 Dec 2022 18:57:23 GMT, Nir Lisker wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> modules/javafx.base/src/main/java/com/sun/javafx/bindin
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote:
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
Second part of the review. I'm still looking at the changes to
On Mon, 26 Dec 2022 14:32:52 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/binding/ListExpression.java
>> line 238:
>>
>>> 236: public Iterator iterator() {
>>> 237: final ObservableList list = get();
>>> 238: return (list == null)?
>>> ListExp
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote:
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
This is the first half of the review. Will finish the classes
On Mon, 19 Dec 2022 18:00:30 GMT, Kevin Rushforth wrote:
> I spot-checked it and it seems OK, but I'll let Nir and Ambarish review it in
> more detail. One question I had was around the changes to remove one of the
> overloads of `mergeSort` (the one without a `Comparator` arg) from
> `SortHel
On Mon, 26 Dec 2022 03:26:14 GMT, Michael Strauß wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> modules/javafx.base/src/main/java/javafx/beans/bind
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote:
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
modules/javafx.base/src/main/java/javafx/beans/binding/ListExp
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote:
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
I spot-checked it and it seems OK, but I'll let Nir and Ambari
Packages fixed:
- com.sun.javafx.binding
- com.sun.javafx.collections
- javafx.beans
- javafx.beans.binding
- javafx.collections
- javafx.collections.transformation
-
Commit messages:
- Use static method for no-op map
- Fix raw type warnings in base
Changes: https://git.openjdk.org
31 matches
Mail list logo
