On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Mon, 14 Aug 2023 02:01:20 GMT, Nir Lisker wrote:
>>> Looks good now. Do you still prefer to repeat the behavior of the
>>> subscription in each of the new methods over the centralized one in [#1069
>>> (comment)](https://github.com/openjdk/jfx/pull/1069#discussion_r1261873147)?
>>
>> I'm re
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 21:40:08 GMT, John Hendrikx wrote:
> > Looks good now. Do you still prefer to repeat the behavior of the
> > subscription in each of the new methods over the centralized one in [#1069
> > (comment)](https://github.com/openjdk/jfx/pull/1069#discussion_r1261873147)?
>
> I'm r
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 15:39:32 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Update wo
On Fri, 11 Aug 2023 15:39:32 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 12:12:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Fri, 11 Aug 2023 14:20:43 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Subscription documentation wording and add example
>
> modules/javafx.base/src/main/java/javafx/util/Subscription
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix sente
On Fri, 11 Aug 2023 12:12:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Sun, 6 Aug 2023 22:38:27 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve Subscription javadoc
>
> modules/javafx.base/src/main/java/javafx/util/Subscription.java line 33:
>
>> 31: /**
>
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Update Su
On Sun, 6 Aug 2023 09:16:32 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally wi
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request with a new targ
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Improve S
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request with a new targ
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request with a new targ
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request with a new targ
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
John Hendrikx has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excl
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote:
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
Now that `Subscription` has moved to `javafx.util`, this PR can r
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote:
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
These changes look good to me, pending the addition of the `@impl
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote:
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
modules/javafx.base/src/main/java/javafx/beans/Subscription.java
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote:
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
As long as this is limited to clarification of the existing docs,
Incorporates review comments from #1069
-
Commit messages:
- Documentation improvements
Changes: https://git.openjdk.org/jfx/pull/1177/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1177&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8312058
Stats: 18 lines in 3 fi
29 matches
Mail list logo
