Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-07 Thread John Hendrikx
On Wed, 7 Feb 2024 23:31:43 GMT, Andy Goryachev wrote: > > so I think that the 2nd line is incorrect. > > interesting: I would think the second line is correct. Could you check what a > browser does in this situation? Tested with `pre-wrap` which I think is the closest match there is for brows

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-07 Thread Andy Goryachev
On Wed, 7 Feb 2024 23:28:12 GMT, John Hendrikx wrote: > so I think that the 2nd line is incorrect. interesting: I would think the second line is correct. Could you check what a browser does in this situation? - PR Comment: https://git.openjdk.org/jfx/pull/1236#issuecomment-19331

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-07 Thread John Hendrikx
On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx wrote: >> one thing: you may sync up with the latest master branch, that's the >> configuration I am testing. > > @andy-goryachev-oracle > > I'm not quite seeing what you are seeing. Here is a screenshots of `LOGICAL` > setting with the text `The

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-07 Thread Andy Goryachev
On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx wrote: >> one thing: you may sync up with the latest master branch, that's the >> configuration I am testing. > > @andy-goryachev-oracle > > I'm not quite seeing what you are seeing. Here is a screenshots of `LOGICAL` > setting with the text `The

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-07 Thread John Hendrikx
On Tue, 6 Feb 2024 23:32:25 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix test comment > > one thing: you may sync up with the latest master branch, that's the > configuration I am testi

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-06 Thread Andy Goryachev
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-06 Thread John Hendrikx
On Tue, 6 Feb 2024 21:38:41 GMT, Andy Goryachev wrote: > > specific to strike though > > I don't think so. I can turn it off and nothing changes, same for underline. > I am not sure why it all suddenly started to fail - I did a clean build > twice... Can you see if the new `TextLayoutTest` sy

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-06 Thread Andy Goryachev
On Tue, 6 Feb 2024 21:35:43 GMT, John Hendrikx wrote: > specific to strike though I don't think so. I can turn it off and nothing changes, same for underline. I am not sure why it all suddenly started to fail - I did a clean build twice... - PR Comment: https://git.openjdk.org/j

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-06 Thread John Hendrikx
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-02-06 Thread Andy Goryachev
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-01-30 Thread John Hendrikx
> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each > wrap