On Thu, 9 Oct 2025 18:12:46 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEnco
On Fri, 10 Oct 2025 11:43:44 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process feedback from reviewer
>
> tests/system/src/test/java/test/com/sun/glass/ui/headless/HeadlessApplication1Test
On Fri, 10 Oct 2025 12:56:02 GMT, Jose Pereda wrote:
>> This PR implements `invokeAndWait` and `finishTerminating` for the headless
>> platform and includes two system tests, one for each, that fail before this
>> PR, and pass after it.
>
> Jose Pereda has updated the pull request incrementally
On Fri, 22 Aug 2025 10:41:49 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> Thanks for all the input. I think there are now two ways to proceed:
>
> 1. Leave it as is, including
On Fri, 10 Oct 2025 12:56:02 GMT, Jose Pereda wrote:
>> This PR implements `invokeAndWait` and `finishTerminating` for the headless
>> platform and includes two system tests, one for each, that fail before this
>> PR, and pass after it.
>
> Jose Pereda has updated the pull request incrementally
On Fri, 10 Oct 2025 15:00:54 GMT, John Hendrikx wrote:
> Just to be sure, the CSR required here is for the newly added constructors?
> The documentation changes on the existing constructors are only
> clarifications, no functionality was changed.
Technically not needed, but it wouldn't hurt to
On Fri, 10 Oct 2025 15:19:14 GMT, Kevin Rushforth wrote:
>> Just to be sure, the CSR required here is for the newly added constructors?
>> The documentation changes on the existing constructors are only
>> clarifications, no functionality was changed.
>
>> Just to be sure, the CSR required her
The headless platform also requires you to use the "sw" pipeline, so:
`java -Dglass.platform=Headless -Dprism.order=sw`. Note that
build.gradle does this when running the headless tests, e.g., when
-PHEADLESS_TEST=true or when running javafx.web tests regardless:
// Run web tests in he
On Fri, 10 Oct 2025 14:59:09 GMT, Kevin Rushforth wrote:
>>> Could this lead to two resize commands in some cases?
>>
>> Yes, I was trying not to be too clever with my checks. I figured if the
>> second notification wasn't necessary it would be benign. At the very least
>> it won't trigger inv