Re: RFR: 8367578: Additional WebKit 622.1 fixes from WebKitGTK 2.48.7 [v2]

2025-10-10 Thread Jay Bhaskar
On Thu, 9 Oct 2025 18:12:46 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adding review comments > > modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEnco

Re: RFR: 8369306: Implement invokeAndWait and finishTerminating on headless platform [v3]

2025-10-10 Thread Jose Pereda
On Fri, 10 Oct 2025 11:43:44 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process feedback from reviewer > > tests/system/src/test/java/test/com/sun/glass/ui/headless/HeadlessApplication1Test

Re: RFR: 8369306: Implement invokeAndWait and finishTerminating on headless platform [v3]

2025-10-10 Thread Kevin Rushforth
On Fri, 10 Oct 2025 12:56:02 GMT, Jose Pereda wrote: >> This PR implements `invokeAndWait` and `finishTerminating` for the headless >> platform and includes two system tests, one for each, that fail before this >> PR, and pass after it. > > Jose Pereda has updated the pull request incrementally

Re: RFR: 8361286: Allow enabling of background loading for images loaded from an InputStream [v4]

2025-10-10 Thread Kevin Rushforth
On Fri, 22 Aug 2025 10:41:49 GMT, John Hendrikx wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo > > Thanks for all the input. I think there are now two ways to proceed: > > 1. Leave it as is, including

Re: RFR: 8369306: Implement invokeAndWait and finishTerminating on headless platform [v3]

2025-10-10 Thread Andy Goryachev
On Fri, 10 Oct 2025 12:56:02 GMT, Jose Pereda wrote: >> This PR implements `invokeAndWait` and `finishTerminating` for the headless >> platform and includes two system tests, one for each, that fail before this >> PR, and pass after it. > > Jose Pereda has updated the pull request incrementally

Re: RFR: 8361286: Allow enabling of background loading for images loaded from an InputStream [v5]

2025-10-10 Thread Kevin Rushforth
On Fri, 10 Oct 2025 15:00:54 GMT, John Hendrikx wrote: > Just to be sure, the CSR required here is for the newly added constructors? > The documentation changes on the existing constructors are only > clarifications, no functionality was changed. Technically not needed, but it wouldn't hurt to

Re: RFR: 8361286: Allow enabling of background loading for images loaded from an InputStream [v5]

2025-10-10 Thread Kevin Rushforth
On Fri, 10 Oct 2025 15:19:14 GMT, Kevin Rushforth wrote: >> Just to be sure, the CSR required here is for the newly added constructors? >> The documentation changes on the existing constructors are only >> clarifications, no functionality was changed. > >> Just to be sure, the CSR required her

Re: Headless Tests in CI try to load shared libraries

2025-10-10 Thread Kevin Rushforth
The headless platform also requires you to use the "sw" pipeline, so: `java -Dglass.platform=Headless -Dprism.order=sw`. Note that build.gradle does this when running the headless tests, e.g., when -PHEADLESS_TEST=true or when running javafx.web tests regardless: // Run web tests in he

Re: RFR: 8364547: Window size may be incorrect when constrained to min or max [v2]

2025-10-10 Thread Martin Fox
On Fri, 10 Oct 2025 14:59:09 GMT, Kevin Rushforth wrote: >>> Could this lead to two resize commands in some cases? >> >> Yes, I was trying not to be too clever with my checks. I figured if the >> second notification wasn't necessary it would be benign. At the very least >> it won't trigger inv