Re: 8u20 review request: RT-35635: new bundlers for fxpackager

2014-03-14 Thread Anthony Petrov
Dmitry, all, Please post your review notes to JIRA to keep all the information in one place. We use the mailing list to send out review requests so that other people could start watching the bug and/or join the review. The review itself should happen in JIRA comments. Thank you in advance.

hg: openjfx/8u-dev/rt: [TEST-ONLY] ignore Node_cssStyleMap_Test until failure can be resolved

2014-03-14 Thread hang . vo
Changeset: 58cfa37fa986 Author:David Grievedavid.gri...@oracle.com Date: 2014-03-14 08:02 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/58cfa37fa986 [TEST-ONLY] ignore Node_cssStyleMap_Test until failure can be resolved !

[8u20] Review request for RT-34283: [Swing] DragDrop with interop on Mac OS X between two processes does not transfer data

2014-03-14 Thread Anthony Petrov
Hi Steve, Petr, Please review a fix for https://javafx-jira.kenai.com/browse/RT-34283 -- best regards, Anthony

hg: openjfx/8u-dev/rt: 2 new changesets

2014-03-14 Thread hang . vo
Changeset: 7b70873c59f9 Author:hudson Date: 2014-03-12 09:12 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/7b70873c59f9 Added tag 8u20-b05 for changeset f00f65d8ca59 ! .hgtags Changeset: c3b28058d4d3 Author:kcr Date: 2014-03-14 09:02 -0700 URL:

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

2014-03-14 Thread Mark Fortner
Just out of curiousity, is there some reason that the new classes are in *com.oracle* and *com.sun* packages instead of just in a *javafx.tools*package? import com.oracle.bundlers.windows.WindowsBundlerParam; import com.sun.javafx.tools.packager.Log; import

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

2014-03-14 Thread Danno Ferrin
This is an interim commit, the next one will be just a move to com.oracle.bundlers. I would consider those to be the definitive api going forward for the bundlers portion. The com.sun.javafx package implies that these are useful only for JavaFX, which is not the case since we are adding

[8u20] Review request for RT-35681: Rendering difference between platforms when specular map is used

2014-03-14 Thread Vadim Pakhnushev
Hi Chien, Please review this simple fix: https://javafx-jira.kenai.com/browse/RT-35681 http://cr.openjdk.java.net/~vadim/RT-35681/webrev.00/ Thanks, Vadim