hg: openjfx/8u-dev/rt: RT-36256 Using showAndWait in the onFinished EventHandler of an Animation doesn't work

2014-03-20 Thread hang . vo
Changeset: c5ebcc5268b4 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-03-20 07:38 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c5ebcc5268b4 RT-36256 Using showAndWait in the onFinished EventHandler of an Animation doesn't work Reviewed by: kcr !

hg: openjfx/8u-dev/rt: 2 new changesets

2014-03-20 Thread hang . vo
Changeset: 492c42c21d9f Author:Anthony Petrov anthony.pet...@oracle.com Date: 2014-03-20 13:52 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/492c42c21d9f RT-36267: [Accessibility] Fix LABELED_BY on Windows Reviewed-by: fheidric !

Review request: RT-36238, [Ensemble8] SwingInterop throws IllegalStateException: Not on FX application thread

2014-03-20 Thread Martin Sladecek
Lisa, please review the following change in Ensemble8: https://javafx-jira.kenai.com/browse/RT-36238 http://cr.openjdk.java.net/~msladecek/rt-36238/webrev.00/ Thanks, -Martin

Re: Node.impl_getMatchingStyles

2014-03-20 Thread David Grieve
The JIRA issue (now public) just says that these impl_ methods that SceneBuilder uses need to be public API. Much work needs to be done in the area of public API for accessing CSS styles and whatnot. But, unless I'm told otherwise, there won't be any implementation of such an API before 9.

Re: Node.impl_getMatchingStyles

2014-03-20 Thread Kevin Rushforth
I just made RT-21096 visible. We have no concrete plan to implement this, but David Grieve might wish to comment. -- Kevin HRJet wrote: Hi, From previous discussions, it seems like Node.impl_getMatchingStyles() is going to be made a public API. The lastest reference I can find is in June

[8u Review Request] RT-36808: items added to AreaChart have no symbol

2014-03-20 Thread David Grieve
Jonathan, Please review http://cr.openjdk.java.net/~dgrieve/RT-36068/webrev.00/ Details of the change can be found in https://javafx-jira.kenai.com/browse/RT-36068 Thanks, -- David

hg: openjfx/8u-dev/rt: 2 new changesets

2014-03-20 Thread hang . vo
Changeset: a0a619f9f425 Author:lisa.se...@oracle.com Date: 2014-03-20 14:49 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a0a619f9f425 RT-34982 - IMX6 - cursor image is seen even though a mouse is not plugged in. Adjust cursor logic to properly show/hide the cursor

Lambda Lambda

2014-03-20 Thread Scott Palmer
So I'm looking at Java 8 stuff now and I see that addListener has methods. One takes a ChangeListener, the other an InvalidationListener. So what does this do: Node n = getSomeNode(); n.managedProperty().addListener(x - test(x)); Well it seems it adds an InvalidationListener. So I tried this:

Proposal on getting warning free (controls) packages

2014-03-20 Thread Tom Schindl
Hi, I've just started looking into getting the controls package warning free and/or suppress them in case not fixable. Most of the generic warnings I've come accross in a first pass involve StyleableProperty cast like this: ((StyleableProperty)graphicProperty()).applyStyle(origin, null); In

Re: Lambda Lambda

2014-03-20 Thread Richard Bair
InvalidationListener has one param, ChangeListener has 3. So the arity of the lambda tells the compiler which kind to produce. If there was ambiguity, the compiler would complain. Richard On Mar 20, 2014, at 12:54 PM, Scott Palmer swpal...@gmail.com wrote: So I'm looking at Java 8 stuff now

Re: Lambda Lambda

2014-03-20 Thread Scott Palmer
Thanks.. just figured that out myself. As my colleague just said to me the world is good again On Thu, Mar 20, 2014 at 4:00 PM, Richard Bair richard.b...@oracle.com wrote: InvalidationListener has one param, ChangeListener has 3. So the arity of the lambda tells the compiler which kind to

Re: Lambda Lambda

2014-03-20 Thread Scott Palmer
So why doesn't this complain: n.managedProperty().ChangeListeneraddListener(x - test(x)); ChangeListener has no business being there. Scott On Thu, Mar 20, 2014 at 4:02 PM, Scott Palmer swpal...@gmail.com wrote: Thanks.. just figured that out myself. As my colleague just said to me the world

hg: openjfx/8u-dev/rt: RT-36068: if animating, add item to plot children in onFinished handler of first KeyFrame.

2014-03-20 Thread hang . vo
Changeset: 901931021129 Author:David Grievedavid.gri...@oracle.com Date: 2014-03-20 15:43 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/901931021129 RT-36068: if animating, add item to plot children in onFinished handler of first KeyFrame. Reviewed by: jgiles !

Re: Proposal on getting warning free (controls) packages

2014-03-20 Thread Jonathan Giles
I'll leave it to David to comment on the specifics of these warnings, but in general I'm very supportive of improving the quality of the controls code. It would be best to file a new jira issue and start putting patches up there (although for that to happen you'll need to email the patch to me so

Re: Lambda Lambda

2014-03-20 Thread Richard Bair
I don’t know. On Mar 20, 2014, at 1:03 PM, Scott Palmer swpal...@gmail.com wrote: So why doesn't this complain: n.managedProperty().ChangeListeneraddListener(x - test(x)); ChangeListener has no business being there. Scott On Thu, Mar 20, 2014 at 4:02 PM, Scott Palmer

[8u] reveiw request: RT-36308 Mouse sometimes jumps to edge of screen on first mouse move

2014-03-20 Thread Lisa Selle
Rafi and Daniel, Please review the fix for: https://javafx-jira.kenai.com/browse/RT-36308 diff is in jira. Thanks, Lisa

Re: Lambda Lambda

2014-03-20 Thread Tom Schindl
If I do that in eclipse and hover it I see it still attaches a InvalidationListener! To me it looks like the compiler does not care about what you are trying to tell him because this syntax does only have a meaning on methods who don't declare a generic type in its signature! Tom On 20.03.14

Re: Proposal on getting warning free (controls) packages

2014-03-20 Thread David Grieve
Too bad we can't go back and have WritableValue also extend Styleable... I'm happy to live with the @SuppressWarnings in this particular context since we know that graphicProperty is indeed a StyleablePropertyNode, as is the case where we cast in implementations of the CssMetaData

webrev for arm FB screen capture

2014-03-20 Thread David Hill
fixing some issues I found with a 565 based display and Robot screen capture. Will tackle Monocle later now that I understand better the framebuffer capture issues. jira:https://javafx-jira.kenai.com/browse/RT-35910 review: http://cr.openjdk.java.net/~ddhill/RT-35910/ -- David Hill

hg: openjfx/8u-dev/rt: RT-24614: in equals method, if both values are strings, compare them with String equalsIgnoreCase

2014-03-20 Thread hang . vo
Changeset: c8f3fda9ec22 Author:David Grievedavid.gri...@oracle.com Date: 2014-03-20 18:57 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c8f3fda9ec22 RT-24614: in equals method, if both values are strings, compare them with String equalsIgnoreCase !

Re: Node.impl_getMatchingStyles

2014-03-20 Thread HRJet
Thanks for the clarification. What about impl_getMatchingStyles ? That is not mentioned in RT-21096. Is it worth tracking as a separate request? On Thu, Mar 20, 2014 at 9:01 PM, David Grieve david.gri...@oracle.comwrote: The JIRA issue (now public) just says that these impl_ methods that