Re: Proposal on getting warning free (controls) packages

2014-03-21 Thread John Hendrikx
On 20/03/2014 20:57, Tom Schindl wrote: Hi, I've just started looking into getting the controls package warning free and/or suppress them in case not fixable. Most of the generic warnings I've come accross in a first pass involve StyleableProperty cast like this:

hg: openjfx/8u-dev/rt: RT-36235: Zero specular power can lead to rendering artifacts.

2014-03-21 Thread hang . vo
Changeset: e07207914384 Author:vadim Date: 2014-03-21 14:11 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e07207914384 RT-36235: Zero specular power can lead to rendering artifacts. Reviewed-by: kcr, ckyang Summary: clamp specular power to 0.001 internally. !

TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Leonid Popov
Hi, I updated my workspace recently, tried to build it and have got the following exception. Any suggestions? FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':web:compileGeneratedWin'. java.lang.ClassFormatError: Invalid Constant Pool entry Type 18

Re: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Kevin Rushforth
Are you using gradle 1.8? This looks like a bug we used to have with prior versions of gradle. -- Kevin Leonid Popov wrote: Hi, I updated my workspace recently, tried to build it and have got the following exception. Any suggestions? FAILURE: Build failed with an exception. * What went

Re: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Stephen F Northover
Was this gradle 1.8 or a problem with an EA version of JDK8? In any case, update both. If you can't, doing a clean every time should work but that's not the long term answer. Steve On 2014-03-21 5:49 AM, Kevin Rushforth wrote: Are you using gradle 1.8? This looks like a bug we used to have

[8u] Review request: RT-34950: [Media] JavaFx Player on MAC Crashes Application When Playing Specific Video

2014-03-21 Thread anton nashatyrev
Hello, could you please review the following fix: Webrev: http://cr.openjdk.java.net/~anashaty/RT-34950/webrev.00/ http://cr.openjdk.java.net/%7Eanashaty/RT-34950/webrev.00/ Issue: https://javafx-jira.kenai.com/browse/RT-34950 Thank you! Anton.

How to build 64-bit FX ?

2014-03-21 Thread Anthony Petrov
Hello, I'm on Win7 64 bit system. Regularly I use 32-bit compilers and a 32-bit JDK, and when building FX by executing the `gradle` command, I get a 32-bit FX build. How do I get a 64-bit FX build on the same system? What additional software do I need? I suppose I need a 64-bit JDK, right?

Re: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Leonid Popov
Thanks Kevin, it helped. Leonid On 3/21/2014 4:49 PM, Kevin Rushforth wrote: Are you using gradle 1.8? This looks like a bug we used to have with prior versions of gradle. -- Kevin Leonid Popov wrote: Hi, I updated my workspace recently, tried to build it and have got the following

Re: How to build 64-bit FX ?

2014-03-21 Thread Kevin Rushforth
If your JDK_HOME points to a 64-bit JDK then you will get a 64-bit FX build. No additional options are needed. You need to do a gradle clean as part of your build if you previously built a 32-build in the same repo. Also, if not building webkit or media, make sure you update your stub_runtime

Re: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Kevin Rushforth
This was a gradle 1.4 bug that is fixed in 1.8: http://issues.gradle.org/browse/GRADLE-2831 Leonid just happened to be running an older gradle. -- Kevin Stephen F Northover wrote: Was this gradle 1.8 or a problem with an EA version of JDK8? In any case, update both. If you can't, doing a

hg: openjfx/8u-dev/rt: Fix for RT-36308 [IMX] Mouse sometimes jumps to edge of screen on first mouse move.

2014-03-21 Thread hang . vo
Changeset: 74b46ab976e2 Author:lisa.se...@oracle.com Date: 2014-03-21 10:56 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/74b46ab976e2 Fix for RT-36308 [IMX] Mouse sometimes jumps to edge of screen on first mouse move. Reviewed by dblaukopf. Tested with

Re: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Stephen F Northover
We fail on gradle 1.11. I have filed this bug: https://javafx-jira.kenai.com/browse/RT-36330 I suggest that if we can't fix the bug quickly, we print out a message that we require gradle 1.8 and exit. We should let people override this choice in the properties file. Steve On 2014-03-21

Re: [8u] Review request: RT-34950: [Media] JavaFx Player on MAC Crashes Application When Playing Specific Video

2014-03-21 Thread Kirill Kirichenko
Looks good. Approved. On 21.03.2014 17:54, anton nashatyrev wrote: Hello, could you please review the following fix: Webrev: http://cr.openjdk.java.net/~anashaty/RT-34950/webrev.00/ http://cr.openjdk.java.net/%7Eanashaty/RT-34950/webrev.00/ Issue:

Re: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin'

2014-03-21 Thread Kevin Rushforth
I suggest that if we can't fix the bug quickly, we print out a message that we require gradle 1.8 and exit. We should let people override this choice in the properties file. Good idea. We already print a warning if not gradle 1.8 so it would be easy to fail the build instead (perhaps we

Re: [8u] Review request: RT-34950: [Media] JavaFx Player on MAC Crashes Application When Playing Specific Video

2014-03-21 Thread Kevin Rushforth
Please add your approved comment to the JIRA. Thanks. -- Kevin Kirill Kirichenko wrote: Looks good. Approved. On 21.03.2014 17:54, anton nashatyrev wrote: Hello, could you please review the following fix: Webrev: http://cr.openjdk.java.net/~anashaty/RT-34950/webrev.00/

Re: How to build 64-bit FX ?

2014-03-21 Thread Anthony Petrov
Thanks, Kevin. The build went fine. However, when starting an app, I get the infamous NoSuchMethodError: notifyInitAccessibility exception (I'm building a fresh 8u20 repo). I tried to specify -Djava.library.path=artifacts\sdk\rt\bin but this didn't help. Note that the x64 JDK I'm using to run

Glass Robot and getSCreenCapture

2014-03-21 Thread David Hill
I have been working on a problem with Robot.getScreenCapture() on a 565 ARM device, and while doing so, encountered a couple of questions which I will bring up: Pixxls getScreenCapture(int x, int y, int width, int height, boolean isHiDPI) I don't seem any real documentation that says how x,y

Re: Glass Robot and getSCreenCapture

2014-03-21 Thread Anthony Petrov
Hi David, I don't think we're making any assumptions. We feed the coordinates to a native API and rely on the OS to do the right thing. In other words, our assumption is that if the box lays (partially or fully) outside of the screen area, then the behavior is undefined. Note that the

hg: openjfx/8u-dev/rt: RT-32459: CMD-BACKSPACE should delete the line to the left of the caret, not the word (Mac)

2014-03-21 Thread hang . vo
Changeset: 37b60b405b4b Author:leifs Date: 2014-03-21 10:04 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/37b60b405b4b RT-32459: CMD-BACKSPACE should delete the line to the left of the caret, not the word (Mac) !

hg: openjfx/8u-dev/rt: RT-36314: JavaFX API javadoc has wrong link to JDK docs

2014-03-21 Thread hang . vo
Changeset: 8a9062f8c637 Author:kcr Date: 2014-03-21 11:05 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8a9062f8c637 RT-36314: JavaFX API javadoc has wrong link to JDK docs ! build.gradle

[8u20] post-commit review: RT-36314: JavaFX API javadoc has wrong link to JDK docs

2014-03-21 Thread Kevin Rushforth
I just pushed the fix for the following bug: JIRA: https://javafx-jira.kenai.com/browse/RT-36314 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8a9062f8c637 This will allow links to JDK classes to be generated in our API docs. -- Kevin

hg: openjfx/8u-dev/rt: [Accessibility] fix comment format

2014-03-21 Thread hang . vo
Changeset: 8c568afe762a Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2014-03-21 12:45 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8c568afe762a [Accessibility] fix comment format ! modules/graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java !

Re: *PropertyBase vs Simple*Property

2014-03-21 Thread Tom Schindl
Hi Richard, Coming back to this old thread and now that we are using lamdas all over I guess we could take one more look into that. I've prototyped an initial version by introducing a new internal type named InvalidatedSimpleObjectProperty (not the best name ever!) - see code pasted below. And

Re: *PropertyBase vs Simple*Property

2014-03-21 Thread Richard Bair
Cool. What we then need to measure is the impact to dynamic footprint (i.e.: heap usage). Do the extra 3 fields per property object (bean, name, invalidated method) have any significant impact? Or are these property instances created so infrequently that it doesn’t make any real difference?

Re: *PropertyBase vs Simple*Property

2014-03-21 Thread Stephen F Northover
This looks good. I wonder if we should make this (massive) change before we lambda graphics and controls? Probably doesn't matter. We'll need a JIRA and someone assigned to it in order to track the work. Steve On 2014-03-21 12:53 PM, Tom Schindl wrote: Hi Richard, Coming back to this old

Re: *PropertyBase vs Simple*Property

2014-03-21 Thread Kevin Rushforth
It does seem promising. We'll also need data to show the trade-offs to help inform whether it is worth making such a massive change. -- Kevin Stephen F Northover wrote: This looks good. I wonder if we should make this (massive) change before we lambda graphics and controls? Probably

hg: openjfx/8u-dev/rt: RT-36264: SceneBuilder doesn't start since FX 8 u20 b04 [work around for In(Sanity) Testing]

2014-03-21 Thread hang . vo
Changeset: 1e3c73548b16 Author:snorthov Date: 2014-03-21 15:40 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1e3c73548b16 RT-36264: SceneBuilder doesn't start since FX 8 u20 b04 [work around for In(Sanity) Testing] !

Gradle 1.11 (and 1.8) will now fail fast with a clear error [was: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin']

2014-03-21 Thread Kevin Rushforth
I just pushed a fix for https://javafx-jira.kenai.com/browse/RT-36330 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/27390e79b4cf There is a bug in gradle 1.11 (already fixed in 1.12-rc1) which would be intrusive to workaround, so 1.11 is now blacklisted. The logic is this: if

hg: openjfx/8u-dev/rt: RT-36330: Gradle 1.11 fails to build JFX

2014-03-21 Thread hang . vo
Changeset: 27390e79b4cf Author:kcr Date: 2014-03-21 16:04 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/27390e79b4cf RT-36330: Gradle 1.11 fails to build JFX ! build.gradle ! gradle.properties.template

Re: Gradle 1.11 (and 1.8) will now fail fast with a clear error [was: TaskExecutionException: Execution failed for task ':web:compileGeneratedWin']

2014-03-21 Thread Stephen F Northover
Great! There were people getting burned by this at EclipseCon. Luckily, I remembered this bug and was able to help them but now we don't have to. Steve On 2014-03-21 4:15 PM, Kevin Rushforth wrote: I just pushed a fix for https://javafx-jira.kenai.com/browse/RT-36330 Changeset:

hg: openjfx/8u-dev/rt: Follow-on for RT-36330 to print the supported gradle version on failure

2014-03-21 Thread hang . vo
Changeset: 6c7047fd93f0 Author:kcr Date: 2014-03-21 17:15 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6c7047fd93f0 Follow-on for RT-36330 to print the supported gradle version on failure ! build.gradle

Ability to decorate ChangeListener

2014-03-21 Thread Mario Ivankovits
Hi! In one of my ObservableValue implementations I do have the need to decorate ChangeListener added to it. Today this is somewhat complicated to implement, as I have to keep a map of the original listener to the decorated one to being able to handle the removal process of a listener. Because