[8u20] review request: RT-36760 - inner shadow displaced after fix for RT-13275

2014-05-09 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36760/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36760 ...jim

hg: openjfx/8u-dev/rt: RT-36995: backout RT-36838 changeset as requested by kcr

2014-05-09 Thread hang . vo
Changeset: c6469a243a3c Author:David Grievedavid.gri...@oracle.com Date: 2014-05-09 09:16 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c6469a243a3c RT-36995: backout RT-36838 changeset as requested by kcr ! modules/graphics/src/main/java/javafx/scene/Node.java

[8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-09 Thread David Grieve
Per Kevin's instructions, the previous changeset for RT-36838 was backed out in order to resolve RT-36995. I've attached a new webrev to RT-36838 which is an improved fix for RT-36838 and which also ensures RT-36995 doesn't regress. These changes won't be pushed until after M4 integration.

[8u] Review Request: RT-37018 - 3DViever hangs if OFF button in MSAA Antialiasing is selected

2014-05-09 Thread David Grieve
Issue is caused by an infinite loop in StyleManager code. The code in question was referencing the wrong variable. Trivial fix can be found in the JIRA issue. https://javafx-jira.kenai.com/browse/RT-37018

hg: openjfx/8u-dev/rt: [TEST-ONLY] Disable failing test until RT-36955 is fixed

2014-05-09 Thread hang . vo
Changeset: 70cc180c3d02 Author:kcr Date: 2014-05-09 09:33 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/70cc180c3d02 [TEST-ONLY] Disable failing test until RT-36955 is fixed ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewMouseInputTest.java

review request: RT-35322: [Text] Name of any samples is wrong in Ensemble8

2014-05-09 Thread Felipe Heidrich
Hi Kevin Please review, http://cr.openjdk.java.net/~fheidric/RT-35322/webrev/ https://javafx-jira.kenai.com/browse/RT-35322 Note, personally I don’t think we need to fix this bug for the milestone release. Felipe

hg: openjfx/8u-dev/rt: Fix RT-36760 - Strange shadow on Puzzle Pieces in Ensemble8

2014-05-09 Thread hang . vo
Changeset: 419d55de712f Author:flar james.gra...@oracle.com Date: 2014-05-09 14:29 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/419d55de712f Fix RT-36760 - Strange shadow on Puzzle Pieces in Ensemble8 Reviewed by: chien, kcr !

[8u20] Review Request RT-36296 - app freeze with zero width dashed border

2014-05-09 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36296/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36296 Do we need 2 reviewers? ...jim

hg: openjfx/8u-dev/rt: RT-37018: loop referenced wrong variable

2014-05-09 Thread hang . vo
Changeset: 65e094638f34 Author:David Grievedavid.gri...@oracle.com Date: 2014-05-09 21:05 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/65e094638f34 RT-37018: loop referenced wrong variable ! modules/graphics/src/main/java/com/sun/javafx/css/StyleManager.java