Re: How to scale control properly?

2014-06-05 Thread Martin Sladecek
Hi Rafal, you can wrap the control in a Group. That way, it's (actually Group's) layoutBounds will be the same as it's transformed bounds (boundsInParent). Alternatively you can use css styling, but I don't know much about how to do it properly, maybe Jonathan can help you there. -Martin On

hg: openjfx/8u-dev/rt: RT-37396: [CSS] pseudo-class state not taking effect

2014-06-05 Thread hang . vo
Changeset: 2a1db2fff116 Author:David Grieve Date: 2014-06-05 10:15 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2a1db2fff116 RT-37396: [CSS] pseudo-class state not taking effect ! modules/graphics/src/main/java/javafx/scene/CssStyleHelper.java

hg: openjfx/8u-dev/rt: RT-37373 [Unit Tests] - Intermittent failure in com.sun.glass.ui.monocle.input.RotateTest

2014-06-05 Thread hang . vo
Changeset: eb7ab0261393 Author:Elina Kleyman Date: 2014-06-05 17:41 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/eb7ab0261393 RT-37373 [Unit Tests] - Intermittent failure in com.sun.glass.ui.monocle.input.RotateTest ! tests/system/src/test/java/com/sun/glass/ui/mon

FXMLLoader checking code conventions too much?

2014-06-05 Thread Guillaume Anctil
Hi, on a project I work on, the code convention does not follow the Java standard and class names start with a lower case 'c': "cSomeClass.java" In the parsing of the FXMLLoader, the loadType function looks like this: int i = name.indexOf('.'); int n = name.length(); while (i != -1 && i < n

Re: How to scale control properly?

2014-06-05 Thread Rafal Leibzig
Thanks for advice. I know this trick with wrapping in a Group, but as i wrote on stackoverflow, there is dropshadow effect after moving mouse over the control. This effect extends group's layoutBounds for a while. And when mouse leaves out the control, then group's layoutBounds shrink. I found the

Re: FXMLLoader checking code conventions too much?

2014-06-05 Thread Stephen F Northover
I see no reason why we should enforce this. Martin, any idea? Steve On 2014-06-05, 12:05 PM, Guillaume Anctil wrote: Hi, on a project I work on, the code convention does not follow the Java standard and class names start with a lower case 'c': "cSomeClass.java" In the parsing of the FXMLLoa

Re: FXMLLoader checking code conventions too much?

2014-06-05 Thread Martin Sladecek
Currently, we use case to distinguish between newly created objects (upper-case class name) and properties (lower-case). Otherwise, it would not be clear when there's e.g. a text property and text class if we should set a property called text or create new text object and try to assign it to th

Re: FXMLLoader checking code conventions too much?

2014-06-05 Thread Stephen F Northover
Seems like we can't/shouldn't fix this. We can at least make sure it is documented. Steve On 2014-06-05, 4:19 PM, Martin Sladecek wrote: Currently, we use case to distinguish between newly created objects (upper-case class name) and properties (lower-case). Otherwise, it would not be clear w

Re: FXMLLoader checking code conventions too much?

2014-06-05 Thread Martin Sladecek
Maybe some special tags can solve the problem, like abc abc They could be used in cases where the class name violates the restrictions we have for property/object tags. FXML version and SB will have to be update though, which means such fxml will not be compatible with older versions. This is

RFR: Fix RT-37209: NPE showing print dialog

2014-06-05 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-37209 http://cr.openjdk.java.net/~prr/rt-37209/

hg: openjfx/8u-dev/rt: RT-37341: Ensemble8: TextField can not change its color

2014-06-05 Thread hang . vo
Changeset: 36f4864a04e8 Author:David Grieve Date: 2014-06-05 16:30 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/36f4864a04e8 RT-37341: Ensemble8: TextField can not change its color ! modules/graphics/src/main/java/javafx/scene/Node.java

hg: openjfx/8u-dev/rt: 2 new changesets

2014-06-05 Thread hang . vo
Changeset: c5cfd184a714 Author:Anthony Petrov Date: 2014-06-06 00:39 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c5cfd184a714 RT-37406: [SwingNode]:swing component in swingnode lost foucs when keycode up(Arrow Up) Summary: consume() KeyEvents for UP and DOWN arrows

Re: FXMLLoader checking code conventions too much?

2014-06-05 Thread Jim Graham
In that code "i < n" is a tautology. It's purpose seems to be to prevent the following "i+1"s from overflowing the string length, but then it should be "i < n-1" or "n" should just be initialized to name.length()-1 (and be called "max" or something to make its purpose clear)...

Re: FXMLLoader checking code conventions too much?

2014-06-05 Thread Stephen F Northover
Guillaume, if you feel strongly about this, please file a JIRA. Thanks! Steve On 2014-06-05, 4:29 PM, Martin Sladecek wrote: Maybe some special tags can solve the problem, like abc abc They could be used in cases where the class name violates the restrictions we have for property/object tags

[8u] Review Request: RT-37408: [ScrollPane] incorrect preferred size when viewport pref size is specified and bar is present

2014-06-05 Thread David Grieve
Martin, Please review the patch attached to https://javafx-jira.kenai.com/browse/RT-37408.

hg: openjfx/8u-dev/rt: Fixed RT-37209) [Printing] NPE when showing print dialog

2014-06-05 Thread hang . vo
Changeset: d9e26c986af1 Author:prr Date: 2014-06-05 15:57 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d9e26c986af1 Fixed RT-37209) [Printing] NPE when showing print dialog Reviewed-by: kcr ! modules/graphics/src/main/java/com/sun/prism/j2d/print/J2DPrinter.java ! mo

hg: openjfx/8u-dev/rt: Fix RT-36016: Dirty region (actually clipping) problems on blurs with large radii

2014-06-05 Thread hang . vo
Changeset: e2d745ffbf0a Author:flar Date: 2014-06-05 16:22 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e2d745ffbf0a Fix RT-36016: Dirty region (actually clipping) problems on blurs with large radii Reviewed by: kcr ! modules/graphics/src/main/java/com/sun/scenari

hg: openjfx/8u-dev/rt: RT-37395: TreeTableView's selectedItems reports changes that include null items when when a TreeItem is collapsed.

2014-06-05 Thread hang . vo
Changeset: 784974feb001 Author:jgiles Date: 2014-06-06 12:40 +1200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/784974feb001 RT-37395: TreeTableView's selectedItems reports changes that include null items when when a TreeItem is collapsed. ! modules/controls/src/main/jav