Re: Selection Events v. Focus Events - order is broken in JavaFX 8?

2015-02-10 Thread Tomas Mikula
Hi Scott, whether that behavior is a bug in JavaFX 8 or not, why not commit on focus lost *or* selection change? Less assumptions means more robust code. Regards, Tomas On Tue, Feb 10, 2015 at 10:15 AM, Scott Palmer swpal...@gmail.com wrote: I have a custom field (my own formatted field done

Re: Selection Events v. Focus Events - order is broken in JavaFX 8?

2015-02-10 Thread Scott Palmer
When I say commit I mean my formatted field sets it's 'value' property based on the conversion from the 'text'. A binding to its value property takes care of updating the table item. The field itself has no business knowing about the table selection changes. For now I'm subclassing the control

[8u60] review request: RT-39826: Replace sun.misc.BASE64* with java.util.Base64

2015-02-10 Thread Kevin Rushforth
Anton, Please review the web changes for the following: https://javafx-jira.kenai.com/browse/RT-39826 http://cr.openjdk.java.net/~kcr/RT-39826/webrev.00/ Details are in the JIRA. -- Kevin

Selection Events v. Focus Events - order is broken in JavaFX 8?

2015-02-10 Thread Scott Palmer
I have a custom field (my own formatted field done in JavaFX 2.2) bound to a property of the selected row in a TableView. My control commits an edit on focus lost. This works on JavaFX 2.2 but fails on JavaFX 8. After a bit of debugging I discovered why. The way to reproduce the problem was to

[8u-dev] Review Request: RT-39869: IndexOutOfBoundsException with Native Menus in Mac

2015-02-10 Thread Morris Meyer
Kevin and David, Could you please take a look at this fix to RT-39869? I added some checking to avoid the IOOBE from the native Glass system menus. Thanks, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-39869.01 JIRA - https://javafx-jira.kenai.com/browse/RT-39869