Re: Problem with gradle ...

2019-10-31 Thread Jeanette Winzenburg
okay, now build everything went fine, but get an file access error Task :controls:test FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':controls:test'. java.nio.file.AccessDeniedException:

Re: Problem with gradle ...

2019-10-31 Thread Scott Palmer
The wrapper script works just like the gradle command but uses the gradle version specified by the project. See https://docs.gradle.org/current/userguide/gradle_wrapper.html > On Oct 31, 2019, at 9:58 AM, Jeanette Winzenburg >

Re: Problem with gradle ...

2019-10-31 Thread Nir Lisker
Seems like an OS level issue. I've not gotten this one yet. Could be a file lock, read-only file, user permissions config etc. On Thu, Oct 31, 2019 at 4:24 PM Jeanette Winzenburg wrote: > > okay, now build everything went fine, but get an file access error > > > Task :controls:test FAILED > >

Re: Problem with gradle ...

2019-10-31 Thread Kevin Rushforth
If you are hitting this error, then you must have your own local installation on gradle. You can either update that local installation manually, or you can use "gradlew" which will always use the supported version of gradle: sh gradlew ... -- Kevin On 10/31/2019 6:41 AM, Jeanette

Re: Problem with gradle ...

2019-10-31 Thread Nir Lisker
Yes, the wrapper will know to download the correct version. I updated the build instructions page [1] to be more specific about the wrapper recently, and there is another update coming soon due to a problem I recently encountered with the buildsrc. Run ./gradlew from the root folder of the

RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-10-31 Thread Jeanette Winzenburg
https://bugs.openjdk.java.net/browse/JDK-8233040 The issue is that the eventFilter in CBPC uses F4 for toggling the popup _and_ consumes it. This prevents client code to register there own filter. The fix was to remove the block entirely - F4 is already handled by a keyMapping in

Re: Problem with gradle ...

2019-10-31 Thread Nir Lisker
Did you run the wrapper with gradlew or just gradle? The latter uses the "global" version installed on the OS which might not be up to date (use 'gradle --version' to check). - Nir On Thu, Oct 31, 2019 at 3:41 PM Jeanette Winzenburg wrote: > > .. fails (gradle run from cygwin console) with: >

Re: Problem with gradle ...

2019-10-31 Thread Jeanette Winzenburg
Zitat von Nir Lisker : Did you run the wrapper with gradlew or just gradle? The latter uses the "global" version installed on the OS which might not be up to date (use 'gradle --version' to check). in my cygwin console I type: gradle and get the error message .. hmm ... so, yeah seems

Re: Problem with gradle ...

2019-10-31 Thread Jeanette Winzenburg
Zitat von Nir Lisker : Seems like an OS level issue. I've not gotten this one yet. Could be a file lock, read-only file, user permissions config etc. yeah, for some reason the folder was write-protected .. removed for now, will dig later as to why it happened in the first place. Thanks

Re: Problem with gradle ...

2019-10-31 Thread Nir Lisker
I think Eclipse sometimes causes folders to be marked as read-only (can't find the reference). I had issues where I couldn't rebuild because the modules\javafx.base folder was read-only for some reason and I had to delete is manually. It would reoccur seemingly randomly. On Thu, Oct 31, 2019 at

RFR: 8233338: FX javadoc headings are out of sequence

2019-10-31 Thread Kevin Rushforth
As indicated in [JDK-828](https://bugs.openjdk.java.net/browse/JDK-828), this fixes all of our javadoc HTML headings to conform with the rule that all HTML heading tags in class documents must start with `` and be nested correctly (i.e., no skipping levels). See

Problem with gradle ...

2019-10-31 Thread Jeanette Winzenburg
.. fails (gradle run from cygwin console) with: * Where: Build file 'C:\Daten\data-for-work\eclipse\gitrep-openjdk\jfx-fork\build.gradle' line: 250 * What went wrong: A problem occurred evaluating root project 'jfx-fork'. FAIL: Gradle version too old: 4.10.2; must be at least 5.3

Re: Problem with gradle ...

2019-10-31 Thread Jeanette Winzenburg
Zitat von Nir Lisker : Yes, the wrapper will know to download the correct version. I updated the build instructions page [1] to be more specific about the wrapper recently, and there is another update coming soon due to a problem I recently encountered with the buildsrc. Run ./gradlew from

Re: RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

2019-10-31 Thread Kevin Rushforth
On Wed, 16 Oct 2019 13:09:35 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 13:07:45 GMT, Jeanette Winzenburg > wrote: > >> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759 >> >> The issue is that default/cancel button on a scene are triggered even though >> a

Re: RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

2019-10-31 Thread Kevin Rushforth
On Wed, 23 Oct 2019 11:32:48 GMT, Jeanette Winzenburg wrote: > The issue is that firing keyEvents on a node that is not focusOwner might > produce false green tests, please see the issue for details. > > fix for https://bugs.openjdk.java.net/browse/JDK-8231692 > - added contructor taking the

Re: RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-10-31 Thread Kevin Rushforth
On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg wrote: > https://bugs.openjdk.java.net/browse/JDK-8233040 > > The issue is that the eventFilter in CBPC uses F4 for toggling the popup > _and_ consumes it. This prevents client code to register there own filter. > > The fix was to remove

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-31 Thread Nir Lisker
On Wed, 30 Oct 2019 14:01:58 GMT, Hadzic Samir wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader >> >>