Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-14 Thread Scott Palmer
On Sat, 14 Dec 2019 16:38:25 GMT, Kevin Rushforth wrote: >> TextFlow isn't mentioned in the JavaDoc for any of the other Text properties >> where the same rule applies. Perhaps that should be remedied with a >> follow-up task? > > A follow-up issue would be fine. I've created

Re: [Rev 05] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-14 Thread Scott Palmer
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to > both. TextFlow's tab size overrides that of contained Text nodes. The pull request has been updated with 1 additional commit. - Added commits: - f846ad6d: 8130738: Add tabSize property to Text and

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-14 Thread Kevin Rushforth
On Fri, 13 Dec 2019 01:20:47 GMT, Scott Palmer wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line >> 494: >> >>> 493: * Values less than 1 are treated as 1. This value overrides the >>> 494: * {@code tabSize} of contained {@link

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-14 Thread Kevin Rushforth
On Fri, 13 Dec 2019 01:10:48 GMT, Scott Palmer wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1450: >> >>> 1449: private static final CssMetaData TAB_SIZE = >>> 1450: new CssMetaData("-fx-tab-size", >>> 1451: