Re: [Rev 02] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-28 Thread Ajit Ghaisas
On Tue, 28 Jan 2020 09:03:40 GMT, Ambarish Rapte wrote: >> This PR is a fix for >> [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) >> This issue is regression of >> [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). >> >> Issue. >> - `Parent.viewOrderChildren` is

RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Guru Hb
cl : Command line warning D9002 : ignoring unknown option '-m32' post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't

Re: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-28 Thread Ajit Ghaisas
On Tue, 28 Jan 2020 09:08:35 GMT, Dean Wookey wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >>

How to build standalone openJFX modules for uploading to a local maven repository

2020-01-28 Thread Danny Gonzalez
We have a java 11 project that uses maven to pull in openJFX modules i.e. javafx-controls, javafx-web, javafx-swing. What we would like to do is build our own versions of these openJFX modules for use as maven dependencies which use a fork of openJFX (which we build locally to fix up some

Re: [Rev 02] RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-28 Thread Dean Wookey
> Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest > removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue >

Re: RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Johan Vos
On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb wrote: > cl : Command line warning D9002 : ignoring unknown option '-m32' > > post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of > cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. > '-m32' flag is gcc

Re: RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 21:03:01 GMT, Johan Vos wrote: >> cl : Command line warning D9002 : ignoring unknown option '-m32' >> >> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of >> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. >> '-m32' flag

Re: [Integrated] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-28 Thread Ambarish Rapte
Changeset: 79fc0d0d Author:Ambarish Rapte Date: 2020-01-28 12:35:52 + URL: https://git.openjdk.java.net/jfx/commit/79fc0d0d 8232824: Removing TabPane with strong referenced content causes memory leak from weak one Reviewed-by: kcr, aghaisas !

Re: TableView slow vertical scrolling with 300+ columns

2020-01-28 Thread Ed Kennard
Hi Clemens, Thanks very much for your message, it definitely helped me crystalize the root of the issue beyond my previous understanding, and also gave me some additional options on how to work around it :) Ed On 27/01/2020, 15:45, "openjfx-dev on behalf of Clemens Kadura" wrote:

Re: TableView slow vertical scrolling with 300+ columns

2020-01-28 Thread Danny Gonzalez
Hi Clemens, I am also experiencing the TableView slow vertical scrolling issue with large number of columns. Did you manage to work around this issue with a code change in TableRowSkinBase as you mentioned in your bullet point 2 and if so could you share what you did? Thanks Danny > On 28

Release roadmap for 2 already-merged TableView PRs

2020-01-28 Thread Ed Kennard
Hi everyone, In Java 9 there were some issues introduced into the TableView code which significantly reduced the extensibility of the skinning. These issues were blocking ones for us, in terms of migrating from 8 to 11, since we rely heavily on what was originally exposed, a good example

Re: Release roadmap for 2 already-merged TableView PRs

2020-01-28 Thread Ed Kennard
Michael, Kevin, Great, will try out right away! Thanks! Ed On 28/01/2020, 13:58, "openjfx-dev on behalf of Michael Paus" wrote: Am 28.01.20 um 12:49 schrieb Ed Kennard: > It looks like the first opportunity to benefit from both changes is to wait for the upcoming Java 14

Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-28 Thread Tom Schindl
I think that can not work because layouts don't take the scale factor into account nor does stuff like ScrollView but i could be wrong. Tom On 27.01.20 17:29, David Grieve wrote: > Wouldn't this just be a scale transform? > >> -Original Message- >> From: openjfx-dev On Behalf Of >>

Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-28 Thread Tom Eugelink
One can't keep taps on everything. :-) It was part of the "One application to rule them all" talk I had on the JavaOne 2017. Just tested it, but it's still doing its thing in my time registration app. Desktop layout: Phone layout: This is on my desktop when I resize the window. I'll stop

Re: Release roadmap for 2 already-merged TableView PRs

2020-01-28 Thread Kevin Rushforth
JavaFX is unbundled (i.e., shipped separately from the JDK) since JDK 11. Early access builds of JavaFX 14 have been available for quite some time [1]. The GA release is scheduled for Tuesday, March 10 [2]. Hope this helps. -- Kevin [1] https://gluonhq.com/products/javafx/#ea [2]

Re: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-01-28 Thread Florian Kirmaier
On Thu, 19 Dec 2019 15:09:02 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > build.gradle line 2514: > >> 2513: compile project(':graphics') >> 2514: testCompile "de.sandec:JMemoryBuddy:0.1.3" >> 2515: } > > This is a new

Re: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-01-28 Thread Florian Kirmaier
On Thu, 19 Dec 2019 15:10:32 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/Parent.java line 1929: > >> 1928: */ >> 1929: public List test_getRemoved() { >> 1930: return removed;

Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-28 Thread Pedro Duque Vieira
Interesting, Tom. I didn't know about this blog post and control. Cheers, -- Pedro Duque Vieira - https://www.pixelduke.com

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Ambarish Rapte
On Tue, 28 Jan 2020 12:39:20 GMT, Robert Lichtenberger wrote: >> Test simulates a single mouse-released event. >> Fix simply guards against the null case. > > The pull request has been updated with 1 additional commit. Fix looks good, suggested minor changes in test.

Re: Release roadmap for 2 already-merged TableView PRs

2020-01-28 Thread Michael Paus
Am 28.01.20 um 12:49 schrieb Ed Kennard: It looks like the first opportunity to benefit from both changes is to wait for the upcoming Java 14 pre-release Feb 6th - is that on schedule, and please could I try that out? Then am I correct in thinking it will be officially published at

Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Ambarish Rapte
On Tue, 28 Jan 2020 18:04:54 GMT, Robert Lichtenberger wrote: >> Test simulates a single mouse-released event. >> Fix simply guards against the null case. > > The pull request has been updated with 1 additional commit. The fix looks good to me. Verified that the new test fails before and

Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 16:04:59 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > The fix looks good to me. > Verified that the new test fails before and passes after fix and observed no > test failures. I don't have any additional comment, so this is

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Robert Lichtenberger
On Tue, 28 Jan 2020 12:38:32 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java > line 57: > >> 56: import javafx.scene.input.KeyEvent; >> 57: import

Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - 39a61821: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all:

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-28 Thread Frederic Thevenet
On Mon, 27 Jan 2020 18:45:17 GMT, Frederic Thevenet wrote: >> I thought of one possibility that might be worth looking into for a short >> term fix (i.e., could still go into openjfx14). Rather than relying on >> `PrismSettings.maxTextureSize` you could instead try to render the entire >>

Re: RFR: 8236839: System menubar removed when other menubars are created or modified

2020-01-28 Thread Kevin Rushforth
On Tue, 14 Jan 2020 20:30:39 GMT, Kevin Rushforth wrote: >> I just realised that I did not make the commit with the same email address >> that I used on the OCA (but both addresses are linked to my GitHub account). >> Will this be a problem? >> Should I redo the commit with the correct email

Re: [Rev 04] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-28 Thread Frederic Thevenet
> This PR aims to address the following issue: JDK-8088198 Exception thrown > from snapshot if dimensions are larger than max texture size > > In order to do that, it simply captures snapshots in multiple tiles of > maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 16:00:35 GMT, Frederic Thevenet wrote: >> I have tested using a recipient WritableImage with an IntARGB pixel format >> (so that is aligned with that of the tile), that I construct by supplying a >> PixelBuffer, and as expected that performance of the tiled code is much

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-28 Thread Thiago Milczarek Sayao
On Tue, 14 Jan 2020 11:30:49 GMT, Thiago Milczarek Sayao wrote: >> I understand. Will do that when the code works 100%. I have submitted the PR >> to avoid duplicated efforts and let people test it (if anyone is willing). > > Sizing and positioning completed and fairly tested. > > Will look

Re: RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb wrote: > cl : Command line warning D9002 : ignoring unknown option '-m32' > > post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of > cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. > '-m32' flag is gcc

RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-28 Thread Nir Lisker
[8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do not play backwards after being paused) has been split to deal with [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not embedded](https://bugs.openjdk.java.net/browse/JDK-8237975) animations. This is a

Re: RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-28 Thread Nir Lisker
On Tue, 28 Jan 2020 19:19:57 GMT, Nir Lisker wrote: > [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do > not play backwards after being paused) has been split to deal with > [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not >

Re: RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 19:22:53 GMT, Nir Lisker wrote: >> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do >> not play backwards after being paused) has been split to deal with >> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not >>

Re: RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface

2020-01-28 Thread Johan Vos
On Wed, 11 Dec 2019 15:41:38 GMT, Ambarish Rapte wrote: > The finalize() method is deprecated in JDK9. See [Java 9 deprecated > features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). > And so the >

Re: [Rev 01] RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface

2020-01-28 Thread Ambarish Rapte
> The finalize() method is deprecated in JDK9. See [Java 9 deprecated > features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). > And so the >