Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v2]

2020-08-24 Thread Bhawesh Choudhary
> Added missing explicit no-arg constructors to classes in package > javafx.scene, javafx.css and javafx.stage. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Marked few class constructor as deprecated as per review

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v5]

2020-08-24 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-08-24 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't

Re: Blurry render of SwingNode

2020-08-24 Thread Kevin Rushforth
It's now in the JDK project in JBS: https://bugs.openjdk.java.net/browse/JDK-8252255 I was able to reproduce it with the test program you sent. -- Kevin On 8/22/2020 12:28 PM, Kevin Rushforth wrote: Actually, someone already did file a bug report a couple days ago (I see it in our internal

Re: RFR: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

2020-08-24 Thread Ambarish Rapte
On Thu, 20 Aug 2020 23:32:24 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8252107 > > - Fixed by checking return value of audio/video bin state change and stopping > pipeline initialization if error occurred. Built and tested on Linux. - Marked as

Integrated: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

2020-08-24 Thread Alexander Matveev
On Thu, 20 Aug 2020 23:32:24 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8252107 > > - Fixed by checking return value of audio/video bin state change and stopping > pipeline initialization if error occurred. This pull request has now been integrated. Changeset:

RFR: 8252060: gstreamer fails to build with gcc 10

2020-08-24 Thread Alexander Matveev
Fixed by defining GST_API as GST_EXPORT for gcc compiler as per Kevin proposed solution. On Windows we do not need to define GST_API, since we using .def file to export symbols. - Commit messages: - 8252060: gstreamer fails to build with gcc 10 Changes: