On Wed, 8 Sep 2021 21:10:27 GMT, Kevin Rushforth wrote:
> I looked at the generated javadoc and this will read better without a
> paragraph break.
When you remove the paragraph break, please also remove the blank line to make
it clearer to future readers of the code that it is intended to be
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
On Tue, 27 Jul 2021 12:41:00 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()** listener
>> - Null check
On Tue, 27 Jul 2021 12:41:00 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()** listener
>> - Null check
When using Swing it's possible to generate a Deadlock.
It's related to the nested eventloop started in enterFullScreenExitingLoop -
and the RenderLock aquired when using setView in Scene.
Sample Programm and Threaddump are added to the ticket.
Removing the nested loop fixes the Problem.
I
On Sun, 29 Aug 2021 04:12:22 GMT, Michael Strauß wrote:
> This PR fixes a bug that was introduced in #454.
>
> Since this fix might impact the performance considerations in the original
> PR, I ran a performance benchmark against the previous `ChangeListener`-based
> implementation, which
On Mon, 6 Sep 2021 11:05:42 GMT, Jose Pereda wrote:
>> I don't doubt that the area should be cleared. What I was questioning is
>> whether this was the best place to do it? I'd be OK with it if you document
>> it.
>
> The two options I see so far to clear the area are the one I've committed
>
On Sun, 29 Aug 2021 06:36:40 GMT, Michel Jung
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Color to int32 conversion and more changes based on feedback
>
>
On Wed, 8 Sep 2021 10:37:40 GMT, Florian Kirmaier wrote:
> When using Swing it's possible to generate a Deadlock.
> It's related to the nested eventloop started in enterFullScreenExitingLoop -
> and the RenderLock aquired when using setView in Scene.
> Sample Programm and Threaddump are added
On Wed, 8 Sep 2021 06:32:06 GMT, Ajit Ghaisas wrote:
> The latest patch does not apply cleanly due to the change in copyright
> headers.
@aghaisas If you fetch the PR branch and merge master (which is what I usually
do when testing a PR), git is able to auto-resolve it; this is why Skara
On Mon, 6 Sep 2021 09:28:20 GMT, Jose Pereda wrote:
>> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 97:
>>
>>> 95:
>>> 96: private int fontSmoothingType;
>>> 97: private Color backgroundColor = Color.WHITE;
>>
>> This might be a problem, since there are code paths
On Tue, 7 Sep 2021 10:40:01 GMT, Michael Strauß wrote:
>> This PR fixes the exception thrown by the sample code in
>> [8273324](https://bugs.openjdk.java.net/browse/JDK-8273324), while retaining
>> the incorrect behavior in the scenario described.
>
> Michael Strauß has updated the pull
On Wed, 8 Sep 2021 12:20:57 GMT, Kevin Rushforth wrote:
> > The latest patch does not apply cleanly due to the change in copyright
> > headers.
>
> @aghaisas If you fetch the PR branch and merge master (which is what I
> usually do when testing a PR), git is able to auto-resolve it; this is
On Tue, 7 Sep 2021 10:40:01 GMT, Michael Strauß wrote:
>> This PR fixes the exception thrown by the sample code in
>> [8273324](https://bugs.openjdk.java.net/browse/JDK-8273324), while retaining
>> the incorrect behavior in the scenario described.
>
> Michael Strauß has updated the pull
On Fri, 3 Sep 2021 18:19:45 GMT, Michael Strauß wrote:
> This PR fixes the exception thrown by the sample code in
> [8273324](https://bugs.openjdk.java.net/browse/JDK-8273324), while retaining
> the incorrect behavior in the scenario described.
This pull request has now been integrated.
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the
16 matches
Mail list logo
