Re: RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2021-10-15 Thread Phil Race
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote: > On an external (non-retina) monitor JavaFX LCD text on macOS is painful on > the eyes. > Retina diminishes it rather than cures it. > > The problem is a mix of a couple of things > 1) CoreText no longer generates LCD glyphs (except perhaps

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Kevin Rushforth
On Fri, 15 Oct 2021 16:23:10 GMT, Kevin Rushforth wrote: > > Do you want to do something about `idMap` in > > `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR? > > I missed that comment. Where do you see this field? I can't find it anywhere. Oh, I see it now. It's

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Kevin Rushforth
On Fri, 15 Oct 2021 15:04:00 GMT, Nir Lisker wrote: > Do you want to do something about `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR? I missed that comment. Where do you see this field? I can't find it anywhere. - PR:

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Kevin Rushforth
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-15 Thread Jeanette Winzenburg
> cell startEdit is supposed to update the editing location on its associated > control - was done in ListCell, not in Tree-/TableCell nor TreeCell. > > Fix was to add control.edit(..). Note that ListCell was also touched to use > the exact same method call pattern as the fixed cell types. > >

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-15 Thread Jeanette Winzenburg
On Wed, 13 Oct 2021 21:25:43 GMT, Marius Hanl wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed formatting as suggested in review >> >> and removed unused (by this fix) import in same file > >

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers

2021-10-15 Thread Nir Lisker
On Thu, 14 Oct 2021 23:50:10 GMT, Kevin Rushforth wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > >

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Nir Lisker
> Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case. Nir Lisker has updated the pull request incrementally with one additional commit since

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling

2021-10-15 Thread Kevin Rushforth
On Thu, 23 Sep 2021 19:01:52 GMT, Marius Hanl wrote: > This PR fixes an issue which is probably in JavaFX since VirtualFlow exists. > While horizontal scrolling any VirtualFlow control the left blue border > sometimes disappear/gets smaller. (see also image below) > > This can be fixed by

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Nir Lisker
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the