Re: MSAA and Scene anti aliasing

2013-07-14 Thread Chien Yang
Hi Richard, Yes, I agree an enum is probably better than a boolean for controlling the visual quality of a rendered scene. As a matter of fact we did explore using enum is earlier 3d discussions but decided to go with boolean due to concerns of complexity we aren't ready to handle for

Re: MSAA and Scene anti aliasing

2013-07-15 Thread Chien Yang
+1. Well said. - Chien Sent from my mobile phone. Please excuse my brevity. On Jul 15, 2013, at 12:19 PM, Thor Johannesson thor.johannes...@oracle.com wrote: I think there should be a simple way to request full scene anti-aliasing to improve 3D rendering. And also an optional more

Re: ConcurrentModificationException during controls test runs

2013-07-16 Thread Chien Yang
Yes, this has already been filed today. https://javafx-jira.kenai.com/browse/RT-31714 - Chien On 7/16/13 3:58 PM, Richard Bair wrote: Is anybody else seeing this? javafx.scene.control.ComboBoxTest test_rt31479 FAILED java.util.ConcurrentModificationException at

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
the setting of either the AA type or number of samples? I would have though that serious graphics developers would really like to have such options available to them. On 24 July 2013 06:58, Chien Yang chien.y...@oracle.com mailto:chien.y...@oracle.com wrote: Yes, very good point, we struggled

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
for DEFAULT implies that it's really more of a BALANCED or MODERATE setting that would have the same characteristics on each platform. On 24 July 2013 06:29, Chien Yang chien.y...@oracle.com wrote: Hi all, We appreciate all the feedback you have contributed to this topic. After listening

Re: Fwd: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-24 Thread Chien Yang
-- From: Scott Palmer swpal...@gmail.com Date: Tue, Jul 23, 2013 at 9:33 PM Subject: Re: API Change Proposal - Re: MSAA and Scene anti aliasing To: Chien Yang chien.y...@oracle.com Is DEFAULT intended to defer to the settings in the system graphics drivers (e.g. nVidia control panel

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-24 Thread Chien Yang
, // disables anti-aliasing FASTEST, // enables anti-aliasing using minimum system setting available that results in better frame rate NICEST // enables anti-aliasing using maximum system setting available that results in best visual quality } Thanks, - Chien On 7/23/2013 1:29 PM, Chien Yang

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-24 Thread Chien Yang
. It seems more consistent to have the only OFF mode to be first and then all the rest of the options (which happen to then have ordinals 0) will be some form of ON mode. Richard On Jul 24, 2013, at 2:37 PM, Chien Yang chien.y...@oracle.com wrote: Thank you for the feedback! We decided to drop DEFAULT

Re: Mixing 2D and 3D

2013-07-25 Thread Chien Yang
Hi August, We did talk through some use cases such as PIP and rear view mirror. You can do simultaneous viewing from different points of view into a single 3D scene via the use of SubScenes. The key point, as you have clearly stated, is the need to clone the scene graph nodes per

Re: Mixing 2D and 3D

2013-07-25 Thread Chien Yang
different points of view? On Jul 25, 2013, at 5:17 PM, Chien Yang chien.y...@oracle.com wrote: Hi August, We did talk through some use cases such as PIP and rear view mirror. You can do simultaneous viewing from different points of view into a single 3D scene via the use of SubScenes. The key

Re: Mixing 2D and 3D

2013-07-26 Thread Chien Yang
Yes, that is still the approach. The challenge isn't just strictly on rendering. Let's take picking a shared node as an example. Imagine this node is in a scenegraph viewed by more than 1 camera. The question is where do we hang the set picked information. There is some level of cloning needed

Re: Mixing 2D and 3D

2013-07-26 Thread Chien Yang
so that we can evaluate it to see if there are any performance / semantic problems. You will likely ended up with a one frame behind rendering in those sub views, but do let us know for your finding. Thanks, - Chien On 7/26/2013 10:53 AM, Chien Yang wrote: Yes, that is still the approach

Re: NSInvalidSendPortException

2013-07-27 Thread Chien Yang
Hi Sven, Yes, please do. Can you provide more specific details? What is the program you were running? It will be great if you have a simple test case to go with the bug report. Thanks, - Chien On 7/27/2013 9:31 AM, Sven Reimers wrote: Hi, I get 2013-07-27 18:28:51.911 java[65246:707]

Re: Mixing 2D and 3D

2013-07-29 Thread Chien Yang
26.07.2013, 17:43 +0200 schrieb Chien Yang chien.y...@oracle.com: Hi August, John Yoon, Richard and I have a private discussion on the possibility of avoiding cloning for your use case. We wonder do you ever need to interact with the 3D scene via the various sub views? Or these sub views

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-31 Thread Chien Yang
these objects without providing public constructors so that these become statically defined by the system. What about Anisotropic filtering? Is that considered a form of AA, or an option on top of AA? ...jim On 7/24/2013 3:07 PM, Chien Yang wrote: Thanks for the help! I was of 2 minds about

Re: Mixing 2D and 3D

2013-08-05 Thread Chien Yang
Hi Jim, We worked closely with Pavel to ensure 3D picking did extend nicely. I believe the specification at this link is still up-to-date: https://wiki.openjdk.java.net/display/OpenJFX/Picking3dAPI - Chien On 8/5/2013 3:44 AM, Pavel Safrata wrote: On 1.8.2013 22:33, Richard Bair wrote: How

Re: JavaFX 3D Material

2013-08-27 Thread Chien Yang
Hi Kensuke, Both are known issues that we have tentative plan to address in FX 8. Here are the links for you to track their status: https://javafx-jira.kenai.com/browse/RT-29527 https://javafx-jira.kenai.com/browse/RT-28874 BTW, please note the limitation of applying opacity on Group

Re: 3D scene antialiasing

2013-09-11 Thread Chien Yang
Hi John, Should it be noticeable? (hopefully yes!) You should see the difference on shape with sloped edge if you platform supports MSAA. Is it just a matter of providing true to the second of the boolean parameters in the Scene constructor? Yes this is correct, however this API is

Re: 3D scene antialiasing

2013-09-11 Thread Chien Yang
how I can attach anything... how do I do that? -Original Message- From: John C. Turnbull [mailto:ozem...@ozemail.com.au] Sent: Thursday, 12 September 2013 07:37 To: 'Chien Yang' Cc: 'Kevin Rushforth'; 'openjfx-dev@openjdk.java.net' Subject: RE: 3D scene antialiasing Hi Chien, I will file

Re: JavaFX 3D Issues reported in April

2013-09-26 Thread Chien Yang
Hi Richard, Don and I did exchange emails to work through the list of issues he encountered this April. As far as I remembered all were tracked with JIRAs and most, such as material and mesh computation bugs, were already fixed. - Chien On 9/26/2013 2:32 PM, Richard Bair wrote:

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

2013-10-04 Thread Chien Yang
We did discuss making divisions in the predefined 3D shapes mutable in earlier meeting. However we decided against it since it is a heavy weight operation as the supporting mesh will has to be regenerated. I believe the constructor with the divisions argument will not have much use in the

V-up texture coordinate support

2013-10-17 Thread Chien Yang
Hi all, Java images are defined such that (0, 0) references the top left most pixel of the image. In JavaFX, the texture coordinate system for 3D objects is defined with its U axis increasing from left to right and the V axis increasing from top to bottom. Hence a texture coordinate of

Re: V-up texture coordinate support

2013-10-22 Thread Chien Yang
); Regards -- Remi From: Chien Yang chien.y...@oracle.commailto:chien.y...@oracle.com Date: Thu, Oct 17, 2013 at 3:08 PM Subject: V-up texture coordinate support To: OpenJFX openjfx-dev@openjdk.java.netmailto:openjfx-dev@openjdk.java.net Hi all, Java images are defined such that (0, 0

Re: V-up texture coordinate support

2013-10-22 Thread Chien Yang
with JavaFX 3D Graphics/Camera/Y-down versus Y-up (http://docs.oracle.com/javafx/8/3d_graphics/camera.htm#CJAHFAHB). Doesn't this approach require an immediate availability of a v-flipping feature? August Am Donnerstag, den 17.10.2013, 15:08 +0200 schrieb Chien Yang chien.y...@oracle.com

Code Review Request For RT-33212: Java FX 8 on Windows Vista - nodes show unpainted regions and distort with resizing with components disappearing

2013-11-15 Thread Chien Yang
Vadim and Kevin, Please review review the following change. Webrev: http://cr.openjdk.java.net/~ckyang/RT-33212/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-33212 Thanks, - Chien

Code Review Request For RT-32525: [FX3D] 3D does not working with Windows 2008 R2

2013-11-15 Thread Chien Yang
Kevin and Vadim, Please review the following change. Webrev: http://cr.openjdk.java.net/~ckyang/RT-32525/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-32525 Thanks, - Chien

Code Review Request For RT-34226: Shading of PhongMaterial Boxes appears unnatural

2013-11-18 Thread Chien Yang
Kevin and Jim, Please review this simple fix. I have also included the report test case this change: JIRA: https://javafx-jira.kenai.com/browse/RT-34226 Webrev: http://cr.openjdk.java.net/~ckyang/RT-34226/webrev.00/ Thanks, - Chien

Code Review Request For RT-29527: MeshView textures are not repeated

2013-11-19 Thread Chien Yang
Kevin and Vadim, Please review my proposed fix for this bug: JIRA: https://javafx-jira.kenai.com/browse/RT-29527 Wevrev: http://cr.openjdk.java.net/~ckyang/RT-29527/webrev.00/ I have done a fairly extensive testing on our 3D programs. This fix exposes a d3d 3D state bug in Prism in 2

Code Review Request For RT-34343: [JFX 8 3D] BaseMesh throws NPE in case of dead face(s)

2013-11-22 Thread Chien Yang
Hi Kevin, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-34343 Thanks, - Chien

Code Review Request For RT-33461: Release native resource used by MSAA buffer when it is freed

2013-11-25 Thread Chien Yang
Hi Kevin, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-33461 Thanks, - Chien

Code Review Request For RT-29101: SubScene require unit test coverage

2013-11-26 Thread Chien Yang
Hi Kevin, Please review my proposed test coverage: https://javafx-jira.kenai.com/browse/RT-29101 Thanks, - Chien

[Doc only] Code Review Request RT-30404: [FX3D] Need better documentation for the default PointLight

2013-12-05 Thread Chien Yang
Hi Kevin, Please review this simple javadoc change: JIRA: https://javafx-jira.kenai.com/browse/RT-30404 Webrev: http://cr.openjdk.java.net/~ckyang/RT-30404/webrev.00/ Thanks, - Chien

8 post-commit review: [Doc only] RT-34292: Document importance of TriangleMesh order of elements

2013-12-06 Thread Chien Yang
In case anyone is interested in this post commit javadoc change: (initial draft was reviewed by kcr) http://cr.openjdk.java.net/~ckyang/RT-34292/webrev.00/ Thanks, - Chien

Code Review Request For RT-28883: Rendering artifacts on NVIDIA GeForce 6600

2013-12-14 Thread Chien Yang
Hi Kevin and Vadim, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-28883 Thanks, - Chien

[8u] Code Review Request - RT-31749: Support Intel GPU on Linux platform

2013-12-23 Thread Chien Yang
Hi Kevin, Please review this simple one line fix to enable support for Intel GPU on the Linux platform: https://javafx-jira.kenai.com/browse/RT-31749 Thanks, - Chien

[8u] Code Review Request - RT-34385: Support Prism HW acceleration on Linux with open-source driver

2013-12-23 Thread Chien Yang
Hi Felipe and Kevin, Please review this simple one line fix to support X.Org open source drivers for ATI/AMD and Nvidia: http://cr.openjdk.java.net/~ckyang/RT-34385/webrev.00/ Thanks, - Chien

Re: [8u] Code Review Request - RT-34385: Support Prism HW acceleration on Linux with open-source driver

2013-12-24 Thread Chien Yang
Here is the link to the JIRA: https://javafx-jira.kenai.com/browse/RT-34385 - Chien On 12/23/2013 3:30 PM, Chien Yang wrote: Hi Felipe and Kevin, Please review this simple one line fix to support X.Org open source drivers for ATI/AMD and Nvidia: http://cr.openjdk.java.net/~ckyang/RT

[8u] Code Review Request - RT-32631: D3D: Need to improve OS version checking into GPU qualifying logic

2013-12-31 Thread Chien Yang
Hi Kevin and Vadim, Can you please review my proposed fix? http://cr.openjdk.java.net/~ckyang/RT-32631/webrev.00/ Thanks, - Chien

Re: [8u] Code Review Request - RT-32631: D3D: Need to improve OS version checking into GPU qualifying logic

2013-12-31 Thread Chien Yang
I should have used the JIRA where link to the webrev is included: https://javafx-jira.kenai.com/browse/RT-32631 - Chien On 12/31/2013 11:40 AM, Chien Yang wrote: Hi Kevin and Vadim, Can you please review my proposed fix? http://cr.openjdk.java.net/~ckyang/RT-32631/webrev.00/ Thanks

Re: JavaFX versus AWT/Swing Hardware Acceleration

2014-01-03 Thread Chien Yang
The Graphics Support section in this link has a detail information on the list of GPUs JavaFX can take advantage of: http://docs.oracle.com/javafx/2/system_requirements_2-2-5/jfxpub-system_requirements_2-2-5.htm Note: Linux and Mac should have the same support coverage except for Intel GMA

Re: JavaFX versus AWT/Swing Hardware Acceleration

2014-01-03 Thread Chien Yang
Jim will probably has more to say about how the caching works. JavaFX has a unified texture resource management system for Prism. An aging algorithm is used to determine which native texture resource to be released when the system is low on VRAM or reached a system configurable VRAM threshold

Code Review Request for RT-35956: Add a stopgap fix to improve mesh update performance for limited use cases that doesn't do 3d lighting in the scene

2014-02-20 Thread Chien Yang
Kevin and Vadim, Please review this very limited and guarded fix as a temporary solution till we have a better API to support dynamic mesh update. More information about performance is captured in the JIRA. Webrev: http://cr.openjdk.java.net/~ckyang/RT-35956/webrev.00/ JIRA:

[8u20] Review request: RT-21702 - [Touch, Windows] MouseEvents generated from touch-screen action have isSynthesized() == false

2014-03-03 Thread Chien Yang
JIRA: https://javafx-jira.kenai.com/browse/RT-21702 Webrev: http://cr.openjdk.java.net/~ckyang/RT-21702/webrev.00/ Thanks, - Chien

Review request: RT-28977 - 3D API methods should handle null values consistently

2014-05-12 Thread Chien Yang
Hi Martin and Kevin, Please review the proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-28977 Webrev: http://cr.openjdk.java.net/~ckyang/RT-28977/webrev.00/ Thanks, - Chien

Code Review Request For RT-36270: Black screen instead of components on Linux

2014-05-14 Thread Chien Yang
Hi Kevin, Please review the proposed fix: https://javafx-jira.kenai.com/browse/RT-36270 Thanks, - Chien

Code Review Request For RT-35993: SceneBuilder does not work on ATI graphic card (build 14 and earlier version)

2014-05-14 Thread Chien Yang
Hi Vadim and Kevin, Please review the proposed fix: https://javafx-jira.kenai.com/browse/RT-35993 Thanks, - Chien

Code Review Request For RT-35153: [D3D] JavaFX SceneBuilder not working and as well as GUI is rendered very bad after installing VGA

2014-05-15 Thread Chien Yang
Hi Vadim and Kevin, Please review the proposed fix: https://javafx-jira.kenai.com/browse/RT-35153 Thanks, - Chien

Code Review Request For RT-37129: [Linux] Need to blacklist old ATI X1nnn series cards

2014-05-16 Thread Chien Yang
Hi Kevin and Vadim, Please review the proposed fix: https://javafx-jira.kenai.com/browse/RT-37129 Thanks, - Chien

Code Review Request For RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device

2014-07-02 Thread Chien Yang
Hi Kevin, Please review this fix, details is in the JIRA: https://javafx-jira.kenai.com/browse/RT-37789 - Chien

hg: openjfx/8u-dev/rt: Fix to RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device

2014-07-03 Thread chien . yang
Changeset: 5343b3c3f733 Author:Chien Yang chien.y...@oracle.com Date: 2014-07-03 13:38 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5343b3c3f733 Fix to RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device Reviewed by kcr. ! modules/graphics/src

hg: openjfx/8u-dev/rt: Fix to RT-37812: Potential NPE if es2 pipeline initialization fails.

2014-07-03 Thread chien . yang
Changeset: b205d3c0b524 Author:Chien Yang chien.y...@oracle.com Date: 2014-07-03 15:08 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b205d3c0b524 Fix to RT-37812: Potential NPE if es2 pipeline initialization fails. ! modules/graphics/src/main/java/com/sun/prism/es2

[8u40] post-commit notification: RT-37812 - Potential NPE if es2 pipeline initialization fails

2014-07-03 Thread Chien Yang
I just pushed a trivial fix for the following bug: JIRA: https://javafx-jira.kenai.com/browse/RT-37812 Details and changeset are in the JIRA. Thanks, - Chien

Code Review Request: RT-37808 - Enforce NPOT requirement on desktop and embedded for 3D support

2014-07-07 Thread Chien Yang
Hi Kevin, Please review my fix to RT-37808: https://javafx-jira.kenai.com/browse/RT-37808 Thanks, - Chien

hg: openjfx/8u-dev/rt: Fix to RT-37808: Enforce NPOT requirement on desktop and embedded for 3D support

2014-07-07 Thread chien . yang
Changeset: 046c16800215 Author:Chien Yang chien.y...@oracle.com Date: 2014-07-07 15:38 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/046c16800215 Fix to RT-37808: Enforce NPOT requirement on desktop and embedded for 3D support Reviewed by kcr ! modules/graphics/src

Re: Camera look at in 3d

2014-07-09 Thread Chien Yang
We aren't ready to support ease of easy camera controls in JavaFX 8. However our sample team did include a camera control utility in the JavaFX 8 Samples download. Please look for the com.javafx.experiments.jfx3dviewer package. Thanks, - Chien On 7/9/2014 3:26 AM, Jack Moxley wrote: One of

Code Review Request For RT-35173: Implement Alpha test functionality for the embedded platform

2014-07-15 Thread Chien Yang
Hi Dave, Jim and Kevin, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-35173 Thanks, - Chien

hg: openjfx/8u-dev/rt: Fix to RT-35173: Implement Alpha test functionality for the embedded platform

2014-07-15 Thread chien . yang
Changeset: 8d90dbdf7ee3 Author:Chien Yang chien.y...@oracle.com Date: 2014-07-15 16:34 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d90dbdf7ee3 Fix to RT-35173: Implement Alpha test functionality for the embedded platform Reviewed by flar, kcr ! modules/graphics

Code Review Request For RT-33209: Support 3D on the embedded platform

2014-07-16 Thread Chien Yang
Hi Dave, Lisa and Kevin, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-33209 Thanks, - Chien

hg: openjfx/8u-dev/rt: Fix to RT-33209: Support 3D on the embedded platform

2014-07-17 Thread chien . yang
Changeset: b15131b2d7dd Author:Chien Yang chien.y...@oracle.com Date: 2014-07-17 09:24 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b15131b2d7dd Fix to RT-33209: Support 3D on the embedded platform reviewed by kcr, lisa ! modules/base/src/main/java/com/sun/javafx

[8u40] API Review for RT-29012: Add support for vertex normals for meshes, in addition to smoothing groups

2014-08-04 Thread Chien Yang
Hi all, We would like to add support for a new vertex format that allows developers to specify their own normals for a given mesh. This work is small in its scope. It requires one new public class and a few new methods to two existing classes. When normals are provided using this new vertex

Re: How to learn the identity of the graphics card?

2014-08-06 Thread Chien Yang
There isn't a public Java API support for what you want to do. However if you are willing to patch JavaFX in your own build, you can add the bad card to the GLGPUInfo blackList[] in the GLFactory class of the specific platform if you are using the es2 pipe. You will need to dig down into the

Re: How to learn the identity of the graphics card?

2014-08-06 Thread Chien Yang
On 8/6/2014 9:57 AM, Mike Hearn wrote: The card isn't bad per se, it's just the HD4000 integrated graphics chip that older MacBook's ship with. It's just that I'm very picky about my framerates :) On Wed, Aug 6, 2014 at 6:49 PM, Chien Yang chien.y...@oracle.com mailto:chien.y...@oracle.com wrote

Re: How to learn the identity of the graphics card?

2014-08-06 Thread Chien Yang
PM, Mike Hearn wrote: I want to use it for rendering :) I just want to fall back to e.g. a color adjust instead of a GaussianBlur. On Wed, Aug 6, 2014 at 8:17 PM, Chien Yang chien.y...@oracle.com mailto:chien.y...@oracle.com wrote: Yes, we know that it is a perfectly fine entry level GPU

hg: openjfx/8u-dev/rt: Fix to RT-38351: [Gtk] Remove Failed in XOpenDisplay warning message

2014-08-18 Thread chien . yang
Changeset: ffedbb480817 Author:Chien Yang chien.y...@oracle.com Date: 2014-08-18 15:31 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ffedbb480817 Fix to RT-38351: [Gtk] Remove Failed in XOpenDisplay warning message A trivial post commit fix, tagged kcr as reviewer

hg: openjfx/8u-dev/rt: Fix to RT-29012: Add support for vertex normals for meshes, in addition to smoothing groups

2014-08-19 Thread chien . yang
Changeset: 1c84e8f0fda4 Author:Chien Yang chien.y...@oracle.com Date: 2014-08-19 13:40 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1c84e8f0fda4 Fix to RT-29012: Add support for vertex normals for meshes, in addition to smoothing groups Reviewed by kcr, vadim

hg: openjfx/8u-dev/rt: Added unit test for VertexFormat.POINT_NORMAL_TEXCOORD type

2014-08-21 Thread chien . yang
Changeset: 72e18dfa5a2a Author:Chien Yang chien.y...@oracle.com Date: 2014-08-21 12:46 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/72e18dfa5a2a Added unit test for VertexFormat.POINT_NORMAL_TEXCOORD type + tests/system/src/test/java/test3d

hg: openjfx/8u-dev/rt: Added test programs for diff vertex format with smooth shading comparison.

2014-08-25 Thread chien . yang
Changeset: f872f5196075 Author:Chien Yang chien.y...@oracle.com Date: 2014-08-25 15:42 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f872f5196075 Added test programs for diff vertex format with smooth shading comparison. + apps/toys/FX8-3DFeatures/src/fx83dfeatures

hg: openjfx/8u-dev/rt: Added visual unit test for diff vertex format comparison

2014-08-25 Thread chien . yang
Changeset: eb3b7811bc31 Author:Chien Yang chien.y...@oracle.com Date: 2014-08-25 16:41 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/eb3b7811bc31 Added visual unit test for diff vertex format comparison + tests/system/src/test/java/test3d/MeshCompareTest.java

[8u40] Code Review Request: RT-26108 - Implement auto-mipmap support

2014-08-29 Thread Chien Yang
Hi Kevin and Jim, Can you please the proposed implementation? https://javafx-jira.kenai.com/browse/RT-26108 Thanks, - Chien

hg: openjfx/8u-dev/rt: Fix to RT-26108: Implement auto-mipmap support

2014-09-04 Thread chien . yang
Changeset: a56acb9d85fa Author:Chien Yang chien.y...@oracle.com Date: 2014-09-04 20:50 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a56acb9d85fa Fix to RT-26108: Implement auto-mipmap support Reviewed by flar, kcr + apps/toys/FX8-3DFeatures/src/fx83dfeatures

Code Review Request For RT-38555: Shader compile failure with PickTest3D on i.MX6

2014-09-08 Thread Chien Yang
Hi Kevin and Dave, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-38555 Thanks, - Chien

hg: openjfx/8u-dev/rt: Fix to RT-38555: Shader compile failure with PickTest3D on i.MX6

2014-09-08 Thread chien . yang
Changeset: 3abef7f2f13f Author:Chien Yang chien.y...@oracle.com Date: 2014-09-08 15:47 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3abef7f2f13f Fix to RT-38555: Shader compile failure with PickTest3D on i.MX6 Reviewed by kcr ! modules/graphics/src/main/java/com/sun

hg: openjfx/8u-dev/rt: Redo fix to RT-38555: Shader compile failure with PickTest3D on i.MX6

2014-09-08 Thread chien . yang
Changeset: d7ac4b8e6371 Author:Chien Yang chien.y...@oracle.com Date: 2014-09-08 16:57 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d7ac4b8e6371 Redo fix to RT-38555: Shader compile failure with PickTest3D on i.MX6 Reviewed by kcr ! modules/graphics/src/main/java

hg: openjfx/8u-dev/rt: Fix to RT-38576: Windows: Compiler error reported when using parfait (clang++)

2014-09-09 Thread chien . yang
Changeset: e3db801977ca Author:Chien Yang chien.y...@oracle.com Date: 2014-09-09 14:55 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e3db801977ca Fix to RT-38576: Windows: Compiler error reported when using parfait (clang++) Reviewed by kcr ! modules/graphics/src

[8u40] Code Review Request For RT-38651: ES2: Need to provide query and print out (on verbose) support for OpenGL ES2 implementation dependent limits

2014-09-17 Thread Chien Yang
Hi Kevin and Jim, Please review the proposed enhancement: https://javafx-jira.kenai.com/browse/RT-38651 Thanks, - Chien

hg: openjfx/8u-dev/rt: Fix to RT-38651: ES2: Need to provide query and print out (on verbose) support for OpenGL ES2 implementation dependent limits

2014-09-18 Thread chien . yang
Changeset: ceb8b1f8094f Author:Chien Yang chien.y...@oracle.com Date: 2014-09-18 21:29 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ceb8b1f8094f Fix to RT-38651: ES2: Need to provide query and print out (on verbose) support for OpenGL ES2 implementation dependent

hg: openjfx/8u-dev/rt: Fix to RT-30529: Implement gradle findbugs task

2014-09-18 Thread chien . yang
Changeset: e5508cd5b8a5 Author:Chien Yang chien.y...@oracle.com Date: 2014-09-18 21:47 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e5508cd5b8a5 Fix to RT-30529: Implement gradle findbugs task Reviewed by kcr ! build.gradle

[8u26] Code Review Request For RT-38628: BoxBlur effect leads to runtime exception in embedded JavaFX

2014-09-22 Thread Chien Yang
Hi Jim and Kevin, Please review the proposed fix: https://javafx-jira.kenai.com/browse/RT-38628 Thanks, - Chien

[8u40] Code Review Request For RT-38808: Mac + JFXPanel + popups: JRE fatal error.

2014-10-11 Thread Chien Yang
Hi Kevin, Please review this simple workaround fix as we have discussed: Webrev: https://javafx-jira.kenai.com/browse/RT-38808 Thanks, - Chien

[8u40] Code Review Request for RT-38726: Scene and scenegraph leak when the Stage is closed

2014-10-23 Thread Chien Yang
Hi Kevin and Morris, Please review the proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-38726 Webrev: http://cr.openjdk.java.net/~ckyang/RT-38726/webrev.00/ Thanks, - Chien

Code Review Request For RT-37946: Add a needsAlphaTest() method to BaseGraphics Class

2014-10-29 Thread Chien Yang
Hi Kevin, Please review this simple refactoring work: JIRA: https://javafx-jira.kenai.com/browse/RT-37946 Thanks, - Chien

[8u40] Post commit notification: RT-39364: Code cleanup: Better naming for scene antialiasing in toolkit and prism

2014-11-11 Thread Chien Yang
This is a prep work for RT-38063 and it is reviewed by kcr. - Chien

[8u40] Code Review Request For RT-39455: Remove unused ShapeUtil.rasterizeGlyphOutline method and relevant prism settings

2014-11-21 Thread Chien Yang
Hi Jim, Phil or Kevin, Please review the proposed fix posted in this JIRA: JIRA: https://javafx-jira.kenai.com/browse/RT-39455 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39455/webrev.00/ Thanks, - Chien

[8u60] Code Review Request For RT-39547: [ES2, 3D] Shader fails on embedded devices with no default precision defined

2014-12-04 Thread Chien Yang
Hi Dave, Jim, Kevin and Vadim, Please review and test the proposed fix if you have an embedded setup. JIRA: https://javafx-jira.kenai.com/browse/RT-39547 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39547/webrev.00/ Thanks, - Chien

[8u60] Code Review Request For RT-39666: Add GL_FRAGMENT_PRECISION_HIGH check to existing 2D shaders before setting precision to highp

2014-12-18 Thread Chien Yang
Hi Kevin and Dave, Please review this fix. JIRA: https://javafx-jira.kenai.com/browse/RT-39666 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39666/webrev.00/ Thanks, - Chien

[8u60] Code Review Request For RT-30193: PrismSettings minTextureSize does not work

2014-12-19 Thread Chien Yang
Hi Jim and Kevin, Please review this fix: JIRA: https://javafx-jira.kenai.com/browse/RT-30193 Webrev: http://cr.openjdk.java.net/~ckyang/RT-30193/webrev.00/ Thanks, - Chien

Re: Release date for Java 8u40

2014-12-24 Thread Chien Yang
Scheduled GA is March 2015: http://openjdk.java.net/projects/jdk8u/releases/8u40.html - Chien On 12/24/2014 12:54 PM, Peter Penzov wrote: Hi All, What is the release date for Java 8u40? BR

Re: NPE in VirtualFlow

2015-01-02 Thread Chien Yang
The closest I can find that is somewhat related to TableView and NPE, but not exactly the same issue is the following JIRA: https://javafx-jira.kenai.com/browse/RT-39624 Please file a JIRA once you have a reproducible test case ready. Here is a link on how to file a bug report with us:

Re: 3D shape not clipped by ScrollPane properly?

2015-01-02 Thread Chien Yang
We haven't specified the semantic of Clip on 3D primitive and it is currently a NOP. - Chien On 12/29/2014 3:28 PM, Mike Hearn wrote: I have a ScrollPane into which I put a Pane with a min width/height, and then I place a Button and a Sphere. For both of them I use setLayoutX/Y to move them

Code Review Request For RT-39921: With two or more application modal windows; windows deeper in the stack are receiving requestToFront when not enabled causes an NSBeep.

2015-02-04 Thread Chien Yang
Hi Kevin, Please review this straightforward fix: JIRA: https://javafx-jira.kenai.com/browse/RT-39921 webrev: http://cr.openjdk.java.net/~ckyang/RT-39921/webrev.00/ Thanks, - Chien

Re: Directional light in JavaFX 3D

2015-02-06 Thread Chien Yang
Hi Herve, A JIRA for directional light has already been filed but there is no immediate plan to add this feature at the moment. Currently JavaFX 3D only supports point light and ambient light. - Chien On 2/6/15 3:10 PM, Herve Girod wrote: Hello, Are there plans to implement an API

Re: Directional light in JavaFX 3D

2015-02-06 Thread Chien Yang
Sorry, I forgot to paste the JIRA link before hitting the send button. https://javafx-jira.kenai.com/browse/RT-33899 - Chien On 2/6/15 3:16 PM, Chien Yang wrote: Hi Herve, A JIRA for directional light has already been filed but there is no immediate plan to add this feature at the moment

Code Review Request For RT-39873: [Mac] Enable parallel execution of FX thread and Renderer thread for JFXPanel, FXCanvas

2015-01-27 Thread Chien Yang
Hi Kevin, Please review the simple proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-39873 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39873/webrev.00/ - Chien

Code Review Request For RT-40245: Regression: Mac (prism-sw) rendering is corrupted

2015-03-17 Thread Chien Yang
Hi Kevin and Jim, Please review the proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-40245 Webrev: http://cr.openjdk.java.net/~ckyang/RT-40245/webrev.00/ Thanks, - Chien

Code Review Request For RT-37862: [ScenePulseListener] NPE in synchronizeSceneProperties

2015-03-19 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://javafx-jira.kenai.com/browse/RT-37862 Thanks, - Chien

Re: Using JavaFX on VMWare / Linux

2015-02-26 Thread Chien Yang
Hi Adam, I would like to inform you that VMware is not a certified hypervisor for Oracle JDK 8 and JRE 8, and hardware rendering is not supported in guest systems on Oracle VM, VirtualBox and Hyper-V Server 2012. Please see this link for details information:

Code Review Request For RT-40099: GridPane percentage layout bug since JavaFx 8u40

2015-03-03 Thread Chien Yang
Hi Kevin, Please review the proposed fix. Detail information is in the JIRA: https://javafx-jira.kenai.com/browse/RT-40099 Thanks, - Chien

Code Review Request For RT-40004: [3D] Texture transparency is ignored in 8u40

2015-04-21 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JiRA: https://javafx-jira.kenai.com/browse/RT-40004 Webrev: http://cr.openjdk.java.net/~ckyang/RT-40004/webrev.00/ Thanks, - Chien

Code Review Request For RT-39856: Layout Regression - bad row height

2015-04-28 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://javafx-jira.kenai.com/browse/RT-39856 Thanks, - Chien

Code Review Request For RT-39418: [Mac,Retina,3D] Lighting is wrong (too dark, incorrect highlight) with pixel scaling

2015-05-06 Thread Chien Yang
Hi Kevin and Jim, Please review the proposed fix, and detail information is in the JIRA: JIRA: https://javafx-jira.kenai.com/browse/RT-39418 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39418/webrev.00/ - Chien

  1   2   >