Re: API review RT-30861: Add simple Font factory method for a default font of a different size

2013-06-03 Thread David Grieve
to take more than a few minutes to figure out, best to punt on this rather than soak up Felipe's precious time. I think its fine. -phil. Richard On Jun 3, 2013, at 11:26 AM, David Grieve david.gri...@oracle.com wrote: I would rather see the deriveFont methods, but not as factory methods

Re: How to see when a scene gets shown?

2013-06-13 Thread David Grieve
Get the window of the scene and add a handler for the onShownProperty via the setOnShown method. Add a listener to the Scene's windowProperty and add/remove your handler there. On Jun 13, 2013, at 8:19 AM, Pedro Duque Vieira pedro.duquevie...@gmail.com wrote: Hi Werner, Thanks for your

Re: Get style properties

2013-06-18 Thread David Grieve
On Jun 18, 2013, at 3:54 PM, Mario Torre neug...@redhat.com wrote: Hi all! I was trying to figure out how JavaFX parses and uses the style under the hood and I stumbled on something I don't fully understand (I admit I'm not really a CSS expert yet :). In the modena.css, right at the

[API Review] Make Scene styleable through CSS

2013-06-25 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-31282 Scene has a fillProperty which should be styleable via CSS but this would require making Scene implement the javafx.css.Styleable interface. The interesting bits from the interface are public String getId() public ObservableListString

Re: [API Review]: Node validation

2013-07-03 Thread David Grieve
Hi Martin, With regard to having this work without a Scene… I think having a method that would layout a node without the node actually having to be part of the scene-graph would be _very_ useful. Often times, developers will do the show-hide trick or add-remove trick to get a node's bounds

Re: [API Review]: Node validation

2013-07-09 Thread David Grieve
On Jul 8, 2013, at 9:52 AM, David Grieve david.gri...@oracle.com wrote: I'm wondering why this validate can't just be implicit in any call that uses or returns layout bounds. Surely we can tell from the dirty bits whether or not something needs layout and/or css. On Jul 8, 2013, at 12:31 PM

Re: CFV: New OpenJFX Committer: Oleg Mazurov

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:17 PM, Richard Bair richard.b...@oracle.com wrote: I hereby nominate Oleg Mazurov to OpenJFX Committer. Oleg has been a key behind-the-scenes contributor to JavaFX performance. Some of his contributions can be counted in code

Re: CFV: New OpenJFX Committer: Danno Ferrin

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:03 PM, Richard Bair richard.b...@oracle.com wrote: I hereby nominate Danno Ferrin to OpenJFX Committer. Danno has been actively submitting patches and following up to make sure they get integrated for the past 8 months or so (the first patch I found was on

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:07 PM, Richard Bair richard.b...@oracle.com wrote: I hereby nominate Debbie Masada to OpenJFX Committer. Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent

Re: [API Review]: Node validation

2013-07-12 Thread David Grieve
I hesitate to mention Node#impl_processCSS(boolean) which is very very close to your notion of applyCss(); impl_processCSS(boolean) is a thorn in my side, but is used in certain places in controls code to ensure CSS is applied before layout in order to ascertain a node's dimensions. What it

Re: [API Review]: Node validation

2013-07-12 Thread David Grieve
or was it just to cover up errors we were seeing? I remember having done this but don't remember if it was truly needed or not? Richard On Jul 12, 2013, at 9:03 AM, David Grieve david.gri...@oracle.com wrote: I hesitate to mention Node#impl_processCSS(boolean) which is very very close to your

Re: Overriding caspian.css -fx-background

2013-07-17 Thread David Grieve
Probably a question better put to the OTN forums, but… In caspian.css, you'll find /* A very light grey used for the background of windows. See also * -fx-text-background-color, which should be used as the -fx-text-fill * value for text painted on top of backgrounds colored with

Re: Font size in JavaFX 8

2013-07-18 Thread David Grieve
Which build? Yesterday I filed https://javafx-jira.kenai.com/browse/RT-31745 On Jul 18, 2013, at 9:39 AM, Peter Penzov peter.pen...@gmail.com wrote: Hi, I tested to run code developed on JavaFX 2.2. On JavaFX 8 the size of the Font cannot be set properly with setStyle(-fx-font-size:

Proposal to move default style-class from Control to SkinBase

2013-08-07 Thread David Grieve
Currently, a control has a default style-class. For example, you can use .button in a style-sheet to style a Button. I propose to move the default style-class from the control to the skin (RT-32186). The impetus for this change is two-fold. Firstly, it can be argued that setting the

Re: Form of ProgressIndicator

2013-08-07 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-31196 On Aug 7, 2013, at 12:35 PM, Martin Klähn grazer...@gmail.com wrote: Hi guys, I've just realized that the ProgressIndicator in Modena isn't shown as a rotating circle. It looks like somebody pried apart the ProgressWheel and left it apart.

Re: custom Styleable properties CSS prefix

2013-08-15 Thread David Grieve
I'm assuming this is 8.0? If so, what com.sun classes did you need to pull in and why? I'd like to know from the perspective of the owner of the styleable API. If you have to pull in com.sun, then I might have missed something somewhere since all you should need is in the javafx.css package.

Re: CFV: New OpenJFX Committer: Mick Fleming

2013-08-15 Thread David Grieve
Vote: Yes On Aug 15, 2013, at 2:11 PM, Artem Ananiev artem.anan...@oracle.com wrote: I hereby nominate Mick Fleming (OpenJDK user name: mickf) to OpenJFX Commmitter. Mick is a member of JavaFX Controls team at Oracle. He fixed many bugs and implemented tons of features in virtually

Re: CFV: New OpenJFX Committer: Felipe Heidrich

2013-08-15 Thread David Grieve
Vote: Yes On Aug 15, 2013, at 1:36 PM, Artem Ananiev artem.anan...@oracle.com wrote: I hereby nominate Felipe Heidrich (OpenJDK user name: felipe) to OpenJFX Committer. Felipe is a member of JavaFX graphics group at Oracle. He is mostly responsible for JavaFX text and fonts, but not

Re: PrefWidth/Height calculations only works if stage is shown

2013-08-28 Thread David Grieve
There is https://javafx-jira.kenai.com/browse/RT-21206, which I've just edited to be public. On Aug 28, 2013, at 2:29 PM, John Smith john_sm...@symantec.com wrote: Is there any plan to make impl_processCSS(true) public API? Should I create a Jira for this? If there were a public API, would

Re: Changes in caspian.bss

2013-09-14 Thread David Grieve
This is (or should be) RT-32839, which is fixed in 8.0 and should make its way into next week's promotion. On Sep 14, 2013, at 7:26 AM, Tom Eugelink t...@tbee.org wrote: On JavaFX 8.0 we're getting all kind of CSS warnings when running the JFXtras 8.0 project. I personally am waiting for

Re: Lambdafication (was Re: Default methods in JFX-8)

2013-10-03 Thread David Grieve
And what about Stream? I like the declarative code that comes from using Stream and I can see places in the code where Stream could be used, but I wonder about its performance relative to iterators and/or enhanced for loops. On Oct 3, 2013, at 4:45 PM, Richard Bair richard.b...@oracle.com

Re: CFV: New OpenJFX Committer: Victor Shubov

2013-10-24 Thread David Grieve
Vote: YES On Oct 24, 2013, at 9:05 AM, Artem Ananiev artem.anan...@oracle.com wrote: I hereby nominate Victor Shubov to OpenJFX Committer. Victor is a member of JavaFX SQE team at Oracle. He has already contributed enough changesets into the tests repository: $ hg log -M -u Victor

Review Request: RT-26277 [API, Layout] Percentage doesn't work in CSS Insets anymore

2013-11-07 Thread David Grieve
Dear OpenJFX Community, Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-26277 The webrev is available at: http://cr.openjdk.java.net/~kcr/RT-26277/webrev/ The JIRA issue contains detailed information. Thanks, David

[API review] Relevant to RT-26277. Affects Region layout. Your input is needed.

2013-11-20 Thread David Grieve
The purpose of this email is to solicit feedback on an issue related to Region layout and the use of percent values in insets. https://javafx-jira.kenai.com/browse/RT-26277 is the relevant JIRA issue. Currently, a Region's width and height depends on the width and height of its content plus

[JavaFX 8.0] Review request for RT-33919: Unit test failure in Node_cssStyleMap_Test :: testStyleMapTracksChanges

2013-11-22 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-33919 Please review: http://cr.openjdk.java.net/~dgrieve/RT-33919/webrev/ Reviewers: jgiles The ObservableMapStyleableProperty?,ListStyle should only contain only those styles that apply in the current CSS transition state. This fix resolves a regression

Re: Slider CSS skinning

2013-11-27 Thread David Grieve
Here is one way that uses a linear-gradient style where the stop offsets are defined by the slider value public void startx(Stage stage) VBox vbox = new VBox(4); final Slider slider = new Slider(); SliderSkin skin = new SliderSkin(slider); slider.setSkin(skin);

Re: Creating a type of toggle with two labels..

2013-12-04 Thread David Grieve
You might want to look at what Gerrit has done here: http://harmoniccode.blogspot.com/2013/10/friday-fun-xviii.html On Dec 4, 2013, at 5:05 PM, Pedro Duque Vieira pedro.duquevie...@gmail.com wrote: OK, sounds reasonable. Too bad about the code duplication that will need to take place.

Re: Reloading stylesheets

2013-12-10 Thread David Grieve
The way it works in 8.0 is that there is a cache of loaded stylesheets. When a scene or parent adds a stylesheet, the stylesheet is added to the cache. Any other scene or parent that uses the same stylesheet will get the one from cache. If a scene or parent later removes the stylesheet, the

Re: Reloading stylesheets

2013-12-11 Thread David Grieve
. Nothing visible happens when I do: scene.stylesheets.clear() scene.stylesheets.add(sameStylesheet) Given your description below, my impression is that RELOADING should also work... Thank you for any suggestions, Neil From: David Grieve david.gri...@oracle.com

Re: Reloading stylesheets

2013-12-12 Thread David Grieve
by:openjfx-dev-boun...@openjdk.java.net This is also impacting Scene Builder. I have filed a Jira with a test case: https://javafx-jira.kenai.com/browse/RT-34863 Jerome On 12/11/13 6:19 PM, David Grieve wrote: There is clearly a bug there somewhere. Would you mind filing

Re: A lot WARING with CSS

2013-12-15 Thread David Grieve
This is of concern to me as I have tried to maintain backward compatibility. It would be helpful if you would file a bug on this and include your .css file, if possible. On Dec 14, 2013, at 3:25 PM, Francisco Javier Godino jgod...@yahoo.com wrote: I have an application running perfectly with

Re: Programmatic (Java) access to style / layout ?

2013-12-17 Thread David Grieve
It is possible, but probably not in the way that https://javafx-jira.kenai.com/browse/RT-17293 would provide. By that I mean, it would be nice to be able to progammatically say the border color for this button when hovered is red. This can be done now by adding an invalidation listener to the

Re: (in)sanity testing

2013-12-19 Thread David Grieve
controls test, for example). Something like basic graphics, extended graphics, all controls, media, 3D, etc. What do you think? Lisa On 12/19/2013 10:47 AM, David Grieve wrote: I typically ran rt-closed/toys/run-many.sh On the plane to Houston, I started playing with a UI that will list

Re: CSS metadata boilerplate

2014-01-08 Thread David Grieve
The reason things are as they are is because most properties in the core classes are lazily created and I didn't want cause the property to be created just to see if it was bound. But that is a particular concern for the core classes and not so much for controls. I'm not sure if you are aware

Re: CSS metadata boilerplate

2014-01-09 Thread David Grieve
Thanks, John. It would be helpful if you could create an issue in jira to track this. On Jan 8, 2014, at 4:18 PM, John Hendrikx hj...@xs4all.nl wrote: On 8/01/2014 14:28, David Grieve wrote: The reason things are as they are is because most properties in the core classes are lazily created

Re: Bug Pass Friday

2014-01-10 Thread David Grieve
I'm going to take a pass at bugs assigned to Mick. https://javafx-jira.kenai.com/issues/?jql=project%20%3D%20RT%20AND%20issuetype%20%3D%20Bug%20AND%20resolution%20%3D%20Unresolved%20AND%20assignee%20%3D%20mickf If I get through that list, I'll start in on

Re: Future of Skins

2014-01-24 Thread David Grieve
On Jan 24, 2014, at 4:02 PM, John Hendrikx hj...@xs4all.nl wrote: I've got an update on this. I've rewritten the code now to make use of multiple skins, and doing some trickery with Factories to make them easily switchable. The main reason I've rewritten them is because I think I will

Re: Future of Skins

2014-01-27 Thread David Grieve
On Jan 25, 2014, at 5:54 AM, John Hendrikx hj...@xs4all.nl wrote: On 24/01/2014 22:28, David Grieve wrote: On Jan 24, 2014, at 4:02 PM, John Hendrikxhj...@xs4all.nl wrote: I've got an update on this. I've rewritten the code now to make use of multiple skins, and doing some trickery

Re: javafx on android - weird box within regions

2014-01-28 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-30479 is probably the issue you are bumping up against. On Jan 28, 2014, at 2:29 PM, Christoph Caks cc...@bestsolution.at wrote: Hi, I have a question regarding regions on android it seems that all regions with a set background have some kind of

[8u] Code Review Request: RT-21495 ScrollPane doesn't take content size into account on USE_COMPUTED_SIZE

2014-01-29 Thread David Grieve
Hi Jonathan, Martin, Please review https://javafx-jira.kenai.com/browse/RT-21495. A patch is attached to the bug that follows the comment I added to the bug on January 13th. The patch addresses Alexander's observation re: potential NPE.

Re: ScrollPane needs GrowToFitWidth?

2014-01-31 Thread David Grieve
I encourage you to take a hack at ScrollPaneSkin. In particular the method computeScrollNodeSize. I suspect the change would be pretty much localized to this method. On Jan 31, 2014, at 2:02 PM, Jeff Martin j...@reportmill.com wrote: ScrollPane has the feature for content that needs to track

Re: Question about CSS styling

2014-02-19 Thread David Grieve
On 2/19/14, 5:07 AM, Hervé Girod wrote: Hello, I have a question about how the CSS styling work, when a node skin use sub nodes. For example, the Button control uses a LabeledText, but it is not necessary to setup the style of the LabeledText inside the button to set the font of the button

Re: JavaFX suggestions from Alex Kishko

2014-02-21 Thread David Grieve
On 2/21/14, 11:36 AM, Aliaksei Kishko wrote: Hello. I allow me to express several opinions on the JavaFX: 5) Styles need get pseudo classes via setStyle(), for example: menuItem.setStyle(:focused {-fx-background-color: yellow;}); The Node#setStyle(String) API is analogous to the 'style'

Re: CSS Font size in points doesn't match Node.Font.Size

2014-03-05 Thread David Grieve
Everyone should just accept that there is no such thing as a 'point' in JavaFX. Work in pixels and you will achieve nirvana. On 3/5/14, 5:49 PM, Pedro Duque Vieira wrote: Here is the definition of point: http://www.w3schools.com/cssref/css_units.asp As Jeff is saying it should be 1/72 inch.

[8u] Review request: RT-37033, CSS warnings (related to MenuItem)

2014-03-06 Thread David Grieve
Hi Martin, Please review Webrev: http://cr.openjdk.java.net/~dgrieve/RT-33073/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-33073 Details are in JIRA. Please note that the webrev has diffs for cssref.html that are not related to this change but are there because of a changeset I

Re: CSS Font size in points doesn't match Node.Font.Size

2014-03-06 Thread David Grieve
Hey Felipe, I recall a couple of years ago when Phil drilled it into me that Font size was pixels. So when you said that Font size is point, I was skeptical. But, indeed, you are correct and I am mistaken. I see now that setting font size from point units in our CSS is broken. Our CSS

Re: CSS Font size in points doesn't match Node.Font.Size

2014-03-06 Thread David Grieve
On 3/6/14, 4:10 PM, Phil Race wrote: I think your sum is backward. If 0.75pts==1 pixel then a 12 pt font will be 16 pixels. Exactly why my wife doesn't let me near the checkbook.

Re: Node.impl_getMatchingStyles

2014-03-20 Thread David Grieve
The JIRA issue (now public) just says that these impl_ methods that SceneBuilder uses need to be public API. Much work needs to be done in the area of public API for accessing CSS styles and whatnot. But, unless I'm told otherwise, there won't be any implementation of such an API before 9.

[8u Review Request] RT-36808: items added to AreaChart have no symbol

2014-03-20 Thread David Grieve
Jonathan, Please review http://cr.openjdk.java.net/~dgrieve/RT-36068/webrev.00/ Details of the change can be found in https://javafx-jira.kenai.com/browse/RT-36068 Thanks, -- David

Re: Proposal on getting warning free (controls) packages

2014-03-20 Thread David Grieve
Too bad we can't go back and have WritableValue also extend Styleable... I'm happy to live with the @SuppressWarnings in this particular context since we know that graphicProperty is indeed a StyleablePropertyNode, as is the case where we cast in implementations of the CssMetaData

[8u Review Request] RT-35864: Button's events are not working in a ListView

2014-03-26 Thread David Grieve
Jonathan, Please review: http://cr.openjdk.java.net/~dgrieve/RT-35864/webrev.00 A summary of the changes is in: https://javafx-jira.kenai.com/browse/RT-35864

[8u post-commit notification] RT-36272: WARNING: Could not resolve messages from CSS

2014-03-27 Thread David Grieve
Hopefully this will resolve this annoying warning once and for all. Details of the change may be found in JIRA. Changeset is http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/37342603df94: JIRA issue is : https://javafx-jira.kenai.com/browse/RT-36272

Re: hg: openjfx/8u-dev/rt: [Accessibility] RT-36400 review. Code format, do not use accGetAttribute in glass, make that lambda HOT!

2014-04-02 Thread David Grieve
I thought we were staying away from the Stream API for now? On 4/2/14, 2:17 PM, hang...@oracle.com wrote: Changeset: db120a66633f Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2014-04-02 11:13 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/db120a66633f

[8u20] API Review: RT-35260 add user-agent stylesheets to Scene

2014-04-11 Thread David Grieve
This is coming a bit late in the game, but the proposal is to add this API to Scene: public ObservableListString getUserAgentStylesheets() This would allow a Scene to have a user-agent style distinct from the application. https://javafx-jira.kenai.com/browse/RT-35260

[8u post commit review]: RE-32560: Changing user_agent stylesheet on scene or subscene

2014-04-24 Thread David Grieve
Jonathan, Could you please review: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/fe6fe6108a11 for https://javafx-jira.kenai.com/browse/RT-35260. I still need to update the cssref and to add unit tests.

Re: Cleaning up Control codebase - How to deal with StyleableProperty cast

2014-05-01 Thread David Grieve
naturally look at this from another angle and say the Syleable interface should have been shown in the API but I guess this not going to change so we need to live with casts and the implementation detail. Tom On 30.04.14 15:39, Tom Schindl wrote: Hi, On 29.04.14 14:35, David Grieve wrote: I've

Re: (In)Sanity testing

2014-05-06 Thread David Grieve
Unit test only changes, too? On 5/5/14, 11:07 AM, Stephen F Northover wrote: Hi all, Note also that this is M4 Milestone week which means no post-commit reviews and extra +1 controls required to release code. The main point is that one of Kevin, Daniel, Jasper, Lisa or David H must be

[8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-08 Thread David Grieve
This bug was reviewed and approved before, but in looking for a fix for RT-36995, I found some issues with the fix. Namely, that it was possible to have more than one REAPPLY queued up and that it was possible for the REAPPLY happen without a following UPDATE. Rather than roll the fixes for

[8u] Review Request: RT-36995

2014-05-08 Thread David Grieve
Please review https://javafx-jira.kenai.com/browse/RT-36995. The fix is a one-liner, so there is no webrev.

[8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-09 Thread David Grieve
Per Kevin's instructions, the previous changeset for RT-36838 was backed out in order to resolve RT-36995. I've attached a new webrev to RT-36838 which is an improved fix for RT-36838 and which also ensures RT-36995 doesn't regress. These changes won't be pushed until after M4 integration.

[8u] Review Request: RT-37018 - 3DViever hangs if OFF button in MSAA Antialiasing is selected

2014-05-09 Thread David Grieve
Issue is caused by an infinite loop in StyleManager code. The code in question was referencing the wrong variable. Trivial fix can be found in the JIRA issue. https://javafx-jira.kenai.com/browse/RT-37018

Re: [8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-12 Thread David Grieve
Can I get your +1 or -1 on this change. Thanks. On 5/9/14, 10:45 AM, David Grieve wrote: Per Kevin's instructions, the previous changeset for RT-36838 was backed out in order to resolve RT-36995. I've attached a new webrev to RT-36838 which is an improved fix for RT-36838 and which also

[8u] Review Request: RT-37025 - CSS not reloaded when loaded through FXML

2014-05-12 Thread David Grieve
Jonathan, Can I get you to review https://javafx-jira.kenai.com/browse/RT-37025 http://cr.openjdk.java.net/~dgrieve/RT-37025/webrev.00/ Thanks

Re: CFV: New OpenJFX Committer: Jerome Cambon

2014-05-14 Thread David Grieve
Vote: YES On 5/14/14, 1:39 PM, Stephen F Northover wrote: I hereby nominate Jerome Cambon to be an OpenJFX Committer. Jerome Cambon is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Inspector Panel as well as the CSS Panel. Jerome has

Re: CFV: New OpenJFX Committer: Mo Chicharro

2014-05-14 Thread David Grieve
Vote: YES On 5/14/14, 1:48 PM, Stephen F Northover wrote: I hereby nominate Mo Chicharro to be an OpenJFX Committer. Mo Chicharro is a significant contributor of the JavaFX Scene Builder 2.0 product, and, as the visual and interaction designer, he is the designated owner of all FXML and CSS

Re: CFV: New OpenJFX Committer: Sandra Lions-Piron

2014-05-14 Thread David Grieve
Vote: YES On 5/14/14, 1:48 PM, Stephen F Northover wrote: I hereby nominate Sandra Lions-Piron to be an OpenJFX Committer. Sandra Lions-Piron is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Hierarchy Panel as well as all menu commands.

Re: CFV: New OpenJFX Committer: Yves Joan

2014-05-14 Thread David Grieve
Vote: YES On 5/14/14, 1:48 PM, Stephen F Northover wrote: I hereby nominate Yves Joan to be an OpenJFX Committer. Yves Joan is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Library Panel, Document Panel and product packaging. Yves has

[8u] Review Request: (RT-36554) Ensemble8: Mac: System menu stays on screen after leaving the Menu demo

2014-05-14 Thread David Grieve
Jonathan, Please review http://cr.openjdk.java.net/~dgrieve/RT-36554/webrev.00/ https://javafx-jira.kenai.com/browse/RT-36554 Kevin, Steve, Lisa I'd like at least one of you to review the StubToolkit change for cross-platform considerations (I'm assuming there are none).

[8u] Review Request: (RT-36778) [TitledPane] Focus on TitledPane inside Accordion not visible

2014-05-15 Thread David Grieve
Jonathan, I've pasted a diff for modena.css in https://javafx-jira.kenai.com/browse/RT-36778

Re: Javadocs and CSS

2014-05-16 Thread David Grieve
Would you mind creating a bug for this? On 5/16/14, 10:38 AM, Scott Palmer wrote: Should a better cross-reference or mention of CSS properties in the Javadocs? Many properties can be set via calling methods or through CSS, but when browsing the Javadocs the related CSS properties are not

Re: Javadocs and CSS

2014-05-16 Thread David Grieve
Maintaining the css ref is a real pain. All those tables should be given over to an automated process. On 5/16/14, 12:03 PM, Scott Palmer wrote: I'm not sure what you mean. I'm only talking about documentation for the public API. It's just a clarification for the existing docs. On a side

Re: TabPaneSkin modification of styleable property

2014-05-20 Thread David Grieve
Good find. The code needs to save off the StyleOrigin and use applyStyle instead of set. I don't like that you have to deal with this level of detail, but I haven't figured out any way around it yet. I'm open to ideas. // save and set tab animation to none - as it is not a

Re: TabPaneSkin modification of styleable property

2014-05-20 Thread David Grieve
, David Grieve wrote: Good find. The code needs to save off the StyleOrigin and use applyStyle instead of set. I don't like that you have to deal with this level of detail, but I haven't figured out any way around it yet. I'm open to ideas. // save and set tab animation to none

[8u] Review Request: (RT-37174) [Ensemble8] Progress Indicator sample: indeterminate progress indicator stops spinning on re-entering sample

2014-05-20 Thread David Grieve
Jonathan, Martin, Please review http://cr.openjdk.java.net/~dgrieve/RT-37174/webrev.00/ http://cr.openjdk.java.net/%7Edgrieve/RT-37174/webrev.00/ https://javafx-jira.kenai.com/browse/RT-37174

[8u] Review request: (RT-37168) Mention if a property is configurable via CSS in the javadocs.

2014-05-22 Thread David Grieve
Steve, Kevin, I'm looking for your ok on a change to rt/build.gradle that will allow me to add @css tags in javadoc. The diff is in the bug. This isn't the fix for the bug, but if you don't want to allow the tag option, then I need to approach this bug in a different way.

Re: [8u] Review request: (RT-37168) Mention if a property is configurable via CSS in the javadocs.

2014-05-22 Thread David Grieve
Only if someone runs javadoc without adding a -tag css arg, which will result in an 'unknown tag' error. On 5/22/14, 3:35 PM, Stephen F Northover wrote: Hi David, I didn't see a problem with this. Is there a downside to adding arbitrary tags to JavaDoc? Steve On 2014-05-22 3:23 PM, David

Re: [8u] Review request: (RT-37168) Mention if a property is configurable via CSS in the javadocs.

2014-05-22 Thread David Grieve
easier! Tom On 22.05.14 21:42, David Grieve wrote: Only if someone runs javadoc without adding a -tag css arg, which will result in an 'unknown tag' error. On 5/22/14, 3:35 PM, Stephen F Northover wrote: Hi David, I didn't see a problem with this. Is there a downside to adding arbitrary tags

Re: CSS vs API modifications in *View classes

2014-05-28 Thread David Grieve
Using styles is preferable to setting the property value. If styles are used, then you don't have the problem you describe. An alternative, if styles are not used, is to cast the property to StyleableProperty and use applyStyle(null, value) instead of set. CSS then thinks that the value has

Re: CSS vs API modifications in *View classes

2014-05-29 Thread David Grieve
a clue about it. Tom Von meinem iPhone gesendet Am 28.05.2014 um 21:19 schrieb David Grieve david.gri...@oracle.com: Using styles is preferable to setting the property value. If styles are used, then you don't have the problem you describe. An alternative, if styles are not used, is to cast

[8u] Review Request: (RT-37299) Separator orientation pseudoclass states don't appear to fire properly

2014-05-29 Thread David Grieve
Jonathan, Please review https://javafx-jira.kenai.com/browse/RT-37299 Webrev: http://cr.openjdk.java.net/~dgrieve/RT-37299/webrev.00

[8u] Review Request: (RT-37173) modena styles for .title-pane don't match what is intended

2014-05-29 Thread David Grieve
Jonathan, If you would please review, https://javafx-jira.kenai.com/browse/RT-37173 Webrev: http://cr.openjdk.java.net/~dgrieve/RT-37173/webrev.00

[8u] Review Request: (RT-23891) [HTMLEditor] content is confused during selection, styles are lost

2014-06-03 Thread David Grieve
Please review diff which is entered as a comment in the bug. The diff changes a MouseEvent handler to update the toolbar state on mouse-released rather than updating the toolbar state on _every_ mouse event. https://javafx-jira.kenai.com/browse/RT-23891

[8u] Review Request: RT-37408: [ScrollPane] incorrect preferred size when viewport pref size is specified and bar is present

2014-06-05 Thread David Grieve
Martin, Please review the patch attached to https://javafx-jira.kenai.com/browse/RT-37408.

[8u] Review Request: RT-37420: [TableView] TableView custom TableCell with ComboBoxes not editable

2014-06-11 Thread David Grieve
Jonathan, Please review the diff added as a comment to https://javafx-jira.kenai.com/browse/RT-37420.

Re: Adding application-wide stylesheet

2014-06-12 Thread David Grieve
In 8u20, you can use @import in your .css file. That, along with Application#setUserAgentStylesheet(String), should do the trick. If I'm missing something, then please feel free to create a new feature request in JIRA. On 6/12/14, 4:57 PM, Robert Krüger wrote: Hi, RT-18543 has been closed

[8u40] Review request: (RT-36510) [CSS] Reduce CssMetaData boilerplate code

2014-06-19 Thread David Grieve
I have attached some java files to RT-36510 that are aimed at reducing the amount of boiler-plate code needed to implement StyleableProperty and CssMetaData. The code is not complete - it can only create a StyleablePropertyBoolean right now - but it is sufficiently far along to warrant a

[8u40] Review Request (second iteration): (RT-36510) [CSS] Reduce CssMetaData boilerplate code

2014-06-24 Thread David Grieve
I am seeking feedback on http://cr.openjdk.java.net/~dgrieve/RT-36510/webrev.00 which addresses https://javafx-jira.kenai.com/browse/RT-36510. This iteration reduces the boiler-plate to one line to create the StyleableProperty and one method to return the CssMetaData list. Example use:

hg: openjfx/8u-dev/rt: RT-36510: reduce CssMetaData boilerplate

2014-06-26 Thread david . grieve
Changeset: 6789ab35bb59 Author:David Grievedavid.gri...@oracle.com Date: 2014-06-24 18:55 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6789ab35bb59 RT-36510: reduce CssMetaData boilerplate + modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java +

hg: openjfx/8u-dev/rt: [JAVADOC ONLY] RT-36510: reduce CssMetaData boilerplate

2014-06-26 Thread david . grieve
Changeset: 796678138fdf Author:David Grievedavid.gri...@oracle.com Date: 2014-06-26 15:04 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/796678138fdf [JAVADOC ONLY] RT-36510: reduce CssMetaData boilerplate ! modules/graphics/src/main/java/javafx/css/CssMetaData.java !

hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-26 Thread david . grieve
Changeset: 8d41ccb6bcdb Author:David Grievedavid.gri...@oracle.com Date: 2014-06-26 15:47 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code !

Re: Warning Could not resolve CSS

2014-06-27 Thread David Grieve
Have you tried the 8u20 EA release? This can happen if a node is having CSS applied before the root node of the scene has had CSS applied. This has been largely resolved in 8u20. On 6/27/14, 12:19 PM, Jeff Martin wrote: Jira and the web at large are full of references to this warning (which

Re: Warning Could not resolve CSS

2014-06-27 Thread David Grieve
looking into it. jeff On Jun 27, 2014, at 12:08 PM, David Grieve david.gri...@oracle.com wrote: Have you tried the 8u20 EA release? This can happen if a node is having CSS applied before the root node of the scene has had CSS applied. This has been largely resolved in 8u20. On 6/27/14, 12:19

hg: openjfx/8u-dev/rt: RT-32522: Parser doesn't handle size{1, 4} except for -fx-padding

2014-07-01 Thread david . grieve
Changeset: 588905b8806f Author:David Grievedavid.gri...@oracle.com Date: 2014-07-01 14:55 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/588905b8806f RT-32522: Parser doesn't handle size{1,4} except for -fx-padding !

hg: openjfx/8u-dev/rt: 3 new changesets

2014-07-09 Thread david . grieve
Changeset: c8fa5e33e810 Author:David Grievedavid.gri...@oracle.com Date: 2014-07-09 08:49 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c8fa5e33e810 RT-37522: TableColumn: default comparator should use Collator for String types Reviewed by: Jonathan !

hg: openjfx/8u-dev/rt: RT-37877: ConcurrentModificationException when changing user-agent stylesheets

2014-07-09 Thread david . grieve
Changeset: 12667ba4eb22 Author:David Grievedavid.gri...@oracle.com Date: 2014-07-09 17:15 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/12667ba4eb22 RT-37877: ConcurrentModificationException when changing user-agent stylesheets !

[8u Review Request] RT-37551: loading user-agent stylesheets one at a time from PlatformImpl is inefficient

2014-07-09 Thread David Grieve
Steve, Kevin - I'd like for you to review these changes as they affect PlatformImpl. https://javafx-jira.kenai.com/browse/RT-37551 http://cr.openjdk.java.net/~dgrieve/RT-37551/webrev.00/ http://cr.openjdk.java.net/%7Edgrieve/RT-37551/webrev.00/

hg: openjfx/8u-dev/rt: RT-37818: [CSS] Drag triggers NPE at com.sun.javafx.css.StyleManager.removeStylesheetContainer

2014-07-09 Thread david . grieve
Changeset: 779bbf1e9a68 Author:David Grievedavid.gri...@oracle.com Date: 2014-07-09 20:47 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/779bbf1e9a68 RT-37818: [CSS] Drag triggers NPE at com.sun.javafx.css.StyleManager.removeStylesheetContainer !

[8u40] API Review: [CSS] Reduce CssMetaData boilerplate code

2014-07-11 Thread David Grieve
The latest API for https://javafx-jira.kenai.com/browse/RT-36510 is posted on http://cr.openjdk.java.net/~dgrieve/RT-36510/webrev.03. Please see the comments in RT-36510 for details.

Re: Double.MAX_VALUE in CSS -fx-max-width?

2014-07-27 Thread David Grieve
Hi Werner, Please file a bug. I'll have to update the parser to accept 'infinity' as a value. On 7/24/14, 1:11 PM, Werner Lehmann wrote: Hi, since FX8 we have a styleable property -fx-max-width on Region. I'd like to use this to replace the FXML attribute Node maxWidth=Infinity/ with

hg: openjfx/8u-dev/rt: 2 new changesets

2014-07-31 Thread david . grieve
Changeset: 101968b1eef0 Author:David Grievedavid.gri...@oracle.com Date: 2014-07-31 14:37 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/101968b1eef0 RT-36510: [CSS] Reduce CssMetaData boilerplate code !

  1   2   >