[9] Review request for 8141345: Cannot build WebKit with bison3 (only on windows)

2015-11-12 Thread Guru Hb
Hi Kevin, Alexander & Vadim, JBS : https://bugs.openjdk.java.net/browse/JDK-8141345 Webrev : http://cr.openjdk.java.net/~ghb/8141345/webrev.00/ Tested on Windows (Bison 3.0.4), Linux and Mac. Thanks, Guru

RE: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

2015-11-12 Thread Guru Hb
Hello Oliver, Could you please provide info where this problem is seen more often. OS type, version & 32 / 64 bit JDK version & 32 / 64 bit. (already mentioned 8u66 and 32 bit in email) fireTime (argument) value can't go less than "1.0E-9". As you pointed out the problem lies in

RE: AW: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

2015-11-13 Thread Guru Hb
d ? Both Host and Test server is having JDK or only JRE ? Tried myself on 8u51, 8u60 and 8u64 (all 32 bit JDK) , but couldn't re-produce here locally. Thanks, Guru -Original Message- From: Schmidtmer, Oliver [mailto:o.schmidt...@elo.com] Sent: Thursday, November 12, 2015 9:22 PM

Review request for JDK-8090035 : JavaFX browser can get stuck in an infinite loop when calling path.getTotalLength()

2015-09-17 Thread Guru Hb
Dear Vadim / Kevin, Please review the fix merged from Chromium webkit to our(JFXwebkit) branch which address the defect logged for JDK-8090035. Tested on Linux(32 and 64 bit) with a test application (attached in JIRA) Origin of the fix taken from

[9, 8u] review request: 8136466 : [regression] [WebView] Load single page application from jar

2015-10-01 Thread Guru Hb
Hi Kevin / Chien / Alexander, JIRA : https://bugs.openjdk.java.net/browse/JDK-8136466 Webrev : http://cr.openjdk.java.net/~psadhukhan/guru/8136466/webrev.00/ Root cause : Relative url of sub resource which are requested from base url of protocol type "jar:" was missing. Fix : Parse

[9, 8u] review request: 8136532 : Outlook paste text into an email causes webkit.ContextMenu NullPointerException

2015-09-28 Thread Guru Hb
Hi Kevin / Chien / Alexander, JIRA : https://bugs.openjdk.java.net/browse/JDK-8136532 Webrev : http://cr.openjdk.java.net/~psadhukhan/guru/8136532/webrev.00/ Please review the fix (comments updated in JIRA). Thanks, Guru

RE: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

2015-12-08 Thread Guru Hb
with regression test Thanks, Guru -Original Message- From: Guru Hb Sent: Tuesday, December 01, 2015 10:29 AM To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth Cc: openjfx-dev@openjdk.java.net Subject: [9] Review request for 8143894 : clipboard paste on outlook email body

RE: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

2015-12-09 Thread Guru Hb
/browse/JDK-8145028 Thanks, Guru -Original Message- From: Guru Hb Sent: Wednesday, December 09, 2015 3:12 AM To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth Cc: Ankit Srivastava; openjfx-dev@openjdk.java.net Subject: RE: [9] Review request for 8143894 : clipboard paste

RE: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

2015-12-08 Thread Guru Hb
Fixed Test failure on MAC Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.02/ Tested on Windows , Linux and Mac Thanks, Guru -Original Message- From: Guru Hb Sent: Tuesday, December 08, 2015 4:08 PM To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth Cc: openjfx

Re: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

2015-12-10 Thread Guru Hb
on MAC Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.02/ Tested on Windows , Linux and Mac Thanks, Guru -Original Message- From: Guru Hb Sent: Tuesday, December 08, 2015 4:08 PM To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth Cc: openjfx-dev@openjdk.java.net

Re: [9] Review request for 8140501 : WebView crashes when loading content in a locationlistener

2015-12-11 Thread Guru Hb
.net/browse/JDK-8140501/ Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.01/ Regression test incorporated and Async loadcontent executed only in READY state. Thanks, Guru -Original Message- From: Guru Hb Sent: Monday, November 30, 2015 12:22 PM To: Alexander Zvegintsev; Arunpr

[9] Review request: 8139842: NullPointerException in WCPageBackBufferImpl when a WebView is too large

2015-12-15 Thread Guru Hb
Hi Kevin, Jim, Alexander Please provide your review comments for JBS : https://bugs.openjdk.java.net/browse/JDK-8139842 Webrev : http://cr.openjdk.java.net/~ghb/8139842/webrev.00/ Tested on Windows , Linux and Mac. Thanks, Guru

RE: Full Screen Mode in JavaFX WebView

2016-01-04 Thread Guru Hb
Please see comments embedded -Original Message- From: BoydEdmondson-NebulaSoftware [mailto:boydedmond...@nebulasoftware.com] Sent: Monday, January 04, 2016 7:01 PM To: openjfx-dev@openjdk.java.net Subject: Full Screen Mode in JavaFX WebView I have a custom Java application that uses

RE: WebKit future planning

2015-12-20 Thread Guru Hb
Hi Bosko, Please find my comments embedded below. Thanks, Guru -Original Message- From: Bosko Popovic [mailto:bosk...@gmail.com] Sent: Saturday, December 19, 2015 7:21 PM To: openjfx-dev@openjdk.java.net Subject: WebKit future planning Hi, We are developing application that uses

RE: [9] Review request for 8140501 : WebView crashes when loading content in a locationlistener

2015-11-30 Thread Guru Hb
Hi Arun, Alexander & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8140501/ Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.01/ Regression test incorporated and Async loadcontent executed only in READY state. Thanks, Guru -Original Message- From: Guru Hb

[9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

2015-11-30 Thread Guru Hb
Hi Arunprasad, Alexander & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/ Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.00 Tested on Windows and Linux (both 64 bit). Thnaks, Guru

[9] Review request for 8140501 : WebView crashes when loading content in a locationlistener

2015-11-29 Thread Guru Hb
Hi Arunprasad, Alexander & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8140501 Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.00/ Tested on Windows and Linux (both 64 bit). Thnaks, Guru

[9] Review request for 8146898 : Webview - Bug in JavaScript Date() constructor after Feb 28 2034

2016-01-13 Thread Guru Hb
Hi Alexander & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8146898 Webrev : http://cr.openjdk.java.net/~ghb/8146898/webrev.00/ RC and Solution updated in JIRA, fix tested on Windows & Ubuntu. Thanks, Guru

[9] Review request : 8159868 :the JVM for our Swing application crashes, once we login into our application server

2016-06-21 Thread Guru Hb
Hi Arun & Kevin, Could you please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8159868 http://cr.openjdk.java.net/~ghb/8159868/webrev.00/ RC and solution update in JBS. Thanks, Guru

Re: [9] Review request : 8159868 :the JVM for our Swing application crashes, once we login into our application server

2016-06-22 Thread Guru Hb
Please ignore my previous email and ref https://bugs.openjdk.java.net/browse/JDK-8159868 http://cr.openjdk.java.net/~ghb/8159868/webrev.00/ Thanks, Guru On 22/6/16 10:34 AM, Guru Hb wrote: Hi Arun & Kevin, Could you please review the fix for : https://bugs.openjdk.java.net/browse/JDK-815

[9] Review request for 8139114: WebView crashes on Yahoo login page

2016-02-20 Thread Guru Hb
Hi Alexander, Kevin and Arun JBS : https://bugs.openjdk.java.net/browse/JDK-8139114 Webrev : http://cr.openjdk.java.net/~ghb/8139114/webrev.00/ RC and Solution updated in JIRA. Thanks, Guru

Re: status behind JDK-8149738

2016-04-12 Thread Guru Hb
refilled. Tomorrow I'll build a clean GWT reproducer app and will send it to you. I'll also do the exact same in pure html/js without GWT being involved. Matthieu On Tue, Apr 12, 2016 at 11:18 AM, Guru Hb <guru...@oracle.com <mailto:guru...@oracle.com>> wrote: Thank you Mat

Re: status behind JDK-8149738

2016-04-12 Thread Guru Hb
Hi Matthieu, Crash is due to Mouse event is not handled correctly from WebView context. Could you please provide these details. 1. What Content is loaded to WebEngine. (Live webpage or custom content) 2. which mouse event lead to crash (Right / left click, Double click, Scroll) 3. W.r.t 2nd

Re: status behind JDK-8149738

2016-04-12 Thread Guru Hb
ash with a simple app consisting of the 2 lines above. On Tue, Apr 12, 2016 at 9:41 AM, Guru Hb <guru...@oracle.com <mailto:guru...@oracle.com>> wrote: Hi Matthieu, Crash is due to Mouse event is not handled correctly from WebView context. Could you please provid

Review request for 8152420 : [WebView] Icon font doesn't work if single page application will be loaded from jar

2016-04-04 Thread Guru Hb
Hi Alexander, Arunprasad & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8152420 Webrev : http://cr.openjdk.java.net/~ghb/8152420/webrev.00/ Root cause and fix description updated in JBS. Thanks, Guru

[9] Review request for 8153049 : Merge "Frame and Page lifetime fixes in WebCore::createwindows" and "FrameLoader::checkCompleted can hit the "ref'ing while destroyed" assertion"

2016-03-29 Thread Guru Hb
Hi Alexander, Arunprasad & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8153049 Webrev : http://cr.openjdk.java.net/~ghb/8153049/webrev.00/ Merging webkit change set, Root cause and description are updated in JBS. Thanks, Guru

Re: [9] Review request for 8152315 : Don't server / request the Cached resource for if its Main resource is explicitly cancelled

2016-03-30 Thread Guru Hb
Updated webrev : http://cr.openjdk.java.net/~ghb/8152315/webrev.01/ Which address heap corruption detected by using GFlag On 22/3/16 12:54 AM, Guru Hb wrote: Hi Alexander, Arunprasad & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8152315 Webrev : http://cr.openjdk.java.net/

[9] Review request for 8152315 : Don't server / request the Cached resource for if its Main resource is explicitly cancelled

2016-03-21 Thread Guru Hb
Hi Alexander, Arunprasad & Kevin, JBS : https://bugs.openjdk.java.net/browse/JDK-8152315 Webrev : http://cr.openjdk.java.net/~ghb/8152315/webrev.00/ RC and Solution updated in JIRA, fix tested on Windows. Thanks, Guru

Re: status behind JDK-8149738

2016-04-13 Thread Guru Hb
the problem not only on 32bits versions but also on 64bits 8u74 & 8u77. Thanks Matthieu On Wed, Apr 13, 2016 at 5:07 AM, Guru Hb <guru...@oracle.com <mailto:guru...@oracle.com>> wrote: Hi Matthieu, If you could update the re-producer html/js in the JBS would be

Re: [9] Review request: 8154186: JVM crash while using JavaFW WebView and colgroup/cols html feature

2016-04-27 Thread Guru Hb
: On 4/27/16, 9:56 AM, Guru Hb wrote: Hi Dave & Kevin, Could you please review updated Unit test case http://cr.openjdk.java.net/~ghb/8152420/webrev.01/ Solution updated in JBS. Hi Guru, JDK-8154186 is closed, so I suspect you will need to open a new bug. Kevin will say for sure but I t

Re: [9] Review request: 8154186: JVM crash while using JavaFW WebView and colgroup/cols html feature

2016-04-27 Thread Guru Hb
Hi Dave & Kevin, Could you please review updated Unit test case http://cr.openjdk.java.net/~ghb/8152420/webrev.01/ Solution updated in JBS. Thanks, Guru On 20/4/16 7:25 PM, Guru Hb wrote: Hi Alexander Z , Kevin & Arunprasad, Please review the fix : https://bugs.openjdk.java.net/br

[9] Review request: 8157145: DRT crash at fast/css-generated-content/initial-letter-basic.html

2016-05-22 Thread Guru Hb
Hi Arun & Kevin, Please review the fix : JBS : https://bugs.openjdk.java.net/browse/JDK-8157145 Webrev : http://cr.openjdk.java.net/~ghb/8157145/webrev.00/ RC and Solution updated in JBS. Thanks, Guru

Re: Problem building WebView with latest 8u-dev and 9-dev

2016-07-24 Thread Guru Hb
webview-deps (version 1.3.1) has been uploaded to maven central. Please revert the work around suggested earlier. -- Guru On 20/7/16 3:52 AM, Kevin Rushforth wrote: With the recently-integrated changes from 8u102, the WebKit build requires a new version of the webview-deps bundle. This new

Re: CFV: New OpenJFX Committer: Andrey Rusakov

2016-07-24 Thread Guru Hb
Vote: YES On 23/7/16 9:05 PM, Murali Billa wrote: Vote: YES Kevin Rushforth wrote: I hereby nominate Andrey Rusakov [1] to OpenJFX Committer. Andrey is a member of JavaFX SQE team at Oracle working on test development, who has contributed 19 changesets [5] to OpenJFX, at least 8 of which are

[9] Review request 8153681: WebView needs to resolve resources relative to "jrt:" URLs

2016-07-29 Thread Guru Hb
Hi Kevin, Arun & Murali, Please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8153681 Webrev : http://cr.openjdk.java.net/~ghb/8153681/webrev.00/ Solution updated in JBS. Thanks, Guru

[9] Review request 8163582: JavaFX browser can get stuck in an infinite loop when calling path.getTotalLength()

2016-08-11 Thread Guru Hb
Hi Kevin, Arun & Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8163582 Webrev : http://cr.openjdk.java.net/~ghb/8163582/webrev.00/ RC : Merged back JDK-8090035 and added Unit test case. Thanks, Guru

[9] Review request 8163971: Revert "MiscellaneousTest.testRT26306 and testWebViewWithoutSceneGraph" Indentation done while JDK-8163582 fix

2016-08-12 Thread Guru Hb
Hi Kevin, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8163971 Webrev : http://cr.openjdk.java.net/~ghb/8163971/webrev.00/ Accidentally Indent two other Unit test case while merging JDK-8163582. Thanks, Guru

[9] Review request 8160837: WebEngine doesn't handle html5 color picker

2016-07-13 Thread Guru Hb
Hi Jonathan, Arun & Alexander Z, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8160837 Webrev : http://cr.openjdk.java.net/~ghb/8160837/webrev.00/ Thanks, Guru

Re: [9] Review request 8160837: WebEngine doesn't handle html5 color picker

2016-07-18 Thread Guru Hb
Hi Kevin, Arun & Alexander Z, Please review the updated webrev : http://cr.openjdk.java.net/~ghb/8160837/webrev.02/ Solution updated in JBS. Thanks, Guru On 14/7/16 10:30 AM, Guru Hb wrote: Hi Jonathan, Arun & Alexander Z, Please review the fix for: https://bugs.openjdk.java.ne

Re: CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-19 Thread Guru Hb
Vote: YES On 19/7/16 7:07 PM, David Hill wrote: I hereby nominate Ankit Srivastava to OpenJFX Committer. Ankit Srivastava is part of the JavaFX team focusing on Web. A list of Ankit's commits and reviews is available by the following links

[webkit][9] Review request 8160563: jvm crash at javafx com.sun.webkit.WebPage.twkPrePaint (GFlag + Heap verification)

2016-07-04 Thread Guru Hb
Hi Alexander & Arun, Please review the fix for: JBS : https://bugs.openjdk.java.net/browse/JDK-8160563 webrev : file:///D:/ws/patch/8160563/webrev.00 RC and Solution updated in JBS. Thanks, Guru

Re: [webkit][9] Review request 8160563: jvm crash at javafx com.sun.webkit.WebPage.twkPrePaint (GFlag + Heap verification)

2016-07-04 Thread Guru Hb
Please ref webrev : http://cr.openjdk.java.net/~ghb/8160563/webrev.00 On 5/7/16 9:43 AM, Guru Hb wrote: Hi Alexander & Arun, Please review the fix for: JBS : https://bugs.openjdk.java.net/browse/JDK-8160563 webrev : file:///D:/ws/patch/8160563/webrev.00 RC and Solution updated in

Re: Fix for test runner review request.

2016-07-07 Thread Guru Hb
http://hg.openjdk.java.net/openjfx/8u-dev/tests/rev/7562f73c8642 http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/30fbc7690076 On 7/7/16 1:51 AM, Andrey Rusakov wrote: Could anyone commit this fix to open fx tests, 8 and 9? It's important for testing process. 05.07.2016 12:56, Andrey

[9] Review request: 8163183: [test] Correct assertEquals ("", actual, expected) in LoadTest.loadJarFile

2016-08-08 Thread Guru Hb
Hi Kevin & Arun, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8163183 Webrev : http://cr.openjdk.java.net/~ghb/8163183/webrev.00/ Thanks, Guru

[9] Review request: 8158196: WebView Form Post fails if connection is closed before keepAlive-Timeout

2017-01-23 Thread Guru Hb
Hi Kevin, Arun & Murali, Please review the fix for: JBS : https://bugs.openjdk.java.net/browse/JDK-8158196 Webrev : http://cr.openjdk.java.net/~ghb/8158196/webrev.00/ RC and solution

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

2017-01-23 Thread Guru Hb
Vote: yes > On 19-Jan-2017, at 3:23 AM, Kevin Rushforth > wrote: > > I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer. > > Ramesh is a member of JavaFX SQE team at Oracle working on test development > for the Java packager, who has contributed 20

Re: CFV: New OpenJFX Committer: Semyon Sadetsky

2017-01-27 Thread Guru Hb
Vote: YES > On 26-Jan-2017, at 1:09 AM, David Hill wrote: > > > I hereby nominate Semyon Sadetsky to OpenJFX Committer. > > Semyon Sadetsky is part of the JavaFX team focusing on glass. > > A list of Semyon's commits and reviews is available by the following links > >

[9] Review request: 8174919: SocketException no longer handled by WebView when processing web pages

2017-02-14 Thread Guru Hb
Hi Kevin & Murali, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8174919 Webrev : http://cr.openjdk.java.net/~ghb/8174919/webrev.00/ Thanks, Guru

[9][tests]Review request for 8164498 : Backout changeset c9f45449d053 which has wrong bug id and commit message

2016-08-19 Thread Guru Hb
Hi Kevin, Please review the change for (Backing out the changes done for JDK-8163084 with wrong bug ID and commit message). Webrev : http://cr.openjdk.java.net/~ghb/rbgangad/8164498/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8164498 Thanks, Guru

[9] Review request for 8164076: [Windows] JavaFX crash in WebPage.twkOpen in 8u112 when closing WebView while debugging

2016-08-31 Thread Guru Hb
Hi Kevin, Murali & Ankit, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8164076 Webrev : http://cr.openjdk.java.net/~ghb/8164960/webrev.00/ RC and Solution updated in JBS. Thanks, Guru

[9] Review request for 8165853: Loading "https://www.windyty.com" with JavaFX WebView crashes JVM.

2016-09-19 Thread Guru Hb
Hi Kevin, Arun & Murali, Please review the fix for (RC and fix updated in JBS) JBS : https://bugs.openjdk.java.net/browse/JDK-8165853 Webrev : http://cr.openjdk.java.net/~ghb/8165853/webrev.00/index.html Thanks, Guru

Re: [WebView] Single page application - relative resource in a different jar

2016-11-18 Thread Guru Hb
Hi Steve, Could you please share the layout of jar file (two jars) so i can re-create the problem and let you know the failure reason. Thanks, Guru > On 16-Nov-2016, at 2:37 PM, Hruda, Steve > wrote: > > Hi, > short question from my side. I’ve submitted the

[9] Review request for 8157686: JavaFX WebView fails to track URL changes for PJAX websites

2016-10-28 Thread Guru Hb
Hi Arun, Kevin & Murali, Please review the fix for JBS: https://bugs.openjdk.java.net/browse/JDK-8157686 Webrev: http://cr.openjdk.java.net/~ghb/8157686/webrev.00/ RC and Solution updated

Re: SVG

2016-10-11 Thread Guru Hb
WebView renders SVG ( WebView.getWebEngine().load("PathToSvg.svg"); ). Could you please let us know which content (SVG) failed to rendered as expected. Please file a JBS with simplified test content , will analyze. Thanks, Guru On 11/10/16 6:56 PM, Scott Palmer wrote: On Oct 11, 2016, at

[webkit][10] 8185940: Web native compiled files not removed during gradle clean

2017-08-09 Thread Guru Hb
Hi Arun, Murali, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8185940 WebRev : http://cr.openjdk.java.net/~ghb/8185940/webrev.00 Thanks, Guru

Re: Support for JavaScript FileReader object in JavaFX WebView

2017-07-17 Thread Guru Hb
Hi Jelurida, You are correct, We are not yet (in Java 9) supporting File Api in our javafx.WebView. Will update once we have this enhancement is implemented https://bugs.openjdk.java.net/browse/JDK-8184785 . Thanks, Guru > On 17-Jul-2017, at

[10] Review request: 8184797: Copy DumpRenderTreeJava.dll from bin to lib directory

2017-07-18 Thread Guru Hb
Hi Arun & Murali, Please review the fix for: JBS : https://bugs.openjdk.java.net/browse/JDK-8184797 Webrev : http://cr.openjdk.java.net/~ghb/8184797/webrev.00/ Thanks, Guru

[10] Review request: 8178360: Build and integrate ICU from source

2017-06-29 Thread Guru Hb
Hi Kevin, Arun and Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8178360 Webrev : http://cr.openjdk.java.net/~ghb/8178360/webrev.07 (Modified Source) patch

[webkit][10] 8185315: Update user agent string to JavaFX/10

2017-07-28 Thread Guru Hb
Hi Arun & Murali, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8185315 Webrev : http://cr.openjdk.java.net/~ghb/8185315/webrev.00/ Thanks, Guru

[webkit][10] Review request: 8170955: HTML5 canvas shadow properties should not be affected by transform

2017-08-22 Thread Guru Hb
Hi Arun & Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8170955 webrev : http://cr.openjdk.java.net/~ghb/8170955/webrev.00/ Thanks, Guru

[10] Review request: 8179673: JVM Crash in WebPage.setBackgroundColor() during webpage navigation (Non Public API)

2017-05-11 Thread Guru Hb
Hi Arun, Murali & Kevin, Please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8179673 Webrev : http://cr.openjdk.java.net/~ghb/8179673/webrev.00/ Thanks, Guru

Re: [webkit][10] Review request: 8187568: JavaFX crash in libjfxwebkit.so

2017-10-11 Thread Guru Hb
Resending with correct Bug id in Subject line. > On 11-Oct-2017, at 6:57 PM, Guru Hb <guru...@oracle.com> wrote: > > Hi Arun, Murali & Kevin, > > Please review the fix for > JBS : https://bugs.openjdk.java.net/browse/JDK-8187568 > <https://bugs.openjdk.jav

Re: CFV: New OpenJFX Committer: Prasanta Sadhukhan

2017-09-28 Thread Guru Hb
Vote: YES > On 28-Sep-2017, at 6:40 AM, Kevin Rushforth > wrote: > > I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer. > > Prasanta is a member of JavaFX team at Oracle, who has contributed 12 > changesets [2] to OpenJFX. > > Votes are due by October

[webkit][10] Review request: 8170955: JavaFX crash in libjfxwebkit.so

2017-10-11 Thread Guru Hb
Hi Arun, Murali & Kevin, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8187568 Webrev: http://cr.openjdk.java.net/~ghb/8187568/webrev.00/ RC and solution updated

[10] Review request: 8191035: WebView Canvas Graphics2D arc renders incorrectly

2017-11-19 Thread Guru Hb
Hi Kevin, Arun, Please review JBS : https://bugs.openjdk.java.net/browse/JDK-8191035 Webrev : http://cr.openjdk.java.net/~ghb/8191035/webrev.00/ RC and solution update in JBS. Thanks, Guru

Re: CFV: New OpenJFX Committer: Ambarish Rapte

2017-11-01 Thread Guru Hb
Vote: yes > On 01-Nov-2017, at 1:48 AM, Kevin Rushforth > wrote: > > I hereby nominate Ambarish Rapte [1] to OpenJFX Committer. > > Ambarish is a member of JavaFX team at Oracle, who has contributed 10 > changesets [2][3] to OpenJFX. > > Votes are due by November

[10] Review request: 8185654: Fix copyright notice on WebKit porting layer files in platform/java

2017-10-24 Thread Guru Hb
Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8185654 http://cr.openjdk.java.net/~ghb/8185654/8185654_0.diff Thanks, Guru

Re: [Integrated] RFR: 8218640: Update ICU4C to version 64.2

2019-10-15 Thread Guru Hb
Changeset: b6e53f4f Author:Arun Joseph Committer: Guru Hb Date: 2019-10-15 17:41:33 + URL: https://git.openjdk.java.net/jfx/commit/b6e53f4f 8218640: Update ICU4C to version 64.2 Reviewed-by: kcr, ghb, jvos ! modules/javafx.web/src/main/legal/icu_web.md ! modules/javafx.web

Re: [Approved] RFR: 8211308: Support HTTP/2 in WebView

2019-11-28 Thread Guru Hb
On Wed, 16 Oct 2019 17:57:58 GMT, Arunprasad Rajkumar wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 1832c2db: Incorporate fixes provided by @kcr > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/14/files > -

Re: [Approved] RFR: 8218640: Update ICU4C to version 64.2

2019-10-09 Thread Guru Hb
On Wed, 9 Oct 2019 13:25:54 GMT, Arun Joseph wrote: > We currently use ICU4C version 62.1. We should update to the latest stable > version 64.2. > http://site.icu-project.org/home > > > > Commits: > - b56b720e: 8218640: Update ICU4C to version 64.2 > > Changes:

Re: [Approved] RFR: 8231854: Change Mercurial to git in various README files

2019-10-04 Thread Guru Hb
On Thu, 3 Oct 2019 23:15:56 GMT, Kevin Rushforth wrote: > https://bugs.openjdk.java.net/browse/JDK-8231854 > > Follow-on fix to > [JDK-8231590](https://bugs.openjdk.java.net/browse/JDK-8231590) -- PR #3 -- > to change Mercurial or hg to git in a few README files where appropriate. > >

Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

2020-02-26 Thread Guru Hb
On Wed, 26 Feb 2020 03:39:49 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8236832 > > - This issue most likely caused by changes in AVFoundation APIs on macOS > 10.15. > - Getting currentTime from AVPlayer was blocked if it is done from > ProcessAudioTap callback

Re: [Integrated] RFR: 8239109: Update SQLite to version 3.31.1

2020-02-23 Thread Guru Hb
Changeset: 4eaff0de Author:Guru Hb Date: 2020-02-24 04:08:43 + URL: https://git.openjdk.java.net/jfx/commit/4eaff0de 8239109: Update SQLite to version 3.31.1 Reviewed-by: ajoseph, kcr, jvos ! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/VERSION ! modules

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-24 Thread Guru Hb
On Fri, 17 Jan 2020 23:18:28 GMT, Kevin Rushforth wrote: >> Previous commits in this pull request have been removed, probably due to a >> force push. The incremental views will show differences compared to the >> previous content of the PR. > > Looks good to me. > > @guruhb can you re-review

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-24 Thread Guru Hb
On Fri, 24 Jan 2020 14:41:11 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really >> contained a mapping for the given button, making it prone to errors, when >> things are extended (as has happened here). >> >> The fix consists of

RFR: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

2020-01-29 Thread Guru Hb
AnimationBase and WebAnimation are two different abstract animation API provider. By default KeyFrameAnimation (which is a sub class of AnimationBase) is used for controlling and rendering the CSS animation. Enabling "WebAnimationsCSSIntegrationEnabled" overrides the CSSAnimationController to

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Guru Hb
> cl : Command line warning D9002 : ignoring unknown option '-m32' > > post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of > cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. > '-m32' flag is gcc specifc and on windows cl.exe (visual studio)

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Guru Hb
On Tue, 28 Jan 2020 23:42:08 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm line 2300: > >> 2299: >> 2300: if (architecture() eq "x86_64" && shouldBuild32Bit() && (isJava() >>

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Guru Hb
On Wed, 29 Jan 2020 12:57:41 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > Marked as reviewed by kcr (Lead). > the -m32 option seems to be ignored by the compiler: > cl : Command line warning D9002 : ignoring unknown option '-m32' > > However,

Re: [Integrated] RFR: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

2020-01-29 Thread Guru Hb
Changeset: b96bc52b Author:Guru Hb Date: 2020-01-29 16:44:56 + URL: https://git.openjdk.java.net/jfx/commit/b96bc52b 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree Reviewed-by: kcr ! modules/javafx.web/src/main/java/com/sun/javafx/webkit

RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Guru Hb
cl : Command line warning D9002 : ignoring unknown option '-m32' post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't

RFR: 8238526: Cherry pick GTK WebKit 2.26.3 changes

2020-02-06 Thread Guru Hb
Fix contains https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html - Commits: - 025373db: 8238526: Cherry pick GTK WebKit 2.26.3 changes Changes: https://git.openjdk.java.net/jfx/pull/107/files Webrev: https://webrevs.openjdk.java.net/jfx/107/webrev.00 Issue:

Re: [Integrated] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-02-03 Thread Guru Hb
Changeset: aa91ebbb Author:Guru Hb Date: 2020-02-03 08:51:25 + URL: https://git.openjdk.java.net/jfx/commit/aa91ebbb 8237944: webview native cl "-m32" unknown option for windows 32-bit build Reviewed-by: kcr ! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm

Re: [Integrated] RFR: 8238526: Cherry pick GTK WebKit 2.26.3 changes

2020-02-06 Thread Guru Hb
Changeset: e224e549 Author:Guru Hb Date: 2020-02-07 02:13:15 + URL: https://git.openjdk.java.net/jfx/commit/e224e549 8238526: Cherry pick GTK WebKit 2.26.3 changes Reviewed-by: kcr, jvos ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg

Re: RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

2020-02-19 Thread Guru Hb
On Wed, 19 Feb 2020 12:09:50 GMT, Arun Joseph wrote: > With new bytecode format introduced in Webkit 608.1, the unlinked and linked > bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand) > bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in >

RFR: 8239513: Update SQLite to version 3.31.1

2020-02-19 Thread Guru Hb
Updating SQlite to 3.31.1 (Currently used 3.30.1). - Commits: - e8312460: 8239513: Update SQLite to version 3.31.1 Changes: https://git.openjdk.java.net/jfx/pull/118/files Webrev: https://webrevs.openjdk.java.net/jfx/118/webrev.00 Issue:

Re: [Integrated] RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

2020-02-19 Thread Guru Hb
Changeset: d8e7f850 Author:Arun Joseph Committer: Guru Hb Date: 2020-02-20 05:33:04 + URL: https://git.openjdk.java.net/jfx/commit/d8e7f850 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions Reviewed-by: ghb, kcr ! modules/javafx.web/src/main

RFR: 8239109: Update SQLite to version 3.31.1

2020-02-19 Thread Guru Hb
Updating SQLite to version 3.31.1 (Currently used version is 3.30.1). - Commits: - d4e17340: 8239109: Update SQLite to version 3.31.1 Changes: https://git.openjdk.java.net/jfx/pull/119/files Webrev: https://webrevs.openjdk.java.net/jfx/119/webrev.00 Issue:

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Guru Hb
On Tue, 14 Jan 2020 14:13:54 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really >> contained a mapping for the given button, making it prone to errors, when >> things are extended (as has happened here). >> >> The fix consists of

RFR: 8233942: Update to 609.1 version of WebKit

2020-01-21 Thread Guru Hb
Updated GTK Webkit 2.26 (609.1) into jfx. - Commits: - 8b48b1e0: 8233942: Update to 609.1 version of WebKit Changes: https://git.openjdk.java.net/jfx/pull/91/files Webrev: https://webrevs.openjdk.java.net/jfx/91/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233942

Re: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Guru Hb
On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger wrote: > As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two

Re: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2020-01-05 Thread Guru Hb
On Mon, 6 Jan 2020 04:32:34 GMT, Arun Joseph wrote: >> Issue: Native part of WebView throws a DOMException and then, continues >> executing the rest of the function assuming that value is present. This >> causes the JVM to crash when retrieving the value. >> >> Fix: Return from the function

Re: RFR: 8234471: Canvas in webview displayed with wrong scale on Windows

2020-01-05 Thread Guru Hb
On Mon, 9 Dec 2019 13:09:04 GMT, Arun Joseph wrote: > This bug can be reproduced when the screen resolution is at 125%, 150% and > 175% for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and > 1.75, respectively. > > Issue: The rectangle inside canvas is rendered on

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Guru Hb
On Thu, 5 Mar 2020 14:51:03 GMT, Arun Joseph wrote: > Issue: The stack pointer is checked close to the stack limit during the last > iteration of calling frameLoaded() and then, grows beyond the thread's stack > range causing a stack overflow and crashes. This occurs as the stack grows by >

Re: [Rev 01] RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

2020-04-09 Thread Guru Hb
On Thu, 9 Apr 2020 01:45:27 GMT, Alexander Matveev wrote: >> https://bugs.openjdk.java.net/browse/JDK-8240694 >> >> - Original fix JDK-8236832 was reverted. >> - Timestamp will be queried on event loop thread when spectrum event is >> received by event loop. >> - FIx only enabled for macOS

Re: RFR: 8242209: Increase web native thread stack size for x86 mode

2020-04-10 Thread Guru Hb
On Mon, 6 Apr 2020 11:57:54 GMT, Arun Joseph wrote: > CLoop interpreter used in 32-bit Windows uses 87 KB of stack space each time > CLoop::execute() is called. For web native > threads which has a default stack size of 320 KB, a Stack Overflow Error is > raised just after two calls to

Re: [Rev 01] RFR: 8223298: SVG patterns are drawn wrong

2020-04-10 Thread Guru Hb
On Wed, 8 Apr 2020 11:55:03 GMT, Arun Joseph wrote: >> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the >> native side which is propagated to the java >> side as well. But, as transform initialization takes place after scaling, >> the transform is reset to default

Re: [Rev 02] RFR: 8223298: SVG patterns are drawn wrong

2020-04-17 Thread Guru Hb
On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph wrote: >> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the >> native side which is propagated to the java >> side as well. But, as transform initialization takes place after scaling, >> the transform is reset to default

Re: [Rev 02] RFR: 8234471: Canvas in webview displayed with wrong scale on Windows

2020-03-26 Thread Guru Hb
On Wed, 25 Mar 2020 18:12:41 GMT, Arun Joseph wrote: >> This bug can be reproduced when the screen resolution is at 125%, 150% and >> 175% for Windows, which correpsonds to >> `pixelScale` values of 1.25, 1.5 and 1.75, respectively. >> Issue: The rectangle inside canvas is rendered on

Re: RFR: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded

2020-04-28 Thread Guru Hb
On Wed, 22 Apr 2020 18:07:09 GMT, Kevin Rushforth wrote: > This PR will allow javafx.web unit tests to run to completion and pass on > Windows with Visual Studio 2019. > > Two of the WebKit tests load the native WebKit library without initializing > the JavaFX runtime. This will lead to test

  1   2   >