RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down

2022-02-24 Thread Hima Bindu Meda
Basically, buttons property is a mask which represents the button/buttons clicked on the mouse. It is observed that event.buttons property is set to 0 when there is mouse press or drag event.This behaviour is observed only with javafx webView.Other browsers set the buttons property to 1,

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v2]

2022-02-25 Thread Hima Bindu Meda
a robot test case for the same. >Performed sanity testing with the added implementation and the buttons > property is compliant with the specification mentioned in > https://w3c.github.io/pointerevents/#the-buttons-property. Hima Bindu Meda has updated the pull request incrementally with one add

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v3]

2022-02-25 Thread Hima Bindu Meda
a robot test case for the same. >Performed sanity testing with the added implementation and the buttons > property is compliant with the specification mentioned in > https://w3c.github.io/pointerevents/#the-buttons-property. Hima Bindu Meda has updated the pull request incrementally with one add

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v2]

2022-02-25 Thread Hima Bindu Meda
On Fri, 25 Feb 2022 13:35:16 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/robot/javafx/web/PointerEventTest.java line >> 212: >> >>> 210: Util.runAndWait(() -> { >>> 211: robot.mouseRelease(MouseButton.PRIMARY, >>> MouseButton.MIDDLE,

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v3]

2022-02-28 Thread Hima Bindu Meda
On Mon, 28 Feb 2022 09:06:30 GMT, Ambarish Rapte wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use ESC key so that the popup, if any, disappears > > tests/system/src/t

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v4]

2022-02-28 Thread Hima Bindu Meda
a robot test case for the same. >Performed sanity testing with the added implementation and the buttons > property is compliant with the specification mentioned in > https://w3c.github.io/pointerevents/#the-buttons-property. Hima Bindu Meda has updated the pull request incrementally with one add

Integrated: 8278759 : PointerEvent: buttons property set to 0 when mouse down

2022-03-01 Thread Hima Bindu Meda
On Thu, 24 Feb 2022 18:46:21 GMT, Hima Bindu Meda wrote: > Basically, buttons property is a mask which represents the button/buttons > clicked on the mouse. > It is observed that event.buttons property is set to 0 when there is > mouse press or drag event.This behaviour is o

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v2]

2022-02-25 Thread Hima Bindu Meda
On Thu, 24 Feb 2022 23:53:04 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor variable names and update the formatting > > modules/javafx.we

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v2]

2022-02-25 Thread Hima Bindu Meda
On Fri, 25 Feb 2022 00:30:28 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformMouseEvent.h >> line 76: >> >>> 74:PlatformMouseEvent(const IntPoint& position, const IntPoint& >>> globalPosition, MouseButton button, PlatformEvent::Type

RFR: 8283328: Update libxml2 to 2.9.13

2022-04-01 Thread Hima Bindu Meda
We currently use libxml2 version 2.9.12. It should be updated to latest stable release, which is version 2.9.13. The steps to update libxml are documented in UPDATING.txt. There is compilation issue with the release 2.9.13, as mentioned here: https://gitlab.gnome.org/GNOME/libxml2/-/issues/349.

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Hima Bindu Meda
g/GNOME/libxml2/-/issues/349. > Updated the code with the changes as per the fix mentioned in above link. > > Compiled and verified on Windows, Mac and Linux platforms. > Sanity testing looks fine. Hima Bindu Meda has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Hima Bindu Meda
On Fri, 1 Apr 2022 08:22:22 GMT, Johan Vos wrote: > This looks good. Just for my understanding: this is the 2.9.13-tagged plus > the fix for the issue with xmlValidNormalizeString() with > --without-valid-build >

Re: RFR: 8283328: Update libxml2 to 2.9.13

2022-04-01 Thread Hima Bindu Meda
On Thu, 31 Mar 2022 20:11:51 GMT, Kevin Rushforth wrote: > 1. As noted in [SKARA-1222](https://bugs.openjdk.java.net/browse/SKARA-1222), > your patch introduces a sym-link that is causing jcheck to throw an > exception. Given that we do not want any sym-links in the repo anyway, you > will

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Hima Bindu Meda
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue

Integrated: 8283328: Update libxml2 to 2.9.13

2022-04-01 Thread Hima Bindu Meda
On Thu, 31 Mar 2022 14:47:32 GMT, Hima Bindu Meda wrote: > We currently use libxml2 version 2.9.12. It should be updated to latest > stable release, which is version 2.9.13. > The steps to update libxml are documented in UPDATING.txt. > There is compilation issue with the re

Re: RFR: 8280841: Update SQLite to 3.37.2 [v2]

2022-02-08 Thread Hima Bindu Meda
qlite-amalgamation-3370200.zip) > > Verified the updated version with unit tests and sanity testing. > No issues are observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Create UPDATING.txt to explain SQLite version upd

Integrated: 8280841: Update SQLite to 3.37.2

2022-02-10 Thread Hima Bindu Meda
On Fri, 4 Feb 2022 12:53:51 GMT, Hima Bindu Meda wrote: > Updated SQLite to 3.37.2 released on 2022-01-06 from the current version > 3.32.3. > > Website : https://www.sqlite.org/index.html > Source code can be found from https://www.sqlite.org/download.html at > [sqlite-am

RFR: 8280841: Update SQLite to 3.37.2

2022-02-07 Thread Hima Bindu Meda
Updated SQLite to 3.37.2 released on 2022-01-06 from the current version 3.32.3. Website : https://www.sqlite.org/index.html Source code can be found from https://www.sqlite.org/download.html at [sqlite-amalgamation-3370200.zip](https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip)

Re: RFR: 8280841: Update SQLite to 3.37.2 [v3]

2022-02-09 Thread Hima Bindu Meda
qlite-amalgamation-3370200.zip) > > Verified the updated version with unit tests and sanity testing. > No issues are observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Accomodated PR comments ---

Re: RFR: 8280841: Update SQLite to 3.37.2 [v2]

2022-02-09 Thread Hima Bindu Meda
On Wed, 9 Feb 2022 13:44:09 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Create UPDATING.txt to explain SQLite version update > > modules/javafx.web/src

RFR: 8278430 : Several tests use terminally deprecated System.runFinalization method

2022-04-21 Thread Hima Bindu Meda
This PR is to remove calls to deprecated method System.runFinalization. Here is the list of module wise test cases affected by the removal: **web**: test.javafx.scene.web.LeakTest **systemTests**: test.memoryleak.JSCallbackMemoryTest test.javafx.embed.swing.SwingNodeDnDMemoryLeakTest

Integrated: 8278430 : Several tests use terminally deprecated System.runFinalization method

2022-04-22 Thread Hima Bindu Meda
On Thu, 21 Apr 2022 15:03:04 GMT, Hima Bindu Meda wrote: > This PR is to remove calls to deprecated method System.runFinalization. > Here is the list of module wise test cases affected by the removal: > > **web**: > test.javafx.scene.web.LeakTest >

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14

2022-05-17 Thread Hima Bindu Meda
On Tue, 17 May 2022 12:32:17 GMT, Hima Bindu Meda wrote: > Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files

RFR: JDK-8286256 : Update libxml2 to 2.9.14

2022-05-17 Thread Hima Bindu Meda
Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for windows , linux and Mac platforms and updated the files accordingly. Updated libxslt to version 1.1.35. Generated the config.h files for windows , Mac and linux platforms and updated accordingly. Verified the build

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-17 Thread Hima Bindu Meda
ted accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Add UPDATING.txt for libxslt update -

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]

2022-05-18 Thread Hima Bindu Meda
ted accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Space correction - Changes: - all: https://git.openj

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Hima Bindu Meda
On Wed, 18 May 2022 12:27:46 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update version inof related steps > > modules/javafx.web/src/main/native/Source/

Integrated: JDK-8286256 : Update libxml2 to 2.9.14

2022-05-23 Thread Hima Bindu Meda
On Tue, 17 May 2022 12:32:17 GMT, Hima Bindu Meda wrote: > Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Hima Bindu Meda
On Tue, 17 May 2022 17:39:27 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Hima Bindu Meda
ted accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Update version inof related steps -

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Hima Bindu Meda
On Tue, 17 May 2022 17:24:11 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/na

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Hima Bindu Meda
On Tue, 17 May 2022 17:19:00 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Hima Bindu Meda
On Tue, 17 May 2022 17:23:15 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/na