Re: Level of detail

2013-07-31 Thread Jim Graham
About the closest thing we have right now is the cacheHints which let you specify that you want to allow the cache to be scaled, but no ability to specify by how much before we re-render. We've felt that mechanism needs to be eventually be evolved to allow more customization, but we haven't

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-31 Thread Jim Graham
D'oh! I knew I should have been checking this list a bit. I hope this isn't too late to have any impact... As an intermediate solution this is fine, but when we want to get into providing settings for MSAA and FSAA and other algorithms I think classes are more flexible than enums. How

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-08-01 Thread Jim Graham
types and twiddles. Richard On Jul 31, 2013, at 1:36 PM, Jim Graham james.gra...@oracle.com wrote: D'oh! I knew I should have been checking this list a bit. I hope this isn't too late to have any impact... As an intermediate solution this is fine, but when we want to get into providing settings

Re: review request RT-34090: NGRegion border painting seems odd

2013-11-08 Thread Jim Graham
Hi Felipe, The changes look good... ...jim On 11/6/13 3:06 PM, Felipe Heidrich wrote: Hi Jim, Please review https://javafx-jira.kenai.com/browse/RT-34090 http://cr.openjdk.java.net/~fheidric/RT34090/webrev/ Thanks Felipe

Re: review request: RT-32837: Ensemble8 left arrow has line artifact

2013-11-08 Thread Jim Graham
Hi Felipe, That looks fine - was there a reason to have the variable to store the predetermined border size? ...jim On 11/4/13 4:55 PM, Felipe Heidrich wrote: Hi Jim Please review https://javafx-jira.kenai.com/browse/RT-32837 You will find the webrev at the end:

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-18 Thread Jim Graham
. Always calculate the stroke bounds as if the shape will be stroked, so it doesn't affect Canvas. If you don't want that to affect the bounds used for a gradient fill when you aren't stroking, set the stoke width to 0. Scott On Nov 18, 2013, at 5:58 PM, Jim Graham james.gra...@oracle.com wrote

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-19 Thread Jim Graham
, Jim Graham james.gra...@oracle.com wrote: Hi Scott, That's an odd take on it. It wouldn't be readily obvious to a developer why their background rectangle had the gradient a little off if they never planned to ever stroke it. Also, keep in mind that while it might be slightly more expensive

Re: discussion about touch events

2013-11-20 Thread Jim Graham
I'm only occasionally skimming this thread so I hope I don't disrupt discussions by throwing in a few observations now and then... On 11/20/2013 7:30 AM, Assaf Yavnai wrote: Pavel, I think that this is a very good example why touch events should be processed separately from mouse events. For

Please evaluate draft fix for RT-33390

2013-11-22 Thread Jim Graham
A number of recent bugs have stemmed from a mistaken assumption in the D3D code that calls to update the render target would always cause a new render target to be installed which would clear the clip on D3D. Recently, that assumption started failing and sometimes the render target does not

review request RT-28691: Region corner radii scaling issues when radii 2*width,height

2013-11-26 Thread Jim Graham
Hi David and Felipe, Please review my proposed fix for: https://javafx-jira.kenai.com/browse/RT-28691 The webrev pointer, and a question, are in my recent comment there. This makes every instance of corner radii handling I could find in Region and NGRegion internally consistent, enforced by

Re: review request RT-28691: Region corner radii scaling issues when radii 2*width,height

2013-12-02 Thread Jim Graham
Updated webrev available in the latest Jira comment, responding to review feedback from Felipe and (in the Jira comments) answering a number of questions about the methodology with David... ...jim On 11/26/13 11:15 PM, Jim Graham wrote: Hi David and Felipe, Please

Post commit notice: RT-34635: warnings printed out when using poolstats

2013-12-02 Thread Jim Graham
The warning message was printed out unconditionally even when the summary was requested for other reasons... http://cr.openjdk.java.net/~flar/RT-34635/webrev.00/ https://javafx-jira.kenai.com/browse/RT-34635 ...jim

review 8.0 fix for RT-34663: pick more appropriate defaults for vram pool sizes

2013-12-03 Thread Jim Graham
Hi Lisa, Here are the changes we discussed. Note that I found the settings at different lines in the embedded configuration files than you indicated, but hopefully I modified all of the required platforms correctly... Jira: https://javafx-jira.kenai.com/browse/RT-34663 webrev:

8u20 post commit review - RT-35089: fix poolstats output formatting

2013-12-20 Thread Jim Graham
I fixed some formatting issues with the poolstats output. The diffs are in the bug report: https://javafx-jira.kenai.com/browse/RT-35089 ...jim

Re: JavaFX versus AWT/Swing Hardware Acceleration

2014-01-03 Thread Jim Graham
Some key points hidden in the shadows here... We have direct rendering shaders for simple objects like rects, ovals, roundrects, simple single lines. We can handle simple strokes on those with only the stroke width being customized (must use an expected join, cap, no dashing). Text is done

Re: JavaFX versus AWT/Swing Hardware Acceleration

2014-01-03 Thread Jim Graham
Chien answered some of these, but here are my answers (inline)... On 1/3/14 9:40 AM, Steve Hannah wrote: Prism. We do mix HW and SW in that we generate masks from a path in SW, but we cache that on the card and render it using shaders. Can you describe roughly how the caching works? I

Re: Very poor performance of JavaFX on iPhone - 6 months later

2014-01-03 Thread Jim Graham
The following Jira is more precisely aimed at the scrolling optimizations that were disabled for Retina: https://javafx-jira.kenai.com/browse/RT-27959 ...jim On 1/3/14 4:04 PM, Stephen F Northover wrote: Hi Jeff, Please add your weight to the JIRA (indicate the

8u20 review request: RT-35209 - errors in the diagnostics in glContext.createProgram

2014-01-07 Thread Jim Graham
Chien, Felipe, I've made some changes to the diagnostic code in glContext.c to help track down why WebLauncher is currently failing on Mac. I need a review and perhaps some help making sure that the changes compile on other platforms... Jira: https://javafx-jira.kenai.com/browse/RT-35209

8u20 review request: RT-35210 - exceptions in WebLauncher on Mac

2014-01-08 Thread Jim Graham
Chien, Felipe, Jira: https://javafx-jira.kenai.com/browse/RT-35210 webrev: http://cr.openjdk.java.net/~flar/RT-35210/webrev.00/ I will finish the cleanup of the shader log logic (RT-35209) as a follow-on fix after this is pushed... ...jim

FX 8u20 review request: RT-25249 ImageInput does not update for changes to WritableImage

2014-01-21 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-25249 webrev: http://cr.openjdk.java.net/~flar/RT-25249/webrev.00/ The code was taken as a boilerplate from the ImageView code... ...jim

8u20 review request: RT-33294 - Canvas PixelWriter slow to fill canvas pixel by pixel

2014-01-21 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-33294 webrev: http://cr.openjdk.java.net/~flar/RT-33294/webrev.00/ Tested using the submitted test case and then also using all of the Canvas toys in rt-closed... ...jim

[8u20] Review request: RT-13275 - 0 radius blurs produce low resolution output

2014-02-21 Thread Jim Graham
Kevin, Chien, Felipe, I'm tagging 3 people on this review to hopefully get some more critical feedback mostly because the webrev is large, though most of the changes are simple due to some method signature changes... Jira: https://javafx-jira.kenai.com/browse/RT-13275 webrev:

8u20 review request: RT-35452 - Canvas does not allow missing moveto in paths

2014-02-28 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-35452/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-35452 ...jim

8u20 review request: RT-35058 - Zoomy gets texture lock errors on ARM

2014-03-03 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-35058/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-35058 ...jim

Re: Poor font rendering..

2014-03-06 Thread Jim Graham
If you look at the first o, the version on top has a leading edge that is only 2 pixels wide and the one below is a dark middle column flanked by 2 lightly colored columns. It's as if the placement on the lower text is trying harder to center its columns of sub-pixel samples to ensure that

8u20 review request: RT-36208: Exception using grayscale icon

2014-03-12 Thread Jim Graham
Simple cut/paste error fix: Jira: https://javafx-jira.kenai.com/browse/RT-36208 webrev: http://cr.openjdk.java.net/~flar/RT-36208/webrev.00/ ...jim

Re: Opacity in Image.getPixelReader.getColor()

2014-03-19 Thread Jim Graham
Kevin and Jasper hit the nail on the head (Jasper's comment that the words are usually associated with particular ranges is mostly true AFAIRemember, but I can't guarantee it). If there is part of the documentation here that could be made clearer, let us know...

Re: Transparency and drop-shadow

2014-03-28 Thread Jim Graham
This is one of the earliest bugs filed against the effects package: https://javafx-jira.kenai.com/browse/RT-381 I can understand the concept, but since our effects are pixel-based, it is hard to figure out where the foreground drawing would have rendered opaquely if it didn't have an alpha

8u20 review request: RT-24903 - Canvas does not always consume its rendering commands

2014-04-02 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-24903/webrev.01/ jira: https://javafx-jira.kenai.com/browse/RT-24903 ...jim

Re: Expected frame rates for a full-screen blur

2014-04-02 Thread Jim Graham
Actually, Box Blurs are no more efficient than Gaussian on GPU hardware due to the inability of shaders to perform incremental operations from pixel to pixel. Both are implemented by convolution kernels and N multiplies per pixel in the first horizontal pass and M multiplies per pixel in the

Re: Expected frame rates for a full-screen blur

2014-04-02 Thread Jim Graham
The tick marks in the MacOS display settings do not turn off retina support, they only affect the amount of scaling within the retina spectrum that is provided. To turn off retina support you need to use a utility like QuickRes that allows you to specify HiDPI (retina) vs. non-HiDPI

[8u20] review request: RT-36790 dirty opts failure when vram shortage frees the back buffer

2014-04-27 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-36790 webrev: http://cr.openjdk.java.net/~flar/RT-36790/webrev.00/ ...jim

[8u20] Review request for RT-36340 - MT issues with GraphicsContext on unattached canvases

2014-05-01 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-36340 webrev: http://cr.openjdk.java.net/~flar/RT-36340/webrev.00/ ...jim

[8u20] review request: RT-36760 - inner shadow displaced after fix for RT-13275

2014-05-09 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36760/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36760 ...jim

[8u20] Review Request RT-36296 - app freeze with zero width dashed border

2014-05-09 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36296/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36296 Do we need 2 reviewers? ...jim

Re: Canvas initial delay issue

2014-05-12 Thread Jim Graham
This is likely due to growing the command buffer which was done linearly at one point (probably still done that way in 2.2), but is now exponential in 8.0. The first render time is nearly instantaneous in 8.0, but takes a long time as you found when I try it with one of my old 2.x builds...

Re: Canvas initial delay issue

2014-05-12 Thread Jim Graham
For the record, no such lengthy caching is done. Ovals are either rendered using a single oval shader or on some platforms (i.e. embedded) using a combination of that shader or an oval farm that is populated nearly instantly on startup (a single texture upload)... ...jim On

Re: Bad performance with Canvas and extensive clipping

2014-05-23 Thread Jim Graham
Are you clipping to an arbitrary path in all cases or just a rectangle? Unfortunately we only offer the arbitrary clip-to-current-path method that isn't optimized for basic rectangular clipping and it implements soft clipping. There is an outstanding tweak that we added faster clipping

Re: Bad performance with Canvas and extensive clipping

2014-05-27 Thread Jim Graham
case. I guess that rect clipping is the most common one so having an optimization for rects and a slow path for none rects might help. Tom Von meinem iPhone gesendet Am 23.05.2014 um 23:35 schrieb Jim Graham james.gra...@oracle.com: Are you clipping to an arbitrary path in all cases or just

Re: Bad performance with Canvas and extensive clipping

2014-05-27 Thread Jim Graham
common one so having an optimization for rects and a slow path for none rects might help. Tom Von meinem iPhone gesendet Am 23.05.2014 um 23:35 schrieb Jim Graham james.gra...@oracle.com: Are you clipping to an arbitrary path in all cases or just a rectangle? Unfortunately we only offer

Re: Bad performance with Canvas and extensive clipping

2014-05-27 Thread Jim Graham
://tomsondev.bestsolution.at/2014/05/24/swtonfx-javafx-canvas-with-many-clipping-calls-unacceptable-slow/#comments Tom On 27.05.14 23:47, Jim Graham wrote: Canvas is, essentially, a draw pixels mechanism. We have to bundle the requests into a command stream due to threading issues, but when the requests get

Re: Bad performance with Canvas and extensive clipping

2014-05-27 Thread Jim Graham
Schindl wrote: I'm on java8u5! Tom On 27.05.14 23:38, Jim Graham wrote: You may have been testing J2D in a pre-retina-aware VM vs. JavaFX which was retina aware a little earlier than J2D (due to JavaFX being on a slightly more liberal feature policy for new releases). I think J2D went retina

8u20 review request: RT-36016 dirty region problems with large blurs

2014-06-04 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36016/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36016 This is a regression caused by the recent work on blurs/shadows on retina... ...jim

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Jim Graham
In that code i n is a tautology. It's purpose seems to be to prevent the following i+1s from overflowing the string length, but then it should be i n-1 or n should just be initialized to name.length()-1 (and be called max or something to make its purpose clear)...

8u20 review request RT-37434: Canvas dimensions not synchronous if bound

2014-06-06 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-37434/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37434 Is there any other way for the properties to be updated that the new fix doesn't cover? ...jim

8u20 review request: RT-36891: canvas does not clear correctly with clipping

2014-06-06 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36891/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36891 Details are in the Jira comments... ...jim

8u20 review request: RT-37449 - use of Canvas PixelWriter leaves graphics in SRC mode

2014-06-06 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-37449/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37449 Simple fix, details in Jira comments... ...jim

8u20 review request: RT-37475 shadow in Ensemble8 Puzzle Pieces demo gets erased

2014-06-13 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-37475/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37475 Lengthy explanation of an aha moment in the Jira, but the actual fix is fairly simple... ...jim

8u20 review request: RT-36341 - error loading image without extension on retina Mac

2014-06-16 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36341/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36341 It will be hard to verify the test because webrev mangled the patch file on the test file, but any image file renamed to the appropriate file name should work as indicated in the

8u40 review request: RT-37300 Optimize Canvas clipping for rectangular clips

2014-07-01 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-37300/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37300 ...jim

8u40 review request: RT-37793 performance problems in Canvas temp and clip buffers

2014-07-10 Thread Jim Graham
Jira: http://cr.openjdk.java.net/~flar/RT-37793/webrev.00/ webrev: http://cr.openjdk.java.net/~flar/RT-37793/webrev.00/ ...jim

Re: 8u40 review request: RT-37793 performance problems in Canvas temp and clip buffers

2014-07-10 Thread Jim Graham
Girod wrote: Hello, I have a question about this (sorry if you explained it before): does rectangular clipping on regular Nodes has / had the same performance problems than with the Canvas? Hervé Sent from my iPhone On Jul 10, 2014, at 21:19, Jim Graham james.gra...@oracle.com wrote: Jira

8u40 review request: RT-30107 - use fast mask methods for Canvas clipping

2014-07-10 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-30107 webrev: http://cr.openjdk.java.net/~flar/RT-30107/webrev.00/ Some explanation and benchmark results are in the Jira comments... ...jim

8u40 review request: RT-38005 problems with blend effect clipping

2014-07-24 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-38005/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38005 ...jim

Re: How to learn the identity of the graphics card?

2014-08-05 Thread Jim Graham
If there is a card that can't keep up with what we want it to do then we should probably be dealing with that on our end as well, whether by disabling 3D on that card or by black listing it and just falling back to sw pipeline. We already do that with a number of embedded GPUs...

Re: Some questions

2014-08-11 Thread Jim Graham
On 8/9/14 3:19 PM, Edu García wrote: Hi, I have a few questions about JavaFX usage, I hope this is the right place to ask them: 1. I'm creating a Pane with a lot of shapes and resizing it to 128x128. I'm saving it as an image with snapshot() and SwingFXUtils.fromFXImage() (is there any other

Re: Elliptical gradient

2014-08-14 Thread Jim Graham
I could have sworn there was a bug for this, but I can't find it. You should submit one so that we can track the request. In the meantime, you could apply your trick to any shape by setting that shape as the clip on the proportionally distorted rectangle... ...jim

8u40 review: RT-37999 - need API for line dashing in Canvas/GraphicsContext

2014-08-20 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-37999/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37999 Includes API unit tests and a graphical test is attached to the Jira issue... ...jim

Re: Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Jim Graham
We simply haven't implemented this yet: https://javafx-jira.kenai.com/browse/RT-28629 ...jim On 8/26/14 3:29 PM, Felipe Heidrich wrote: I'm curious. Why setSmooth doesn't work? I tried setSmooth but it doesn’t work. See the doc: Indicates whether to use a better

8u40 API review: RT-23822 - need API for LCD font smoothing in Canvas

2014-08-26 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-23822/webrev.01/ Jira: https://javafx-jira.kenai.com/browse/RT-23822 Includes API unit tests and a graphical test is attached to the Jira issue... ...jim

Re: Displaying pixel-perfect images without blur when zooming

2014-08-27 Thread Jim Graham
. On the other hand, it could just be a bug of JavaFX. I repeat: On 8/26/14 4:35 PM, Jim Graham wrote: We simply haven't implemented this yet: https://javafx-jira.kenai.com/browse/RT-28629 ...jim setSmooth() is not hooked up to any mechanism at all. Nothing examines

Re: Displaying pixel-perfect images without blur when zooming

2014-08-27 Thread Jim Graham
, but it's free to ask :). On Thu, Aug 28, 2014 at 8:01 AM, Jim Graham james.gra...@oracle.com wrote: On 8/27/14 1:04 AM, Nico Krebs | www.mensch-und-maschine.de wrote: Question 1: I don't know why setSmooth(false) doesnt work. Perhaps am i using it the wrong way? I set it for each ImageView object i

8u40 review request: RT-38183 - ManagedResource warnings when switching screen configurations

2014-08-27 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-38183/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38183 Short and long explanations of the fix are in the Jira comments... ...jim

Re: Displaying pixel-perfect images without blur when zooming

2014-08-28 Thread Jim Graham
. ...jim On 8/27/14 11:51 PM, Nico Krebs | www.mensch-und-maschine.de wrote: Thank you both! i added a vote to the feature request. Could you provide a short sample, how snapshot(..) can help me zooming without antialiasing? Nico Jim Graham mailto:james.gra...@oracle.com 28

Re: outstanding resource locks

2014-09-02 Thread Jim Graham
Originally it would complain about the resources being locked on every frame since they remained locked. More recently we installed a report and forgive mechanism that reports that the locks were outstanding (because that is a bug), but then it conditionally can either mark the resource as

Re: 8u40 review request: RT-38183 - ManagedResource warnings when switching screen configurations

2014-09-02 Thread Jim Graham
A new version of this fix was just posted for review after the sanity testing failures from this morning... ...jim On 8/27/14 7:21 PM, Jim Graham wrote: webrev: http://cr.openjdk.java.net/~flar/RT-38183/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38183

8u40 review request: RT-36205 ManagedResource pool warnings when printing from a live app

2014-09-03 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36205/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36205 Description of fix and testing is in the Jira issue. I'd especially appreciate some more rigorous testing from Phil if he can spare the time and has any printing test suites that

8u40 review request for critical bug: RT-38574 tests deadlocking

2014-09-09 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-38574/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38574 ...jim

8u40 review request RT-38536: Deadlock initializing Image converter module from multiple threads

2014-09-10 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-38536/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38536 As mentioned in the Jira comments I would appreciate advice on turning the tests attached to the issue into unit tests that run in separate/fresh runtimes...

8u40 review request: RT-36221 INNER/OUTER stroke types wrong on Linux

2014-09-11 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-36221/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36221 Simple workaround copied from other parts of the code base... ...jim

8u40 review request: RT-38556 large LinearGradient can cause a later scene fill to fail

2014-09-16 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-38556/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38556 ...jim

8u40 review request: RT-37356 SW pipeline renders progress bar too darkly

2014-09-17 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-37356/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37356 Details in the Jira comments... ...jim

8u40 review request: RT-25263 AreaChart has flattened series symbols in the legend

2014-09-23 Thread Jim Graham
Hi Kevin, Chien, webrev: http://cr.openjdk.java.net/~flar/RT-25263/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-25263 CC'ing Felipe in case he has any comments from when he worked on this code... ...jim

8u40 review request: RT-36854 SwingFXUtils.fromFXImage always adds an alpha channel

2014-09-23 Thread Jim Graham
Hi Kevin, webrev: http://cr.openjdk.java.net/~flar/RT-36854/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36854 ...jim

8u40 (already reviewed) post-push notification: RT-36566 - make vram target limit more dynamic

2014-10-10 Thread Jim Graham
Kevin already reviewed this fix during a discussion on the Jira issue (see the comments), but I realized after I pushed that I never sent out a public request for reviews to the list... Jira: https://javafx-jira.kenai.com/browse/RT-36566 webrev:

New vram usage algorithms, [was Re: 8u40 (already reviewed) post-push notification: RT-36566 - make vram target limit more dynamic]

2014-10-10 Thread Jim Graham
... ...jim On 10/10/14 2:36 AM, Jim Graham wrote: Kevin already reviewed this fix during a discussion on the Jira issue (see the comments), but I realized after I pushed that I never sent out a public request for reviews to the list... Jira: https://javafx-jira.kenai.com

8u40 review request: adding unit test for fromFXImage()

2014-10-15 Thread Jim Graham
Kevin, You asked for it, you got it, now you get to review it... ;) webrev: http://cr.openjdk.java.net/~flar/RT-38846/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38846 ...jim

8u40 review request: RT-39046 - region cache rendering artifacts on SW pipeline

2014-10-21 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-39046 webrev: http://cr.openjdk.java.net/~flar/RT-39046/webrev.00/ ...jim

preliminary 8u40 review request for RT-38948: Subscene text is blurry

2014-10-23 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-38948 webrev: http://cr.openjdk.java.net/~flar/RT-38948/webrev.01/ There are some notes that raise questions in the Jira comments. A webrev.02 will likely follow, but the webrev does fix the bug in question... ...jim

8u40 review request: RT-39120 Shape objects are blurry in some 3D transforms

2014-10-24 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-39120 webrev: http://cr.openjdk.java.net/~flar/RT-39120/webrev.01/ This is a fallout fix from working on RT-38948... ...jim

8u40 review request: RT-39119 NaN values from short Transitions

2014-10-29 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-39119 webrev: http://cr.openjdk.java.net/~flar/RT-39119/webrev.00/ ...jim

8u40 review request: RT-34467 huge memory consumption resizing transparent window

2014-10-31 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-34467/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-34467 This builds on the recent fixes for RT-38923 by adding a mechanism to reuse old buffers when they are large enough. Both test cases in RT-34467 now seem to be fairly well behaved

8u40 post-commit review: RT-39209 deleted dead code associated with obsolete FullCubic shaders

2014-10-31 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-39209/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-39209 The artifacts directory on Windows was approximately 44k smaller (out of 30m) after the code/shaders were removed... ...jim

[8u40] review request: RT-39424 center of pixel sampling for non-AA rendering

2014-11-21 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-39424/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-39424 Note that curves still show a lot of errors due to RT-39439. Those will be fixed by work on the BND constants in a separate fix... ...jim

[8u40] review request: RT-39327 retina windows are double scaled when started from external monitors on Mavericks

2014-11-26 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-39327/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-39327 ...jim

Re: [8u40] review request: RT-39327 retina windows are double scaled when started from external monitors on Mavericks

2014-11-27 Thread Jim Graham
In case Kevin is not back before our code close on Sunday night, anyone with access to a retina machine (or intimate familiarity with MacOS and Glass) feel free to review this fix... ...jim On 11/26/14 5:00 PM, Jim Graham wrote: webrev: http://cr.openjdk.java.net

[8u40] review request: RT-39590 TableCell border lines are rendered incorrectly

2014-12-05 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-39590 webrev: http://cr.openjdk.java.net/~flar/RT-39590/webrev.00/ I'm pretty sure these calls to setSmooth(false) are not intentional because the rectangles were used for rendering, not clipping, and they have always been rendered AA so far until

[8u40] review request: RT-39602 Shape.setSmooth() can leak setting to any following Region nodes

2014-12-05 Thread Jim Graham
Jira: https://javafx-jira.kenai.com/browse/RT-39602 webrev: http://cr.openjdk.java.net/~flar/RT-39602/webrev.00/ This is the fix for the true underlying problem behind RT-39590. It's a simple application of restore your state in the rendering methods to the new AA flag in NGShape...

[8u60] review request: RT-33085 static caches in BaseResourceFactory

2014-12-18 Thread Jim Graham
Phil (and Kevin), Please review: webrev: http://cr.openjdk.java.net/~flar/RT-33085/webrev.01/ Jira: https://javafx-jira.kenai.com/browse/RT-33085 Mainly I'll need Phil to test the impact on printing... ...jim

Question/feedback regarding Windows Hi DPI support and how it will affect applications

2015-02-17 Thread Jim Graham
I'm currently investigating what changes we need to make to get Windows HiDPI support up and running. As it stands, anyone with a Hi DPI Windows machine will see all Java and JavaFX programs run very tiny since the Java executables have declared that we are DPI Aware in the program manifest

Re: Question/feedback regarding Windows Hi DPI support and how it will affect applications

2015-02-18 Thread Jim Graham
On 2/18/2015 2:13 AM, Werner Lehmann wrote: Finally, it would be nice to get information about the actual screen DPI. In my tests Screen.getDpi always returns 96, regardless of what it actually is... I'm not sure if there is a legacy API for that value in Windows pre-Win8.1, but I know that

8u60 review request: Fix (eliminate) non-final static pixel scale variable

2015-01-26 Thread Jim Graham
Fix: http://cr.openjdk.java.net/~flar/RT-28164/webrev.00/ Webrev: https://javafx-jira.kenai.com/browse/RT-28164 ...jim

Re: Path Rendering in 8u40

2015-01-27 Thread Jim Graham
Where are the attached files? When you say you zoomed them in, is that with a screen pixel scaler, or by applying a scaling transform to the SVG path? I'm guessing that you are correct about RT-39439, but the fix there should have made the paths more accurate? Could the kinks have been in

Re: Canvas performance on Mac OS

2015-03-30 Thread Jim Graham
On 3/30/15 12:04 PM, Jim Graham wrote: drawPolygon() is a very complex operation that involves things like: - dealing with only rendering common points of intersection once An example of the distinction here - try a test case where you execute the exact same diagonal line primitive 1,000

Re: Canvas performance on Mac OS

2015-03-30 Thread Jim Graham
...@lesspain.de: The bad full screen performance is without the arcs. It is just one call to fillRect, two to strokeOval and one to fillOval, that's all. I will build a simple test case and file an issue. On Fri, Mar 27, 2015 at 9:58 PM, Jim Graham james.gra...@oracle.com wrote: Hi Robert

Re: Gradients w/o BGRA_PRE

2015-02-27 Thread Jim Graham
think it makes sense to use a byte array in both cases as you initially suggested. - Michael On 23 Feb 2015, at 20:58, Jim Graham james.gra...@oracle.com wrote: Oh dear, it is a bit worse than that. The texture creation code doesn't even have an enum constant to specify BYTE_RGBA_PRE

Re: Gradients w/o BGRA_PRE

2015-02-23 Thread Jim Graham
you describe: the red and the blue channel are swapped. Thanks, Michael On 23 Feb 2015, at 00:55, Jim Graham james.gra...@oracle.com wrote: Hi Michael, What error are you seeing, or is it just rendering incorrectly? Looking at the code in ES2Texture.uploadPixels() it looks like ES2 might

Re: Gradients w/o BGRA_PRE

2015-02-22 Thread Jim Graham
Hi Michael, What error are you seeing, or is it just rendering incorrectly? Looking at the code in ES2Texture.uploadPixels() it looks like ES2 might support BGRA via an extension. Perhaps we've only encountered platforms with that extension so far. Otherwise, if I read the code correctly it

Re: Canvas performance on Mac OS

2015-03-27 Thread Jim Graham
Hi Robert, Please file a Jira issue with a simple test case. Arcs are handled as a generalized shape rather than via a predetermined shader, but it shouldn't be that slow. Something else may be going on. Another test might be to replace the arcs with rectangles or ellipses and see if the

Re: Canvas performance on Mac OS

2015-04-02 Thread Jim Graham
an expected use case for JavaFX or would I be better off with Graphics2D? Thanks, Chris On Mon, March 30, 2015 20:04, Jim Graham wrote: Hi Chris, drawLine() is a very simple primitive that can be optimized with a GPU shader. It either looks like a (potentially rotated) rectangle or a rounded rect

  1   2   3   >