Re: [API REVIEW] RT-30576 Parent : add new public layout method, optimized to only layout this parent and it's children.

2013-05-22 Thread Martin Sladecek
Hi Mick, I would like to introduce similar call, see https://javafx-jira.kenai.com/browse/RT-30363 I called it requestParentLayout. There's an implementation in the attached diff : https://javafx-jira.kenai.com/secure/attachment/37081/rt-30363.diff Regards, -Martin On 05/22/2013 04:18 PM,

Re: API Review: Missing UNSORTED Comparator constant in SortedList

2013-06-04 Thread Martin Sladecek
After some discussion in the JIRA issue, the change will be much simpler: null comparator will mean UNSORTED, not natural order (i.e. using Comparable) as it does now. The natural order can be done by passing Comparator.naturalOrder() to the SortedList. -Martin On 05/31/2013 08:25 AM, Martin

Re: Usecase for needsLayout property?

2013-06-05 Thread Martin Sladecek
Hi John, the problem you described is most likely caused by something else as the layout pass occurs BEFORE the actual rendering. Also, you bind managed and visible of the entire VBox, not just the title. So it's strange that you see Label correctly laid-out, but not the content. Can you

Re: ObservableValue Stacktrace

2013-06-06 Thread Martin Sladecek
JavaFX should not fail in these cases, but doesn't consider that a valid state, so it always prints a warning on the stderr, for the developer to see something went wrong. Regards, -Martin On 5.6.2013 21:38, John Hendrikx wrote: Hi List, I'm getting some log messages sometimes (see at the

Re: [API Review]: Add margin property to node and make it styleable from CSS

2013-06-11 Thread Martin Sladecek
On 06/11/2013 03:01 PM, Tom Eugelink wrote: I know I'm reiterating, but just to keep the point alive; personally I would still prefer to have such information placed in an explicit layout constraint class. node.setMargin(x); layout.getChildren().add(node); vs layout.add(node, new

[API Review]: Node validation

2013-07-03 Thread Martin Sladecek
Hi, JIRA: https://javafx-jira.kenai.com/browse/RT-31133 I propose a single method public final void validate() to be added to Node class. The validate method would ensure that the metrics (layout bounds) of the Node are valid with regards to the current scenegraph (CSS layout). Together

Re: [API Review]: Node validation

2013-07-03 Thread Martin Sladecek
this work on the CSS side would require decoupling the 'css graph' from the scene-graph. RT-30894 touches on that. On Jul 3, 2013, at 8:33 AM, Martin Sladecek martin.slade...@oracle.com wrote: Hi, JIRA: https://javafx-jira.kenai.com/browse/RT-31133 I propose a single method public final void

Re: [API Review]: Node validation

2013-07-08 Thread Martin Sladecek
). For example TextField.validate() may look like validating the input. Also I wouldn't be surprised if users run into problems with custom nodes having their validate methods for different purposes. Pavel On 3.7.2013 14:33, Martin Sladecek wrote: Hi, JIRA: https://javafx-jira.kenai.com/browse/RT

Re: [API Review]: Node validation

2013-07-10 Thread Martin Sladecek
( if method is a side effect free): verify() verfifyNode() verifyBounds() checkNode() checkBounds() best Regards Ali Ebrahimi On Mon, Jul 8, 2013 at 4:50 PM, Martin Sladecek martin.slade...@oracle.comwrote: The plan is to have a final validate() method. Anyway, does anybody have a better suggestion

Re: [API Review]: Node validation

2013-07-10 Thread Martin Sladecek
() best Regards Ali Ebrahimi On Mon, Jul 8, 2013 at 4:50 PM, Martin Sladecek martin.slade...@oracle.com mailto:martin.slade...@oracle.comwrote: The plan is to have a final validate() method. Anyway, does anybody have a better suggestion? The validate should do both CSS and layout and I would

Re: [API Review]: Node validation

2013-07-11 Thread Martin Sladecek
. Steve On 10/07/2013 2:50 AM, Martin Sladecek wrote: +1 -Martin On 07/09/2013 05:06 PM, Pavel Safrata wrote: To me this sounds best so far. Perhaps updateVisuals() would be even better? Pavel On 8.7.2013 18:45, Scott Palmer wrote: validateVisuals() ? Or something with the word visual

Re: [API Review]: Node validation

2013-07-11 Thread Martin Sladecek
No, I will change the dirty roots to dirty flags on every node. With them, it's possible to use it the way you suggest (applyCSS layout on nearest layout root), but it's much more convenient if we could identify the layout root of the subtree and apply the layout from there downwards. I think

Re: [API Review]: Node validation

2013-07-12 Thread Martin Sladecek
wrote: I don't think I understand the answer. Are you saying that what we are suggesting is wrong conceptually or hard to implement or ...? Steve On 11/07/2013 1:23 PM, Martin Sladecek wrote: No, I will change the dirty roots to dirty flags on every node. With them, it's possible to use

Re: [API Review]: Node validation

2013-07-12 Thread Martin Sladecek
validate does? Is it sent to a leaf or the root node or does it matter? Steve On 12/07/2013 6:36 AM, Martin Sladecek wrote: What you suggest would be quite hard to use. Actually I think most of the developers will not know how to use it properly in order to get the right measurement. Simple

Re: [API Review]: Node validation

2013-07-12 Thread Martin Sladecek
On 07/12/2013 04:49 PM, Richard Bair wrote: The thing is that in order to compute the layout correctly, you have to start from the layout root. I think where you start the computation from depends on what you are trying to do. I think that validate or whatever we would call it would just be a

Re: [API Review]: Node validation

2013-07-15 Thread Martin Sladecek
Sounds like a plan. I'll retarget RT-31133 (validate) to Van Ness in case it would be required later. I will change the layout processing so that it uses flags instead of dirty root lists. That way, getRoot().layout() will trigger a complete layout pass or both Scenes and SubScenes. Means

Re: Rowsorting of TableView with SortedList/FilteredList

2013-08-16 Thread Martin Sladecek
can enable sorting just be wrapping it into a SortedList before passing it to the TableView. Regards, -Martin On 08/16/2013 11:04 AM, Jonathan Giles wrote: This is a FilteredList issue that Martin Sladecek is looking into. -- Jonathan Sent from a touch device. Please excuse my brevity. Martin

Re: replace a section of ObservableList in one operation?

2013-09-02 Thread Martin Sladecek
Hi Tomas, unfortunately, this is not possible. I have filed a JIRA issue https://javafx-jira.kenai.com/browse/RT-32655 for the setAll method with range. The subList doesn't return an ObservableList, as the sublists become invalid once there's some structural change on the list. That would

[API Review] : Baseline offset depends on layout bounds which are calculated during layout

2013-09-03 Thread Martin Sladecek
Hi, related JIRA issue: https://javafx-jira.kenai.com/browse/RT-31006 I propose to add constant public static final double USE_COMPUTED_BASELINE_OFFSET to Node class. This would be returned by the default Node implementation of getBaselineOffset. Currently, the layout bounds are returned,

Re: [API Review] : Baseline offset depends on layout bounds which are calculated during layout

2013-09-09 Thread Martin Sladecek
around instead of having things in the wrong place the first time, only to be moved around the next pass. Richard On Sep 3, 2013, at 9:50 PM, Martin Sladecek martin.slade...@oracle.com mailto:martin.slade...@oracle.com wrote: Maybe the USE_COMPUTED_BASELINE_OFFSET should

[API Review] FXMLLoader's protected fields

2013-09-11 Thread Martin Sladecek
Hello, FXMLLoader contains a number of protected (non-final) fields that were made 'protected' probably just by accident. I'm going to make these fields private. If there's somebody who is working on a FXMLLoader subclass, let me know if you need some of the fields, so we could turn them

[API Review] FXML: Property handlers should take 3 parameters instead of Event

2013-09-11 Thread Martin Sladecek
Hi, I propose to support Property handlers that are similar to ChangeListener (used to listen on property changes) and accept (ObservableValue, T, T), where T can be of any class. Failure to provide a class that is a the same or supertype/interface of the real class will result in CCE (as

FXMLLoader.load

2013-09-19 Thread Martin Sladecek
Hi, I would like to change FXMLLoader load() and load(InputStream). Both are returning Object (i.e. require a cast), while the static load() methods are generified by T. A simple change would allow us to avoid casts, but keeping the ABI unchanged: public T T load(); public T T

FXMLLoader templates

2013-09-20 Thread Martin Sladecek
Hi, I would like to discuss a 8.0 feature of FXMLLoader - the template flag. I was introduced with this issue: https://javafx-jira.kenai.com/browse/RT-23413, but unfortunately, it never worked: https://javafx-jira.kenai.com/browse/RT-28121. I was trying to fix the issue, but the whole concept

Re: Event for when a node gets shown on screen

2013-10-01 Thread Martin Sladecek
That would work, except you need to hard-ref the binding otherwise it might get GCed. -Martin On 10/01/2013 02:53 PM, anton nashatyrev wrote: Hi Pedro, you may try the following code: Bindings.select(node.sceneProperty(), window, showing).addListener(new ChangeListenerBoolean() );

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
It depends on what you need to recompute. If you invalidate some properties and the internal layout depends on these properties, then also your pref/min size depends on these properties. The layout (simplified) usually works in 3 steps: 1)compute the layout using min/pref/max size of children

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
On 11/06/2013 07:31 PM, John Hendrikx wrote: On 5/11/2013 20:10, Jonathan Giles wrote: You're right in that controls don't tend to use ScenePulseListener. This may be due to an oversight on our part, or just that our requirements differ (I don't honestly know). You're also right that it is

Re: GridPane prevents layouting

2013-11-07 Thread Martin Sladecek
Hi Mario, this is definitely a bug. Can you file this to JIRA, preferably with some test case that fails for you? Thanks, -Martin On 11/07/2013 11:48 AM, Mario Ivankovits wrote: Hi JavaFX-Devs! I do have a situation where the GridPane prevents the refreshing of parts of a scene. Unhappily

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
This is something different. When properties depends on each other (using bindings), the binding computation is deferred to the first query (get() call) of the dependant. That means, if q depends on p, you can call p.set() as many times you want, but the recomputation will be triggered just

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
On 11/07/2013 03:18 PM, Tomas Mikula wrote: Hi Martin, On Thu, Nov 7, 2013 at 2:32 PM, Martin Sladecek martin.slade...@oracle.com wrote: This is something different. When properties depends on each other (using bindings), the binding computation is deferred to the first query (get() call

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
On 11/07/2013 04:03 PM, Tomas Mikula wrote: On Thu, Nov 7, 2013 at 3:34 PM, Martin Sladecek martin.slade...@oracle.com wrote: On 11/07/2013 03:18 PM, Tomas Mikula wrote: Hi Martin, On Thu, Nov 7, 2013 at 2:32 PM, Martin Sladecek martin.slade...@oracle.com wrote: This is something different

Review Request: Accordion/ScrollPane : Scrollbars appear in wrong place for Accordion close/stretch/re-open

2013-11-08 Thread Martin Sladecek
Hello, Please review the fix for: https://javafx-jira.kenai.com/browse/RT-32692#comment-367554 available here: http://cr.openjdk.java.net/~msladecek/rt-32692/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-32692/webrev.00/ Thanks, -Martin

Review request for RT-34271 : Infinite loop in computing layout

2013-11-14 Thread Martin Sladecek
webrev: http://cr.openjdk.java.net/~msladecek/rt-34271/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-34271/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-34271 Thanks, -Martin

Review request: RT-27775 : Picking a region shape doesn't respect center shape or scale shape properties

2013-11-15 Thread Martin Sladecek
Webrev: http://cr.openjdk.java.net/~msladecek/rt-27775/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-27775/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-27775 Thanks, -Martin

Review request: RT-33776 : [2d traversal] Focus indicator moves to unexpected place

2013-11-15 Thread Martin Sladecek
Hi, please review the following change. webrev: http://cr.openjdk.java.net/~msladecek/rt-33776/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-33776/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-33776 Thanks, -Martin

Review request: RT-34128 : 3D: dirty regions ignore all animations but one

2013-11-21 Thread Martin Sladecek
Jim, Chien, please review: webrev: http://cr.openjdk.java.net/~msladecek/rt-34128/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-34128/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-34128 Thanks, -Martin

Review Request: RT-34450,TreeView is not visible in SplitPane

2013-11-25 Thread Martin Sladecek
Jonathan, please review the following. Webrev: http://cr.openjdk.java.net/~msladecek/rt-34450/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-34450 Thanks, -Martin

Review request: RT-34513 : Regression: Popup in a popup behaves unexpectedly

2013-11-28 Thread Martin Sladecek
Hi Jonathan, please review the following: JIRA: https://javafx-jira.kenai.com/browse/RT-34513 webrev: http://cr.openjdk.java.net/~msladecek/rt-34513/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-34513/webrev.00/ Thanks, -Martin

Review Request: RT-34609: [FXML] b118 FXMLLoader rejects some FXML texts that was accepted before

2013-12-02 Thread Martin Sladecek
Hi David, Eva, please review: JIRA: https://javafx-jira.kenai.com/browse/RT-34609 Webrev: http://cr.openjdk.java.net/~msladecek/rt-34609/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-34609/webrev.00/ Thanks, -Martin

Review Request: RT-34142 : GridPane.addRow/addColumn methods should account for colSpan/rowSpan values

2013-12-06 Thread Martin Sladecek
Jonathan, please review: JIRA: https://javafx-jira.kenai.com/browse/RT-34142 webrev: http://cr.openjdk.java.net/~msladecek/rt-34142/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-34142/webrev.00/ Thanks, -Martin

Review request: RT-34586,Gtk: MenuButton in MenuButton context on Linux doesn't work

2013-12-10 Thread Martin Sladecek
Anthony, Alexander, please review the following: JIRA: https://javafx-jira.kenai.com/browse/RT-34586 Webrev: http://cr.openjdk.java.net/~msladecek/rt-34586/webrev.00/ Thanks, -Martin

Review request: RT-29816,Custom cursor lost over ComboBox options

2013-12-11 Thread Martin Sladecek
Hi Kevin, please review: https://javafx-jira.kenai.com/browse/RT-29816 webrev: http://cr.openjdk.java.net/~msladecek/rt-29816/webrev.00/ Thanks, -Martin

8u review request: RT-34882, NullPointerException when chaining DropShadow Effect to Reflection Effect

2013-12-13 Thread Martin Sladecek
Hi Jim, please review the following: https://javafx-jira.kenai.com/browse/RT-34882 webrev: http://cr.openjdk.java.net/~msladecek/rt-34882/webrev.00/ Thanks, -Martin

Re: Dead horse, Bindings spam when something is null

2014-01-03 Thread Martin Sladecek
Hi John, the reason why the logging was introduced is that when selectBinding is evaluated and there's a null along the way, you don't know where the actual (null) value comes from. E.g. Bindings.selectString(insertedMedia, title) might be null if insertedMedia.get() == null ||

Review request:RT-34928,Ensemble: Bouncing Balls leave tracks

2014-01-03 Thread Martin Sladecek
Jim, please review JIRA: https://javafx-jira.kenai.com/browse/RT-34928 Webrev: http://cr.openjdk.java.net/~msladecek/rt-34928/webrev.00/ Thanks, -Martin

Review request: RT-35015,[ScrollPane] ScrollPane can leave trails of horizontal lines.

2014-01-07 Thread Martin Sladecek
Jim, Jonathan, please review: http://cr.openjdk.java.net/~msladecek/rt-35015/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-35015 Thanks, -Martin

8u API Review request: RT-153 : [Stage] Option to keep Stages always on top

2014-01-07 Thread Martin Sladecek
Steve, Kevin, please review: https://javafx-jira.kenai.com/browse/RT-153 http://cr.openjdk.java.net/~msladecek/rt-153/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-153/webrev.00/ The only API change is adding alwaysOnTop property to Stage, which includes the following methods:

[8u] Post-commit review: RT-35237, When a Bidirectional binding fails, old value restoration may cause an exception hiding the real cause

2014-01-13 Thread Martin Sladecek
Hello, here's a changeset for RT-35237 (When a Bidirectional binding fails, old value restoration may cause an exception hiding the real cause), if anybody's interested. http://hg.openjdk.java.net/openjfx/8u-dev/graphics/rt/rev/f487abfe1990 Thanks, -Martin

Re: FXML, Presentation Model bi-directional binding

2014-01-20 Thread Martin Sladecek
Related JIRA issue: https://javafx-jira.kenai.com/browse/RT-17646 Uni-directional binding is possible using ${path.to.property} syntax (see http://docs.oracle.com/javafx/2/api/javafx/fxml/doc-files/introduction_to_fxml.html#expression_binding) -Martin On 01/20/2014 08:42 PM, Richard Bair

[8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all Observable collections. There were multiple requests for a way how to avoid duplicates in listeners lists. The way RT-25613 solves this is that it introduces public boolean

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
of duplicates listeners is always an error, I warmly recommend changing the API to be duplicate free. Yours Randahl On 22 Jan 2014, at 11:07, Martin Sladecek martin.slade...@oracle.com wrote: Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
On 01/22/2014 11:27 AM, Tom Schindl wrote: On 22.01.14 11:07, Martin Sladecek wrote: Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all Observable collections. There were multiple requests for a way how to avoid duplicates in listeners lists

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
-Djavafx.debug=true. Regards, -Martin Yours Randahl On 22 Jan 2014, at 11:26, Martin Sladecek martin.slade...@oracle.com wrote: The reason why this was decided this way is simple : performance. You usually don't (try to) add a listener twice, so in most cases it doesn't make sense to check

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
On 01/22/2014 12:30 PM, Richard Bair wrote: The default implementation (for Observable) would look like this: public default void ensureListener(InvalidationListener listener) { removeListener(listener); addListener(listener); } subclasses might do something more effective. The same

[8u] Review Request: RT-35462,A controller with private fields gets broken when it's subclass is used as a fxml controller

2014-01-22 Thread Martin Sladecek
Hi David, please review: http://cr.openjdk.java.net/~msladecek/rt-35462/webrev https://javafx-jira.kenai.com/browse/RT-35462 Thanks, -Martin

Review request: RT-28978, Consolidate/document handling of null values in javafx.scene.canvas.GraphicsContext

2014-01-24 Thread Martin Sladecek
Hi, please review: https://javafx-jira.kenai.com/browse/RT-28978 http://cr.openjdk.java.net/~msladecek/rt-28978/webrev.00/ Thanks, -Martin

[8u] Review request: RT-32090,Focus traversing on popups issue

2014-01-28 Thread Martin Sladecek
Jonathan, David, please review the following. Webrev: http://cr.openjdk.java.net/~msladecek/rt-32090/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-32090 Thanks, -Martin

[8u] Review request: RT-35570,[Touch] JVM irreversible state, Too many touchpoints

2014-02-03 Thread Martin Sladecek
Anthony, please review: https://javafx-jira.kenai.com/browse/RT-35570 http://cr.openjdk.java.net/~msladecek/rt-35570/webrev.00/ Thanks, -Martin

[8u] Review request: RT-35437,Gtk: Always on top notifications do not work on Linux

2014-02-04 Thread Martin Sladecek
Anthony, please review: https://javafx-jira.kenai.com/browse/RT-35437 http://cr.openjdk.java.net/~msladecek/rt-35437/webrev.00/ Thanks, -Martin

[8u] Review request: RT-21091,List on touch screen selects item on panning

2014-02-06 Thread Martin Sladecek
Hi Jonathan, please review: https://javafx-jira.kenai.com/browse/RT-21091 http://cr.openjdk.java.net/~msladecek/rt-21091/webrev/ Thanks, -Martin

[8u] Review request: RT-35180,Scrolling by touch (sliding) is not possible on horizontal list view on embedded systems

2014-02-10 Thread Martin Sladecek
Jonathan, please review: https://javafx-jira.kenai.com/browse/RT-35180 http://cr.openjdk.java.net/~msladecek/rt-35180/webrev.00/ Thanks, -Martin

[8u20] Review request: RT-23406 RT-21664

2014-02-11 Thread Martin Sladecek
Hi Jonathan, please review the following: https://javafx-jira.kenai.com/browse/RT-23406 http://cr.openjdk.java.net/~msladecek/rt-23406/webrev.00/ https://javafx-jira.kenai.com/browse/RT-21664 http://cr.openjdk.java.net/~msladecek/rt-21664/webrev.00/ Thanks, -Martin

Re: Layout issue

2014-02-11 Thread Martin Sladecek
The rule of thumb in case you modify content during the layout is that content should depend on layout pane size, not the other way around. It means that changing the content won't modify the min/pref/max size of the pane as that would trigger another layout pass (possibly falling into a

Review request: RT-23528,FocusTraversal : Wrong behavior of radio buttons in a ToggleGroup

2014-02-16 Thread Martin Sladecek
Jonathan, please review: https://javafx-jira.kenai.com/browse/RT-23528 http://cr.openjdk.java.net/~msladecek/rt-23528/webrev.00/ Thanks, -Martin

Re: OpenJFX Lambda Day, Feb 25th 2014

2014-02-18 Thread Martin Sladecek
Looks good, please file the request into JIRA, so it won't get lost. Thanks, -Martin On 02/18/2014 06:25 PM, anton nashatyrev wrote: Hello All, I'd like to add my 2 cents to lambdafication of JavaFX: Recently I was working on a fix in the JFX and used convenient JFX beans feature -

Re: hg: openjfx/8u-dev/rt: RT-34472 Add annotation processor for @FXML annotation

2014-02-25 Thread Martin Sladecek
I'm sorry, but I can't. We decided to keep the discussion there internal. -Martin On 02/25/2014 01:36 PM, Tom Schindl wrote: Can you make the bug public? Tom On 25.02.14 12:48, hang...@oracle.com wrote: Changeset: 876e334f748a Author:Martin Sladecek martin.slade...@oracle.com Date

Re: Backwards compatibility broken: Why was Color made final

2014-03-19 Thread Martin Sladecek
Here's the related JIRA issue: https://javafx-jira.kenai.com/browse/RT-31746 -Martin On 03/19/2014 09:46 AM, Randahl Fink Isaksen wrote: After upgrading to FX8, the framework I have been developing since the early access release of JavaFX three years ago is now broken. My framework has some

Review request: RT-36238, [Ensemble8] SwingInterop throws IllegalStateException: Not on FX application thread

2014-03-20 Thread Martin Sladecek
Lisa, please review the following change in Ensemble8: https://javafx-jira.kenai.com/browse/RT-36238 http://cr.openjdk.java.net/~msladecek/rt-36238/webrev.00/ Thanks, -Martin

Re: Ability to decorate ChangeListener

2014-03-24 Thread Martin Sladecek
Mario, thanks for your suggestion, but I think your specific case will not justify the change. First of all, as it was already said, equals should be symmetric. Knowing the implementation, you could rely on the fact that either the equals is called on the provided listener or on the listeners

Re: Ability to decorate ChangeListener

2014-03-24 Thread Martin Sladecek
On 24.3.2014 15:24, Mario Ivankovits wrote: But, after this discussion I do not see why one ever used .equals() at all. Look, it does not fit my needs, I do not see any use-case where one would add an removeListener with asymmetric .equals() and thus it is better you use == I think. This

Re: layoutChildren without min/pref size?

2014-04-02 Thread Martin Sladecek
Hi Tom, in all of our layout panes we do check for min/pref/max size (I think), but strictly speaking they are all just size hints so I can imagine a layout pane which would not check for these and compute the size of the child in some different way. On the other hand, the size hints, esp. min

Re: com.​sun.​javafx.​fxml.​expression

2014-04-03 Thread Martin Sladecek
Yes, that's an expression parser for FXML expressions, see http://docs.oracle.com/javase/8/javafx/api/javafx/fxml/doc-files/introduction_to_fxml.html#expression_binding -Martin On 04/03/2014 12:57 AM, Jeffrey Guenther wrote: Hi, In the midst of an autocomplete in NetBeans I discovered

Re: Dynamic position/size change and built-in layouts

2014-04-03 Thread Martin Sladecek
And are you changing the height of the child or it's preferred height? The height of a managed node is set by the VBox, so you shouldn't manipulate with it since if the VBox layout gets dirty, it will reset the heigh according to the preferred height. -Martin On 3.4.2014 19:14, Pedro Duque

Re: com.​sun.​javafx.​fxml.​expression

2014-04-07 Thread Martin Sladecek
it supports and the goals for the path resolution mechanism? How does interact with native Java objects? From: Martin Sladecek martin.slade...@oracle.com To: openjfx-dev@openjdk.java.net Cc: Date: Thu, 03 Apr 2014 09:15:11 +0200 Subject: Re: com.​sun.​javafx.​fxml.​expression Yes, that's

Re: Dynamic position/size change and built-in layouts

2014-04-07 Thread Martin Sladecek
Can you provide some small sample where this can be reproduce and preferably submit a bug to JIRA? Thanks, -Martin On 3.4.2014 23:57, Pedro Duque Vieira wrote: In the situation I described nothing happens after c1 changes height. But strangely if some other child changes, for instance c3

Re: Why can Scene's only be constructed on the UI thread?

2014-04-29 Thread Martin Sladecek
The patch tries to solve the issue by deferring the construction of Scene in PopupWindow, but the issues I ran into just show that it's not enough. In order to fix RT-17716, we need Scene construction outside of the thread. Looking at the Scene code, it seems that there are not that many

Re: Clarification on javafx.concurrent.Task cancellation behavior

2014-05-12 Thread Martin Sladecek
Hi Weiqi, this is definitely a bug, I filed https://javafx-jira.kenai.com/browse/RT-37067 to track this. Thanks, -Martin On 11.5.2014 20:22, weiqi...@gmail.com wrote: Hi, Looking at the javafx.concurrent.Task code, I see the following in the nested class TaskCallableV’s call() method:

Re: add calculating methods to bind

2014-05-23 Thread Martin Sladecek
That would be nice. Don't forget to add it to JIRA! -Martin On 23.5.2014 07:11, Tom Eugelink wrote: I feel the standard binding should offer an easy hook option heightProperty().multiply(3.4).calc( value - { snap(vallue); } ).add(5.0) On 2014-5-21 22:00, Tomas Mikula wrote: Just a side

Re: Label prefHeight vs wrapText

2014-05-28 Thread Martin Sladecek
Hi Werner, the important min/pref/max height is the one with width parameter as Label is horizontally biased. So while minHeight(width) == 17, prefHeight(width) == 34. But in your case, with ListView's prefHeight == 1000, you'll overflow by over 400px. VBox does evenly subtract these overflow

Re: Label prefHeight vs wrapText

2014-05-28 Thread Martin Sladecek
). It calls for a 3-state property (no wrapping, wrapping only when space available, wrapping), but it's too late for that unfortunately. Anyway, looks like we have another candidate for JIRA ;-) -Martin Werner On 28.05.2014 16:17, Martin Sladecek wrote: Hi Werner, the important min/pref/max

Re: Label baseline offset with a graphic

2014-06-03 Thread Martin Sladecek
Hi Werner, this has changed in 8u20. See https://javafx-jira.kenai.com/browse/RT-36729 -Martin On 06/03/2014 02:11 PM, Werner Lehmann wrote: Hi, I am trying to align labels on their baseline in an hbox. This is surprisingly difficult if some of the labels have a graphic (on the left). Turns

Re: How to scale control properly?

2014-06-05 Thread Martin Sladecek
Hi Rafal, you can wrap the control in a Group. That way, it's (actually Group's) layoutBounds will be the same as it's transformed bounds (boundsInParent). Alternatively you can use css styling, but I don't know much about how to do it properly, maybe Jonathan can help you there. -Martin On

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Martin Sladecek
Currently, we use case to distinguish between newly created objects (upper-case class name) and properties (lower-case). Otherwise, it would not be clear when there's e.g. a text property and text class if we should set a property called text or create new text object and try to assign it to

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Martin Sladecek
it is documented. Steve On 2014-06-05, 4:19 PM, Martin Sladecek wrote: Currently, we use case to distinguish between newly created objects (upper-case class name) and properties (lower-case). Otherwise, it would not be clear when there's e.g. a text property and text class if we should set

Re: monitor mouse events but not capture them

2014-06-09 Thread Martin Sladecek
Hi Tom, have you tried .addEventFilter() method? It receives the Event before the controls underneath the canvas, in the capturing phase. If you don't consume the Event, it should pass down to the controls. For more on the topic, see http://docs.oracle.com/javafx/2/events/processing.htm or

Re: monitor mouse events but not capture them

2014-06-09 Thread Martin Sladecek
/2014 08:44 AM, Tom Eugelink wrote: Ye. It does not work on the canvas pane, I suspect because of the pickOnBounds, but it does work on the stackpane. Plus, I can register to the stack pane without claiming the onMouseClick/Press hook. Many thanks! Tom On 2014-6-9 8:29, Martin Sladecek

Re: monitor mouse events but not capture them

2014-06-09 Thread Martin Sladecek
: Hm, maybe I chose bad words; I'm not using Canvas, but just a Pane. Since the Pane is only used to draw the menu on when it need to appear, I'm calling it the canvas pane, as in what is painted on. On 2014-6-9 9:46, Martin Sladecek wrote: Just looked at the code and it seems Canvas does pick

Re: How to scale control properly?

2014-06-10 Thread Martin Sladecek
/controlsfx/controlsfx/src/96f40eb0b579277139192e2398fbbaf7fd01f91e/controlsfx/src/main/resources/org/controlsfx/control/rating.css?at=default -- Rafal 2014-06-05 16:12 GMT+02:00 Martin Sladecek martin.slade...@oracle.com: Hi Rafal, you can wrap the control in a Group. That way, it's (actually

Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
Hello, I would like to start some discussion about formatted text field API. The related JIRA issues are RT-14000 (formatted text field) and RT-30881 (content filter). The RT-30881 defines a content filter for all text input controls (in TextInputControl class), like TextField and TextArea.

Re: Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
be no problem with having writable value. -Martin On 11.6.2014 15:53, Scott Palmer wrote: In FormattedTextField why is the value property returned as a read-only property? This control should allow bi-directional bindings to the value property. Scott On Wed, Jun 11, 2014 at 4:50 AM, Martin

Re: Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
for this: - a regular binding could be used with a read-only FormattedTextField for cases where you want the text representation shown in the UI and have it selectable and readable for copy/paste. - a bi-directional binding should just work Scott On Wed, Jun 11, 2014 at 9:59 AM, Martin Sladecek martin.slade

Re: Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
ComboBox? Scott On Wed, Jun 11, 2014 at 10:08 AM, Martin Sladecek martin.slade...@oracle.com mailto:martin.slade...@oracle.com wrote: Although I'm not sure the second one can be considered a use-case, I agree that somebody might want uneditable field with some format (and it's up

hg: openjfx/8u-dev/rt: RT-37668 FilteredList reports a size of zero until a Predicate is supplied.

2014-06-24 Thread martin . sladecek
Changeset: c367a3e860f2 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-06-24 15:35 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c367a3e860f2 RT-37668 FilteredList reports a size of zero until a Predicate is supplied. ! modules/base/src/main/java/javafx

hg: openjfx/8u-dev/rt: RT-17716 Some controls can only be created on the FX application thread

2014-06-26 Thread martin . sladecek
Changeset: 26d0acd8a72e Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-06-26 09:30 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/26d0acd8a72e RT-17716 Some controls can only be created on the FX application thread Reviewed by: anthony ! modules/graphics

Re: Deserializing javafx.event.EventType

2014-06-30 Thread Martin Sladecek
Hi, EventTypes are serializable solely for the purpose of Event serialization (which is serializable because it inherits from java.util.EventObject). When you deserialize Events, the corresponding EventType objects are already initialized, so the EventTypes are correctly mapped. -Martin On

hg: openjfx/8u-dev/rt: [TEST] RT-37752 Unit test failure in Snapshot1Test after fix for RT-17716

2014-06-30 Thread martin . sladecek
Changeset: 65cabfa41abe Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-06-30 09:53 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/65cabfa41abe [TEST] RT-37752 Unit test failure in Snapshot1Test after fix for RT-17716 ! tests/system/src/test/java/javafx

hg: openjfx/8u-dev/rt: [COMMENT-ONLY] removed obsolete comment after RT-37752 fix

2014-06-30 Thread martin . sladecek
Changeset: 030772161397 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-06-30 17:21 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/030772161397 [COMMENT-ONLY] removed obsolete comment after RT-37752 fix ! tests/system/src/test/java/javafx/scene

Re: Formatted text field API (RT-14000, RT-30881)

2014-07-02 Thread Martin Sladecek
There's a new proposal here: https://javafx-jira.kenai.com/browse/RT-14000 I merged FormattedTextField and content filter to a single Formatter class, that's now part of the TextInputControl. -Martin On 06/11/2014 10:50 AM, Martin Sladecek wrote: Hello, I would like to start some discussion

hg: openjfx/8u-dev/rt: RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed

2014-07-02 Thread martin . sladecek
Changeset: c21b1705eb10 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-07-02 13:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c21b1705eb10 RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed Reviewed

hg: openjfx/8u-dev/rt: RT-37747 Additional app-thread checks should be added (back) after RT-17716

2014-07-02 Thread martin . sladecek
Changeset: 8cc538c3a7f8 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-07-02 13:17 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8cc538c3a7f8 RT-37747 Additional app-thread checks should be added (back) after RT-17716 Reviewed by: kcr, anthony ! modules

  1   2   >