Will there be an API for creating materials?

2017-05-10 Thread Nir Lisker
It seems that currently developers can't create their own material because the abstract class Material is not designed to be subclassed, and so PhongMaterial is the only one available. Are there any plans to allow developers to subclass Material and crate their own materials? Phong is somewhat

Re: Corrections for Javadoc

2017-05-11 Thread Nir Lisker
t; I'll add your note to this new JBS bug. > > Thank you. > > -- Kevin > > > > > Nir Lisker wrote: > >> I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. >> I can't submit issues to the JIRA so I'll list them here. A simila

Corrections for Javadoc

2017-05-10 Thread Nir Lisker
I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the JIRA so I'll list them here. A similar issue was https://bugs.openjdk.java.net/browse/JDK-8177341. - The following use "a Observable..." instead of "an Observable...". -

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
last minute typos: > > https://bugs.openjdk.java.net/browse/JDK-8180070 > > I'll add your note to this new JBS bug. > > Thank you. > > -- Kevin > > > > > Nir Lisker wrote: > >> I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. >> I c

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
Yes, I saw that the due date on the report is the 24th. I don't know if it's worth anyone's time, but there are simple scripts that catch all sorts of spelling and grammar mistakes. Pretty sure it won't be that hard to integrate one.

Default PointLight for Scene

2017-05-23 Thread Nir Lisker
A Scene supplies a default PointLight if it contains a 3D object. However, adding a Light to any group in the scene removes the default light. Is it possible to retain the light, or get a reference to it from the scene?

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
gt; Thank you. > > -- Kevin > > > > > Nir Lisker wrote: > >> I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. >> I can't submit issues to the JIRA so I'll list them here. A similar issue >> was https://bugs.openjdk.java.net/browse/J

Re: Default PointLight for Scene

2017-05-23 Thread Nir Lisker
ht source is a Color.WHITE > PointLight placed at the camera position. > > > - Chien > > > > > On 05/23/2017 09:11 AM, Nir Lisker wrote: > >> A Scene supplies a default PointLight if it contains a 3D object. However, >> adding a Light to any group in t

Re: Corrections for Javadoc

2017-05-26 Thread Nir Lisker
Looks like the above didn't make it in time. Can it be fixed in the next batch? On Tue, May 23, 2017 at 9:26 PM, Nir Lisker <nlis...@gmail.com> wrote: > Hopefully this makes it in time: > > javafx.scene.control.TreeView has wrong javadoc for the > queryAccessibleAttribute metho

Re: Corrections for Javadoc

2017-05-16 Thread Nir Lisker
gt; > Thanks. > > -- Kevin > > > Nir Lisker wrote: > > Add this to the list as well please: > > javafx.scene.image.Image's constructors: > > - Image(String url) > - Image(String url, boolean backgroundLoading) > - Image(String url, double requestedWidth, double re

Re: OpenJFX initiative

2017-09-22 Thread Nir Lisker
en > this is not clear) and also what it *should be* (where we coalesce > everyone’s own ideas) so we can move forward. > > That is of course *if* JavaFX is actually going to “move forward” rather > than “sideways”. > > Honestly though, if you’re not moving forward, you a

Re: OpenJFX initiative

2017-09-22 Thread Nir Lisker
penJFX better" or be integrated? > > ​​ > Graciously, > > John-Val Rose > Chief Scientist/Architect > Rosethorn Technology > Australia > > On 23 September 2017 at 09:08, Nir Lisker <nlis...@gmail.com> wrote: > >> > What do you mean by “go with

OpenJFX initiative

2017-09-22 Thread Nir Lisker
I didn't see any update on the idea for our initiative. Are we still waiting for a reply from Oracle or do we go with Johan Vos's experience? I think that the least we can do without putting any work into this is have a semi-formal list of people who would like to work on this and a list of what

Re: openjfx-dev Digest, Vol 71, Issue 15

2017-10-13 Thread Nir Lisker
Hi, Thanks for the slides Laurent. Was the talk not recorded? Would like to get in on the community effort discussion. If possible, include me in it. Thanks, Nir On Fri, Oct 13, 2017 at 3:00 PM, wrote: > Send openjfx-dev mailing list submissions to >

Re: WebView and WebGL

2017-09-10 Thread Nir Lisker
I don't want to hijack the WebGL discussion but since it rolled into the 3D library territory anyway I'll give my 2 cents. 3D enhancement are indeed not planned for Java10 (at the minimum) and indeed you can't bring your own shader (asked already at

Re: Innovation (Was: WebView and WebGL)

2017-09-10 Thread Nir Lisker
pool our resources and skills and "Just do it" (with > or without Oracle's help). > > I like what you are suggesting and what Sverre is requesting and what > numerous others are wanting, and I for one *want* them to become realities. > > Quite frankly, I don't see these

Re: WebView and WebGL

2017-08-25 Thread Nir Lisker
It has been suggested already in https://bugs.openjdk.java.net/browse/JDK-8091035.

Re: openjfx-dev Digest, Vol 73, Issue 20

2017-12-13 Thread Nir Lisker
John, As as I said in the past I'm all for it. Just didn't see anything going on. My personal preference is in the area of the 3D API. Iv'e already built on top of it for my own use and I (personally) think that some of what Iv'e done could be useful for the API. I also looked into the Prism HLSL

Re: javadoc changes [was: openjfx-dev Digest, Vol 73, Issue 25]

2017-12-16 Thread Nir Lisker
you are of a > mind to to do it. > > -- Kevin > > [1] http://openjdk.java.net/projects/jdk/10/ > > [2] https://bugs.openjdk.java.net/browse/JDK-8188314 > > > Nir Lisker wrote: > >> Kevin, >> >> I wouldn't mind pushing javadoc changes into 10, b

Re: openjfx-dev Digest, Vol 73, Issue 25

2017-12-15 Thread Nir Lisker
Kevin, I wouldn't mind pushing javadoc changes into 10, but don't have OpenJFX built yet as I'm waiting for updated instructions on that. Can you tell when is RDP1 ending and when is it planned to update the build instructions so I'll know what my time window is? Thanks, Nir On Fri, Dec 15,

TabPane bug: removing and adding a tab

2017-12-08 Thread Nir Lisker
Looks like there's a bug with TabPane which happens when a tab is removed and quickly added back, before the layout is updated. This causes incorrect positioning of the headers. It was posted on SO: https://stackoverflow.com/ questions/47616221/javafx-tabpane-tabs-dont-update-position/ and

Re: Paint Phase Debugging / Performance

2018-05-07 Thread Nir Lisker
Hi, I'm having a performance issue myself. I'm using animations on 3D models (in a 3D subscene) and when there are "too many" models the QuantumRenderer thread is running 100% of the time and utilizing 20-25% of the CPU, though the OS reports that overall all cores are at ~40%. The application is

Re: Announcing EA builds of standalone JavaFX SDK

2018-05-08 Thread Nir Lisker
Thanks Kevin, that's good to hear. Michael, adding the external jars as single entries is the simplest and most granular way, but you can also define a library from those jars and then add that single library to any project: 1. Add Library... 2. User Library 3. User Libraries... 4. New... (give

Re: Paint Phase Debugging / Performance

2018-05-08 Thread Nir Lisker
flags here to try narrow it down - > Just open PrismSettings.java in your IDE or web browser. > > Code explains them better than most posts I’ve seen. > > Good luck. > Matt > > Sent from my phone. > > On 7/05/2018, at 2:36 PM, Nir Lisker <nlis...@gmail.com> w

JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-04-27 Thread Nir Lisker
Hi Murali, Can you have a look at https://bugs.openjdk.java.net/browse/JDK-8195974 please? There are some usages of j.u.l in the web module I'd like your opinion on. I'm not familiar with the intent of these pieces of code and would like to know what the options are for advancing with this issue

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-05 Thread Nir Lisker
Hi Prasanta, If @override is not added, then it will cause recursion between > LightweightContent.java:130 and LightweightContent.java:187 I don't understand how the existence or lack thereof of an @Override can cause or prevent recursion (bar reflection). Since all the methods of the interface

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-04 Thread Nir Lisker
Hi Prasanta, In SwingNode, lines 870 -883, is there a reason that only the first method uncommented @Override? I don't understand the comment that wants to skip @Override. Some minor code comments: * LightweightFrameWrapper#isCompEqual: you can skip the 'if' and just 'return c !=

Review Request: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-19 Thread Nir Lisker
Hi, Please review the fix approach for: https://bugs.openjdk.java.net/browse/JDK-8195974 http://cr.openjdk.java.net/~nlisker/8195974/webrev.00/ Many details in the issue. Thanks, Nir

Re: Matrox Graphics Cards Problems

2018-05-17 Thread Nir Lisker
Hi Matthew, Is there a way to get more details on why JavaFx fails to enable the D3D > pipeline? Add the VM argument -Dprism.verbose=true and post what it spits. - Nir On Thu, May 17, 2018 at 5:04 PM, Matthew Elliot < matthew.james.ell...@gmail.com> wrote: > Hi all, > > we have some

Re: OpenJFX status update

2018-05-16 Thread Nir Lisker
What will happen to the JavaDocs? Will they be removed from the EA docs and upon release from the release docs? - Nir On Wed, May 16, 2018 at 12:59 AM, Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: > I wanted to update you on the progress of the last couple weeks on the > OpenJFX

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

2018-05-21 Thread Nir Lisker
Since the packager is being removed I don't see a reason to keep any references to it. In any case, the Eclipse files are planned to be updated [1] after j.u.l. is removed [2]. [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-April/021740.html [2]

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

2018-05-21 Thread Nir Lisker
Fine by me. - Nir On Tue, May 22, 2018 at 12:29 AM, Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: > In that case, why don't I revert my changes and let you remove the > references after j.u.l is removed. > > -- Kevin > > > > On 5/21/2018 2:13 PM, Nir Lisker

Re: Review Request: JDK-8195974: Replace use of java.util.logging

2018-05-22 Thread Nir Lisker
Hi Daniel, I see that you have changed javafx.base tests to stop using > java.util.logging for verifying the log messages produced > by javafx.base classes, and I was wondering whether that > was really necessary? This was the most acceptable approach. The reason is that using j.u.l., even in

Re: Review Request: JDK-8195974: Replace use of java.util.logging

2018-05-22 Thread Nir Lisker
Tom, is there an Eclipse issue about this in Bugzilla? As I mentioned some time ago, if I add the dependency to the .classpath it should function the same as adding it to module-info. On Tue, May 22, 2018 at 5:37 PM, Tom Schindl wrote: > From a pure library

Re: OpenJFX code review policies, etc.

2018-05-24 Thread Nir Lisker
Thanks for the detailed plan Kevin, I will provide an initial list of reviewers to the registrar based on past > contributions, and also recognizing Committers who have become experts in > their area. It will be a good idea to list the reviewers/experts (names and mail) according to their

Re: OpenJFX status update

2018-05-18 Thread Nir Lisker
We are just prefixing the release value in JBS with > "openjfx" before the "11" to distinguish it from the JDK 11 release. > > After JavaFX 11, we could have a discussion on whether to make the next > version "12" or something else. > > -- Kevin > >

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Nir Lisker
isDebug() was called, that being the mLog > method. Did you replace the call ti isDebug() with a direct call to > isLoggable instead? Note that without the isLoggable check you will incur > the redundant cost of the method calls + string construction. > > -- Kevin > > > &

Re: OpenJFX status update

2018-05-18 Thread Nir Lisker
> > We still expect to do a release of JavaFX 11 around the same time as JDK > 11, but using a different release number will help track the actual content > of JavaFX 11 separately from JDK 11. Iv'e just realized that not releasing JavaFX with version number 11 will cause confusion with all the

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Nir Lisker
@Override > > public String format(LogRecord record) { > > return formatMessage(record) + "\n"; > > } > > }); > > log.addHandler(handler); > > } > > > > Thanks, > > MUrali > &g

Re: [11] Review request: 8200446: Update minimum boot JDK to 10

2018-06-14 Thread Nir Lisker
> > Once this is done, we can start using JDK 10 features, such as 'var' for > local variables (although please don't take this as a license to use 'var' > gratuitously). I'll remind that there's a style guide at http://openjdk.java.net/projects/amber/LVTIstyle.html. - Nir On Thu, Jun 14, 2018

Change of default behavior of When

2018-06-29 Thread Nir Lisker
Hi all, The class javafx.beans.binding.When is using eager evaluation of its arguments [1]. Kevin and I discussed the idea of changing this default behavior to the more intuitive lazy evaluation as done in a simple ternary expression. This is a potentially breaking change for current code that

gradle javadoc commands are SKIPPED

2018-06-25 Thread Nir Lisker
Hi, When I run gradle javadoc (or for a specific module), all the javadoc tasks are marked as SKIPPED. I don't remember this happening previously. > Task :javadoc > Task :base:javadoc SKIPPED > Task :controls:javadoc SKIPPED > Task :fxml:javadoc SKIPPED > Task :fxpackagerservices:compileJava

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Nir Lisker
m.sun.javafx.webkit.drt.DumpRenderTree”, I need to > check few more things (since we use “addHandler” in drt) and will get back > to you. > > > > Please let me know, if you have any queries for 1. > > Thanks, > > Murali > > *From:* Nir Lisker <nlis

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Nir Lisker
ial in its usage of the logger (that it requires its own property)? - Nir On Thu, May 3, 2018 at 3:31 AM, Kevin Rushforth <kevin.rushfo...@oracle.com> wrote: > inline > > > On 5/2/2018 4:52 PM, Nir Lisker wrote: > >> Thanks Murali, >> >> I won’t suggest reading level

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-03 Thread Nir Lisker
..@oracle.com> wrote: > > > On 5/2/2018 6:25 PM, Nir Lisker wrote: > > Not sure what you mean by "that file". > > > Sorry, I meant the log/config file. > > > I see. This isn't something that a library like JavaFX should read. > > keeping the verb

JDK build fails on missing javah

2017-12-31 Thread Nir Lisker
After successfully building OpenJFX (11) Iv'e went on to build OpenJDK (11) as instructed under "Integration with OpenJDK" ( http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html). When executing `bash configure --with-import-modules=jfx_path\rt\build\modular-sdk` the build fails:

Re: Updated OpenJFX build instructions

2017-12-22 Thread Nir Lisker
Thanks Kevin, I'm going through the process now on Win 10. A few things to note: - In the Platform Prerequisites/cygwin it says to make sure mercurial package is installed. Later, under Common Prerequisites/Mercurial it says "you can also install Mercurial as a cygwin package". It's not clear

Re: Updated OpenJFX build instructions

2017-12-22 Thread Nir Lisker
I'll note it. > > As for the build failure, did you install Visual Studio 2017 and set the > two env variables (VS150COMNTOOLS and MSVC_VER) to point to it? If so, then > it should determine WINSDK_DIR without anything else needed. > > -- Kevin > > > > Nir Lisker wrote:

Re: Updated OpenJFX build instructions

2017-12-24 Thread Nir Lisker
hether that file > exists somewhere else. If it does, then point VS150COMNTOOLS to the > directory containing that bat file. > > I won't have any more time to look at it this until after the new > year...maybe someone else on the list can help? > > > -- Kevin > > >

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
: > > I also note that tith simple javadoc changes... > > "with" simple ... > > -- Kevin > > > > Kevin Rushforth wrote: > >> >> >> Nir Lisker wrote: >> >>> > This shows a lack of understanding about our processes >&

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
oca-486395.html > [3] https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report > [4] https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews > [5] https://wiki.openjdk.java.net/display/OpenJFX/Committing+the+Code > > > > Nir Lisker wrote: > >> Iv'e create

Error while pushing changeset

2018-01-09 Thread Nir Lisker
Iv'e created a small documentation fix and tried to push it to http://hg.openjdk.java.net/openjfx/jfx-dev/rt. I got an error: abort: push creates new remote head 2152a80ee902! hint: pull and merge or see 'hg help push' for details about pushing new heads [command returned code 255 Tue Jan 09

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
Submitted a new bug with ID: 9052190. On Tue, Jan 9, 2018 at 10:51 PM, Kevin Rushforth <kevin.rushfo...@oracle.com > wrote: > > > Nir Lisker wrote: > > If there isn't an existing JBS issue, then please file one > > > I thought I would point to "8188314: Fi

Review request: 8194871: Fix mistakes in FX API docs

2018-01-10 Thread Nir Lisker
Hi Kevin, Please review the attached webrev. I addressed a few fixes I found as I was working, so they are not listed in the JIRA report. About Transition#getParentTargetNode: The current behavior of parent-child relationship is that an animation can be added to multiple parent transitions.

Re: Review request: 8194871: Fix mistakes in FX API docs

2018-01-10 Thread Nir Lisker
/TableView.java:209: > Trailing whitespace > modules/javafx.graphics/src/main/java/javafx/animation/Transition.java:161: > Trailing whitespace > > I can fix this before I push. > > -- Kevin > > > Nir Lisker wrote: > > Hi Kevin, > > Please review the attached webrev

Re: Review request: 8194871: Fix mistakes in FX API docs

2018-01-10 Thread Nir Lisker
Y are used in layout > calculations. > > > -- Kevin > > > Kevin Rushforth wrote: > > I just removed the trailing whitespace (using the handy > tools/scripts/checkWhiteSpace script with the '-F' option). > > -- Kevin > > > Nir Lisker wrote: > > T

Instructions for working on OpenJFX

2018-01-08 Thread Nir Lisker
Hello, I have OpenJFX and OpenJDK built. I have also set up TortoiseHg and am working with Eclipse. I have several questions: 1. Are the instructions at https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE still valid from JDK 8? There are old TODOs there. If not, can I get a quick update?

Re: fx 1.x issues in JBS

2018-01-15 Thread Nir Lisker
m not sure what you mean by this. > > -- Kevin > > > > Nir Lisker wrote: > >> Hello, >> >> JBS still has open issues for JavaFX 1 versions and they appear in >> searches >> even though there's nothing to do about them since that version is n

fx 1.x issues in JBS

2018-01-15 Thread Nir Lisker
Hello, JBS still has open issues for JavaFX 1 versions and they appear in searches even though there's nothing to do about them since that version is not supported anymore. Is it appropriate to close them all? There are also a lot in Resolved. - Nir

Re: Instructions for working on OpenJFX

2018-01-24 Thread Nir Lisker
files, that would be fine, too. > > > -- Kevin > > > Nir Lisker wrote: > > If you're still catching up, I would like to verify that I should ignore > project-level errors from the IDE. For example, Eclipse complains about the > graphics project: > > Project

JDK-8196130: Eclipse configuration files need to be updated

2018-01-25 Thread Nir Lisker
Iv'e removed all the classpath dependencies that were causing errors. I don't mind sorting out the rest of the files while at it, though for that there are a few things I'm not sure about: 1. Some dependencies are marked as optional and as such they don't cause errors, but they are still missing.

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-25 Thread Nir Lisker
> > -- Kevin > > > > Kevin Rushforth wrote: > >> >> >> Nir Lisker wrote: >> >>> Iv'e removed all the classpath dependencies that were causing errors. I >>> don't mind sorting out the rest of the files while at it, though fo

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-30 Thread Nir Lisker
preferable to both reverse the order and also add > in the location of the built class files. So the following order seems best: > > rt/modules/javafx.base/build/classes/main/javafx.base/ > rt/modules/javafx.base/src/main/java/ > jdk/modules/javafx.base > > > -- Ke

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-02-02 Thread Nir Lisker
n > gradle) without a module-info so that they run in the unnamed module. This > allows them to access JUnit, etc., as well as any public package of any > module in the system. As such we need to explicitly list any internal > packages that they use from the module they are testing. These

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-27 Thread Nir Lisker
On Fri, Jan 26, 2018 at 9:20 PM, Kevin Rushforth <kevin.rushfo...@oracle.com > wrote: > inline > > Nir Lisker wrote: > > Alright, cleaned that part. fxpackager build fails with an internal NPE in > Eclipse, so I'm going to leave that alone and all of the projects that >

Re: More community participation in JavaFX

2018-02-04 Thread Nir Lisker
Hello, As someone who has recently made the climb and managed to build OpenJFX with OpenJDK on Win 10 I might have some relevant input. --- Building OpenJFX --- * With the recently updated instructions on the Wiki, building OpenJFX is not that hard. Having to build OpenJDK for that was a real

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-29 Thread Nir Lisker
hat are in the JDK that you are using? The FX build puts the > class files in: > > rt/build/modular_sdk/modules/javafx.base/... > > > -- Kevin > > > Nir Lisker wrote: > > Another question: do imports of javafx.* packages point to the

Re: More community participation in JavaFX

2018-02-04 Thread Nir Lisker
n a PR. > Merging a PR > on the public GitHub repository means, in my opinion, that it is ready to > be opened as > an upstream bug/feature request. Automating the process with patch sets, > webrevs, formatting/lint > results, etc. would be the most ideal situation and I would be

Re: More community participation in JavaFX

2018-02-06 Thread Nir Lisker
final review/merge to the staging repo after it has been reviewed >>> by >>> the "wider audience" >>> which includes people without commit rights (people like us). Then, as >>> this >>> thing evolves, >>> based on the pool of people who

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-02-06 Thread Nir Lisker
has external org.eclipse.swt imports which weren't addressed. Let's call this round 1. Next rounds will be when Eclipse fixes some bugs and when the source repo is cleaned from unused projects. - Nir On Fri, Feb 2, 2018 at 6:52 PM, Nir Lisker <nlis...@gmail.com> wrote: > Alright,

Updating class javafx.beans.binding.When

2018-02-05 Thread Nir Lisker
Hi, I was looking at https://bugs.openjdk.java.net/browse/JDK-8089579, which prompted me to have a look at When. There are a few points I would like to address: * StringConditionBuilder#otherwise(ObservableStringValue) does not check for null as other condition builders do. This results in a

Additional info on JDK-8197536: TableView, ListView: unexpected scrolling behaviour on up/down keys

2018-02-14 Thread Nir Lisker
I tested the issue. It is not present in 1.8.0_152-b16, but it is present in 9+181 and 10-ea+37. - Nir

Re: Repositories, AdoptOpenJDK and github

2018-02-14 Thread Nir Lisker
Thank you! My concerns (not complaints) and questions: 1. Developer forks the github repo, enhances it, and creates a PR. 2. He discusses it with a committer, and eventually the PR is accepted. As I said before, we need to be careful where the discussion is made. PRs on GitHub have their own

Re: Updating class javafx.beans.binding.When

2018-02-08 Thread Nir Lisker
Iv'e managed to refactor a large portion of the class. About a 1/3 of the (repetitious) code was removed. On Tue, Feb 6, 2018 at 1:08 AM, Nir Lisker <nlis...@gmail.com> wrote: > Hi, > > I was looking at https://bugs.openjdk.java.net/browse/JDK-8089579, which > prompted me to h

Re: Updating class javafx.beans.binding.When

2018-02-20 Thread Nir Lisker
that the tests are testing an implementation > detail that would not affect an application that just uses public API. > > > -- Kevin > > > Nir Lisker wrote: > > Let's start with the refactoring then. Before I submit a bug let's check > that this plan makes sense. Att

Re: Updating class javafx.beans.binding.When

2018-02-16 Thread Nir Lisker
ensuring that the existing unit tests pass. > > Thanks. > > -- Kevin > > > > Nir Lisker wrote: > >> Hi, >> >> I was looking at https://bugs.openjdk.java.net/browse/JDK-8089579, which >> prompted me to have a look at When. There are a few points

Re: JDK build fails on missing javah

2018-01-03 Thread Nir Lisker
PM, Nir Lisker <nlis...@gmail.com> wrote: > After successfully building OpenJFX (11) Iv'e went on to build OpenJDK > (11) as instructed under "Integration with OpenJDK" ( > http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html). > > When executing `b

Code conventions formalization

2018-08-03 Thread Nir Lisker
Hi all, As we're getting closer to 12 and the GitHub repo is gaining traction, I think we should start formalizing in writing the exact code conventions we want to use to decrease future mess. The wiki has some rules [1], but there are areas which are still fuzzy. The check tools could also use

Review Request: JDK-8204653: Fix mistakes in FX API docs

2018-07-29 Thread Nir Lisker
Hi Kevin, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8204653 http://cr.openjdk.java.net/~nlisker/8204653/webrev.00/ I did not include a fix for https://github.com/javafxports/openjdk-jfx/issues/122, which is pending.

Re: Swing module's module-info file

2018-08-07 Thread Nir Lisker
And both newimlp and oldimpl packages compile for you? On Tue, Aug 7, 2018 at 8:04 PM, Tom Schindl wrote: > Hi Nir, > > I'm using OpenJDK-11 in my eclipse for development so I have that module > included. > > Tom > > On 07.08.18 18:34, Nir Lisker wrote: > > So yo

JDK-8209015: Update Eclipse project files

2018-08-08 Thread Nir Lisker
Hi, After the removal of some dependencies on JDK modules the Eclipse classpath files should be updated to allow developers to work on Eclipse without needing to do tricky configuration themselves. Iv'e submitted a JBS issue [1] to track the progress. There were discussion about removing

Swing module's module-info file

2018-08-06 Thread Nir Lisker
Hi, I didn't follow all the latest changes to the Swing module, but I notice now its module-info.java file is not in the same place where other modules have theirs: It's under javafx.swing\src\main\module-info instead of javafx.\src\main\java. Is there a reason for this? - Nir

Re: Swing module's module-info file

2018-08-07 Thread Nir Lisker
ile is modified > > Tom > > On 07.08.18 19:51, Tom Schindl wrote: > > Yes they do! > > > > Tom > > > > On 07.08.18 19:36, Nir Lisker wrote: > >> And both newimlp and oldimpl packages compile for you? > >> > >> On

Review Request: JDK-8209015: Update Eclipse project files

2018-08-14 Thread Nir Lisker
Hi, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8209015 http://cr.openjdk.java.net/~nlisker/8209015/webrev.00/ Thanks, Nir

Re: Swing module's module-info file

2018-08-07 Thread Nir Lisker
o/module-info.java" > into "$buildDir/gensrc/java/" > filter { line-> > !HAS_UNSUPPORTED_DESKTOP && > line.contains('jdk.unsupported.desktop') > ? null : line > } > } > > Regards > Prasanta > > On 8/7/2018 6:

Re: Fate of jdk.packager and jdk.packager.services?

2018-08-07 Thread Nir Lisker
Hi Lennart, You should be able to use the packager from JDK 10, see https://bugs.openjdk.java.net/browse/JDK-8203379. There is a draft for a replacement, see https://bugs.openjdk.java.net/browse/JDK-8200758. - Nir On Tue, Aug 7, 2018 at 12:28 PM, Lennart Börjeson wrote: > I'm migrating to

Re: Swing module's module-info file

2018-08-07 Thread Nir Lisker
So you rebuilt the JDK with the new jdk.unsupported.desktop module? On Tue, Aug 7, 2018 at 3:11 PM, Tom Schindl wrote: > Well I simply added the folder to my class-folders and things then work > perfectly fine inside Eclipse > > Tom > > On 07.08.18 14:02, Nir Lisker

Re: Swing module's module-info file

2018-08-08 Thread Nir Lisker
Yes, but since this thread was about the Swing module's module-info I'll start another thread with the link to the JBS issue I created a few days ago about Eclipse. On Wed, Aug 8, 2018 at 10:10 AM, Tom Schindl wrote: > Hi, > > On 08.08.18 08:55, Tom Schindl wrote: > > Hi Nir, > > > > I

JDK-8208761: Update constant collections to use the new immutable collections

2018-08-23 Thread Nir Lisker
Hi All, Iv'e been working on updating OpenJFX to use the Java 9 immutable collections [1]. If you know of any additional location which can be updated, please add a comment or reply here. New code should be mindful of these collections' existence (contributors and reviewers alike) so that we

Re: How to access com.sun.webkit.network.CookieManager at JDK 10?

2018-08-24 Thread Nir Lisker
x.controls; > } > > What is the next step? > > > On Fri, Aug 24, 2018 at 4:02 PM Nir Lisker wrote: > >> Hi Miro, >> >> Can I use the 2nd option with declaration in the source code, or the only >>> possible option is to pass as parameter when starting the

Re: How to access com.sun.webkit.network.CookieManager at JDK 10?

2018-08-24 Thread Nir Lisker
Hi Miro, Can I use the 2nd option with declaration in the source code, or the only > possible option is to pass as parameter when starting the application? > If your app is not a module then you don't have a module-info.java in your source code to declare the dependency. What you can do is

Re: INFO: JFX Issue

2018-08-21 Thread Nir Lisker
Hi, Shouldn't it be marked as In Progress in this case? - Nir On Wed, Aug 22, 2018 at 12:37 AM Kevin Rushforth wrote: > Hi Ankit, > > This one is actively under development by Murali; it was just targeted > to openjfx12 today. If you have any comments on this enhancement that > might be

Animation enhancements

2018-08-30 Thread Nir Lisker
Hi All, Iv'e taken upon myself to handle most of the enhancement proposals for animations (I could fine). A list of all these can be found here [1]. Some of the proposals are more viable than others (I do not outright suggest that they all be implemented). For those of you who are interested in

Re: JavaFX website

2018-09-04 Thread Nir Lisker
e a JBS > bug and assign it to me, I can see what needs to be done to either > correct (if simple) or archive pages that are so out of date as to be > useless (or worse, misleading). > > -- Kevin > > > > On 9/4/2018 1:18 AM, Nir Lisker wrote: > > 1. Yes. The

Re: Animation enhancements

2018-09-11 Thread Nir Lisker
Hi Brian, Thanks for the input. How is "starting" different from "started" etc.? On Mon, Sep 10, 2018 at 6:23 PM Brian Hudson wrote: > I would love to see "Animation needs more events" resolved [1]. > > Maybe following events: started, paused, resumed, cycleStarted, cycleEnded, >

Re: Instructions for working on OpenJFX

2018-01-24 Thread Nir Lisker
the JDK. > > java @build/run.args ... > > > #3. I don't know since I don't use Eclipse; maybe someone on the list who > uses Eclipse can answer. It might have to do with the level of JDK 9 > support in Eclipse > > > #4 - previously answered > > -- Kevin > >

JDK-8210361: Add images to docs for public API classes of controls

2018-09-12 Thread Nir Lisker
Hi, Iv'e started working on JDK-8210361 [1] and I'd like my comment there addressed before continuing. [1] https://bugs.openjdk.java.net/browse/JDK-8210361 Thanks, Nir

Re: Animation enhancements

2018-09-11 Thread Nir Lisker
uot; actions are really what I've had a need for, other than > "starting" I can't really think of use cases for the other "-ing" events > > On Tue, Sep 11, 2018 at 4:42 AM Nir Lisker wrote: > >> Hi Brian, >> >> Thanks for the input. How is &

Re: Animation enhancements

2018-09-11 Thread Nir Lisker
Alright, Iv'e queued the multiple event handlers issue after the additional event types issue. On Tue, Sep 11, 2018 at 5:15 PM Rick Walker wrote: > Thank you, yes that looks like it, I had not seen that comment. > > On Tue, 11 Sep 2018 at 09:51, Nir Lisker wrote: > >> Hi

Re: Animation enhancements

2018-09-11 Thread Nir Lisker
ed. > The other "-ing" events probably aren't useful an cause the complications > you describe. > > > > On Tue, Sep 11, 2018 at 10:11 AM Nir Lisker wrote: > >> So the "-ed" events are synchronous? That is, in case of "started", the >&

  1   2   3   4   5   6   7   8   9   >