Thread checks in Glass

2013-07-22 Thread Petr Pchelko
Hello all, FX is a single threaded UI toolkit. Well written FX applications should not access FX objects from outside the UI thread. There are exceptions to this rule and these are well documented. Documentation is great, but enforcing thread checks in code is better. Glass (the underlying

Re: Thread checks in Glass

2013-07-22 Thread Petr Pchelko
Seems as if the ticket isn't public... Sorry for that. Fixed. With best regards. Petr. On Jul 22, 2013, at 1:22 PM, Werner Lehmann wrote: Seems as if the ticket isn't public... On 22.07.2013 11:06, Petr Pchelko wrote: You can follow progress inhttps://javafx-jira.kenai.com/browse/RT-26891

Re: hg: openjfx/8/graphics/rt: RT-26702 Poor DisplacementMap effect performance on Mac

2013-07-24 Thread Petr Pchelko
? Thanks Richard On Jul 24, 2013, at 12:32 AM, hang...@oracle.com wrote: Changeset: dd30604ab7d0 Author:Petr Pchelko petr.pche...@oracle.com Date: 2013-07-24 11:24 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/dd30604ab7d0 RT-26702 Poor DisplacementMap

Re: hg: openjfx/8/graphics/rt: RT-26702 Poor DisplacementMap effect performance on Mac

2013-07-24 Thread Petr Pchelko
about on Windows, is there any impact there from this change or is it truly just for Mac? Has anybody tried to measure for dropped frames on Windows? Richard On Jul 24, 2013, at 11:31 AM, Petr Pchelko petr.pche...@oracle.com wrote: Hello, Richard. These changes fix the problem

Re: hg: openjfx/8/graphics/rt: RT-26702 Poor DisplacementMap effect performance on Mac

2013-07-25 Thread Petr Pchelko
we're hitting each frame right on target. Any ideas? Richard On Jul 24, 2013, at 11:31 AM, Petr Pchelko petr.pche...@oracle.com wrote: Hello, Richard. These changes fix the problem with dropping frames on Mac because of locking between the render thread and UI thread. I have

Re: hg: openjfx/8/graphics/rt: RT-26702 Poor DisplacementMap effect performance on Mac

2013-07-25 Thread Petr Pchelko
in the whole of rt and I don't see CALayer drawInGLContext anywhere in the code. (I did both an IDEA case insensitive recursive search and also a grep -r on the command line) Thanks Richard On Jul 25, 2013, at 11:26 AM, Petr Pchelko petr.pche...@oracle.com wrote: Hello, Richard. Where did

Re: Swing and JavaFX thread merge

2013-08-08 Thread Petr Pchelko
Hello. I've just pushed the fix to the repo, so it should be available in a couple of builds. However, it is an experimental feature, so we lack the documentation or examples on it. If you experience any issues with it - please contact me. As I wrote, it won't work by default in JDK8, you'll

Re: Glass thread checks

2013-08-08 Thread Petr Pchelko
Hello, OpenJFX Team. As you know, the previous attempt to switch on the thread checks have failed. The problems were fixed, so I'm going to enable them again tomorrow morning if nobody objects. With best regards. Petr.

Re: CFV: New OpenJFX Committer: Alexander Zvegintsev

2013-08-15 Thread Petr Pchelko
Vote: YES With best regards. Petr. On Aug 15, 2013, at 4:40 PM, Artem Ananiev wrote: I hereby nominate Alexander Zvegintsev (OpenJDK user name: alexz) to OpenJFX Committer. Alexander is a primary maintainer of Gtk port of Glass (windowing toolkit for JavaFX), and also an active

Re: CFV: New OpenJFX Committer: Yao Wang

2013-09-25 Thread Petr Pchelko
Vote: YES. With best regards. Petr. On Sep 25, 2013, at 8:01 PM, Artem Ananiev artem.anan...@oracle.com wrote: I hereby nominate Yao Wang to OpenJFX Committer. Yao is a member of JavaFX Graphics team at Oracle. Most of recent Yao's changes are in 3D support code, but not only there:

Default methods in JFX-8

2013-10-03 Thread Petr Pchelko
Hello, OpenJFX Community. There's a question about using Java 8 features in FX. I've been working on the support for InputMethods in JFXPanel which is an important feature for many users who speak hieroglyphic languages. The issue is tracked under: https://javafx-jira.kenai.com/browse/RT-13248

Re: Default methods in JFX-8

2013-10-03 Thread Petr Pchelko
other options you have, besides adding InputMethodRequests2 or whatever and having to do an instanceof test and cast. But that might actually be the better way to handle this situation. What code needs to call these new methods? Richard On Oct 3, 2013, at 11:24 AM, Petr Pchelko petr.pche

Enabling Glass thread checks

2013-10-04 Thread Petr Pchelko
Hello, OpenJFX. FX is a single threaded UI toolkit. Glass (the underlying native window toolkit portability layer for FX) is being changed to ensure it is accessed from the UI thread. You can follow progress in https://javafx-jira.kenai.com/browse/RT-26891 We are reenabling the Glass thread

Re: JFXPanel with WebView in JDK8

2013-11-06 Thread Petr Pchelko
Hello, Artem. This exception is expected, when an old JDK8 build is used. Actually I suppose it’s a bug, here’s a JIRA for it: https://javafx-jira.kenai.com/browse/RT-34077 I’ll fix it in a couple of days probably. With best regards. Petr. On Nov 6, 2013, at 11:53 AM, Artem Ananiev

Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Petr Pchelko
Hello, OpenJFX community. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34077 The webrev is available at: http://cr.openjdk.java.net/~pchelko/fx/34077/webrev/ Thank you. With best regards. Petr.

Review Request: RT-34107 [Mac] Cannot set app name for menu items in app menu of system menubar

2013-11-08 Thread Petr Pchelko
Hello, OpenJFX Community. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34107 The details are available in the bug comments. Thank you. With best regards. Petr.

Review Request: RT-34162 [macosx] Regression in Input Method panel positioning

2013-11-12 Thread Petr Pchelko
Hello, OpenJFX Community. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34162 The details about the fix are in bug comments. Thank you. With best regards. Petr.

Review Request: RT-34576 stage.getX()/getY() returns wrong result in applet mode

2013-12-03 Thread Petr Pchelko
Hello, OpenJFX. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34576 The details are available in the bug comments. With best regards. Petr.

Review Request: RT-34770 [TextArea MacOS] selected text is removed on focus leaving then returning

2013-12-09 Thread Petr Pchelko
Hello, OpenJFX. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34770 The details are in the bug comments. With best regards. Petr.

Re: CFV: New OpenJFX Committer: Vadim Pakhnushev

2013-12-11 Thread Petr Pchelko
Vote: YES. With best regards. Petr. On 12.12.2013, at 1:17, David Hill david.h...@oracle.com wrote: I hereby nominate Vadim Pakhnushev to OpenJFX Committer. Vadim is a member of JavaFX Embedded team at Oracle. Vadim's changes are in Glass Windows/D3d: hg log -M -u vadim An

Re: NSView-based embedding on Mac OS X

2013-12-19 Thread Petr Pchelko
Hello, Eli. The NSView-based embedding was implemented and is already available in JDK8 EA builds and JDK7u40. Here's the bug which was used to track the changes: https://bugs.openjdk.java.net/browse/JDK-7154778 However, this implementation was designed specifically to support the SWT_AWT

Re: SceneBuilder Integration in NetBeans

2014-03-17 Thread Petr Pchelko
Hello, Sven. Looks like you are not specifying the representation class for the DataFlavor and it defaults to the InputStream. So, scene builder puts a ByteBuffer while the DataTransferer is trying to treat it as an InputStream. Could you please try to explicitly specify the representation

Re: SceneBuilder Integration in NetBeans

2014-03-17 Thread Petr Pchelko
own DataFlavors.. Any further help appreciated.. -Sven Am 17.03.2014 09:54 schrieb Petr Pchelko petr.pche...@oracle.com: Hello, Sven. Looks like you are not specifying the representation class for the DataFlavor and it defaults to the InputStream. So, scene builder puts

[8u20] Review Request: RT-36293 [TouchEvent, PopupControl] Using a ListView in PopupControl generates a lot of TouchEvent NPE

2014-04-04 Thread Petr Pchelko
Hello, Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-36293 Webrev: http://cr.openjdk.java.net/~pchelko/fx/36293/webrev/ With best regards. Petr.

Re: Building OpenJFX on Mac OS X 10.9.2 / XCode 5.1 / XCode 4.3.3

2014-04-04 Thread Petr Pchelko
Hello, Philipp. As a quick workaround you can run: sudo ln -s /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk FX does-not use any new API’s

Re: Review Request: RT-37788

2014-07-02 Thread Petr Pchelko
Hello, Danno. I’ve noticed that you are leaking userDefaults and expandedOptions objects. Adding autorelease to them would save you some memory. With best regards. Petr. On Jul 3, 2014, at 1:43 AM, Danno Ferrin danno.fer...@oracle.com wrote: Yes, this has to be fixed in native code. 8u40

Re: AWT Dev [9/8u40] Review request for RT-37149 and JDK-8049065 : Implement DnD for SwingNode

2014-08-11 Thread Petr Pchelko
Hello, Anthony. The AWT part looks good to me. With best regards. Petr. On Aug 6, 2014, at 9:12 PM, Anthony Petrov anthony.pet...@oracle.com wrote: Anton: thank you for reviewing the fix. All: I need at least one more reviewer for the JDK part of the fix because we're going to