Re: JavaFX PDF Support

2013-05-22 Thread Phil Race
This seems to me like something that is a great 3rd party component but not so much as part of the core platform. Its a disproportionate amount of code, work, divergent needs and long term maintenance for the likely audience. As well as duplicating what support was already out there. We wanted to

Re: Backwards compatibility issue?

2013-05-31 Thread Phil Race
Hmm. I see this from the very first build of 7u21 (only available internally) whereas the latest build of 7u17 is fine. I did find one CSS fix from David that looks like it was in that build and relates to the way CSS is doing class lookups. So I think that is the most likely culprit. -phil.

Re: JavaFX graphics performance and suitability for advanced animations

2013-05-31 Thread Phil Race
On 5/31/13 4:52 PM, Richard Bair wrote: The text in PowerPoint is very likely outlines (treat the text as shapes) since there isn't much text per slide and its usually very large (in fact most render engines stop rendering text as glyphs at a given size -- for us it is 80pt.). H. I

Re: API review RT-30861: Add simple Font factory method for a default font of a different size

2013-06-03 Thread Phil Race
On 6/3/2013 11:40 AM, Richard Bair wrote: I agree these would be useful. The reason I filed this particular issue is that whenever I'm writing some code it seems like I'm always reaching for Font.font(size) and when I don't find it there I have to figure out what to pass as the family (it

Re: [API Review]: Node validation

2013-07-03 Thread Phil Race
I think SceneBuilder would like this, and I know printing would love it :-) -phil. On 7/3/13 7:03 AM, Kevin Rushforth wrote: +1 This would allow apps to dispense with the following workaround when taking a snapshot: // create a dummy scene so layout and CSS will work new Scene(new

Re: CFV: New OpenJFX Committer: Chien Yang

2013-08-15 Thread Phil Race
Vote: yes -phil. On 8/15/2013 8:50 AM, Artem Ananiev wrote: I hereby nominate Chien Yang to OpenJFX Committer.

Re: Poor quality font rendering

2013-08-22 Thread Phil Race
On 8/22/13 12:29 AM, John Hendrikx wrote: System.setProperty(prism.lcdtext, false); So you deliberately asked for it to be different than usual Windows apps ? I'm not sure why you do this, but if its in effect we can't expect to make any comparisons since IE10 etc will use LCD text I

Re: Poor quality font rendering

2013-08-22 Thread Phil Race
On 8/22/2013 12:54 PM, John Hendrikx wrote: 3+4 fail when I drag the Window to my projector. Colored fringes are visible. This is probably a driver problem as Windows may not realize that my Projector is not using LCD (DLP projector). I'm not sure how JavaFX figures this out, but I assume

Re: Poor quality font rendering

2013-08-22 Thread Phil Race
On 8/22/2013 12:59 PM, John Hendrikx wrote: If you want to turn off cleartype in Windows 7, then just turning it off is not sufficient. You need to replace the default font with Tahoma as well as the Windows 7 default font (Segoe UI) sucks without LCD smoothing. I can recommend the

Re: Poor quality font rendering

2013-08-28 Thread Phil Race
If you let Label choose the colours, they are different, but your eye has to be pretty good. The foreground colour of the label text is not exactly black even though you think it is. You'll need to force it. Also the background fill chosen by the layout managers seems to be not quite white

Re: CFV: New OpenJFX Committer: Oleg Barbashov

2013-10-24 Thread Phil Race
Vote: yes -phil.

RFR RT-33135: Printing: page setup dialog: updated page margins are not saved

2013-11-15 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-33135 http://cr.openjdk.java.net/~prr/javafx/rt-33135/ -phil

Re: Does the rendering system in JavaFX process font hints?

2013-12-02 Thread Phil Race
Hi, There are no such configuration options available in either JDK 7 or 8. The rasteriser used in FX 2.x is the same as the one used in JDK, and it can process hints just fine. However it is not configured that way in FX Java FX was from Day 1 (meaning FX 1.0) intended to provide a graphics

RFR: rt-29185 Canvas won't Print.

2013-12-02 Thread Phil Race
http://cr.openjdk.java.net/~prr/fxprinting/rt-29185/ https://javafx-jira.kenai.com/browse/RT-29185 An exception was occurring because the Texture resource backing the Canvas was not compatible with the 2D pipeline. The fix adds code to Canvas to detect this case and copy the canvas data to a

RFR RT-33113: HtmlEditor not printing

2013-12-02 Thread Phil Race
http://cr.openjdk.java.net/~prr/fxprinting/RT-33113/ https://javafx-jira.kenai.com/browse/RT-33113 The problem is that printing doesn't have a screen so we get a NPE. We likely should make printing report a dummy screen so that callers don't need to be aware of this, but at this stage in the

RFR: RT-34523: [Printing] When turning on button style, the printed page is blank

2013-12-02 Thread Phil Race
Please review :- http://cr.openjdk.java.net/~prr/fxprinting/rt-34523/ https://javafx-jira.kenai.com/browse/RT-34523

Re: Failure to find any font (probably on Embedded)

2014-02-13 Thread Phil Race
I agree that embeded is the only place it should happen. On a Linux desktop system if fontconfig isn't there then likely your entire desktop is DOA. And embedded is likely to be an integrated h/w s/w stack so I would expect that this would not be a common end-user problem ... -phil. On

Re: Poor font rendering..

2014-03-06 Thread Phil Race
PS .. my second guess would be different rasterisers -phil. On 3/6/2014 10:51 AM, Phil Race wrote: There really isn't any evidence of that. If it were true you'd see the blending into the pixels either side, but the pixels either side of the stem are 100% white in both cases. And examining

Re: Poor font rendering..

2014-03-06 Thread Phil Race
shift.. Scott On Thu, Mar 6, 2014 at 1:51 PM, Phil Race philip.r...@oracle.com mailto:philip.r...@oracle.com wrote: There really isn't any evidence of that. If it were true you'd see the blending into the pixels either side, but the pixels either side of the stem are 100

RFR: RT-36178: Printing: Scene is not printed when blending is used.

2014-03-12 Thread Phil Race
Bug: https://javafx-jira.kenai.com/browse/RT-36178 Fix: http://cr.openjdk.java.net/~prr/rt-36178/

Re: Is Quicktime API calls inside JavaFX?

2014-03-25 Thread Phil Race
I see .. so AVFoundation was already there since 10.7, its AVKit that's new in 10.9 but AV Foundation is what FX would use. It looks like Apple starting encouraging migration to AV Foundation about 18 months ago based on the date of this document :-

Re: Fractional Metrics

2014-04-03 Thread Phil Race
On 4/3/14 6:13 PM, Jeff Martin wrote: Is there a way to turn off FractionalMetrics in Canvas.fillText() or Text? No. At least not via any supported API. Also, does text rendering perform kerning, and if so, can I disable that? No. What I really need is to know the x position (or advance)

Re: Fractional Metrics

2014-04-04 Thread Phil Race
to do this is to get the bounds of a Text node containing the string. -phil. Neil From: Phil Race philip.r...@oracle.com To: Jeff Martin j...@reportmill.com, openjfx-dev@openjdk.java.net Mailing openjfx-dev@openjdk.java.net Date: 04/03/2014 10:40 PM Subject: Re: Fractional Metrics Sent

[8u20] Review request

2014-05-07 Thread Phil Race
Please review the fix for this OS X printing bug https://javafx-jira.kenai.com/browse/RT-35414 -phil.

[8u20] RFR: RT-35070 : [Printing] Page dialog can not be opened after print dialog on Linux

2014-05-08 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-35070 http://cr.openjdk.java.net/~prr/rt-35070/ http://cr.openjdk.java.net/%7Eprr/rt-35070/

Please review fix for RT-37215 [Printing] Illegal argument exception for HARDWARE_MINIMUM margin

2014-05-21 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-37215 http://cr.openjdk.java.net/~prr/rt-37215/

RFR: Fix RT-37209: NPE showing print dialog

2014-06-05 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-37209 http://cr.openjdk.java.net/~prr/rt-37209/

Re: New alias for hg commit notifications?

2014-06-24 Thread Phil Race
Sounds good. This would be consistent with the various jdk forests .. -phil. On 6/24/14 6:34 AM, Kevin Rushforth wrote: It has been suggested that we create a new alias for Mercurial (hg) commit notifications -- perhaps openjfx-chan...@openjdk.java.net -- rather than sending all of them to

RFR: Fix for RT-37480: Incorrect paper sizes and margins

2014-07-17 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-37480

Re: Rotate a label

2014-09-10 Thread Phil Race
? S I H T E K I L N A E M U O Y That is rotating the individual glyphs or vertical layout. I can't think of any remotely easy way to do this right now. But transforming so the string reads normally if you rotate the screen should be possible with transforms on the node. -phil. On

Re: CFV: New OpenJFX Committer: Morris Meyer

2014-09-25 Thread Phil Race
Vote: yes -phil.

Re: Why would most FontAwesome icons work but not one?

2014-10-10 Thread Phil Race
A box implies that the code point could not be mapped. FX code in this respect is completely cross-platform until you get down to requesting the glyph from DirectWrite or CoreText so the most likely things are that either they can't map it or its what Mario said. Suppose you also have a copy

Re: British english on JavaFX controls

2014-10-16 Thread Phil Race
On 10/16/2014 7:38 AM, Stephen F Northover wrote: Please enter a JIRA for the missing translation. If AWT/Swing is missing a translation, is there a way to add it short of modifying the system? I don't think Swing (or any other part of the JDK classes for that matter) would reach out to an

Re: Font derivation, plus ConcurrentModificationException on font load

2014-12-07 Thread Phil Race
PS .. the ConcurrentModificationException is one we fixed for 8u40. You should test that out with a current EA build. -phil. On 12/7/14 8:56 PM, Phil Race wrote: There's probably an RFE or bug that mentions the omission of deriveFont Its the most direct way to say many things

Re: Font derivation

2014-12-08 Thread Phil Race
https://javafx-jira.kenai.com/browse/RT-6808 mentions that we could add a deriveFont. This is in the context of a loadFont context but it is somewhat buried in the larger subject of that bug. So if anyone (external) would like to file an RFE directly requesting it along with justification, that

Re: Font derivation

2014-12-09 Thread Phil Race
I missed that one. It was assigned a little oddly to someone not really working on fonts so I've grabbed it and will address under that ID. -phil. On 12/9/2014 3:31 PM, Jeff Hain wrote: https://javafx-jira.kenai.com/browse/RT-6808 Created a JIRA account to be able to see this, but I still

Re: custom controls: printing

2015-01-27 Thread Phil Race
On 1/27/15 4:08 PM, Tom Eugelink wrote: Do I need to do something special to support printing of custom controls? The use case is that on screen a spreadsheet can be shown in a scrollpane, but when printing the whole spreadsheet should be printed. Being a 'custom' control doesn't really make

Re: custom controls: printing

2015-01-28 Thread Phil Race
job) Correct? Tom On 28-1-2015 02:43, Phil Race wrote: On 1/27/15 4:08 PM, Tom Eugelink wrote: Do I need to do something special to support printing of custom controls? The use case is that on screen a spreadsheet can be shown in a scrollpane, but when printing the whole spreadsheet should

Re: custom controls: printing

2015-01-28 Thread Phil Race
the example you referenced but once you have 500 items in your agenda, someone is going to have to handle the magic that splits that across pages and there's no way the core printing API could know how to do that for a control. All it sees are Nodes .. -phil. Tom On 29-1-2015 05:53, Phil Race

Re: JavaFX always choose monospace font - possible bug?

2015-04-24 Thread Phil Race
FX should just be asking fontconfig what your set up is. What do you get if you run the fontconfig command line app ? $ fc-match sans:regular:roman Vera.ttf: Bitstream Vera Sans Roman -phil. On 4/24/15 1:30 AM, Adam Granger wrote: I'm using a redhat 6 system with jdk 1.8u40 where the only

Re: Font size, dpi and text crispness (snapping to pixels)

2015-04-16 Thread Phil Race
https://docs.oracle.com/javase/8/javafx/api/javafx/scene/text/Font.html#getDefault-- Gets the default font which will be from the family System, and typically the style Regular, and be of a size consistent with the user's desktop environment, to the extent that can be determined. -phil.

Re: Private APIs not usable in Java 9?

2015-04-08 Thread Phil Race
it's not strictly JFX-only. Its not remotely FX only, in fact I could argue FX is not so affected, as being relatively new it does not have 20 years of accumulation of people using internal APIs that the larger JDK does, often dating from when there were no suitable public APIs. There still

Re: Understanding the com.sun.* APIs being (ab)used by the community

2015-06-03 Thread Phil Race
I can't speak for Jonathan on that point but if you find you are using something not on the list at the URL below, you may want to ask on the appropriate list what would be a suitable replacement https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool Note that sometimes it can

Re: Font rendering hints - RT-36146 - progress?

2015-06-15 Thread Phil Race
they are setting would arrive at a best match configuration that could replace the all defaults configuration we have now? Then, later down the track, these hints/options could potentially be made user-configurable. On 16 June 2015 at 06:05, Phil Race philip.r...@oracle.com mailto:philip.r

Re: Font rendering hints - RT-36146 - progress?

2015-06-15 Thread Phil Race
I would have to look at it starting more or less from scratch and I do not know that it would be as simple as providing a way to tweak DirectWrite rendering. The differences seem to be quite small differences in sub-pixel intensity and sub-pixel accumulation of the total advance. I do not know

Re: JavaFX printing on OS X is horribly broken

2015-06-10 Thread Phil Race
dev is not what is used to create the promoted builds. That would be master. Even then, the 8u60 backport is marked as fixed in build team so you are very premature in testing this unless you want to pull the 8u60 sources and build your own and test with that. Once Resolved In Build:team

Re: Supported Font of JavaFX

2015-07-01 Thread Phil Race
Exactly what version of Windows are you using ? Is there an actual italic variant of Algerian installed on your computer that you can see in the filesystem ? There used to be an issue that we had not implemented synthetic styling but I thought that went away when we started using DirectWrite.

Re: Supported Font of JavaFX

2015-07-01 Thread Phil Race
. Thanks 2015-07-01 17:23 GMT+02:00 Phil Race philip.r...@oracle.com mailto:philip.r...@oracle.com: Exactly what version of Windows are you using ? Is there an actual italic variant of Algerian installed on your computer that you can see in the filesystem ? There used to be an issue

Re: OpenJFX / JDK 9 questions

2015-08-19 Thread Phil Race
On 08/18/2015 03:23 PM, Kevin Rushforth wrote: Currently the gradle openZip method makes it easy to create builds that unpack into OpenJDK / Zulu JDK but this assumes a pre-Jigsaw (JRE) structure and doesn't work with JDK9. Shall I submit a bug? We are in the process of making major

Re: 8u60-b26 ?

2015-08-05 Thread Phil Race
I am going to guess its because when you get real close to release and start building candidates for release the build string no longer has EA in it, and someone might mistakenly think it is an actual confirmed FCS build you can use in production. That is not the case until it has passed final

Re: Error: JFX not installed? Running openJDK7

2015-07-19 Thread Phil Race
I do not think all the open source pieces necessary for an open source version of FX are available for OpenJDK 7. If you want to use FX on JDK 7 I think you are going to have to use Oracle JDK .. but the public updates for that just ceased. So you really need to target [Open]JDK 8. And in any

Re: Questions about Stream/Iterable/Files - and possibly the compiler

2015-11-05 Thread Phil Race
For streams I recommend core-libs-...@openjdk.java.net. That is probably the best place for your question. For compiler and language questions you might try compiler-...@openjdk.java.net -phil. On 11/05/2015 05:53 AM, Fabrizio Giudici wrote: On Thu, 05 Nov 2015 14:28:50 +0100, Kevin

Re: Mac App Store Refusal because of QTKit API's

2015-09-30 Thread Phil Race
; wrote: Please let us know what you hear back with Apple on this given the information below we hope they will see this as an oversight. - Don On 30/09/2015 12:28 PM, Phil Race wrote: Yes, these look like ICU functions which so far as I know FX only references from its *own* internal copy

Re: Mac App Store Refusal because of QTKit API's

2015-09-30 Thread Phil Race
from my iPhone On Sep 30, 2015, at 2:54 PM, Phil Race <philip.r...@oracle.com> wrote: It looks like there may be something to this :- On mac fx in 8u60 is linking webkit against the system icu library to find these symbols. $ nm -a libjfxwebkit.dylib | grep ubrk_getRule

Re: Mac App Store Refusal because of QTKit API's

2015-09-30 Thread Phil Race
Yes, these look like ICU functions which so far as I know FX only references from its *own* internal copy of webkit which in turn has a copy of ICU. What is very odd is that Apple is essentially then objecting to referencing functions that are internal to your app. ie referenced by your app

Re: In(Sanity) Testing Mondays

2015-09-25 Thread Phil Race
I believe Kevin said integration will be skipped this week so none of this is necessary. -phil. On 09/25/2015 07:30 AM, Vadim Pakhnushev wrote: Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing

Re: CFV: New OpenJFX Committer: Alexander Matveev

2015-08-28 Thread Phil Race
Vote: yes

Re: Future of JavaFX

2015-12-03 Thread Phil Race
As Kevin already said, you won't get anywhere by discussing that on *this* list. It is out of the control of JavaFX. It is an OpenJDK-wide policy regarding the bug tracker. You would need to take it to openjdk-discuss since it is common across all OpenJDK projects. And there is some work in

Re: including fonts

2016-01-04 Thread Phil Race
Hi, I can't speak authoritatively on the CSS implementation because I am not familiar with it but here are some thoughts and observations that might help. Suppose you have : @font-face { font-family: RobotoMedium src: url("robotomedium.ttf" } My reading of the W3C spec. is that the name

Re: including fonts

2016-01-04 Thread Phil Race
Font.loadFont to load a font from a @font-face src url. See com/sun/javafx/css/StyleManager.java On 1/4/16 2:43 PM, Phil Race wrote: Hi, I can't speak authoritatively on the CSS implementation because I am not familiar with it but here are some thoughts and observations that might help

Re: JEP 283: Enable GTK 3 on Linux

2016-02-19 Thread Phil Race
We had not forgotten that the other JEP was there (as a draft) but the new JEP started with a pure FX focus on allowing FX to use either GTK2 or GTK3 depending on what you needed. It was extended (feature creep) whilst being drafted to include doing the same for AWT/Swing but the focus was

Re: JavaFX Application Heat up MacBook Pro

2016-03-25 Thread Phil Race
See https://developer.apple.com/library/mac/qa/qa1734/_index.html It is mentioned in (one of) the bugs you can get to if you follow the JBS bug trail -phil. On 3/25/2016 2:48 PM, Tai Hu wrote: Thanks for the info. What entry should I put into info.plist? Thanks On Friday, March 25, 2016,

Re: CFV: New OpenJFX Committer: Murali Billa

2016-03-31 Thread Phil Race
Vote: yes -phil. On 03/31/2016 02:04 PM, Kevin Rushforth wrote: I hereby nominate Murali Billa [1] to OpenJFX Committer.

Re: CFV: New OpenJFX Committer: Arunprasad Rajkumar

2016-04-25 Thread Phil Race
Vote: yes -phil.

RFR: 8087298: FontMetrics.computeStringWidth method is not correct for persian/arabic

2016-04-27 Thread Phil Race
Jonathan, Please review the fix we discussed :- bug: https://bugs.openjdk.java.net/browse/JDK-8087298 webrev : http://cr.openjdk.java.net/~prr/8087298/ -phil.

Re: CFV: New OpenJFX Committer: Guru Hb

2016-04-28 Thread Phil Race
Vote: yes -phil.

8139838: Bug in PrismFontFactory generates NullPointerException when loading .ttc font

2016-05-19 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8139838 webrev : http://cr.openjdk.java.net/~prr/8139838/ Adds loadFonts() equivalents of the existing loadFont(). The existing loadFont() will now not NPE and will just return the first font in the collection. I have tested this on Mac, Linux and

Re: RFR: 8152423: Generated temp files (+JXF...temp) for custom fonts not deleted on exit.

2016-05-13 Thread Phil Race
shouldn't happen in practice, but still seems odd... ...jim On 05/05/2016 11:40 AM, Phil Race wrote: On 05/05/2016 11:26 AM, Jim Graham wrote: Is this true of any other objects managed by DWDisposer? DWDisposer is only the class used to implement "dispose()" of a single

Re: RFR: 8152423: Generated temp files (+JXF...temp) for custom fonts not deleted on exit.

2016-05-05 Thread Phil Race
re even if something different were done for 9. -phil. ...jim On 05/05/2016 11:12 AM, Phil Race wrote: Please review :- Bug : https://bugs.openjdk.java.net/browse/JDK-8152423 Fix : http://cr.openjdk.java.net/~prr/8152423/ <http://cr.openjdk.java.net/%7Eprr/8152423/

RFR: 8154177: Font spacing is incorrect at 125% or 150% scaling on Windows

2016-04-15 Thread Phil Race
The problem is in GlyphCache.render(..) pt.setLocation(x + gl.getPosX(gi), y + gl.getPosY(gi)); int subPixel = strike.getQuantizedPosition(pt); GlyphData data = getCachedGlyph(gc, subPixel); xform.transform(pt, pt); addDataToQuad(data,

Re: [9] Review request for 8150076: Print jobs are not finished when used a page range

2016-04-13 Thread Phil Race
I have an old PageRange printing test where I set settings.setPageRanges(new PageRange(1,3)); and it prints fine on JDK 9 on Win 7 x64. In fact it also prints fine with 8u74 Also a thread dump doesn't show any problem with the print thread not terminating. So I

RFR: 8130762: PrintJob doesn't update copies number

2016-08-03 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8130762. Eval + diff in-line in the bug report. -phil.

Re: CFV: New OpenJFX Committer: Semyon Sadetsky

2017-01-25 Thread Phil Race
Vote: yes -phil.

Re: Running JavaFX headless without native dependencies

2016-10-05 Thread Phil Race
The JDK itself that runs JavaFX has lots of native code so I am not sure you are heading down a productive path. -phil. On 10/05/2016 10:39 AM, Tobi wrote: Hi, thanks for all your hints, but my problem is not to start JavaFX in headless mode with Monocle. I need to start JavaFX without

RFR: 8088325 & 8169339 : Provide internal JDK API to JavaFX to locate JDK fonts

2016-11-07 Thread Phil Race
Hi, Two bug ids, two webrevs and a cross-post since JDK needs to provide a qualified export to JavaFX so it can access any fonts that may be provided with the JDK. FX bug: https://bugs.openjdk.java.net/browse/JDK-8088325 FX fix : http://cr.openjdk.java.net/~prr/8088325/

Re: [9] RFR: 8169271: Bump JavaFX minimum build JDK to b144

2016-11-14 Thread Phil Race
Is this going to be a weekly event ? -phil. On 11/14/2016 09:51 AM, Kevin Rushforth wrote: +1 Note that this will need to wait until after the repo is "unlocked" at 1pm PT. -- Kevin David DeHaven wrote: Kevin, David, please review this trivial change to bump the minimum JDK version to

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread Phil Race
David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sorting by path name. In particular files like build.gradle and so on .. people then get a sense of what it is

Re: Question/discussion about JDK-8129582

2017-01-04 Thread Phil Race
You can't skip layout just because it is bidi .. where here you are apparently implicitly meaning Hebrew. This might be apparently working but may not always work even for Hebrew and will be a disaster for Arabic. Here is a web page which talks about OTL (OpenType Layout) for Hebrew :

Re: What is the process ?

2016-12-20 Thread Phil Race
Sometimes the keepers of the OCA first send you a question about what has been sent in. I recall at least one instance when the applicant over-looked that email. You may want to check your email from around that time. Meanwhile I can forward this internally to see if that was the case, or

RFR: 8088395: Print dialogs are not blocking/modal w.r.t specified owner windows

2017-03-17 Thread Phil Race
This is the 8u backport of this FX+JDK fix Not much changed so not much re-review is needed. First the FX part. https://bugs.openjdk.java.net/browse/JDK-8088395 webrev : http://cr.openjdk.java.net/~prr/8088395.8u/ The patch applied cleanly but the fix needed some small updates. In JDK 9 we

Re: [OpenJDK 2D-Dev] RFR: 8088395: Print dialogs are not blocking/modal w.r.t specified owner windows

2017-03-14 Thread Phil Race
I have updated webrevs described below, and also I answer your questions FX is updated only to fix trailing white space and one modifier ordering http://cr.openjdk.java.net/~prr/8088395.1/ The JDK side has a few modifications : http://cr.openjdk.java.net/~prr/8176350.1/ (a) awt_PrintDialog.cpp

RFR: 8088395: Print dialogs are not blocking/modal w.r.t specified owner windows

2017-03-10 Thread Phil Race
This has an FX bug + webrev : https://bugs.openjdk.java.net/browse/JDK-8088395 http://cr.openjdk.java.net/~prr/8088395/index.html and also a JDK-side fix and webrev :- https://bugs.openjdk.java.net/browse/JDK-8176530

RFR: 8185358: gradle 4.X has changed location of built classes

2017-07-26 Thread Phil Race
In gradle 4 the default location of classes when using has changed from: Java, `src/main/java` -> build/classes/main .. to .. Java, `src/main/java` -> build/classes/java/main This breaks some parts of the FX build .. which eventually is going to need gradle 4.1 for JDK 10 and already does for

RFR: 8185011: build.gradle cannot always parse gradle minor version

2017-07-20 Thread Phil Race
Kevin (or anyone else), Please review this small change so FX can use gradle-4.1-rc1 https://bugs.openjdk.java.net/browse/JDK-8185011 -phil.

Re: CFV: New OpenJFX Committer: Ajit Ghaisas

2017-05-26 Thread Phil Race
Vote: yes -phil.

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-22 Thread Phil Race
xander. On 21/09/2017 22:25, Phil Race wrote: Some procedural comments : Since 90% of this is in AWT code, I'd have thought awt-dev should be included here. I've added that list. And apart from needing separate bug ids, I don't see why the bug below is confidential. I agree with what Kevin point

Re: [10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-21 Thread Phil Race
Some procedural comments : Since 90% of this is in AWT code, I'd have thought awt-dev should be included here. I've added that list. And apart from needing separate bug ids, I don't see why the bug below is confidential. I agree with what Kevin pointed out off-line that as in the dialog

Re: System font fails to load on Windows 7 - possible causes/fixes?

2017-11-27 Thread Phil Race
It seems to be mostly about this font that is NOT your system font .. but one you are loading from somewhere. Temp file created: C:\Users\user\AppData\Local\Temp\+JXF7252213042545373012.tmp^M Mapping IDWriteFont="Segoe UI Semilight" Postscript name="SegoeUI-Semilight" Win32 name="Segoe UI

Building OpenJFX.

2017-12-19 Thread Phil Race
In the "innovation" email thread it was suggested that one obstacle to getting involved and contributing to OpenJFX is just building it. So what are the top one or two pain points with building OpenJFX today ? - Insufficient or out-dated build docs ? - Tool-chain configuration problems -

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

2017-11-08 Thread Phil Race
look ? I have other patches coming soon... Cheers, Laurent Le 27 oct. 2017 8:02 PM, "Laurent Bourgès" <bourges.laur...@gmail.com <mailto:bourges.laur...@gmail.com>> a écrit : Hi Phil, Thanks for your comments. Le 27 oct.

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-11-08 Thread Phil Race
I think they should be separate webrevs sent to the separate lists and you should start with 2D as I can then run the JDK regression tests on it. I know you can theoretically run the open regression tests too (are you ?) but there are some random scattered closed regression tests that so far as

Re: Text classes

2017-12-05 Thread Phil Race
This is a gap it would be nice to fill. Since it is not a small effort to do right there'd be a design side as well as implementation so it can't be just 'slid in'. And I don't think just moving internal APIs to public is the way to approach it. There are no current plans to allocate Oracle

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-12-11 Thread Phil Race
to review it for FX. -- Kevin Phil Race wrote: I think they should be separate webrevs sent to the separate lists and you should start with 2D as I can then run the JDK regression tests on it. I know you can theoretically run the open regression tests too (are you ?) but there are some random

RFR: 8187147: Remove T2K from JavaFX in JDK 10

2017-10-20 Thread Phil Race
The Oracle version of JavaFX carries platform independent support for font rasterization + layout in closed source. It has not been used since JDK 7 so it is time to remove it. This change removes references to it in open code : http://cr.openjdk.java.net/~prr/8187147/ -phil.

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-04 Thread Phil Race
Two quick comments. 1) I'd like "Peer" removed from all the exported API. 2) It is probably stable enough now that you can start to add some javadoc. -phil. On 05/04/2018 05:00 AM, Prasanta Sadhukhan wrote: Hi All, Please review an enhancement to remove the tight coupling of JDK internal

RFR: 8195808: Eliminate dependency on sun.print in javafx.graphics

2018-05-25 Thread Phil Race
FX bug : https://bugs.openjdk.java.net/browse/JDK-8195808 FX webrev: http://cr.openjdk.java.net/~prr/8195808/ This updates FX to use proposed new standard Java SE API to specify an owner window for a Java 2D printer dialog, or to specify "always on top" behaviour where that is not possible.

RFR: 8129582: Controls slow considerably when displaying RTL-languages text on Linux

2018-05-24 Thread Phil Race
Please review this fix for a performance problem in Pango Text Layout. The root cause was pointed out by itai...@gmail.com, that the fontmap is an expensive thing to create, and we were recreating it on each call to layout. By caching it we can avoid this huge overhead. Bug :

Re: OpenJFX code review policies, etc.

2018-06-12 Thread Phil Race
One other point .. something I mentioned off line to Kevin but he did not so far bring up here, is that when counting the number of reviewers on a fix, we must require at least one Reviewer, with a capital "R", but to make up the total of 2 reviewers, it is sufficient to have one other person

Re: JDK-8187100 [PATCH][JavaFX] To make display Variation Selector(IVS/SVS/FVS)

2018-06-13 Thread Phil Race
Hi, As I said in response to your email on the 2D list, you need to sign the OCA before we can consider any of this. -phil. On 06/13/2018 12:40 AM, Nakajima Akira wrote: I happened to create similar patch without knowing the report below. https://bugs.openjdk.java.net/browse/JDK-8187100

Re: negative line spacing in Text

2018-06-13 Thread Phil Race
I looked at the source and it is a double property that is just added to the default line height So I don't see why it would just cause line wrap to fail such that text was all on the same line, which is how I am interpreting what you are saying. Perhaps if you are using too large a negative

  1   2   >