Re: [8u-dev] Review request: RT-38836: JDK crash on Mac 10.10 with very large stage

2015-03-27 Thread Sergey Bylokhov
Hi, Morris. Just curiously, does it mean that after the fix, there is no way to maximize the window on two monitors in multi-monitors configuration? Does this issue affects an applets? Seems that on Windows the clipping on the screen bounds is a default native behavior. 27.03.15 22:39,

Re: Java 8 updates are causing "Apps that use non-public APIs will be rejected"

2015-11-17 Thread Sergey Bylokhov
I think openjfx-dev@openjdk.java.net (cc) is correct place to ask this question. On 16.11.15 23:10, Ondřej Kvasnovský wrote: Hi, We are facing to an issue with latest Java updates when we try to release apps into Apple app store. I have described the issue here, with all my findings:

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Sergey Bylokhov
Note that in jdk9 the same data can be obtained via GraphicsConfiguration.getDefaultTransform(); On 17.02.16 2:53, Jim Graham wrote: I added a comment on the bug about BC, but it sounds like you already considered it. I'm fine with this as is, but would push for moving to JDK9 ASAP...

Re: [9] Review request for 8137050: Support Linux settings for HiDPI scaling

2016-05-12 Thread Sergey Bylokhov
Hi Jim. Do you plan to implement the new HiDPI API for the Robot class? On 13.05.16 0:43, Jim Graham wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8137050 webrev: http://cr.openjdk.java.net/~flar/JDK-8137050/webrev-00/ The order of taking scaling parameters in order of higher to lower

Re: Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-05-02 Thread Sergey Bylokhov
Just FYI. Sometimes the size is matter: https://youtrack.jetbrains.com/issue/IDEA-74599 On 03.05.16 0:47, Kevin Rushforth wrote: That sounds like a good idea. I like the idea of keeping the reduced scope (private where possible) for clarity if there isn't a noticeable performance penalty for

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-02 Thread Sergey Bylokhov
Probably the logging should be enabled only if we pass the upper case "True" to "-Dsun.javafx.marlin=True". I do not know is it correct to write to the system output unconditionally, can this affect application? And instead of "sun." can we use something different like "jdk." I guess the same

Re: [OpenJDK 2D-Dev] RFR: 8088395: Print dialogs are not blocking/modal w.r.t specified owner windows

2017-03-14 Thread Sergey Bylokhov
> There is no API for the "alwaysOnTop" AWT property for the print dialogs. > I actually don't think it can be implemented for the windows native print > controls. > There is an internal way to make an AWT window owner for the Swing print > dialog > but nothing public and it doesn't help here

Re: [OpenJDK 2D-Dev] RFR: 8088395: Print dialogs are not blocking/modal w.r.t specified owner windows

2017-03-14 Thread Sergey Bylokhov
Hi, Phil. I have only two questions: - Does it mean that we do not support "ontop" property via public API in idk? - Probably the name should contain «owner» instead of «parent»?, But since this is not a public API I guess it is not an issue. > > > This has an FX bug + webrev : >

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-09-18 Thread Sergey Bylokhov
ed.singleThread" On 9/13/17 03:11, Prasanta Sadhukhan wrote: Hi Sergey, I have modified the fix to not use SecondaryLoop and not to create one thread per dispatch http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.03/ Regards Prasanta On 8/30/2017 11:41 AM, Sergey Bylokhov wrote: H

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-09-22 Thread Sergey Bylokhov
s Prasanta On 9/13/17 03:11, Prasanta Sadhukhan wrote: Hi Sergey, I have modified the fix to not use SecondaryLoop and not to create one thread per dispatch http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.03/ Regards Prasanta On 8/30/2017 11:41 AM, Sergey Bylokhov wrote: Hi, Pras

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-22 Thread Sergey Bylokhov
Hi, Alexander. How can we be sure that the parent frame will not be disposed while we use a pointer? long ownerWindowPtr = peer.getOverridenWindowHandle(); < Dispose the peer if (ownerWindowPtr != 0) { //Place window above JavaFX stage CWrapper.NSWindow.addChildWindow(

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-08-30 Thread Sergey Bylokhov
dispatch look inefficient. > > Modified webrev > http://cr.openjdk.java.net/~psadhukhan/fx/8088132/webrev.02/ > > Regards > Prasanta > On 8/23/2017 9:31 PM, Sergey Bylokhov wrote: > > Hi, Prasanta. > > > > On 16.08.2017 3:33, Prasanta Sadhukhan

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-09-25 Thread Sergey Bylokhov
From the AWT point of view the fix looks fine. On 9/23/17 00:03, Prasanta Sadhukhan wrote: Hi Sergey, Please find modified webrev catering to DefaultKeyboardFocusManager also http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.05/ Regards Prasanta On 9/23/2017 7:52 AM, Sergey Bylokhov wrote

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-08-23 Thread Sergey Bylokhov
but dispatch() for each were called in other order then the sequenced will not be preserved? I have tested with couple of singleThread testcase without any issue. Regards Prasanta On 8/14/2017 10:07 PM, Sergey Bylokhov wrote: Hi, Prasanta, Kevin. I have two notes. - Does this option

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-10-12 Thread Sergey Bylokhov
://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/ Now we are postponing actual window closing, it happens only after we ensure that native window pointer is valid on Swing side. Thanks, Alexander. On 23/09/2017 08:01, Sergey Bylokhov wrote: Hi, Alexander. How can we be sure that the parent frame

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-11-07 Thread Sergey Bylokhov
et/browse/JDK-8088395> Test added: http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/05/ Thanks, Alexander. On 13/10/2017 01:14, Sergey Bylokhov wrote: Looks fine. I am not sure but it looks like the fix has an assumption that the CPlatformWindow.setVisible() code will be executed o

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-03 Thread Sergey Bylokhov
Just curious what attribute caused the first request to fail. Is it related to kCGLPFAAccelerated or XXXSize? 87 kCGLPFAAccelerated, 88 kCGLPFAColorSize, 32, 89 kCGLPFAAlphaSize, 8, 90 kCGLPFADepthSize, depth, 91

Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-29 Thread Sergey Bylokhov
On Tue, 29 Oct 2019 23:05:46 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > >> This PR updates the header files we use the build the OpenGL ES2 pipeline to >> Mesa 19.2.1. See [this review >>

Re: JavaFX System Tray Support

2020-04-22 Thread Sergey Bylokhov
On 4/22/20 6:39 am, Sebastian Stenzel wrote: Judging from the comments in the aforementioned issues it doesn't seem like we can expect anything to change on AWT side. This is why it has often been requested to create an alternative using JavaFX. [2] That said, it has always been postponed.