Re: JNI and C++ exceptions

2013-09-27 Thread Vadim Pakhnushev
BTW, operator new doesn't return NULL if allocation is unsuccessful, it throws bad_alloc instead, so if (!obj) after new is non-standard and will not work on any recent compiler. Thanks, Vadim On 27.09.2013 13:10, Artem Ananiev wrote: Hi, here is a short question. In some JDK

Review request: RT-34231: FX3D doesn't work with DirectX debug runtime

2013-11-12 Thread Vadim Pakhnushev
Hi, Could you please review a fix for this: https://javafx-jira.kenai.com/browse/RT-34231 http://cr.openjdk.java.net/~vadim/RT-34231/webrev.00/ Thanks, Vadim

RT-34233: D3D_DEBUG_INFO is not defined correctly

2013-11-12 Thread Vadim Pakhnushev
Hi Chien, Kevin, Could you please review this? https://javafx-jira.kenai.com/browse/RT-34233 http://cr.openjdk.java.net/~vadim/RT-34233/webrev.00/ Thanks, Vadim

RFR: RT-32226: 3D: Window can't restore after screen lock

2013-11-14 Thread Vadim Pakhnushev
Hi, Could you please review? https://javafx-jira.kenai.com/browse/RT-32226 http://cr.openjdk.java.net/~vadim/RT-32226/webrev.00/ Thanks, Vadim

RFR: RT-34094 Crash on MacOS 10.9 in Java_com_sun_t2k_T2KFontFile_getGlyphBoundingBoxNative

2013-11-19 Thread Vadim Pakhnushev
Hi Felipe, Steve, Could you please review a fix for: https://javafx-jira.kenai.com/browse/RT-34094 http://cr.openjdk.java.net/~vadim/RT-34094/webrev.00/ Thanks, Vadim

Post commit review: RT-34514: [D3D] fix for RT-33390 is incorrect

2013-11-26 Thread Vadim Pakhnushev
This is post commit notification. The fix for RT-33390 was incorrectly resetting clip on failures as well. In this follow-up fix we reset clip only of the call was succeeded and render target was changed, which indicated by the D3D_OK return value. If the call was succeeded, but render target

RFR: RT-33792: Implement specular lighting as specified for the PhongMaterial

2013-11-27 Thread Vadim Pakhnushev
Chien, Kevin, Please review the fix here: https://javafx-jira.kenai.com/browse/RT-33792 http://cr.openjdk.java.net/~vadim/RT-33792/webrev.00/ Thanks, Vadim

RFR: RT-32880: D3D: Near clip appears to clip further (away from viewer) than the specified near value

2013-12-02 Thread Vadim Pakhnushev
Hi Chien, Kevin, Please review a fix for this bug: https://javafx-jira.kenai.com/browse/RT-32880 http://cr.openjdk.java.net/~vadim/RT-32880/webrev.00/ Thanks, Vadim

[8u20] post-commit notification: RT-34820: Self Illumination map issues of PhongMaterial

2013-12-13 Thread Vadim Pakhnushev
Hello, https://javafx-jira.kenai.com/browse/RT-34820 http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8a5c6817206d Thanks, Vadim

Re: Javafxpackager build error on Win7 64

2013-12-14 Thread Vadim Pakhnushev
Francisco, It seems that somehow /machine:X86 got added to the command line. Please make sure that your environment is consistent, that is you have JAVA_HOME and PATH set to x64 JDK. Then try to gradle clean sdk. Hope this helps, Vadim On 14.12.2013 4:12, Francisco Javier Godino wrote:

Re: Javafxpackager build error on Win7 64

2013-12-16 Thread Vadim Pakhnushev
wrote: Francisco, it can also be caused by using Windows SDK 7.0A, which is bundled with Visual Studio 2010 Express. It can't be used to build 64-bit FX, you need either VS 2010 Pro, or Windows SDK 7.1 (downloaded as a separate bundle from MS site). Thanks, Artem On 12/14/2013 2:07 PM, Vadim

[8] RFR: RT-32501: JavaFx Application crashes on Exit

2013-12-20 Thread Vadim Pakhnushev
Hi! Felipe, Anthony, Kevin, Steve, Could you please review the fix: https://javafx-jira.kenai.com/browse/RT-32501 http://cr.openjdk.java.net/~vadim/RT-32501/webrev.00/ Thanks, Vadim

[8u20] Review request for RT-16923: The various addListener methods should throw NPE if a null listener is passed in, rather than throwing NPE when the listener list is iterated

2014-03-04 Thread Vadim Pakhnushev
Hi Felipe, Anthony, Please review this fix: https://javafx-jira.kenai.com/browse/RT-16923 http://cr.openjdk.java.net/~vadim/RT-16923/webrev.00/ Thanks, Vadim

[8u20] Review request for RT-35681: Rendering difference between platforms when specular map is used

2014-03-14 Thread Vadim Pakhnushev
Hi Chien, Please review this simple fix: https://javafx-jira.kenai.com/browse/RT-35681 http://cr.openjdk.java.net/~vadim/RT-35681/webrev.00/ Thanks, Vadim

[8u20] Review request for RT-36235: Zero specular power can lead to rendering artifacts.

2014-03-17 Thread Vadim Pakhnushev
Hi Chien, Kevin, Please review this fix: https://javafx-jira.kenai.com/browse/RT-36235 Thanks, Vadim

[8u20] Review request for RT-35025: Scene turns black sometimes.

2014-03-28 Thread Vadim Pakhnushev
Chien, Kevin, Please review a fix for this: http://cr.openjdk.java.net/~vadim/RT-35025/webrev.00/ http://cr.openjdk.java.net/%7Evadim/RT-35025/webrev.00/ https://javafx-jira.kenai.com/browse/RT-35025

[8u20] Review request for RT-33475: NPE in PPSRenderer (when display disconnected?)

2014-04-01 Thread Vadim Pakhnushev
Jim, Kevin, Please review a fix for this: https://javafx-jira.kenai.com/browse/RT-33475 Thanks, Vadim

Re: CFV: New OpenJFX Committer: Jerome Cambon

2014-05-14 Thread Vadim Pakhnushev
Vote: yes On 14.05.2014 21:39, Stephen F Northover wrote: I hereby nominate Jerome Cambon to be an OpenJFX Committer. Jerome Cambon is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Inspector Panel as well as the CSS Panel. Jerome has

Re: CFV: New OpenJFX Committer: Sandra Lions-Piron

2014-05-14 Thread Vadim Pakhnushev
Vote: yes On 14.05.2014 21:48, Stephen F Northover wrote: I hereby nominate Sandra Lions-Piron to be an OpenJFX Committer. Sandra Lions-Piron is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Hierarchy Panel as well as all menu commands.

Re: CFV: New OpenJFX Committer: Eric Le Ponner

2014-05-14 Thread Vadim Pakhnushev
Vote: yes On 14.05.2014 21:33, Stephen F Northover wrote: I hereby nominate Eric Le Ponner to be an OpenJFX Committer. Eric Le Ponner is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the architect of the SB Kit API as well as the designated owner of the Content

Re: CFV: New OpenJFX Committer: Mo Chicharro

2014-05-14 Thread Vadim Pakhnushev
Vote: yes On 14.05.2014 21:48, Stephen F Northover wrote: I hereby nominate Mo Chicharro to be an OpenJFX Committer. Mo Chicharro is a significant contributor of the JavaFX Scene Builder 2.0 product, and, as the visual and interaction designer, he is the designated owner of all FXML and CSS

[8u20] Review request for RT-32213: Decoding BMP file throws an exception

2014-05-30 Thread Vadim Pakhnushev
Jim, Felipe, Kevin, Please review a fix for this: https://javafx-jira.kenai.com/browse/RT-32213 http://cr.openjdk.java.net/~vadim/RT-32213/webrev.00/ Thanks, Vadim

[8u20] Review request for RT-20295: Error loading JPG image when scaling

2014-06-03 Thread Vadim Pakhnushev
Jim, Please review a fix for this: https://javafx-jira.kenai.com/browse/RT-20295 http://cr.openjdk.java.net/~vadim/RT-20295/webrev.00/ Thanks, Vadim

[8u20] Review request forRT-15619: BMPImageLoader fails to correctly load an image if the input stream read(byte[] b, int off, int len) method happens to return fewer than 'len' bytes

2014-06-16 Thread Vadim Pakhnushev
Jim, Please review this very simple addition to the existing test: https://javafx-jira.kenai.com/browse/RT-15619 http://cr.openjdk.java.net/~vadim/RT-15619/webrev.00/ Thanks, Vadim

[8u40] Review request for RT-37613: ImageStorageTest fails in NetBeans

2014-08-05 Thread Vadim Pakhnushev
Jim, Please review the fix: https://javafx-jira.kenai.com/browse/RT-37613 http://cr.openjdk.java.net/~vadim/RT-37613/webrev.00/ Thanks, Vadim

hg: openjfx/8u-dev/rt: RT-37613: ImageStorageTest fails in NetBeans

2014-08-06 Thread vadim . pakhnushev
Changeset: 1955ca43317a Author:vadim Date: 2014-08-06 12:56 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1955ca43317a RT-37613: ImageStorageTest fails in NetBeans Reviewed-by: flar ! modules/graphics/src/test/java/com/sun/javafx/iio/ImageStorageTest.java

Re: Poor scrolling animation when swiping a Macbook touchpad

2014-08-08 Thread Vadim Pakhnushev
Hi Robert, I've reported this issue a while back: https://javafx-jira.kenai.com/browse/RT-34963 Thanks, Vadim On 08.08.2014 8:38, Robert Lebel wrote: On a brand new Macbook pro 2014 (my first), scrolling is not smooth when I swipe 2 fingers up or down on the touchpad. If I use the mouse

hg: openjfx/8u-dev/rt: RT-37577: [Mac, Retina] Image loading for @2x images may try to append @2x suffix to wrong part of URL

2014-08-08 Thread vadim . pakhnushev
Changeset: 063c15dcc93f Author:vadim Date: 2014-08-09 05:36 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/063c15dcc93f RT-37577: [Mac, Retina] Image loading for @2x images may try to append @2x suffix to wrong part of URL Reviewed-by: flar, snorthov !

[8u40] Review request for RT-37486: Implement BI_BITFIELDS BMP format support

2014-08-20 Thread Vadim Pakhnushev
Hi Jim, Please review the fix: https://javafx-jira.kenai.com/browse/RT-37486 http://cr.openjdk.java.net/~vadim/RT-37486/webrev.00/ Thanks, Vadim

[8u40] Review request for RT-38230: Document the image file formats supported by javafx.scene.image.Image

2014-08-27 Thread Vadim Pakhnushev
Hi Jim, Please review the fix: https://javafx-jira.kenai.com/browse/RT-38230 http://cr.openjdk.java.net/~vadim/RT-38230/webrev.00/ Thanks, Vadim

hg: openjfx/8u-dev/rt: RT-38230: Document the image file formats supported by javafx.scene.image.Image

2014-08-27 Thread vadim . pakhnushev
Changeset: 99757c39bff9 Author:vadim Date: 2014-08-27 22:20 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/99757c39bff9 RT-38230: Document the image file formats supported by javafx.scene.image.Image Reviewed-by: fheidric !

[8u40] Review request for RT-38855: DoubleProperty.doubleProperty() Javadoc needs small fix

2014-10-03 Thread Vadim Pakhnushev
Hi Kevin, Please review this simple javadoc fix: https://javafx-jira.kenai.com/browse/RT-38855 http://cr.openjdk.java.net/~vadim/RT-38855/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2014-10-10 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

Re: CFV: New OpenJFX Committer: Chris Bensen

2014-10-10 Thread Vadim Pakhnushev
Vote: yes On 11.10.2014 3:49, Kevin Rushforth wrote: I hereby nominate Chris Bensen to OpenJFX Committer. Chris is a member of JavaFX team at Oracle working on the Java (FX) packager tool. A list of Chris' commits is available by the following link:

Re: Ensemble8

2014-10-11 Thread Vadim Pakhnushev
Bryan, It's in the apps/samples/Ensemble8 directory of the http://hg.openjdk.java.net/openjfx/8u-dev/rt repository If you don't want to get whole repository, you can get the zip of the Ensemble8 source here:

[8u40] Review request for RT-12725: Issue with 16 bit color

2014-10-14 Thread Vadim Pakhnushev
Hi David, Please review this fix: https://javafx-jira.kenai.com/browse/RT-12725 http://cr.openjdk.java.net/~vadim/RT-12725/webrev.00/ Thanks, Vadim

[8u40] Review request for RT-23180: Allow animated GIF to be loaded partially if it has errors in the data stream

2014-10-14 Thread Vadim Pakhnushev
Hi Jim, Please review this fix: https://javafx-jira.kenai.com/browse/RT-23180 http://cr.openjdk.java.net/~vadim/RT-23180/webrev.00/ Thanks, Vadim

[8u40] Review request for RT-38971: [Chart] Infinite loop after resizing a chart

2014-10-15 Thread Vadim Pakhnushev
Jonathan, Kevin, Please review this fix: https://javafx-jira.kenai.com/browse/RT-38971 http://cr.openjdk.java.net/~vadim/RT-38971/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2014-10-17 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[8u40] Review request for RT-38822: [Charts, CSS] Memory leak in PieChart

2014-10-17 Thread Vadim Pakhnushev
Hi Jonathan, Kevin, Please review this fix: https://javafx-jira.kenai.com/browse/RT-38822 http://cr.openjdk.java.net/~vadim/RT-38822/webrev.00/ Thanks, Vadim

[8u40] Review request for RT-39045: [Stage, Windows] Bad rendering of Icons

2014-10-23 Thread Vadim Pakhnushev
Hi David, Please review this fix: https://javafx-jira.kenai.com/browse/RT-39045 http://cr.openjdk.java.net/~vadim/RT-39045/webrev.00/ Thanks, Vadim

[8u40] Review request for RT-39066: [Slider] Tick labels for slider are not shown (regression)

2014-10-24 Thread Vadim Pakhnushev
Hi Jonathan, Please review this fix: https://javafx-jira.kenai.com/browse/RT-39066 http://cr.openjdk.java.net/~vadim/RT-39066/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2014-10-24 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

Re: Problem accessing jfx native libs under eclipse on windows

2014-10-29 Thread Vadim Pakhnushev
At least for the OpenJFX without media/webkit Cygwin is used only for path manipulation (cygpath) so I don't think dropping it will boost performance at all. In fact, I just did a quick test and built OpenJFX without cygwin at all (modifying build.gradle so it will not call cygpath). Visual

Re: Problem accessing jfx native libs under eclipse on windows

2014-10-29 Thread Vadim Pakhnushev
Gradle 1.11, see http://www.gradle.org/docs/1.11/release-notes#generate-visual-studio-configuration-for-a-native-binary-project). So you should be able to get that productivity boost without having to roll your own project files and maintain them. Scott On Wed, Oct 29, 2014 at 12:04 PM, Vadim

Re: Problem accessing jfx native libs under eclipse on windows

2014-10-29 Thread Vadim Pakhnushev
? +if (res.exitValue != 0) return path; return out.toString().trim(); } This will effectively bypass cygpath calls and will enable to build at least OpenJFX without Cygwin while not breaking anything running from Cygwin. Vadim On 29.10.2014 21:51, Vadim Pakhnushev wrote: Unfortunately, gradle

[8u40] Review request for RT-39304: Some tests doesn't test actual controls classes

2014-11-10 Thread Vadim Pakhnushev
Hi Kevin, Please review this fix: https://javafx-jira.kenai.com/browse/RT-39304 http://cr.openjdk.java.net/~vadim/RT-39304/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2014-11-21 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2014-11-28 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

[8u40] Review request for RT-39528: Repeated ListProperty.bindContent() silently breaks the list

2014-11-29 Thread Vadim Pakhnushev
Hi Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-39528 http://cr.openjdk.java.net/~vadim/RT-39528/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2014-12-05 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. We are under rampdown rules for M4 and RDP2 until Dec 15. Happy

In(Sanity) Testing Mondays

2014-12-12 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

[8u60] Review request for RT-39541: Firing SimpleUpdateChange does not get propagated properly on SortedList

2014-12-16 Thread Vadim Pakhnushev
Chien, Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-39541 http://cr.openjdk.java.net/~vadim/RT-39541/webrev.00/ Thanks, Vadim

[8u60] Review request for RT-27010: javafx.scene.image.Image() constructor may hangs on corrupted image

2014-12-16 Thread Vadim Pakhnushev
Jim, Please review the fix: https://javafx-jira.kenai.com/browse/RT-27010 http://cr.openjdk.java.net/~vadim/RT-27010/webrev.00/ Thanks, Vadim

[8u60] Review request for RT-36520: [Logging] Cannot turn off javafx.scene Logging

2014-12-18 Thread Vadim Pakhnushev
Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-36520 http://cr.openjdk.java.net/~vadim/RT-36520/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2014-12-19 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-01-23 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

[8u60] Review request for RT-39807: ObservableList.sorted() does nothing

2015-02-04 Thread Vadim Pakhnushev
Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-39807 http://cr.openjdk.java.net/~vadim/RT-39807/webrev.00/ Thanks, Vadim

[8u60] Review request for RT-39710: FilteredList doesn't always handle update Changes from source list

2015-02-04 Thread Vadim Pakhnushev
Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-39710 http://cr.openjdk.java.net/~vadim/RT-39710/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-02-06 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-01-30 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

[8u60] Review request for RT-23233: GIF frames have incorrect background

2015-01-13 Thread Vadim Pakhnushev
Jim, Please review the fix: https://javafx-jira.kenai.com/browse/RT-23233 http://cr.openjdk.java.net/~vadim/RT-23233/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-02-13 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-03-20 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-03-13 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-02-27 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-03-27 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. And after that there will be new rules in effect regarding pushing

[8u60, 9] Review request for RT-40544: Updating BarChart data causes memory leak

2015-04-22 Thread Vadim Pakhnushev
Jonathan, Please review the fix: https://javafx-jira.kenai.com/browse/RT-40544 http://cr.openjdk.java.net/~vadim/RT-40544/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-04-24 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[8u60, 9] Review request for RT-28705: JNI warnings in javafx-iio

2015-05-06 Thread Vadim Pakhnushev
Kevin, Could you please review the fix: https://javafx-jira.kenai.com/browse/RT-28705 http://cr.openjdk.java.net/~vadim/RT-28705/webrev.00/ Thanks, Vadim

[8u60, 9] Review request for RT-40482: The image in application rotates only 1 time, but the image in browser rotates all the time.

2015-05-07 Thread Vadim Pakhnushev
Jim, Could you please review the fix: https://javafx-jira.kenai.com/browse/RT-40482 The patch is inline in JIRA. Thanks, Vadim

[8u60, 9] Review request for RT-40778: BMP image fails to load when a specific size is requested

2015-05-15 Thread Vadim Pakhnushev
Jim, Could you please review the fix: https://javafx-jira.kenai.com/browse/RT-40778 http://cr.openjdk.java.net/~vadim/RT-40778/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-05-15 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-04-17 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-04-03 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

[8u60, 9] Review request for RT-40632: LineChart.getData.clear() method exception

2015-06-02 Thread Vadim Pakhnushev
Jonathan, Please review the fix: https://javafx-jira.kenai.com/browse/RT-40632 http://cr.openjdk.java.net/~vadim/RT-40632/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-06-05 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-06-26 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

Re: CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread Vadim Pakhnushev
Vote: yes On 29.05.2015 16:16, Kevin Rushforth wrote: I hereby nominate Anton Nashatyrev to OpenJFX Committer. Anton is a member of JavaFX team at Oracle working on WebKit and Media. A list of Anton's contributions is available via the following link:

In(Sanity) Testing Mondays

2015-05-29 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[8u60, 9] Review request for RT-46144: Refactor charts tests

2015-06-02 Thread Vadim Pakhnushev
Jonathan, Please review the fix: https://javafx-jira.kenai.com/browse/RT-46144 http://cr.openjdk.java.net/~vadim/RT-46144/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-07-03 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Starting next week we would like to change the test target to

[8u60, 9] Review request for RT-46083: TimelineClipCore exceptions handling improvent

2015-05-26 Thread Vadim Pakhnushev
Jim, Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-46083 http://cr.openjdk.java.net/~vadim/RT-46083/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-05-22 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[9] Review request for 8133839: StringIndexOutOfBoundsException in setter search when using

2015-08-19 Thread Vadim Pakhnushev
Jonathan, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8133839 http://cr.openjdk.java.net/~vadim/8133839/webrev.00/ Thanks, Vadim

[9] Review request for 8129401: Bindings.bindContentBidirectional does not work correctly

2015-08-19 Thread Vadim Pakhnushev
Chien, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8129401 http://cr.openjdk.java.net/~vadim/8129401/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-08-21 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-07-31 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[9] Review request for 8089557: bindBidirection works for ReadOnly*Wrapper incorrectly

2015-08-04 Thread Vadim Pakhnushev
Chien, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8089557 http://cr.openjdk.java.net/~vadim/8089557/webrev.00/ Thanks, Vadim

[9] post-commit notification for 8132906: ReadOnly*Wrapper.ReadOnlyPropertyImpl could use ReadOnly*PropertyBase

2015-08-04 Thread Vadim Pakhnushev
Hello, https://bugs.openjdk.java.net/browse/JDK-8132906 Changeset: f06e176e6142 Author: vadim Date: 2015-08-04 12:49 +0300 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/f06e176e6142 Thanks, Vadim

[9] Review request for 8130458: Memory leak in bind/unbind of [Primitive]PropertyBase

2015-08-03 Thread Vadim Pakhnushev
Chien, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8130458 http://cr.openjdk.java.net/~vadim/8130458/webrev.00/ Thanks, Vadim

[9] Review request for 8089305: Memory leak - many weak listeners within JavaFX core classes do not implement WeakListener

2015-07-30 Thread Vadim Pakhnushev
Chien, Kevin, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8089305 http://cr.openjdk.java.net/~vadim/8089305/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-08-14 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. Testing assignments were slightly shuffled: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

Re: [PATCH] 8130458 : BooleanBinding binding/unbinding leaks

2015-07-24 Thread Vadim Pakhnushev
Hi Jesper, First of all if you want to contribute to OpenJFX you need to sign OCA, as described here: http://openjdk.java.net/contribute/ The change itself looks OK, but we might want to look at the other similar issues, for example, all objects returned from helper class Bindings will

In(Sanity) Testing Mondays

2015-07-24 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

In(Sanity) Testing Mondays

2015-07-17 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[9] Review request for 8131324: XYChart.extraValue change doesn't result in chart update.

2015-07-15 Thread Vadim Pakhnushev
Jonathan, Please review the fix: https://bugs.openjdk.java.net/browse/JDK-8131324 http://cr.openjdk.java.net/~vadim/8131324/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-10-23 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

[9] Review request for 8140503: JavaFX "Pair" Hash Code Collisions

2015-11-03 Thread Vadim Pakhnushev
Hi Chien, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8140503 http://cr.openjdk.java.net/~vadim/8140503/webrev.00/ Thanks, Vadim

In(Sanity) Testing Mondays

2015-10-30 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Happy testing! Thanks, Vadim

  1   2   3   >