Re: [9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

Thanks for pointing out the problem. Currently, the directory is not removed regardless "-verbose" is specified or not. I think we can check if "-verbose" is specified, and if it is not, remove the temporary directory. New webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.01/

[9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

Chris, Please review the changes about removing temporary files. JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/ --Victor

[9] Review request: JDK-8172789: fx packager: fx:info doesn't work

Chris, Please review the changes about fx:info JIRA: https://bugs.openjdk.java.net/browse/JDK-8172789 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8172789/webrev.00/ --Victor

[9] Review request:JDK-8173202: fx packager: Error: -includedt requires the java deployment toolkit, which is not included in this distribution

Chris, Please review the changes about including DT files in jdk.packager. JIRA: http://bugs.openjdk.java.net/browse/JDK-8173202 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8173202/webrev.00/ --Victor

[9] Review request: JDK-8175179: Windows Defender warning is not correct for all cases

Chris, Please review the changes about temp directory JIRA: https://bugs.openjdk.java.net/browse/JDK-8175179 Webrev:http://cr.openjdk.java.net/~vdrozdov/JDK-8175179/webrev.00/ --Victor

[9] Review request: JDK-8172906: Remove closed modules from Redistributable List

Chris, Please review the changes about removing closed modules from redistributable.list JIRA: https://bugs.openjdk.java.net/browse/JDK-8172906 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8172906/webrev.00/ --Victor

[9] Review request: JDK-8165522 Remove #ifndef USE_JLI_LAUNCH from native launcher

Chris, Please review the changes about removing native packager JNI code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165522 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165522/webrev.00/ --Victor

[9] Review request: JDK-8162923 Error: Unknown Argument thrown by javpackager when argument values are passed with multiple words with in quotation

Chris, Please review the changes about argument quotation for javapackager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162923 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162923/webrev.00/ --Victor

[9] Review request: JDK-8162693 javapackager returns null if com.oracle.tools.packager.windows.WinAppBundler called twice

Chris, Please review the changes about WinAppBundler. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162693 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162693/webrev.00/ --Victor

Re: [9] Review request: JDK-8162693 javapackager returns null if com.oracle.tools.packager.windows.WinAppBundler called twice

Correct links: JIRA: https://bugs.openjdk.java.net/browse/JDK-8162693 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162693/webrev.00/ --Victor Chris, Please review the changes about WinAppBundler. JIRA:

[9] Review request: JDK-8168089, Secondary Launchers (*.exe files) are not generated

Chris, Please review the changes about secondary launchers: JIRA: https://bugs.openjdk.java.net/browse/JDK-8168089 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8168089/webrev.00/ --Victor

[9] Review request: JDK-8166281: -Bidentifier="" not working for modules in MAC

Chris, Please review the changes about fixing the -Bidentifier for backward compatibility: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166281 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8166281/webrev.00/ --Victor

[9] Review request: JDK-8168501 javapackager system wide installation is failed when bundled through ANT in windows operating system

Chris, Please review the changes about system wide installation (bundled through ANT). JIRA: https://bugs.openjdk.java.net/browse/JDK-8168501 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8168501/webrev.00/ --Victor

[9] Review request: JDK-8170134: Linux Ant Swing Test Fails

Chris, Please review the changes about Linux Ant Swing Test. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170134 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8170134/webrev.00/ --Victor

[9] Review request: JDK-8170851: Secondary Launchers picks wrong main class from module

Chris, Please review the changes about picking wrong main class from module. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170851 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8170851/webrev.00/ --Victor

[9] Review request: JDK-8167388: value for key "LSApplicationCategoryType" is not set in Info.plist when trying to set through javapackager -BapplicationCategory=""

Chris, Please review the changes about ApplicationCategory (Info.plist) JIRA: https://bugs.openjdk.java.net/browse/JDK-8167388 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8167388/webrev.00/ --Victor

[9] Review request: JDK-8088064: Enhance Launcher to Support Long File Names

Chris, Please review the changes about enhancing support of long file names. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088064 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8088064/webrev.00/ --Victor

[9] Review request: JDK-8165794: javapackager throws "No application jars found" when "-srcfiles" is omitted in CLI

Chris, Please review the changes about "No application jars found" exception. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165794 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165794/webrev.00/ --Victor

[9] Review request: JDK-8154250: [packager] Mac Bundle Plugins directory rename

Chris, Please review the changes about renaming PlugIns directory. JIRA: https://bugs.openjdk.java.net/browse/JDK-8154250 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8154250/webrev.00/ --Victor

[9] Review request: JDK-8157913: Launcher can not find path to libpackager.so

Chris, Please review the changes about getting path to libpackager.so JIRA: https://bugs.openjdk.java.net/browse/JDK-8157913 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8157913/webrev.00/ --Victor

[9] Review request: JDK-8154472: javapackager -createbss command is not working

Chris, Kevin, Please review the changes about exporting com.sun.javafx.css.parser to module jdk.packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8154472 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8154472/webrev.00/ --Victor

[9] Review request: JDK-8171858: Application fail to launch with early access build 150 in both Oracle Linux 7.0 and Ubuntu

Chris, Please review the changes about libjli.so (P1) JIRA: https://bugs.openjdk.java.net/browse/JDK-8171858 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8171858/webrev.00/ --Victor

[10] Review request: JDK-8175574: Singleton App

Chris, Please review the changes about single instance. JIRA: https://bugs.openjdk.java.net/browse/JDK-8175574 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8175574/webrev.04/ --Victor

[9] Review request: JDK-8089548: [parfait] Memory leak in rt/modules/fxpackager/src/main/native/library/common/

Chris, Please review the changes related with parfait warnings. See my comments in JBS. JIRA: https://bugs.openjdk.java.net/browse/JDK-8089548 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8089548/webrev.00/ --Victor

[10] Review request: 8184688: Single Instance Example

Chris, Please review my changes about adding single instance example. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184688 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184688/webrev.00/ --Victor

[10] Review request: 8184077: Resolve Singleton TODO

Chris, Please review my changes about removing getSessionSpecificString() JIRA: https://bugs.openjdk.java.net/browse/JDK-8184077 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184077/webrev.0/ --Victor

[10] Review request: 8184301: Add new projects for jdk.packager.services and jdk.packager

Chris, Please review my changes about adding new projects for jdk.packager.services and jdk.packager JIRA: https://bugs.openjdk.java.net/browse/JDK-8184301 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184301/webrev.00 --Victor

[10] Review request: 8182615: Check registry paths

Chris, Please review my changes about correcting registry paths JIRA: https://bugs.openjdk.java.net/browse/JDK-8182615 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8182615/webrev.00/ --Victor

[10] Review request: 8181291: Singleton for javapackager

Kevin, Chris, Please review my changes about Single Instance for Java Packager (compared to previous webrev, the code was modified according to CSR JDK-8181293) JIRA: https://bugs.openjdk.java.net/browse/JDK-8181291 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8175574/webrev.06/

[10] Review request: JDK-8179445: Use jdeps ToolProvider

Chris, Kevin Please review my changes about jdeps ToolProvider JIRA: https://bugs.openjdk.java.net/browse/JDK-8179445 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8179445/webrev.00/ --Victor

[9] Review request: JDK-8180368: javapackager.exe fails to launch: Unrecognized option: -m

Kevin, Please review my changes about removing the code that constructs java cmd based on JAVA_HOME. JIRA: https://bugs.openjdk.java.net/browse/JDK-8180368 Webrev: webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8180368/webrev.00/ --Victor

JEP 311: Java Packager API & CLI

New JEP Candidate: JEP 311: Java Packager API & CLI: http://openjdk.java.net/jeps/311 Mailing list for further discussion: jdk-...@openjdk.java.net --Victor

Re: JEP 311: Java Packager API & CLI (Kevin Rushforth)

Hi, Sverre. The preliminary list of new arguments has arguments for DEB, but not RPM. Really hope RPM is not phased out after refactoring arguments for later removal after JDK10. RPM will not be phased out. It's just a preliminary list of arguments. What is the reason for removing support

[10] Review request: 8191712: javapackager help output has a typo

Alexander, Please review my changes about fixing typos in javapackager help output and jdk/packager/builders/mac/MacAppImageBuilder. The fix also corrected the typo from JDK-8189339 JIRA: https://bugs.openjdk.java.net/browse/JDK-8191712 Webrev:

Re: javapackager feedback and questions

Hi, Mani. Thanks for providing the feedback! We will consider adding more examples and more details in the docs as you proposed(there is an arg named jvmOptions but that's not mentioned in the table). Looks like there is a bug when you specify systemWide=true on the MacOSX in non-gui mode.

[10] Review request: 8186642: Assertion error if output application already exists

Kevin, Please review the changes about fixing "AssertionError: Duplicate entry". JIRA: https://bugs.openjdk.java.net/browse/JDK-8186642 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8186642/webrev.00/ --Victor

[10] Review request: 8193353: javapackager is totally broken in "-createbss" mode

Kevin, Please review the changes about removing old code related with jfxrt.jar JIRA: https://bugs.openjdk.java.net/browse/JDK-8193353 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8193353/webrev.00/ --Victor

[10] Review request: 8191176: JavaFX Self-Contained Application fails with error "Failed to find library: jvm.dll"

Kevin, Please review the changes about fixing the error "Failed to find library: jvm.dll" JIRA: https://bugs.openjdk.java.net/browse/JDK-8191176 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8191176/webrev.00/ --Victor

[10] Review request: 8190758: javapackager fails to consider filesystem type

Kevin, Please review my changes about filesystem type for .dmg JIRA: https://bugs.openjdk.java.net/browse/JDK-8190758 Webrev:http://cr.openjdk.java.net/~vdrozdov/JDK-8190758/webrev.00/ --Victor

[10] Review request: 8191514: Deprecate com.sun.* and com.oracle.* packages in jdk.packager for removal

Kevin, Please review the changes about deprecating com.sun.* and com.oracle.* packages for removal. JIRA: https://bugs.openjdk.java.net/browse/JDK-8191514 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8191951/webrev.00/ --Victor

Re: [10] Review request: 8179033: javapackager fails to create Mac Application Bundle

On 12/2/17 7:11 AM, Kevin Rushforth wrote: Michael Hall wrote: On Dec 2, 2017, at 8:31 AM, Kevin Rushforth > wrote: Michael Hall wrote: On Dec 1, 2017, at 7:43 PM, victor.droz...@oracle.com

[10] Review request: 8193161: NullPointerException when generating image/installer on Linux

Alexander, Please review the changes about fixing NPE when generating an image or installer on Linux. JIRA: https://bugs.openjdk.java.net/browse/JDK-8193161 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8193161/webrev.00/ --Victor

[10] Review request: 8137114: native launcher not finding cfg-file

Kevin, Please review the changes about fixing GenericPlatform::GetAppName(). JIRA: https://bugs.openjdk.java.net/browse/JDK-8137114 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8137114/webrev.00/ --Victor

[10] Review request: 8179033: javapackager fails to create Mac Application Bundle

Kevin, Please review the changes about copying classpath entries on Mac and Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8179033 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8179033/webrev.00/ --Victor

[10] Review request: 8178951: "Module ... does not exist" is printed on console

Alexander, Please review my changes for fixing the issue: " 8178951: "Module ... does not exist" is printed on console" JIRA: https://bugs.openjdk.java.net/browse/JDK-8178951 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8178951/webrev.00/ --Victor

[10] Review request: 8194488: "javapackager -singleton" is not working in linux

Alexander, Please review my changes for fixing the issue: "JDK-8194488: "javapackager -singleton" is not working in linux" JIRA: https://bugs.openjdk.java.net/browse/JDK-8194488 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8194488/webrev.00/ --Victor

[10] Review request: 8194144: com.oracle.tools.packager.Bundler.execute() returns null on MAC

Kevin, Please review my changes for fixing the issue: "JDK-8194144: com.oracle.tools.packager.Bundler.execute() returns null on MAC" JIRA: https://bugs.openjdk.java.net/browse/JDK-8194144 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8194144/webrev.00/ --Victor

[10] Review request: 8194040: "javapackager -help" doesn't display new option "-singleton"

Kevin, Please review my changes for fixing the issue: "8194040: "javapackager -help" doesn't display new option "-singleton"" JIRA: https://bugs.openjdk.java.net/browse/JDK-8194040 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8194040/webrev.00/ --Victor

Re: Packaging DMG with Ant fails on OS-X 10.13.3

Hi, Michael. Could you provide more details about your system and steps to reproduce the problem(at least, a command line)? We will investigate this issue about SetFile failure. --Victor On 2/13/18 2:36 PM, Michael Paus wrote: The bug you mentioned is indeed fixed in JDK 10 but since I

[10] Review request: 8189661: Regression of JDK-8095828 (though workaround does not work)

Alexander, Please review my changes for fixing the issue: "JDK-8189661: Regression of JDK-8095828 (though workaround does not work)" JIRA: https://bugs.openjdk.java.net/browse/JDK-8189661 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8189661/webrev.00/ --Victor