Re: [8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-12 Thread David Grieve 

Can I get your +1 or -1 on this change. Thanks.

On 5/9/14, 10:45 AM, David Grieve wrote:
Per Kevin's instructions, the previous changeset for RT-36838 was 
backed out in order to resolve RT-36995. I've attached a new webrev to 
RT-36838 which is  an improved fix for RT-36838 and which also ensures 
RT-36995 doesn't regress. These changes won't be pushed until after M4 
integration.


http://cr.openjdk.java.net/~dgrieve/RT-36838/webrev.02/
https://javafx-jira.kenai.com/browse/RT-36838

[8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-09 Thread David Grieve 
Per Kevin's instructions, the previous changeset for RT-36838 was backed 
out in order to resolve RT-36995. I've attached a new webrev to RT-36838 
which is  an improved fix for RT-36838 and which also ensures RT-36995 
doesn't regress. These changes won't be pushed until after M4 integration.


http://cr.openjdk.java.net/~dgrieve/RT-36838/webrev.02/
https://javafx-jira.kenai.com/browse/RT-36838

[8u] Review Request: RT-36838 - Strange behavior of TreeItem's disclosure arrow // expanded/collapsed state not reflected correctly

2014-05-08 Thread David Grieve 
This bug was reviewed and approved before, but in looking for a fix for 
RT-36995, I found some issues with the fix. Namely, that it was possible 
to have more than one REAPPLY queued up and that it was possible for the 
REAPPLY happen without a following UPDATE. Rather than roll the fixes 
for these issues into RT-36995 (especially given than the fix for 
RT-36995 is dead simple), I reopened RT-36838.


http://cr.openjdk.java.net/~dgrieve/RT-36838/webrev.01
https://javafx-jira.kenai.com/browse/RT-36838