Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Martin Sladecek
Currently, we use case to distinguish between newly created objects (upper-case class name) and properties (lower-case). Otherwise, it would not be clear when there's e.g. a text property and text class if we should set a property called text or create new text object and try to assign it to

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Stephen F Northover
Seems like we can't/shouldn't fix this. We can at least make sure it is documented. Steve On 2014-06-05, 4:19 PM, Martin Sladecek wrote: Currently, we use case to distinguish between newly created objects (upper-case class name) and properties (lower-case). Otherwise, it would not be clear

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Martin Sladecek
Maybe some special tags can solve the problem, like fx:property name=TEXTabc/fx:property fx:new class=hello.text text=abc/ fx:static class=text property=TEXTabc/fx:static They could be used in cases where the class name violates the restrictions we have for property/object tags. FXML version

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Jim Graham
In that code i n is a tautology. It's purpose seems to be to prevent the following i+1s from overflowing the string length, but then it should be i n-1 or n should just be initialized to name.length()-1 (and be called max or something to make its purpose clear)...

Re: FXMLLoader ?import? checking code conventions too much?

2014-06-05 Thread Stephen F Northover
Guillaume, if you feel strongly about this, please file a JIRA. Thanks! Steve On 2014-06-05, 4:29 PM, Martin Sladecek wrote: Maybe some special tags can solve the problem, like fx:property name=TEXTabc/fx:property fx:new class=hello.text text=abc/ fx:static class=text