Re: [Integrated] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-09 Thread Ajit Ghaisas
Changeset: 71ca899f Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-12-09 08:08:34 + URL: https://git.openjdk.java.net/jfx/commit/71ca899f 8220722: ProgressBarSkin: adds strong listener to control's width property Reviewed-by: aghaisas, arapte !

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-08 Thread Ambarish Rapte
On Mon, 9 Dec 2019 06:39:06 GMT, Jeanette Winzenburg wrote: >> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >> >> - replaces the manually registered listener with registerChangeListener(...) >> - added test that's failing before and passing after the fix (plus a sanity >> test

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-06 Thread Ajit Ghaisas
On Fri, 6 Dec 2019 09:42:05 GMT, Jeanette Winzenburg wrote: >> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >> >> - replaces the manually registered listener with registerChangeListener(...) >> - added test that's failing before and passing after the fix (plus a sanity >> test

Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-05 Thread Kevin Rushforth
On Thu, 5 Dec 2019 11:42:01 GMT, Jeanette Winzenburg wrote: > On Wed, 4 Dec 2019 16:54:41 GMT, Kevin Rushforth wrote: > >> On Wed, 4 Dec 2019 15:51:42 GMT, Jeanette Winzenburg >> wrote: >> >>> On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg >>> wrote: >>> fix for

Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-05 Thread Jeanette Winzenburg
On Wed, 4 Dec 2019 16:54:41 GMT, Kevin Rushforth wrote: > On Wed, 4 Dec 2019 15:51:42 GMT, Jeanette Winzenburg > wrote: > >> On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg >> wrote: >> >>> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >>> >>> - replaces the manually

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-05 Thread Jeanette Winzenburg
The pull request has been updated with a complete new set of changes (possibly due to a rebase). Commits: - a4fae9d7: 8220722: ProgressBarSkin: adds strong listener to control's width Changes: https://git.openjdk.java.net/jfx/pull/59/files Webrev:

Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-04 Thread Kevin Rushforth
On Wed, 4 Dec 2019 15:51:42 GMT, Jeanette Winzenburg wrote: > On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg > wrote: > >> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >> >> - replaces the manually registered listener with registerChangeListener(...) >> - added test that's

Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-04 Thread Jeanette Winzenburg
On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg wrote: > fix for https://bugs.openjdk.java.net/browse/JDK-8220722 > > - replaces the manually registered listener with registerChangeListener(...) > - added test that's failing before and passing after the fix (plus a sanity > test that the

RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-04 Thread Jeanette Winzenburg
fix for https://bugs.openjdk.java.net/browse/JDK-8220722 - replaces the manually registered listener with registerChangeListener(...) - added test that's failing before and passing after the fix (plus a sanity test that the skin still is listening to changes) Commits: -