Re: [Integrated] RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
Changeset: a68347cb Author:Jose Pereda Committer: Johan Vos Date: 2019-12-05 12:23:10 + URL: https://git.openjdk.java.net/jfx/commit/a68347cb 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl Reviewed-by: jvos ! modules/javafx.graphics/src/main/java/com/sun/glass/ui/ios/IosApplication.java
Re: [Approved] RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
On Sat, 30 Nov 2019 18:23:07 GMT, Jose Pereda wrote: > In `GlassApplication.m` for iOS, the method > `Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has > signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`, > `_leaveNestedEventLoopImpl()` signature doesn't match that. > > This PR fixes this. > > > > Commits: > - e5fc04a9: Use correct signature in _leaveNestedEventLoopImpl > > Changes: https://git.openjdk.java.net/jfx/pull/57/files > Webrev: https://webrevs.openjdk.java.net/jfx/57/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8235150 > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/jfx/pull/57.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/57/head:pull/57 Approved by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/57
Re: RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
On Sun, 1 Dec 2019 16:31:39 GMT, Johan Vos wrote: > On Sat, 30 Nov 2019 18:23:07 GMT, Jose Pereda wrote: > >> In `GlassApplication.m` for iOS, the method >> `Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has >> signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`, >> `_leaveNestedEventLoopImpl()` signature doesn't match that. >> >> This PR fixes this. >> >> >> >> Commits: >> - e5fc04a9: Use correct signature in _leaveNestedEventLoopImpl >> >> Changes: https://git.openjdk.java.net/jfx/pull/57/files >> Webrev: https://webrevs.openjdk.java.net/jfx/57/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8235150 >> Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod >> Patch: https://git.openjdk.java.net/jfx/pull/57.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/57/head:pull/57 > > Looks like a trivial fix to me. > It only impacts the iOS platform. Yes, this looks like a simple, and correct fix. A single reviewer will be sufficient. PR: https://git.openjdk.java.net/jfx/pull/57
Re: RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
On Sat, 30 Nov 2019 18:23:07 GMT, Jose Pereda wrote: > In `GlassApplication.m` for iOS, the method > `Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has > signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`, > `_leaveNestedEventLoopImpl()` signature doesn't match that. > > This PR fixes this. > > > > Commits: > - e5fc04a9: Use correct signature in _leaveNestedEventLoopImpl > > Changes: https://git.openjdk.java.net/jfx/pull/57/files > Webrev: https://webrevs.openjdk.java.net/jfx/57/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8235150 > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/jfx/pull/57.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/57/head:pull/57 Looks like a trivial fix to me. It only impacts the iOS platform. PR: https://git.openjdk.java.net/jfx/pull/57
RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
In `GlassApplication.m` for iOS, the method `Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`, `_leaveNestedEventLoopImpl()` signature doesn't match that. This PR fixes this. Commits: - e5fc04a9: Use correct signature in _leaveNestedEventLoopImpl Changes: https://git.openjdk.java.net/jfx/pull/57/files Webrev: https://webrevs.openjdk.java.net/jfx/57/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8235150 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/57.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/57/head:pull/57 PR: https://git.openjdk.java.net/jfx/pull/57
