Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-31 Thread Tom Schindl
Hi, Please see a revised full blown API on the JIRA ticket. See https://javafx-jira.kenai.com/browse/RT-19659 I think the last API addresses all issues you and Scott have. I still think the 3-Boolean API proposed would be suffient for u40 and the Callback-API could be introduced later to give

Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Tom Schindl
No - it allows also to drag the tab to another TabPane as well and in future outside the window to detach it. Tom On 30.07.14 10:07, Eric Le Ponner wrote: Hi Tom, I wonder if we should really use the wording « dnd ». The feature is really to enable the user to re-order the tabs inside a

Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Mikael Grev
That is decidedly awesome! Is there some other way of deciding whether to to do one or the other? I mean one might want to reorder but not drag to another pane. Cheers, Mikael On 30 Jul 2014, at 10:09, Tom Schindl tom.schi...@bestsolution.at wrote: No - it allows also to drag the tab to

Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Eric Le Ponner
Interesting. Then may be ‘drag’ wording would more consistent with remaining APIs. ‘dnd’ is currently used nowhere else. Eric Le 30 juil. 2014 à 10:09, Tom Schindl tom.schi...@bestsolution.at a écrit : No - it allows also to drag the tab to another TabPane as well and in future outside the

Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Tom Schindl
Hi, The proposed API only allows to turn on/off dragging all together. For your usecase I'd envision a future API which would allow one to control the aspects you are asking for like. The API i currently have in mind is but I have not yet explored: // Would allow to cancel dragging of certain

Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Mikael Grev
Wouldn’t you still need to specify the “kind” of drag you are moderating? With just a boolean on/off now, a later API where one needs to say what kinds of drags (reorder, between tabpanes and drag out) would be hard to create. One don’t want an API with a master switch AND one for each kind of

Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Stephen F Northover
Thanks Tom, We'll take a look at the patch in the JIRA: https://javafx-jira.kenai.com/browse/RT-19659 Steve On 2014-07-30, 3:35 AM, Tom Schindl wrote: Hi, I'd like you to review the API proposed to make TabPane Tabs draggable. The proposed public API only allows to put the TabPane in DnD