Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag
On Tue, 28 Jan 2020 16:04:59 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > The fix looks good to me. > Verified that the new test fails before and passes after fix and observed no > test failures. I don't have any additional comment, so this is good to go with 1 reviewer. @arapte can sponsor this. - PR: https://git.openjdk.java.net/jfx/pull/89
Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag
On Tue, 28 Jan 2020 18:04:54 GMT, Robert Lichtenberger wrote: >> Test simulates a single mouse-released event. >> Fix simply guards against the null case. > > The pull request has been updated with 1 additional commit. The fix looks good to me. Verified that the new test fails before and passes after fix and observed no test failures. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/89
Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - 39a61821: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all: https://git.openjdk.java.net/jfx/pull/89/files - new: https://git.openjdk.java.net/jfx/pull/89/files/a54a5306..39a61821 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/89/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/89/webrev.02-03 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/89.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/89/head:pull/89 PR: https://git.openjdk.java.net/jfx/pull/89
