Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - s/Enhancement/Enhancements > - Create release notes for JavaFX 18 There are 7 such issues. I created a [filter](https://bugs.openjdk.java.net/browse/JDK-8279345?filter=42366) to make it easy for you to have a look at them. I use a script to create the release notes which skips `noreg-doc` labelled issues. For future reference, it would be good to know if we want to keep these in the release notes. - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - s/Enhancement/Enhancements > - Create release notes for JavaFX 18 However, the two you mentioned are sort of borderline as to whether you want to include them or not. I would be just as happy excluding them. - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Mon, 14 Mar 2022 19:46:18 GMT, Abhinay Agarwal wrote: >>> @kevinrushforth Before I integrate the PR, can you have a look at [my >>> comment on the >>> issue](https://bugs.openjdk.java.net/browse/JDK-8282766?focusedCommentId=14482267=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14482267)? >> >> Oh, I had missed your question.. Yes, those three issues were intentionally >> added to the JBS filter. Even though they are `noreg-build` issues, they >> touch on behaviors that are visible to developers. > > @kevinrushforth What about the "noreg-doc" and "test_sprint" issues in the > filter? > > For example: > > * https://bugs.openjdk.java.net/browse/JDK-8271085 > * https://bugs.openjdk.java.net/browse/JDK-8271090 @abhinayagarwal I would expect the `noreg-doc` fixes to be included if they touch user-visible documentation. I see the two you mentioned in the filter I provided, although I don't see them in this PR. As for `test_sprint`, the filter doesn't consider that label. If they are test bugs then they should have `testbug` and/or `noreg-self` and be excluded as a result. - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Mon, 14 Mar 2022 17:08:32 GMT, Kevin Rushforth wrote: >> Marked as reviewed by kcr (Lead). > >> @kevinrushforth Before I integrate the PR, can you have a look at [my >> comment on the >> issue](https://bugs.openjdk.java.net/browse/JDK-8282766?focusedCommentId=14482267=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14482267)? > > Oh, I had missed your question.. Yes, those three issues were intentionally > added to the JBS filter. Even though they are `noreg-build` issues, they > touch on behaviors that are visible to developers. @kevinrushforth What about the "noreg-doc" and "test_sprint" issues in the filter? - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - s/Enhancement/Enhancements > - Create release notes for JavaFX 18 Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Mon, 14 Mar 2022 18:18:38 GMT, Kevin Rushforth wrote: >> doc-files/release-notes-18.md line 105: >> >>> 103: [JDK-8274929](https://bugs.openjdk.java.net/browse/JDK-8274929)|Crash >>> while reading specific clipboard content|window-toolkit >>> 104: [JDK-8275723](https://bugs.openjdk.java.net/browse/JDK-8275723)|Crash >>> on macOS 12 in GlassRunnable::dealloc|window-toolkit >>> 105: >> >> [REDO] Wrong stage gets focused after modal stage creation >> https://bugs.openjdk.java.net/browse/JDK-8271054 ? > > No, that fix is in 19. These release notes are for 18. Sorry, my mistake. - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Mon, 14 Mar 2022 17:55:45 GMT, Thiago Milczarek Sayao wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - s/Enhancement/Enhancements >> - Create release notes for JavaFX 18 > > doc-files/release-notes-18.md line 105: > >> 103: [JDK-8274929](https://bugs.openjdk.java.net/browse/JDK-8274929)|Crash >> while reading specific clipboard content|window-toolkit >> 104: [JDK-8275723](https://bugs.openjdk.java.net/browse/JDK-8275723)|Crash >> on macOS 12 in GlassRunnable::dealloc|window-toolkit >> 105: > > [REDO] Wrong stage gets focused after modal stage creation > https://bugs.openjdk.java.net/browse/JDK-8271054 ? No, that fix is in 19. These release notes are for 18. - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - s/Enhancement/Enhancements > - Create release notes for JavaFX 18 doc-files/release-notes-18.md line 105: > 103: [JDK-8274929](https://bugs.openjdk.java.net/browse/JDK-8274929)|Crash > while reading specific clipboard content|window-toolkit > 104: [JDK-8275723](https://bugs.openjdk.java.net/browse/JDK-8275723)|Crash on > macOS 12 in GlassRunnable::dealloc|window-toolkit > 105: [REDO] Wrong stage gets focused after modal stage creation https://bugs.openjdk.java.net/browse/JDK-8271054 ? - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Mon, 14 Mar 2022 13:31:34 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - s/Enhancement/Enhancements >> - Create release notes for JavaFX 18 > > Marked as reviewed by kcr (Lead). > @kevinrushforth Before I integrate the PR, can you have a look at [my comment > on the > issue](https://bugs.openjdk.java.net/browse/JDK-8282766?focusedCommentId=14482267=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14482267)? Oh, I had missed your question.. Yes, those three issues were intentionally added to the JBS filter. Even though they are `noreg-build` issues, they touch on behaviors that are visible to developers. - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Mon, 14 Mar 2022 13:31:34 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - s/Enhancement/Enhancements >> - Create release notes for JavaFX 18 > > Marked as reviewed by kcr (Lead). @kevinrushforth Before I integrate the PR, can you have a look at [my comment on the issue](https://bugs.openjdk.java.net/browse/JDK-8282766?focusedCommentId=14482267=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14482267)? - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - s/Enhancement/Enhancements > - Create release notes for JavaFX 18 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/752
Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]
> Add release notes for JavaFX 18 to the repository Abhinay Agarwal has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - s/Enhancement/Enhancements - Create release notes for JavaFX 18 - Changes: - all: https://git.openjdk.java.net/jfx/pull/752/files - new: https://git.openjdk.java.net/jfx/pull/752/files/e1457420..d5fdfce5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=752=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=752=00-01 Stats: 442154 lines in 6858 files changed: 139291 ins; 246279 del; 56584 mod Patch: https://git.openjdk.java.net/jfx/pull/752.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/752/head:pull/752 PR: https://git.openjdk.java.net/jfx/pull/752
