Re: 8u20 review request: RT-35635: new bundlers for fxpackager

2014-03-14 Thread Anthony Petrov
Dmitry, all, Please post your review notes to JIRA to keep all the information in one place. We use the mailing list to send out review requests so that other people could start watching the bug and/or join the review. The review itself should happen in JIRA comments. Thank you in advance.

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

2014-03-14 Thread Mark Fortner
Just out of curiousity, is there some reason that the new classes are in *com.oracle* and *com.sun* packages instead of just in a *javafx.tools*package? import com.oracle.bundlers.windows.WindowsBundlerParam; import com.sun.javafx.tools.packager.Log; import

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

2014-03-14 Thread Danno Ferrin
This is an interim commit, the next one will be just a move to com.oracle.bundlers. I would consider those to be the definitive api going forward for the bundlers portion. The com.sun.javafx package implies that these are useful only for JavaFX, which is not the case since we are adding