Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread David Grieve
Create an issue in JIRA and include a simple example that reproduces the 
issue.


On 2/4/15 4:13 PM, Tom Eugelink wrote:
I've just now ran JFXtras Samples under the latest 1.8.0_40 and it 
does not render identical as when run under 1.8.0_31, some CSS rules 
are not applied. Samples is easily downloaded from here 
(http://jfxtras.org/resources/java/jfxtras-labs-samples-8.0-r4-SNAPSHOT-shadow.jar) 
and started simply with java -jar.


When run under 1.8.0_31 or older, the LocalDateTimeTextfieldSample 
shows a textfield with a popup button. When the button is pressed a 
popup is shown, with a gradient as the background and both an ok and 
cancel icon in the right top. The exact same jar under 1.8.0_40 does 
not show the gradient nor the two icons.


LocalDateTimeTextfield under water uses CalendarTextField, so the code 
for this is in the calendar based control:
https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/java/jfxtras/internal/scene/control/skin/CalendarTextFieldSkin.java 

https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/resources/jfxtras/internal/scene/control/CalendarTextField.css 



Interesting are the lines starting at 351 in the skin, which do:
Popup lPopup = new Popup();
...
BorderPane lBorderPane = new BorderPane();
lBorderPane.getStyleClass().add(this.getClass().getSimpleName() + 
_popup); // this amounts to CalendarTextFieldSkin_popup 

...
lPopup.getContent().add(lBorderPane);

This no longer results in applying the background colors as defined in 
the css file on line 12.

.CalendarTextFieldSkin_popup {
-fx-background-color: -fx-shadow-highlight-color, 
-fx-outer-border, -fx-inner-border, -fx-body-color;

-fx-background-insets: 0 0 -1 0,0,1,2;
-fx-background-radius: 5,5,4,3;
-fx-padding: 0.77em 0.73em 0.75em 0.73em;
-fx-text-fill: -fx-text-base-color;
}

Neither are the two in the css defined icons applied to the ImageViews.

Is this intentional or a bug?

Tom




Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread Werner Lehmann
FWIW, we are also experiencing css differences between 8u25 and 8u40. In 
some custom controls portions appear completely unstyled on 8u40, as if 
the selectors would stop working. Couldn't take a closer look so far due 
to time constraints...


Werner


Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread Tom Eugelink

Luckily I had a test project still available from a previous CSS issue, so a 
simple test was easily created.
https://javafx-jira.kenai.com/browse/RT-39995

Now I only need a way to attach a file to that issue...

Tom


On 5-2-2015 16:47, David Grieve wrote:

Create an issue in JIRA and include a simple example that reproduces the issue.

On 2/4/15 4:13 PM, Tom Eugelink wrote:

I've just now ran JFXtras Samples under the latest 1.8.0_40 and it does not render 
identical as when run under 1.8.0_31, some CSS rules are not applied. Samples is easily 
downloaded from here 
(http://jfxtras.org/resources/java/jfxtras-labs-samples-8.0-r4-SNAPSHOT-shadow.jar) and 
started simply with java -jar.

When run under 1.8.0_31 or older, the LocalDateTimeTextfieldSample shows a 
textfield with a popup button. When the button is pressed a popup is shown, with a 
gradient as the background and both an ok and cancel icon in the right top. The exact 
same jar under 1.8.0_40 does not show the gradient nor the two icons.

LocalDateTimeTextfield under water uses CalendarTextField, so the code for this 
is in the calendar based control:
https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/java/jfxtras/internal/scene/control/skin/CalendarTextFieldSkin.java
https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/resources/jfxtras/internal/scene/control/CalendarTextField.css

Interesting are the lines starting at 351 in the skin, which do:
Popup lPopup = new Popup();
...
BorderPane lBorderPane = new BorderPane();
lBorderPane.getStyleClass().add(this.getClass().getSimpleName() + _popup); // this 
amounts to CalendarTextFieldSkin_popup 
...
lPopup.getContent().add(lBorderPane);

This no longer results in applying the background colors as defined in the css 
file on line 12.
.CalendarTextFieldSkin_popup {
-fx-background-color: -fx-shadow-highlight-color, -fx-outer-border, 
-fx-inner-border, -fx-body-color;
-fx-background-insets: 0 0 -1 0,0,1,2;
-fx-background-radius: 5,5,4,3;
-fx-padding: 0.77em 0.73em 0.75em 0.73em;
-fx-text-fill: -fx-text-base-color;
}

Neither are the two in the css defined icons applied to the ImageViews.

Is this intentional or a bug?

Tom






Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread David Grieve

Thanks, Tom.  Send me the source and I'll attach it on your behalf.

On 2/5/15 1:08 PM, Tom Eugelink wrote:
Luckily I had a test project still available from a previous CSS 
issue, so a simple test was easily created.

https://javafx-jira.kenai.com/browse/RT-39995

Now I only need a way to attach a file to that issue...

Tom


On 5-2-2015 16:47, David Grieve wrote:
Create an issue in JIRA and include a simple example that reproduces 
the issue.


On 2/4/15 4:13 PM, Tom Eugelink wrote:
I've just now ran JFXtras Samples under the latest 1.8.0_40 and it 
does not render identical as when run under 1.8.0_31, some CSS rules 
are not applied. Samples is easily downloaded from here 
(http://jfxtras.org/resources/java/jfxtras-labs-samples-8.0-r4-SNAPSHOT-shadow.jar) 
and started simply with java -jar.


When run under 1.8.0_31 or older, the LocalDateTimeTextfieldSample 
shows a textfield with a popup button. When the button is pressed a 
popup is shown, with a gradient as the background and both an ok and 
cancel icon in the right top. The exact same jar under 1.8.0_40 does 
not show the gradient nor the two icons.


LocalDateTimeTextfield under water uses CalendarTextField, so the 
code for this is in the calendar based control:
https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/java/jfxtras/internal/scene/control/skin/CalendarTextFieldSkin.java 

https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/resources/jfxtras/internal/scene/control/CalendarTextField.css 



Interesting are the lines starting at 351 in the skin, which do:
Popup lPopup = new Popup();
...
BorderPane lBorderPane = new BorderPane();
lBorderPane.getStyleClass().add(this.getClass().getSimpleName() + 
_popup); // this amounts to CalendarTextFieldSkin_popup 

...
lPopup.getContent().add(lBorderPane);

This no longer results in applying the background colors as defined 
in the css file on line 12.

.CalendarTextFieldSkin_popup {
-fx-background-color: -fx-shadow-highlight-color, 
-fx-outer-border, -fx-inner-border, -fx-body-color;

-fx-background-insets: 0 0 -1 0,0,1,2;
-fx-background-radius: 5,5,4,3;
-fx-padding: 0.77em 0.73em 0.75em 0.73em;
-fx-text-fill: -fx-text-base-color;
}

Neither are the two in the css defined icons applied to the ImageViews.

Is this intentional or a bug?

Tom








Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread Kevin Rushforth

Thanks, David.

-- Kevin


David Grieve wrote:

Thanks, Tom.  Send me the source and I'll attach it on your behalf.

On 2/5/15 1:08 PM, Tom Eugelink wrote:
Luckily I had a test project still available from a previous CSS 
issue, so a simple test was easily created.

https://javafx-jira.kenai.com/browse/RT-39995

Now I only need a way to attach a file to that issue...

Tom


On 5-2-2015 16:47, David Grieve wrote:
Create an issue in JIRA and include a simple example that reproduces 
the issue.


On 2/4/15 4:13 PM, Tom Eugelink wrote:
I've just now ran JFXtras Samples under the latest 1.8.0_40 and it 
does not render identical as when run under 1.8.0_31, some CSS 
rules are not applied. Samples is easily downloaded from here 
(http://jfxtras.org/resources/java/jfxtras-labs-samples-8.0-r4-SNAPSHOT-shadow.jar) 
and started simply with java -jar.


When run under 1.8.0_31 or older, the 
LocalDateTimeTextfieldSample shows a textfield with a popup 
button. When the button is pressed a popup is shown, with a 
gradient as the background and both an ok and cancel icon in the 
right top. The exact same jar under 1.8.0_40 does not show the 
gradient nor the two icons.


LocalDateTimeTextfield under water uses CalendarTextField, so the 
code for this is in the calendar based control:
https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/java/jfxtras/internal/scene/control/skin/CalendarTextFieldSkin.java 

https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/resources/jfxtras/internal/scene/control/CalendarTextField.css 



Interesting are the lines starting at 351 in the skin, which do:
Popup lPopup = new Popup();
...
BorderPane lBorderPane = new BorderPane();
lBorderPane.getStyleClass().add(this.getClass().getSimpleName() + 
_popup); // this amounts to CalendarTextFieldSkin_popup 

...
lPopup.getContent().add(lBorderPane);

This no longer results in applying the background colors as defined 
in the css file on line 12.

.CalendarTextFieldSkin_popup {
-fx-background-color: -fx-shadow-highlight-color, 
-fx-outer-border, -fx-inner-border, -fx-body-color;

-fx-background-insets: 0 0 -1 0,0,1,2;
-fx-background-radius: 5,5,4,3;
-fx-padding: 0.77em 0.73em 0.75em 0.73em;
-fx-text-fill: -fx-text-base-color;
}

Neither are the two in the css defined icons applied to the 
ImageViews.


Is this intentional or a bug?

Tom








Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread Kevin Rushforth
If the code sample is small (a small number of reasonably short files) 
then just paste it in the comments. Otherwise, you can e-mail it as a 
zip file to one of the developers @ Oracle (either myself or the 
assigned engineer for the bug).


-- Kevin


Tom Eugelink wrote:
Luckily I had a test project still available from a previous CSS 
issue, so a simple test was easily created.

https://javafx-jira.kenai.com/browse/RT-39995

Now I only need a way to attach a file to that issue...

Tom


On 5-2-2015 16:47, David Grieve wrote:
Create an issue in JIRA and include a simple example that reproduces 
the issue.


On 2/4/15 4:13 PM, Tom Eugelink wrote:
I've just now ran JFXtras Samples under the latest 1.8.0_40 and it 
does not render identical as when run under 1.8.0_31, some CSS rules 
are not applied. Samples is easily downloaded from here 
(http://jfxtras.org/resources/java/jfxtras-labs-samples-8.0-r4-SNAPSHOT-shadow.jar) 
and started simply with java -jar.


When run under 1.8.0_31 or older, the LocalDateTimeTextfieldSample 
shows a textfield with a popup button. When the button is pressed a 
popup is shown, with a gradient as the background and both an ok and 
cancel icon in the right top. The exact same jar under 1.8.0_40 does 
not show the gradient nor the two icons.


LocalDateTimeTextfield under water uses CalendarTextField, so the 
code for this is in the calendar based control:
https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/java/jfxtras/internal/scene/control/skin/CalendarTextFieldSkin.java 

https://github.com/JFXtras/jfxtras/blob/8.0/jfxtras-controls/src/main/resources/jfxtras/internal/scene/control/CalendarTextField.css 



Interesting are the lines starting at 351 in the skin, which do:
Popup lPopup = new Popup();
...
BorderPane lBorderPane = new BorderPane();
lBorderPane.getStyleClass().add(this.getClass().getSimpleName() + 
_popup); // this amounts to CalendarTextFieldSkin_popup 

...
lPopup.getContent().add(lBorderPane);

This no longer results in applying the background colors as defined 
in the css file on line 12.

.CalendarTextFieldSkin_popup {
-fx-background-color: -fx-shadow-highlight-color, 
-fx-outer-border, -fx-inner-border, -fx-body-color;

-fx-background-insets: 0 0 -1 0,0,1,2;
-fx-background-radius: 5,5,4,3;
-fx-padding: 0.77em 0.73em 0.75em 0.73em;
-fx-text-fill: -fx-text-base-color;
}

Neither are the two in the css defined icons applied to the ImageViews.

Is this intentional or a bug?

Tom