Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-05 Thread Kevin Rushforth
OK, thanks. For the benefit of others who might be interested, this bug is now visible here: https://bugs.openjdk.java.net/browse/JDK-8201135 -- Kevin Matthew Elliot wrote: Hi Kevin, Priyanka from Oracle beat me to it and this small example hit the nail on the head immediately. The below w

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-05 Thread Matthew Elliot
Hi Kevin, Priyanka from Oracle beat me to it and this small example hit the nail on the head immediately. The below will throw and swallow and IllegalArgumentException in CSSParser in the following method. private ParsedValueImpl colorValueOfString(String str) { import javafx.application.Appli

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread Kevin Rushforth
Hi Matt, Thank you for filing this bug. Can you provide a standalone test case that reproduces this (a .java and a .css file), so we can attach it to the bug? Our WebBugs triage engineer will ask for this, and it will save time if you can provide it now. Otherwise the bug report looks fine.

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread Matthew Elliot
Hey David, thanks. I have filed a bug via the Oracle website. internal review ID : 9053225 Hopefully this was correct as it was also my first time. Matt On 4 April 2018 at 17:21, David Grieve wrote: > On 4/4/18 10:44 AM, Matthew Elliot wrote: > > Hi David, thanks for the quick response, the p

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread David Grieve
On 4/4/18 10:44 AM, Matthew Elliot wrote: Hi David, thanks for the quick response, the parser does seem to have knowledge of the property and values as in the method ... ParsedValueImpl valueFor(String property, Term root, CSSLexer lexer)throws ParseException {} it looks for particular propert

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread Matthew Elliot
Hi David, thanks for the quick response, the parser does seem to have knowledge of the property and values as in the method ... ParsedValueImpl valueFor(String property, Term root, CSSLexer lexer) throws ParseException {} it looks for particular properties for parsing... e.g. } else if ("-fx-bac

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread David Grieve
The parser doesn't have any concept of what the property is or value it might have. This allows the addition of new properties (such as an user might add for their own CSS styles) without having to modify the parser to handle them. On 4/4/18 10:03 AM, Matthew Elliot wrote: Hi all, (first pos