Re: JavaFX 11 maven snapshots - empty jars

Thanks Johan for the update. I will test it asap. Best Regards, Steve Am Mi., 29. Aug. 2018 um 10:28 Uhr schrieb Johan Vos : > Hi Steve, > > This has been applied in 11-ea+24 which is now in maven central. > > Thanks, > > - Johan > > On Thu, Aug 9, 2018 at 3:32 PM Steve Hruda wrote: > >>

Re: JavaFX 11 maven snapshots - empty jars

Thanks, that worked perfect. ea-24 is available now. - Johan On Wed, Aug 22, 2018 at 3:03 PM Lennart Börjeson wrote: > Sound reasonable, thank you. > > In the meantime (waiting for the next version of the maven artefacts) I've > updated my PR

Re: JavaFX 11 maven snapshots - empty jars

Hi Steve, This has been applied in 11-ea+24 which is now in maven central. Thanks, - Johan On Thu, Aug 9, 2018 at 3:32 PM Steve Hruda wrote: > Johan, > another temporary fix could be the META-INF attribute > "Automatic-Module-Name". E.g. set it at the empty jar to >

Re: JavaFX 11 maven snapshots - empty jars

Sound reasonable, thank you. In the meantime (waiting for the next version of the maven artefacts) I've updated my PR (https://github.com/johanvos/javafx11samples/pull/1 ) for your javafx11samples with a build.gradle work-around to filter out

Re: JavaFX 11 maven snapshots - empty jars

I spent some more time on this. Adding the Automatic-Module-Name seems the easiest fix to me. I created a PR at https://github.com/javafxports/openjdk-jfx/pull/162 for this. Having the platform-name hardcoded in the artifact Id would require upfront magic in build.gradle or pom.xml to prevent the

Re: JavaFX 11 maven snapshots - empty jars

FWIW, I've fixed the Gradle builds in the current javafx11samples and sent you a pull request. I know these samples are only temporary, but I believe I'm not the only gradle user who's been frustrated by not having any working example to try out. My fix still uses the 11.0.0-SNAPSHOT builds

Re: JavaFX 11 maven snapshots - empty jars

Right, that's a good idea. Thanks. On Thu, Aug 9, 2018 at 3:32 PM Steve Hruda wrote: > Johan, > another temporary fix could be the META-INF attribute > "Automatic-Module-Name". E.g. set it at the empty jar to > javafx.controls.workaround >

Re: JavaFX 11 maven snapshots - empty jars

Johan, another temporary fix could be the META-INF attribute "Automatic-Module-Name". E.g. set it at the empty jar to javafx.controls.workaround https://docs.oracle.com/javase/10/docs/specs/jar/jar.html#main-attributes Regards, Steve Am Sa., 14. Juli 2018 um 12:16 Uhr schrieb Steve Hruda <

Re: JavaFX 11 maven snapshots - empty jars

I've been forging ahead in my JavaFX work trying to get things figured out with OpenJDK 11 and OpenJFX. It's an exciting challenge. I've read the other two threads regarding the Maven snapshot artifacts and there are probably more questions than answers at this point. Since Johan mentioned the

Re: JavaFX 11 maven snapshots - empty jars

Hi Johan, a discussion with a wider audience ist a very good Idea. Maybe some core developers of Gradle join the discussion and assist OpenJFX. Pleased dont missunderstand me, it's not my intention to push a solution which works only fit one case. >From my current understandig, it's not a

Re: JavaFX 11 maven snapshots - empty jars

Hi Steve, I think we really want a solution that allows for as many use cases as possible. If the current proposal is not working with Eclipse, we need to fix it. I wonder if we want to create a javafx gradle plugin? We already have a jfxmobile plugin for gradle to deal with JavaFX on mobile, but

Re: JavaFX 11 maven snapshots - empty jars

Okay, I understand. If the empty jar will be the final solution, then I think I will find a workaround at our Gradle's build to avoid loading of such empty jars. Am Fr., 13. Juli 2018 um 17:39 Uhr schrieb Kevin Rushforth < kevin.rushfo...@oracle.com>: > > > Is there a plan to split the really

Re: JavaFX 11 maven snapshots - empty jars

> Is there a plan to split the really platform dependent stuff (natives) from the platform independent Code? Not any time soon. And that would cause it's own set of problems. In particular I would not be in favor of a solution that leaked new "module names" for what is (and should remain)

Re: JavaFX 11 maven snapshots - empty jars

Johan, hmm but is that not quite the same in case of the classifier? Because I also have to define a property or static value in case of the classifier. Kevin, The same name could b e a problem. "Module names, like package names, must not conflict. The recommended way to name a module is to use

Re: JavaFX 11 maven snapshots - empty jars

Would it help Eclipse if instead of an empty jar, the jar contained just the module-info.class file? Or will that then cause problems because of two .jar files with the same module name? -- Kevin On 7/13/2018 7:37 AM, Johan Vos wrote: Hi Steve, Yes, that has been considered, but I'm more

Re: JavaFX 11 maven snapshots - empty jars

Hi Steve, Yes, that has been considered, but I'm more than happy to re-open the discussion. The problem with javafx-controls-${javafx.platform} as the artifactId is that in that case, the gradle developer is in all cases required to add the platform suffix to the dependency, which makes it very