Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

2020-06-19 Thread Kevin Rushforth
On Fri, 19 Jun 2020 15:49:43 GMT, Rony G. Flatscher wrote: > CSR-update: looks good! I have moved the CSR to the "proposed" state in preparation for formal review. - PR: https://git.openjdk.java.net/jfx/pull/192

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

2020-06-19 Thread Kevin Rushforth
On Fri, 19 Jun 2020 15:49:36 GMT, Rony G. Flatscher wrote: >> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1769: >> >>> 1768: try { >>> 1769: if (isCompiled) { >>> 1770:compiledScript.eval(localBindings); >> >> I think

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

2020-06-19 Thread Rony G . Flatscher
On Fri, 19 Jun 2020 00:04:37 GMT, Kevin Rushforth wrote: >> Rony G. Flatscher has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now >> contains 27 commits: >> - Updates to meet Kevin's comment in PR 192 as of May 27th. >> - Merge

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

2020-06-18 Thread Kevin Rushforth
On Thu, 4 Jun 2020 15:44:49 GMT, Rony G. Flatscher wrote: >> This PR adds a "compile" process instruction to FXML files with the optional >> PI data "true" (default) and "false". The >> PI data is turned into a boolean value using "Boolean.parseBoolean(String)". >> This makes it possible to