Re: RFR: 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

2020-08-21 Thread Kevin Rushforth
On Fri, 21 Aug 2020 00:15:11 GMT, Alexander Matveev  
wrote:

> Fixed. It looks like github auto truncate long titles.

Thanks. Yes, GitHub does do that.

-

PR: https://git.openjdk.java.net/jfx/pull/285


Re: RFR: 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

2020-08-21 Thread Kevin Rushforth
On Thu, 20 Aug 2020 23:32:24 GMT, Alexander Matveev  
wrote:

> https://bugs.openjdk.java.net/browse/JDK-8252107
> 
> - Fixed by checking return value of audio/video bin state change and stopping 
> pipeline initialization if error occurred.

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/285


Re: RFR: 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

2020-08-20 Thread Alexander Matveev
On Thu, 20 Aug 2020 23:59:24 GMT, Kevin Rushforth  wrote:

> The PR title doesn't match the JBS title. Can you fix it?

Fixed. It looks like github auto truncate long titles.

-

PR: https://git.openjdk.java.net/jfx/pull/285


Re: RFR: 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

2020-08-20 Thread Alexander Matveev
On Thu, 20 Aug 2020 23:57:12 GMT, Kevin Rushforth  wrote:

> I built and tested it on Linux and it looks good. Have you done a build / 
> test on Mac and Windows as well?

Yes, Mac and Windows was tested with all formats.

-

PR: https://git.openjdk.java.net/jfx/pull/285