Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote: >> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Fix color in DefaultPlugin Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/382
Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote: >> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Fix color in DefaultPlugin Changes looks good to me. Did a local build on all three Platform and sanity test by loading top 10 websites loaded without any deviation from old build. - Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/382
Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]
On Thu, 21 Jan 2021 19:11:21 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix color in DefaultPlugin > > Looks good. Build + automated tests passed on all three platforms. I ran into > one manual test issue related to input events on Linux only. I'll file a > follow-on bug for that. I filed [JDK-8260257](https://bugs.openjdk.java.net/browse/JDK-8260257) to track the Linux input event issue. - PR: https://git.openjdk.java.net/jfx/pull/382
Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote: >> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Fix color in DefaultPlugin Looks good. Build + automated tests passed on all three platforms. I ran into one manual test issue related to input events on Linux only. I'll file a follow-on bug for that. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/382
Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Fix color in DefaultPlugin - Changes: - all: https://git.openjdk.java.net/jfx/pull/382/files - new: https://git.openjdk.java.net/jfx/pull/382/files/f55e82f8..ccb53c63 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=382=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=382=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/382.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/382/head:pull/382 PR: https://git.openjdk.java.net/jfx/pull/382
