On Tue, 7 Sep 2021 06:31:18 GMT, Ambarish Rapte wrote:
>> Since the `Background` constructors take a list of `Paint` objects, I think
>> saying a "single" `{@code Paint}` is helpful. I can see how adding "for
>> `BackgroundFill`" (or maybe "as a `BackgroundFill`"?) might make it clearer.
>
>
On Fri, 3 Sep 2021 21:08:27 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
>> line 366:
>>
>>> 364: */
>>> 365: public static Background fill(Paint fill) {
>>> 366: return new Background(new BackgroundFill(fill, null,
On Tue, 7 Sep 2021 08:37:31 GMT, Ambarish Rapte wrote:
>> Good idea to indicate what happens on `null`, although that might be better
>> in the description?
>
> I think that should be fine too.
> How should we describe the @param in that case.
> `@param fill Any Paint as BackgroundFill` ->
On Fri, 3 Sep 2021 21:06:38 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
>> line 361:
>>
>>> 359: *
>>> 360: * @implSpec This call is equivalent to {@code new Background(new
>>> BackgroundFill(fill, null, null));}.
>>> 361:
On Fri, 3 Sep 2021 21:04:13 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
>> line 357:
>>
>>> 355:
>>> 356: /**
>>> 357: * A convenience factory method for creating a background with a
>>> single {@code Paint}. The
On Fri, 3 Sep 2021 13:23:39 GMT, Marius Hanl wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected comment tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
> line 366:
>
>>
On Thu, 2 Sep 2021 12:14:58 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected comment tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
> line 357:
>
>>
On Fri, 27 Aug 2021 17:40:48 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected comment tags
On Fri, 27 Aug 2021 17:40:48 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected comment tags
Provided few suggestions for
On Fri, 27 Aug 2021 14:13:01 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected comment tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
> line 364:
>
On Fri, 27 Aug 2021 14:15:06 GMT, Kevin Rushforth wrote:
> I presume you will add some unit tests?
Yes, when the implementation is settled upon.
-
PR: https://git.openjdk.java.net/jfx/pull/610
> Added convenience factory factory methods for Background and Border.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Corrected comment tags
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/610/files
- new:
12 matches
Mail list logo
