Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect > that the value can change externally, and thus the properties are not > bindable, but this should be clarified further and for all such properties > and methods. > > See the Description of the JBS issues for this bug and its associated CSR for > more details. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/708
Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect > that the value can change externally, and thus the properties are not > bindable, but this should be clarified further and for all such properties > and methods. > > See the Description of the JBS issues for this bug and its associated CSR for > more details. Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/708
Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager
On Thu, 13 Jan 2022 11:35:22 GMT, Ajit Ghaisas wrote:
>> Update the API specification for the `Window` and `Stage` classes to clarify
>> that the values for some properties and methods can be changed or ignored by
>> the platform. Several of the properties already have a comment to the effect
>> that the value can change externally, and thus the properties are not
>> bindable, but this should be clarified further and for all such properties
>> and methods.
>>
>> See the Description of the JBS issues for this bug and its associated CSR
>> for more details.
>
> modules/javafx.graphics/src/main/java/javafx/stage/Window.java line 660:
>
>> 658: /**
>> 659: * Whether or not this {@code Window} has the keyboard or input
>> focus.
>> 660: *
>
> Is this removal intentional?
Yes, this is intentional. This property has no setter, so the existing comment
is in error.
-
PR: https://git.openjdk.java.net/jfx/pull/708
Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote:
> Update the API specification for the `Window` and `Stage` classes to clarify
> that the values for some properties and methods can be changed or ignored by
> the platform. Several of the properties already have a comment to the effect
> that the value can change externally, and thus the properties are not
> bindable, but this should be clarified further and for all such properties
> and methods.
>
> See the Description of the JBS issues for this bug and its associated CSR for
> more details.
Changes look good to me except at one place where you have removed the
description. I will it out separately.
modules/javafx.graphics/src/main/java/javafx/stage/Window.java line 660:
> 658: /**
> 659: * Whether or not this {@code Window} has the keyboard or input
> focus.
> 660: *
Is this removal intentional?
-
PR: https://git.openjdk.java.net/jfx/pull/708
Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect > that the value can change externally, and thus the properties are not > bindable, but this should be clarified further and for all such properties > and methods. > > See the Description of the JBS issues for this bug and its associated CSR for > more details. This looks ok to me. The clarifications make sense. There is unfortunately no guarantee about (low-level) cross-platform behaviour in these cases, but at least the JavaDoc makes this clear. - PR: https://git.openjdk.java.net/jfx/pull/708
