Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Kevin Rushforth
On Mon, 20 Dec 2021 17:48:19 GMT, Paul  wrote:

> I have an AMD Radeon VII (vega20) series GPU which is identifying with a 
> vendor string of "AMD".
> 
> This is not present in the `X11GLFactory` list of `preQualificationFilter` 
> vendor names, so my system (and probably any other vega20 based cards under 
> Linux) will always fall back to software rendering.
> 
> This adds the "amd" string to the `preQualificationFilter` list.

Looks good to me, too.

-

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/698


Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Kevin Rushforth
On Mon, 20 Dec 2021 17:48:19 GMT, Paul  wrote:

> I have an AMD Radeon VII (vega20) series GPU which is identifying with a 
> vendor string of "AMD".
> 
> This is not present in the `X11GLFactory` list of `preQualificationFilter` 
> vendor names, so my system (and probably any other vega20 based cards under 
> Linux) will always fall back to software rendering.
> 
> This adds the "amd" string to the `preQualificationFilter` list.

I'll check into this.

-

PR: https://git.openjdk.java.net/jfx/pull/698


Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Paul
On Tue, 21 Dec 2021 08:09:08 GMT, Paul  wrote:

> ... I signed the OCA **last year** ...

Added some emphasis. Hope I get a year off for Christmas next year! ;-)

-

PR: https://git.openjdk.java.net/jfx/pull/698


Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Johan Vos
On Mon, 20 Dec 2021 17:48:19 GMT, Paul  wrote:

> I have an AMD Radeon VII (vega20) series GPU which is identifying with a 
> vendor string of "AMD".
> 
> This is not present in the `X11GLFactory` list of `preQualificationFilter` 
> vendor names, so my system (and probably any other vega20 based cards under 
> Linux) will always fall back to software rendering.
> 
> This adds the "amd" string to the `preQualificationFilter` list.

I agree this would be a good and easy fix. Since there is an easy fallback to 
sw-rendering, this issue might impact more runtime environments than we are 
aware of. 
@kevinrushforth is there anything we can do to check the OCA status?

-

PR: https://git.openjdk.java.net/jfx/pull/698


Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Paul
On Mon, 20 Dec 2021 17:48:19 GMT, Paul  wrote:

> I have an AMD Radeon VII (vega20) series GPU which is identifying with a 
> vendor string of "AMD".
> 
> This is not present in the `X11GLFactory` list of `preQualificationFilter` 
> vendor names, so my system (and probably any other vega20 based cards under 
> Linux) will always fall back to software rendering.
> 
> This adds the "amd" string to the `preQualificationFilter` list.

Just as a side note, I signed the OCA last year when I was doing some work with 
the Helidon project. I thought it was one OCA for all things Oracle?

Hi. I'm just wondering if there is anything else I need to do for the OCA? It's 
been 4 weeks now, so even taking into account the holidays, I'm wondering if 
this request has fallen through the cracks?

Thanks

-

PR: https://git.openjdk.java.net/jfx/pull/698


Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Kevin Rushforth
On Tue, 21 Dec 2021 08:09:08 GMT, Paul  wrote:

> I thought it was one OCA for all things Oracle?

It is. There is a manual step to verify the connection between a user's GitHub 
account and their OCA, but it ordinarily happens quickly. Given that we are 
close to the holidays, there may be a longer delay than usual.

-

PR: https://git.openjdk.java.net/jfx/pull/698