Nir Lisker wrote:
Solved the configuration issues, so I'm continuing with this.
I submitted https://bugs.openjdk.java.net/browse/JDK-8199514 for the
refactoring part.
As mentioned before, this seems OK long as the refactoring is
behavior-neutral and limited in scope.
As for https://bugs.
Solved the configuration issues, so I'm continuing with this.
I submitted https://bugs.openjdk.java.net/browse/JDK-8199514 for the
refactoring part.
As for https://bugs.openjdk.java.net/browse/JDK-8089579, should it be
closed as Not an Issue and a new issue created for the new API propasal, or
sh
OK, let's wait with this until I figure out if there's a problem with the
test suit.
On Fri, Feb 16, 2018 at 11:46 PM, Kevin Rushforth <
kevin.rushfo...@oracle.com> wrote:
> This will take me a bit more time to look at than I have right now (and
> Monday is a US holiday), so one quick comment for
This will take me a bit more time to look at than I have right now (and
Monday is a US holiday), so one quick comment for now:
The refactoring must not alter any public API signatures for exported
packagers, and must be behavior neutral. So if there are unit tests that
pass without your fix an
Let's start with the refactoring then. Before I submit a bug let's check
that this plan makes sense. Attached webrev for discussion.
Changes:
* Main change was to the XxxCondition classes. Instead of having 4
combinations of primitives and observables I used the unification approach
that NumberCon
Sorry for the delay in responding. I was traveling when this was sent
and barely able to keep up with urgent email / tasks.
Most of what you suggest below seems good. My only concern is whether
the "on demand" evaluation will have any side effects. Conceptually, it
seems like the right thing t
Iv'e managed to refactor a large portion of the class. About a 1/3 of the
(repetitious) code was removed.
On Tue, Feb 6, 2018 at 1:08 AM, Nir Lisker wrote:
> Hi,
>
> I was looking at https://bugs.openjdk.java.net/browse/JDK-8089579, which
> prompted me to have a look at When. There are a few poi