Re: RFR: 8374909: CodeArea: Exception in IME [v3]
On Tue, 13 Jan 2026 22:31:31 GMT, Andy Goryachev wrote: >> Fixes a bug which was reported in >> https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016 >> (introduced by adding IME support >> https://bugs.openjdk.org/browse/JDK-8368478 ) >> >> Adds proper clamping and normalization of selection range within the >> `StyledTextModel`, and replaces the implementation of getText() with the >> standard export(). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8374909.exception > - limit > - lf > - whitespace > - fix > - tests Thank you all for reviewing! - PR Comment: https://git.openjdk.org/jfx/pull/2029#issuecomment-3750050798
Re: RFR: 8374909: CodeArea: Exception in IME [v3]
On Tue, 13 Jan 2026 22:31:31 GMT, Andy Goryachev wrote: >> Fixes a bug which was reported in >> https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016 >> (introduced by adding IME support >> https://bugs.openjdk.org/browse/JDK-8368478 ) >> >> Adds proper clamping and normalization of selection range within the >> `StyledTextModel`, and replaces the implementation of getText() with the >> standard export(). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8374909.exception > - limit > - lf > - whitespace > - fix > - tests lgtm+... Tested with monkey tester. - Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2029#pullrequestreview-3659286878
Re: RFR: 8374909: CodeArea: Exception in IME [v3]
On Tue, 13 Jan 2026 22:31:31 GMT, Andy Goryachev wrote: >> Fixes a bug which was reported in >> https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016 >> (introduced by adding IME support >> https://bugs.openjdk.org/browse/JDK-8368478 ) >> >> Adds proper clamping and normalization of selection range within the >> `StyledTextModel`, and replaces the implementation of getText() with the >> standard export(). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8374909.exception > - limit > - lf > - whitespace > - fix > - tests Tested and works as expected in MonkeyTester and test app, the tests also works fine. - Marked as reviewed by zelmidaoui (Committer). PR Review: https://git.openjdk.org/jfx/pull/2029#pullrequestreview-3658634350
Re: RFR: 8374909: CodeArea: Exception in IME [v3]
On Tue, 13 Jan 2026 22:55:48 GMT, Ziad El Midaoui
wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into 8374909.exception
>> - limit
>> - lf
>> - whitespace
>> - fix
>> - tests
>
> I am not able to reproduce the issue same as in the video :
> https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016
> I am using chinese input (Pinyin - Simplified) and typing some text in RTA
> and click enter or a number (1-2-3-...) have the same result as in a TextField
> I could be missing something in the steps to reproduce.
> Tried it in MonkeyTester and a simple app with both RTA and TextField :
>
> @Override
> public void start(Stage stage) {
> TextField textField = new TextField();
> textField.setPromptText("TextField");
> RichTextArea richTextArea = new RichTextArea();
> richTextArea.setPrefHeight(200);
> VBox root = new VBox(10, textField, richTextArea);
> stage.setScene(new Scene(root, 400, 300));
> stage.setTitle("TextField + RichTextArea");
> stage.show();
> }
@Ziad-Mid you have to make sure that pinyin is active and type in letters
(pinyin is a sort of phonetic entry，type "hanzi1" to get 汉子 )
https://github.com/user-attachments/assets/20dae2d8-8bd5-4049-9d6b-15f168c1b103";
/>
-
PR Comment: https://git.openjdk.org/jfx/pull/2029#issuecomment-3746954815
Re: RFR: 8374909: CodeArea: Exception in IME [v3]
On Tue, 13 Jan 2026 22:31:31 GMT, Andy Goryachev wrote:
>> Fixes a bug which was reported in
>> https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016
>> (introduced by adding IME support
>> https://bugs.openjdk.org/browse/JDK-8368478 )
>>
>> Adds proper clamping and normalization of selection range within the
>> `StyledTextModel`, and replaces the implementation of getText() with the
>> standard export().
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master' into 8374909.exception
> - limit
> - lf
> - whitespace
> - fix
> - tests
I am not able to reproduce the issue same as in the video :
https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016
I am using chinese input (Pinyin - Simplified) and typing some text in RTA and
click enter or a number (1-2-3-...) have the same result as in a TextField
I could be missing something in the steps to reproduce.
Tried it in MonkeyTester and a simple app with both RTA and TextField :
@Override
public void start(Stage stage) {
TextField textField = new TextField();
textField.setPromptText("TextField");
RichTextArea richTextArea = new RichTextArea();
richTextArea.setPrefHeight(200);
VBox root = new VBox(10, textField, richTextArea);
stage.setScene(new Scene(root, 400, 300));
stage.setTitle("TextField + RichTextArea");
stage.show();
}
-
PR Comment: https://git.openjdk.org/jfx/pull/2029#issuecomment-3746933314
Re: RFR: 8374909: CodeArea: Exception in IME [v3]
> Fixes a bug which was reported in > https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016 > (introduced by adding IME support > https://bugs.openjdk.org/browse/JDK-8368478 ) > > Adds proper clamping and normalization of selection range within the > `StyledTextModel`, and replaces the implementation of getText() with the > standard export(). Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into 8374909.exception - limit - lf - whitespace - fix - tests - Changes: https://git.openjdk.org/jfx/pull/2029/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=2029&range=02 Stats: 328 lines in 8 files changed: 280 ins; 31 del; 17 mod Patch: https://git.openjdk.org/jfx/pull/2029.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2029/head:pull/2029 PR: https://git.openjdk.org/jfx/pull/2029
Re: RFR: 8374909: CodeArea: Exception in IME [v2]
On Fri, 9 Jan 2026 23:19:26 GMT, Andy Goryachev wrote: >> Fixes a bug which was reported in >> https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016 >> (introduced by adding IME support >> https://bugs.openjdk.org/browse/JDK-8368478 ) >> >> Adds proper clamping and normalization of selection range within the >> `StyledTextModel`, and replaces the implementation of getText() with the >> standard export(). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > limit @arapte could you please take a look at this so it makes it into jfx26? - PR Comment: https://git.openjdk.org/jfx/pull/2029#issuecomment-3745396458
Re: RFR: 8374909: CodeArea: Exception in IME [v2]
> Fixes a bug which was reported in > https://github.com/andy-goryachev-oracle/Test/issues/6#issuecomment-3726867016 > (introduced by adding IME support > https://bugs.openjdk.org/browse/JDK-8368478 ) > > Adds proper clamping and normalization of selection range within the > `StyledTextModel`, and replaces the implementation of getText() with the > standard export(). Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: limit - Changes: - all: https://git.openjdk.org/jfx/pull/2029/files - new: https://git.openjdk.org/jfx/pull/2029/files/46ef7baa..f7405a19 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=2029&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2029&range=00-01 Stats: 84 lines in 2 files changed: 81 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jfx/pull/2029.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2029/head:pull/2029 PR: https://git.openjdk.org/jfx/pull/2029
RFR: 8374909: CodeArea: Exception in IME
Adds several tests and fixes export range bugs in the `StyledTextModel`. - Commit messages: - lf - whitespace - fix - tests Changes: https://git.openjdk.org/jfx/pull/2029/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=2029&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374909 Stats: 242 lines in 7 files changed: 198 ins; 30 del; 14 mod Patch: https://git.openjdk.org/jfx/pull/2029.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2029/head:pull/2029 PR: https://git.openjdk.org/jfx/pull/2029
