Hi,
I forgot to add an ENOMEM check. I added it now. I think this patch is
ready for Howard and Hallvard to review. :)
Timur
On Thu, Jan 29, 2015 at 2:42 PM, Timur Kristóf timur.kris...@gmail.com wrote:
Here is a fixed version of the patch.
On Thu, Jan 29, 2015 at 10:29 AM, Timur Kristóf
Timur Kristóf wrote:
Hi,
I forgot to add an ENOMEM check. I added it now. I think this patch is
ready for Howard and Hallvard to review. :)
It looks OK to me. No one raises any concerns I'll commit it in a few hours.
Timur
On Thu, Jan 29, 2015 at 2:42 PM, Timur Kristóf
On 02/02/15 00:40, Howard Chu wrote:
It looks OK to me. No one raises any concerns I'll commit it in a few
hours.
Some sudden last thoughts:
mdb_dump.c also has a check (memchr(key.mv_data, '\0', key.mv_size)
to exclude non-databases, which is no longer valid.
Database names with \0 in them
On 02/02/15 02:00, Hallvard Breien Furuseth wrote:
Come to think of it, I have no
idea if the dump format supports DB names with \0 in them.
...and there will now be database names which cannot be spelled
on the command line, like for mdb_stat/mdb_dump -s subdb.
I don't think that was quite
Hallvard Breien Furuseth wrote:
On 02/02/15 00:40, Howard Chu wrote:
It looks OK to me. No one raises any concerns I'll commit it in a few
hours.
Some sudden last thoughts:
mdb_dump.c also has a check (memchr(key.mv_data, '\0', key.mv_size)
to exclude non-databases, which is no longer valid.
