Re: ldap_get_values() called on binary data - does this return an error, or garbage data?

2024-04-03 Thread Ondřej Kuzník
On Wed, Apr 03, 2024 at 02:08:15PM +0100, Graham Leggett wrote: > On 03 Apr 2024, at 13:03, Ondřej Kuzník wrote: > >>> This has been historically vague - first off, what happens if an >>> attempt is made to call ldap_get_values() on binary data, do you get >&

Re: ldap_get_values() called on binary data - does this return an error, or garbage data?

2024-04-03 Thread Ondřej Kuzník
eloper (I'm sure we can assume that they understand how strings are laid out etc.) Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

SASL Binds and meaning of "users"

2023-04-18 Thread Ondřej Kuzník
ed%20mappings [1]. Admin guide for direct mappings already says "it allows mapping to DNs which refer to entries not held by this server" in the first paragraph -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged,

Re: make test fail on riscv64 (was: RE26 testing call #1 (2.6.4))

2022-11-16 Thread Ondřej Kuzník
On Wed, Nov 16, 2022 at 01:33:55PM +0100, Michael Ströder wrote: > On 11/16/22 12:08, Ondřej Kuzník wrote: >> Also of note might be ITS#9916 which has a proposed >> patch already[0], can you give that a try? > > Are you refererring to this commit? > > https://git.ope

Re: make test fail on riscv64 (was: RE26 testing call #1 (2.6.4))

2022-11-16 Thread Ondřej Kuzník
try? Thanks, [0]. https://git.openldap.org/openldap/openldap/-/merge_requests/582 -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Plain syncrepl vs. accesslog aka. ITS#9580 - deltasync design considerations

2022-06-16 Thread Ondřej Kuzník
On Tue, Jun 14, 2022 at 01:40:56PM +0200, Ondřej Kuzník wrote: > It's becoming untenable how a plain refresh cannot be represented in > accesslog in a way that's capable of serving a deltasync session. > Whatever happens, we have lost a fair amount of information to run a > proper d

Re: Plain syncrepl vs. accesslog aka. ITS#9580 - proposal 4

2022-06-15 Thread Ondřej Kuzník
On Tue, Jun 14, 2022 at 01:40:56PM +0200, Ondřej Kuzník wrote: > It's becoming untenable how a plain refresh cannot be represented in > accesslog in a way that's capable of serving a deltasync session. > Whatever happens, we have lost a fair amount of information to run a > proper d

Re: Plain syncrepl vs. accesslog aka. ITS#9580 - proposal 3

2022-06-15 Thread Ondřej Kuzník
On Tue, Jun 14, 2022 at 01:40:56PM +0200, Ondřej Kuzník wrote: > It's becoming untenable how a plain refresh cannot be represented in > accesslog in a way that's capable of serving a deltasync session. > Whatever happens, we have lost a fair amount of information to run a > proper d

Re: Plain syncrepl vs. accesslog aka. ITS#9580 - proposal 1

2022-06-14 Thread Ondřej Kuzník
On Tue, Jun 14, 2022 at 01:40:56PM +0200, Ondřej Kuzník wrote: > It's becoming untenable how a plain refresh cannot be represented in > accesslog in a way that's capable of serving a deltasync session. > Whatever happens, we have lost a fair amount of information to run a > proper d

Plain syncrepl vs. accesslog aka. ITS#9580

2022-06-14 Thread Ondřej Kuzník
in the future. Since we do not follow RFC 4533 in many aspects already, e.g. we send cookies in the middle of a refresh, our cookies are often unusable on their own, we can just own up to this and define an extension to the protocol if needed. -- Ondřej Kuzník Senior Software Engineer Symas Corporation

Re: Release Maintenance Policy

2021-08-06 Thread Ondřej Kuzník
disclosure, or unauthorized > remote code execution. We do not consider assert() failures or crashes > resulting only in Denial of Service as security flaws. Sounds good and to the point. Thanks, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.sym

Re: New logging system ideas

2021-07-18 Thread Ondřej Kuzník
On Wed, Jul 14, 2021 at 03:40:35PM +0100, Howard Chu wrote: > Howard Chu wrote: >> Just some initial thoughts on what a new logging daemon should do for us: > > Scaling back to something easier for now: > > We'll use the existing Debug msgs as-is. The olcLogFile directive will > specify the >

Re: slapo-ppolicy 2.4 vs. 2.5

2021-05-04 Thread Ondřej Kuzník
TS#7084 and the ppolicy draft. It it makes a difference, it's possible that some of this is interfering, or that it's intentional, will probably have to decide on a case by case basis. -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged,

Re: slapo-ppolicy 2.4 vs. 2.5

2021-05-04 Thread Ondřej Kuzník
eAuthNsRemaining warning specifies the remaining number of times a user will be allowed to authenticate with an expired password. """ If not, please reopen ITS#7596 with a test case. Thanks, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Merge request management

2021-03-18 Thread Ondřej Kuzník
not be the best fit, there's also way to request review from a particular person. BTW non-project members are invited to help with review and testing, it's a great way to get familiar with the codebase and helps the project move faster and at higher quality. -- Ondřej Kuzník Senior Software Engineer Symas

Re: HAProxy proxy protocol support

2020-12-22 Thread Ondřej Kuzník
in and wishing you nice holidays, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Two new repos

2020-08-12 Thread Ondřej Kuzník
. Please review and come back with suggestions or, if you feel so inclined, patches. Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: contrib modules to promote to mainline for 2.5?

2020-04-23 Thread Ondřej Kuzník
> +1 for pw-sha2 and pw-argon2. > > FWIW: > slapo-noopsrch and slapo-lastbind is what I use in almost every > installation. Might want to improve the core lastbind support to make that overlay obsolete instead? -- Ondřej Kuzník Senior Software Engineer Symas Corporation

Re: New logging system ideas

2020-03-06 Thread Ondřej Kuzník
the runtime hot path, which is the main > goal. Suggestions? Moving a lot of work to the log postprocessor is good. -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: New release policy for OpenLDAP

2020-01-28 Thread Ondřej Kuzník
; but I wouldn't see that as a benefit/gain. -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: ITS#9124: slapd RE24 crashes (was: ldap0 does not work with RE24)

2020-01-03 Thread Ondřej Kuzník
On Fri, Jan 03, 2020 at 04:48:51PM +0100, Michael Ströder wrote: > On 1/3/20 12:55 PM, Ondřej Kuzník wrote: >> On Thu, Jan 02, 2020 at 03:12:26PM +0100, Michael Ströder wrote: >>> I've changed the subject to make it more clear what the real issue is. >> >> Y

Re: ITS#9124: slapd RE24 crashes (was: ldap0 does not work with RE24)

2020-01-03 Thread Ondřej Kuzník
t to have a look. > Is there actually a test for cancel operation in the test suite? There is now, in a way :) -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: dynlist enhancements, ITS#9121

2019-12-17 Thread Ondřej Kuzník
On Wed, Dec 18, 2019 at 02:02:40AM +, Howard Chu wrote: > Ondřej Kuzník wrote: >> How about being able to merge identical attribute definitions whether >> they come from config or directly from code? > > We've got other overlays that do something similar, ignore an

Re: dynlist enhancements, ITS#9121

2019-12-16 Thread Ondřej Kuzník
ms like a messy loose end to leave dangling, but not sure what > a better approach would be. > Suggestions? How about being able to merge identical attribute definitions whether they come from config or directly from code? -- Ondřej Kuzník Senior Software Engineer Symas Corporation

Re: Test suite overhaul

2019-07-25 Thread Ondřej Kuzník
On Thu, Jul 25, 2019 at 12:34:13AM +0100, Howard Chu wrote: > Ondřej Kuzník wrote: >> Historically, there has been a decent coverage in the test suite and >> that's what's being run before anyone pushes, but it's not been enough >> to capture some of the issues. It also

Test suite overhaul

2019-07-24 Thread Ondřej Kuzník
ready! Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: Please review 2.5 plan (non-development items)

2019-07-23 Thread Ondřej Kuzník
On Tue, Jul 23, 2019 at 05:03:48PM +0200, Michael Ströder wrote: > On 7/23/19 3:37 PM, Ondřej Kuzník wrote: >> I've prepared a plan what the project wants to achieve as part of the >> 2.5 stream apart from core OpenLDAP development that I intend to send to >> -technical

Re: back_ldap / TLS Issues with OPENLDAP_REL_ENG_2_4_48

2019-07-21 Thread Ondřej Kuzník
ssion? > > And we need to know the answer to that and have a fix in rather quickly. I'll see tomorrow about reproducing the regression with ldap.conf. If I'm successful, extending the test case and a fix should not take long. Thanks, -- Ondřej Kuzník Senior Software Engineer Symas Corporation

Re: back_ldap / TLS Issues with OPENLDAP_REL_ENG_2_4_48

2019-07-20 Thread Ondřej Kuzník
nage > olcSuffix: cn=authn > olcRootDN: cn=admin,cn=authn > olcRootPW: {SSHA} > olcDbURI: ldaps://remote-authn.acme.foo:636 > > The debug output shows the following: > > TLS: peer cert untrusted or revoked (0x42) > TLS: can't connect: (unknown error code). Hi Nikos, wher

Re: Persistent failures of test050

2019-07-01 Thread Ondřej Kuzník
On Mon, Jul 01, 2019 at 03:07:15PM +0200, Ondřej Kuzník wrote: > On Tue, Jun 25, 2019 at 04:45:30PM -0700, Quanah Gibson-Mount wrote: > > --On Saturday, June 22, 2019 2:06 PM -0700 Quanah Gibson-Mount > > wrote: > > > >> [build@freebsd12 ~/git/openldap-2-4/tests

Re: Persistent failures of test050

2019-07-01 Thread Ondřej Kuzník
est. It's probably the consumer CSN checks that need to be run again if we don't receive the CSN with the PDU (which is what happens in present phase), but that might have to be a '>=' on the contextCSN set rather than a strict '>'? Something tells me that we need to deal with present phase comi

Re: Current RE24 status (2.4.48)

2019-06-28 Thread Ondřej Kuzník
ne option would be to revert ITS#8427, although I'd > prefer to see a fix rather than a revert. I will have another look at ITS#8427 after I have a better grasp of what things are involved in breaking test050. Also not sure we will be able to get all of those fixed in the 2.4 series, but remain ho

Re: Persistent failures of test050

2019-06-27 Thread Ondřej Kuzník
e why the CSN was generated on server2. Might take a while to reproduce this again though. Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: ITS review 6/4/2019

2019-06-13 Thread Ondřej Kuzník
rch time > (has patch, IPR OK) This one isn't ready yet, might not belong to 2.4 anyway, also pending answer on https://www.openldap.org/lists/openldap-devel/201903/msg00011.html > OpenLDAP related ITSes for RE25 > --- > ITS#8875 - back-mdb - fix

Generating contextCSN on a newly adopted DB

2019-04-25 Thread Ondřej Kuzník
with SLAP_SINGLE_SHADOW(be) which means we might be a cascading replica. Is there a scenario that would break things? How about starting with an empty DB, should we still put a contextCSN there? Thanks, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http

Fwd: (ITS#9001) avl in libldap?

2019-03-29 Thread Ondřej Kuzník
cally linked so it can be used from there? Are there other options on the table? -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: VC exop and LDAPWhoAmI?

2018-01-19 Thread Ondřej Kuzník
On Fri, Nov 24, 2017 at 01:16:47PM +0100, Ondřej Kuzník wrote: > Trying to get SASL bind support into the Load Balancer now and a bit > stuck when it comes to figuring out what the resulting authorisation > identity is (SASL or LDAP say it's backend specific) for use with the > proxya

Approaches to ITS#8772

2017-11-24 Thread Ondřej Kuzník
the mutex types and drop recursive mutex (un)locking functions 3. Update accesslog to use the above 4. Drop rmutex.c Any objections? -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered

VC exop and LDAPWhoAmI?

2017-11-24 Thread Ondřej Kuzník
ed on each of its client's behalf. -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Re: ACL checks and slapo-unique

2017-11-24 Thread Ondřej Kuzník
nd decide which error code is appropriate. This would help plug that side channel, but might be quite expensive if there are many offending entries and as such would provide a different one again (open to the same class of attackers that you highlighted). Not sure that's worth it? -- Ondřej Kuzník Seni

Re: Persistent sessionlog

2017-10-26 Thread Ondřej Kuzník
On Tue, Oct 24, 2017 at 06:45:42PM +0200, Ondřej Kuzník wrote: > On Tue, Oct 24, 2017 at 04:52:57PM +0100, Howard Chu wrote: >> Ondřej Kuzník wrote: >>> ITS#8486 suggests we use a more efficient structure to maintain the >>> sessionlog in. If we're messing with s

Re: Persistent sessionlog

2017-10-24 Thread Ondřej Kuzník
On Tue, Oct 24, 2017 at 04:52:57PM +0100, Howard Chu wrote: > Ondřej Kuzník wrote: >> ITS#8486 suggests we use a more efficient structure to maintain the >> sessionlog in. If we're messing with sessionlog already, we might as >> well see if we can address another issue

Re: Persistent sessionlog

2017-10-24 Thread Ondřej Kuzník
On Tue, Oct 24, 2017 at 01:43:21PM +0200, Ondřej Kuzník wrote: > ITS#8486 suggests we use a more efficient structure to maintain the > sessionlog in. If we're messing with sessionlog already, we might as > well see if we can address another issue - it is always empty on slapd > sta

Persistent sessionlog

2017-10-24 Thread Ondřej Kuzník
be able to use whatever we built until then, but can't continue -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Load balancer

2017-09-28 Thread Ondřej Kuzník
this can be merged soon and extended further. Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

Variadic Debug() macro

2017-07-14 Thread Ondřej Kuzník
lcome your review and suggestions. [0]. http://coccinelle.lip6.fr/ [1]. https://github.com/coccinelle/coccinelle -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP